41326 2010-06-28 19:08:38 -0700 Refactor common code into addChildCommon 2010-06-29 10:33:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41331 1 abarth abarth abarth commit-queue darin eric webkit.review.bot oldest_to_newest 244041 0 abarth 2010-06-28 19:08:38 -0700 Refactor common code into addChildCommon 244042 1 59976 abarth 2010-06-28 19:09:29 -0700 Created attachment 59976 Patch for landing 244059 2 59976 commit-queue 2010-06-28 20:45:14 -0700 Comment on attachment 59976 Patch for landing Rejecting patch 59976 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/dom/ContainerNode.cpp Hunk #2 FAILED at 550. 1 out of 3 hunks FAILED -- saving rejects to file WebCore/dom/ContainerNode.cpp.rej patching file WebCore/dom/ContainerNode.h patching file WebCore/dom/Node.h Hunk #1 FAILED at 265. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/dom/Node.h.rej Full output: http://webkit-commit-queue.appspot.com/results/3328917 244064 3 59980 abarth 2010-06-28 21:10:28 -0700 Created attachment 59980 Patch for landing 244077 4 abarth 2010-06-28 21:37:58 -0700 Committed r62084: <http://trac.webkit.org/changeset/62084> 244082 5 webkit.review.bot 2010-06-28 21:52:52 -0700 http://trac.webkit.org/changeset/62084 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62083 http://trac.webkit.org/changeset/62084 244356 6 darin 2010-06-29 10:25:32 -0700 Seems parserAddChild should be inlined. 244366 7 abarth 2010-06-29 10:33:58 -0700 > Seems parserAddChild should be inlined. Yep. Or addChildCommon could be inlined. 59976 2010-06-28 19:09:29 -0700 2010-06-28 21:10:18 -0700 Patch for landing bug-41326-20100628190927.patch text/plain 4078 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWU4NzZjNmFkZjgwZTFkMTM1YjViYzIzNjcyZmMyMGEwNmZmNTNhNi4uOGQ0NDQ4YTdhNWVlN2Qx NzZlOTE1ZjU2ZGI5OGI3YjdiZDVmYmMwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0wNi0yOCAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCisgICAgICAgIFVucmV2aWV3ZWQuCisKKyAg ICAgICAgUmVmYWN0b3IgY29tbW9uIGNvZGUgaW50byBhZGRDaGlsZENvbW1vbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEzMjYKKworICAgICAgICBF cmljIGFza2VkIHRoYXQgd2Ugc2hhcmUgdGhlIGNvbW1vbiBjb2RlIGJldHdlZW4gdGhlc2UgY29k ZXBhdGhzLgorCisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q29udGFpbmVyTm9kZTo6YWRkQ2hpbGRDb21tb24pOgorICAgICAgICAoV2ViQ29yZTo6 Q29udGFpbmVyTm9kZTo6cGFyc2VyQWRkQ2hpbGQpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFp bmVyTm9kZTo6YWRkQ2hpbGQpOgorICAgICAgICAqIGRvbS9Db250YWluZXJOb2RlLmg6CisgICAg ICAgICogZG9tL05vZGUuaDoKKworMjAxMC0wNi0yOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIEZp eCBBU1NFUlQgc28gd2UgY2FuIHJ1biBtb3JlIEhUTUw1bGliIHRlc3RzCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUu Y3BwCmluZGV4IDkwMmExMjgxMDIwOTk5NDRiYTYyZjcxZjc0ZjY3YTdiYjczY2Q1MWQuLmE3Y2U1 Yzk5OWE0MjI2ZDdkMjY2NGEzNjJjZDMwZTdiZDU1OGRmZDcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv ZG9tL0NvbnRhaW5lck5vZGUuY3BwCisrKyBiL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3Bw CkBAIC01MzcsMTIgKzUzNyw4IEBAIGJvb2wgQ29udGFpbmVyTm9kZTo6YXBwZW5kQ2hpbGQoUGFz c1JlZlB0cjxOb2RlPiBuZXdDaGlsZCwgRXhjZXB0aW9uQ29kZSYgZWMsIGJvCiAgICAgcmV0dXJu IHRydWU7CiB9CiAKLXZvaWQgQ29udGFpbmVyTm9kZTo6cGFyc2VyQWRkQ2hpbGQoUGFzc1JlZlB0 cjxOb2RlPiBuZXdDaGlsZCkKK3ZvaWQgQ29udGFpbmVyTm9kZTo6YWRkQ2hpbGRDb21tb24oUGFz c1JlZlB0cjxOb2RlPiBuZXdDaGlsZCkKIHsKLSAgICBBU1NFUlQobmV3Q2hpbGQpOwotICAgIC8v IFRoaXMgZnVuY3Rpb24gaXMgb25seSB1c2VkIGR1cmluZyBwYXJzaW5nLgotICAgIC8vIEl0IGRv ZXMgbm90IHNlbmQgYW55IERPTSBtdXRhdGlvbiBldmVudHMuCi0KICAgICBmb3JiaWRFdmVudERp c3BhdGNoKCk7CiAgICAgTm9kZSogbGFzdCA9IG1fbGFzdENoaWxkOwogICAgIGFwcGVuZENoaWxk VG9Db250YWluZXI8Tm9kZSwgQ29udGFpbmVyTm9kZT4obmV3Q2hpbGQuZ2V0KCksIHRoaXMpOwpA QCAtNTU0LDYgKzU1MCwxNSBAQCB2b2lkIENvbnRhaW5lck5vZGU6OnBhcnNlckFkZENoaWxkKFBh c3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQpCiAgICAgY2hpbGRyZW5DaGFuZ2VkKHRydWUsIGxhc3Qs IDAsIDEpOwogfQogCit2b2lkIENvbnRhaW5lck5vZGU6OnBhcnNlckFkZENoaWxkKFBhc3NSZWZQ dHI8Tm9kZT4gbmV3Q2hpbGQpCit7CisgICAgQVNTRVJUKG5ld0NoaWxkKTsKKyAgICAvLyBUaGlz IGZ1bmN0aW9uIGlzIG9ubHkgdXNlZCBkdXJpbmcgcGFyc2luZy4KKyAgICAvLyBJdCBkb2VzIG5v dCBzZW5kIGFueSBET00gbXV0YXRpb24gZXZlbnRzLgorCisgICAgYWRkQ2hpbGRDb21tb24obmV3 Q2hpbGQpOworfQorCiBDb250YWluZXJOb2RlKiBDb250YWluZXJOb2RlOjphZGRDaGlsZChQYXNz UmVmUHRyPE5vZGU+IG5ld0NoaWxkKQogewogICAgIEFTU0VSVChuZXdDaGlsZCk7CkBAIC01NjQs MTYgKzU2OSw4IEBAIENvbnRhaW5lck5vZGUqIENvbnRhaW5lck5vZGU6OmFkZENoaWxkKFBhc3NS ZWZQdHI8Tm9kZT4gbmV3Q2hpbGQpCiAgICAgaWYgKGRvY3VtZW50KCktPmlzSFRNTERvY3VtZW50 KCkgJiYgIWNoaWxkQWxsb3dlZChuZXdDaGlsZC5nZXQoKSkpCiAgICAgICAgIHJldHVybiAwOwog Ci0gICAgZm9yYmlkRXZlbnREaXNwYXRjaCgpOwotICAgIE5vZGUqIGxhc3QgPSBtX2xhc3RDaGls ZDsKLSAgICBhcHBlbmRDaGlsZFRvQ29udGFpbmVyPE5vZGUsIENvbnRhaW5lck5vZGU+KG5ld0No aWxkLmdldCgpLCB0aGlzKTsKLSAgICBhbGxvd0V2ZW50RGlzcGF0Y2goKTsKKyAgICBhZGRDaGls ZENvbW1vbihuZXdDaGlsZCk7CiAKLSAgICBkb2N1bWVudCgpLT5pbmNET01UcmVlVmVyc2lvbigp OwotICAgIGlmIChpbkRvY3VtZW50KCkpCi0gICAgICAgIG5ld0NoaWxkLT5pbnNlcnRlZEludG9E b2N1bWVudCgpOwotICAgIGNoaWxkcmVuQ2hhbmdlZCh0cnVlLCBsYXN0LCAwLCAxKTsKLSAgICAK ICAgICBpZiAobmV3Q2hpbGQtPmlzRWxlbWVudE5vZGUoKSkKICAgICAgICAgcmV0dXJuIHN0YXRp Y19jYXN0PENvbnRhaW5lck5vZGUqPihuZXdDaGlsZC5nZXQoKSk7CiAgICAgcmV0dXJuIHRoaXM7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmggYi9XZWJDb3JlL2RvbS9D b250YWluZXJOb2RlLmgKaW5kZXggODM1OTg3ODNhZjI4MWYyNjhkNDNjMTcwNzA5MzMxN2ZjNDJk MGJkZi4uNWMwM2NiZTk4YjdhOTc3NGFhMzNhNjM5MzQ2ZmYyOWU0MzFjM2U5MCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5oCisrKyBiL1dlYkNvcmUvZG9tL0NvbnRhaW5l ck5vZGUuaApAQCAtOTEsMTAgKzkxLDEyIEBAIHByb3RlY3RlZDoKIAogICAgIHZvaWQgc2V0Rmly c3RDaGlsZChOb2RlKiBjaGlsZCkgeyBtX2ZpcnN0Q2hpbGQgPSBjaGlsZDsgfQogICAgIHZvaWQg c2V0TGFzdENoaWxkKE5vZGUqIGNoaWxkKSB7IG1fbGFzdENoaWxkID0gY2hpbGQ7IH0KLSAgICAK KwogcHJpdmF0ZToKKyAgICB2b2lkIGFkZENoaWxkQ29tbW9uKFBhc3NSZWZQdHI8Tm9kZT4pOwor CiAgICAgc3RhdGljIHZvaWQgZGlzcGF0Y2hQb3N0QXR0YWNoQ2FsbGJhY2tzKCk7Ci0gICAgCisK ICAgICBib29sIGdldFVwcGVyTGVmdENvcm5lcihGbG9hdFBvaW50JikgY29uc3Q7CiAgICAgYm9v bCBnZXRMb3dlclJpZ2h0Q29ybmVyKEZsb2F0UG9pbnQmKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEv V2ViQ29yZS9kb20vTm9kZS5oIGIvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IGRiNDkzMmUxZDAx NTFiZGQzMDRhODM4NzI2YmQzMmE3MWZjYmZmNDUuLjZjMDY3NTQ2MjEyNTI1ZTZkM2Y2Y2Q0ZDFh OWM2OTVkN2FiMjhlYzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9XZWJD b3JlL2RvbS9Ob2RlLmgKQEAgLTI2NSw5ICsyNjUsNiBAQCBwdWJsaWM6CiAgICAgLy8gQWxzbyBk b2VzIG5vdCBkaXNwYXRjaCBET00gbXV0YXRpb24gZXZlbnRzLgogICAgIC8vIFJldHVybnMgdGhl IGFwcHJvcHJpYXRlIGNvbnRhaW5lciBub2RlIGZvciBmdXR1cmUgaW5zZXJ0aW9ucyBhcyB5b3Ug cGFyc2UsIG9yIDAgZm9yIGZhaWx1cmUuCiAgICAgdmlydHVhbCBDb250YWluZXJOb2RlKiBhZGRD aGlsZChQYXNzUmVmUHRyPE5vZGU+KTsKLSAgICAvLyBhZGRDaGlsZCBpcyB0aWVkIGludG8gdGhl IGxvZ2ljIG9mIHRoZSBMZWdhY3lIVE1MVHJlZUJ1aWxkZXIuICBXZSBuZWVkCi0gICAgLy8gYSAi Y2xlYW4iIHZlcnNpb24gdG8gdXNlIGZvciB0aGUgSFRNTDUgdmVyc2lvbiBvZiB0aGUgSFRNTFRy ZWVCdWlsZGVyLgotICAgIHZpcnR1YWwgdm9pZCBwYXJzZXJBZGRDaGlsZChQYXNzUmVmUHRyPE5v ZGU+KTsKIAogICAgIC8vIENhbGxlZCBieSB0aGUgcGFyc2VyIHdoZW4gdGhpcyBlbGVtZW50J3Mg Y2xvc2UgdGFnIGlzIHJlYWNoZWQsCiAgICAgLy8gc2lnbmFsaW5nIHRoYXQgYWxsIGNoaWxkIHRh Z3MgaGF2ZSBiZWVuIHBhcnNlZCBhbmQgYWRkZWQuCg== 59980 2010-06-28 21:10:28 -0700 2010-06-28 21:10:28 -0700 Patch for landing bug-41326-20100628211027.patch text/plain 3050 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjA4MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDYtMjggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBVbnJldmlld2VkLgorCisgICAgICAgIFJlZmFjdG9yIGNvbW1vbiBjb2Rl IGludG8gYWRkQ2hpbGRDb21tb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQxMzI2CisKKyAgICAgICAgRXJpYyBhc2tlZCB0aGF0IHdlIHNoYXJlIHRo ZSBjb21tb24gY29kZSBiZXR3ZWVuIHRoZXNlIGNvZGVwYXRocy4KKworICAgICAgICAqIGRvbS9D b250YWluZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRhaW5lck5vZGU6OmFkZENo aWxkQ29tbW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRhaW5lck5vZGU6OnBhcnNlckFkZENo aWxkKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRhaW5lck5vZGU6OmFkZENoaWxkKToKKyAgICAg ICAgKiBkb20vQ29udGFpbmVyTm9kZS5oOgorCiAyMDEwLTA2LTI4ICBEYW5pZWwgQmF0ZXMgIDxk YmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhdHRlbXB0IHRvIGZpeCBRdCBi b3RzLgpJbmRleDogV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAJKHJldmlzaW9uIDYyMDgxKQorKysgV2ViQ29y ZS9kb20vQ29udGFpbmVyTm9kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzNywxMiArNTM3LDgg QEAgYm9vbCBDb250YWluZXJOb2RlOjphcHBlbmRDaGlsZChQYXNzUmVmUAogICAgIHJldHVybiB0 cnVlOwogfQogCi12b2lkIENvbnRhaW5lck5vZGU6OnBhcnNlckFkZENoaWxkKFBhc3NSZWZQdHI8 Tm9kZT4gbmV3Q2hpbGQpCit2b2lkIENvbnRhaW5lck5vZGU6OmFkZENoaWxkQ29tbW9uKFBhc3NS ZWZQdHI8Tm9kZT4gbmV3Q2hpbGQpCiB7Ci0gICAgQVNTRVJUKG5ld0NoaWxkKTsKLSAgICAvLyBU aGlzIGZ1bmN0aW9uIGlzIG9ubHkgdXNlZCBkdXJpbmcgcGFyc2luZy4KLSAgICAvLyBJdCBkb2Vz IG5vdCBzZW5kIGFueSBET00gbXV0YXRpb24gZXZlbnRzLgotCiAgICAgZm9yYmlkRXZlbnREaXNw YXRjaCgpOwogICAgIE5vZGUqIGxhc3QgPSBtX2xhc3RDaGlsZDsKICAgICBhcHBlbmRDaGlsZFRv Q29udGFpbmVyPE5vZGUsIENvbnRhaW5lck5vZGU+KG5ld0NoaWxkLmdldCgpLCB0aGlzKTsKQEAg LTU1NCw2ICs1NTAsMTUgQEAgdm9pZCBDb250YWluZXJOb2RlOjpwYXJzZXJBZGRDaGlsZChQYXNz UgogICAgIGNoaWxkcmVuQ2hhbmdlZCh0cnVlLCBsYXN0LCAwLCAxKTsKIH0KIAordm9pZCBDb250 YWluZXJOb2RlOjpwYXJzZXJBZGRDaGlsZChQYXNzUmVmUHRyPE5vZGU+IG5ld0NoaWxkKQorewor ICAgIEFTU0VSVChuZXdDaGlsZCk7CisgICAgLy8gVGhpcyBmdW5jdGlvbiBpcyBvbmx5IHVzZWQg ZHVyaW5nIHBhcnNpbmcuCisgICAgLy8gSXQgZG9lcyBub3Qgc2VuZCBhbnkgRE9NIG11dGF0aW9u IGV2ZW50cy4KKworICAgIGFkZENoaWxkQ29tbW9uKG5ld0NoaWxkKTsKK30KKwogQ29udGFpbmVy Tm9kZSogQ29udGFpbmVyTm9kZTo6bGVnYWN5UGFyc2VyQWRkQ2hpbGQoUGFzc1JlZlB0cjxOb2Rl PiBuZXdDaGlsZCkKIHsKICAgICBBU1NFUlQobmV3Q2hpbGQpOwpAQCAtNTY0LDE2ICs1NjksOCBA QCBDb250YWluZXJOb2RlKiBDb250YWluZXJOb2RlOjpsZWdhY3lQYXJzCiAgICAgaWYgKGRvY3Vt ZW50KCktPmlzSFRNTERvY3VtZW50KCkgJiYgIWNoaWxkQWxsb3dlZChuZXdDaGlsZC5nZXQoKSkp CiAgICAgICAgIHJldHVybiAwOwogCi0gICAgZm9yYmlkRXZlbnREaXNwYXRjaCgpOwotICAgIE5v ZGUqIGxhc3QgPSBtX2xhc3RDaGlsZDsKLSAgICBhcHBlbmRDaGlsZFRvQ29udGFpbmVyPE5vZGUs IENvbnRhaW5lck5vZGU+KG5ld0NoaWxkLmdldCgpLCB0aGlzKTsKLSAgICBhbGxvd0V2ZW50RGlz cGF0Y2goKTsKKyAgICBhZGRDaGlsZENvbW1vbihuZXdDaGlsZCk7CiAKLSAgICBkb2N1bWVudCgp LT5pbmNET01UcmVlVmVyc2lvbigpOwotICAgIGlmIChpbkRvY3VtZW50KCkpCi0gICAgICAgIG5l d0NoaWxkLT5pbnNlcnRlZEludG9Eb2N1bWVudCgpOwotICAgIGNoaWxkcmVuQ2hhbmdlZCh0cnVl LCBsYXN0LCAwLCAxKTsKLSAgICAKICAgICBpZiAobmV3Q2hpbGQtPmlzRWxlbWVudE5vZGUoKSkK ICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PENvbnRhaW5lck5vZGUqPihuZXdDaGlsZC5nZXQo KSk7CiAgICAgcmV0dXJuIHRoaXM7CkluZGV4OiBXZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5oCShyZXZpc2lvbiA2MjA4 MSkKKysrIFdlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtOTEs MTAgKzkxLDEyIEBAIHByb3RlY3RlZDoKIAogICAgIHZvaWQgc2V0Rmlyc3RDaGlsZChOb2RlKiBj aGlsZCkgeyBtX2ZpcnN0Q2hpbGQgPSBjaGlsZDsgfQogICAgIHZvaWQgc2V0TGFzdENoaWxkKE5v ZGUqIGNoaWxkKSB7IG1fbGFzdENoaWxkID0gY2hpbGQ7IH0KLSAgICAKKwogcHJpdmF0ZToKKyAg ICB2b2lkIGFkZENoaWxkQ29tbW9uKFBhc3NSZWZQdHI8Tm9kZT4pOworCiAgICAgc3RhdGljIHZv aWQgZGlzcGF0Y2hQb3N0QXR0YWNoQ2FsbGJhY2tzKCk7Ci0gICAgCisKICAgICBib29sIGdldFVw cGVyTGVmdENvcm5lcihGbG9hdFBvaW50JikgY29uc3Q7CiAgICAgYm9vbCBnZXRMb3dlclJpZ2h0 Q29ybmVyKEZsb2F0UG9pbnQmKSBjb25zdDsKIAo=