<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>41283</bug_id>
          
          <creation_ts>2010-06-28 10:05:41 -0700</creation_ts>
          <short_desc>[chromium] password autocomplete and field autocomplete should be moved out of EditorClientImpl.cpp</short_desc>
          <delta_ts>2010-10-29 13:02:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>48217</dependson>
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Jay Civelli">jcivelli</reporter>
          <assigned_to name="Jay Civelli">jcivelli</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>dpranke</cc>
    
    <cc>fishd</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>243743</commentid>
    <comment_count>0</comment_count>
    <who name="Jay Civelli">jcivelli</who>
    <bug_when>2010-06-28 10:05:41 -0700</bug_when>
    <thetext>The code for password autocompletion and form field autocomplete is currently in EditClientImpl.cpp
It should be moved to the Chromium code.
The motivation is to keep the logic out of the Chromium WebKit API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>295806</commentid>
    <comment_count>1</comment_count>
      <attachid>71096</attachid>
    <who name="Jay Civelli">jcivelli</who>
    <bug_when>2010-10-18 15:48:31 -0700</bug_when>
    <thetext>Created attachment 71096
Turning on the Chromium autocomplete implementation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>296483</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-10-19 15:54:25 -0700</bug_when>
    <thetext>fyi, FIXME in WebKit shouldn&apos;t contain names.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>297485</commentid>
    <comment_count>3</comment_count>
      <attachid>71450</attachid>
    <who name="Jay Civelli">jcivelli</who>
    <bug_when>2010-10-21 10:06:58 -0700</bug_when>
    <thetext>Created attachment 71450
Removed name in FIXME</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>298237</commentid>
    <comment_count>4</comment_count>
      <attachid>71450</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-10-22 16:06:49 -0700</bug_when>
    <thetext>Comment on attachment 71450
Removed name in FIXME

Clearing flags on attachment: 71450

Committed r70361: &lt;http://trac.webkit.org/changeset/70361&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>298238</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-10-22 16:06:55 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>300906</commentid>
    <comment_count>6</comment_count>
      <attachid>72149</attachid>
    <who name="Jay Civelli">jcivelli</who>
    <bug_when>2010-10-27 23:58:46 -0700</bug_when>
    <thetext>Created attachment 72149
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>300907</commentid>
    <comment_count>7</comment_count>
      <attachid>72150</attachid>
    <who name="Jay Civelli">jcivelli</who>
    <bug_when>2010-10-28 00:00:40 -0700</bug_when>
    <thetext>Created attachment 72150
Patch for landing</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>71096</attachid>
            <date>2010-10-18 15:48:31 -0700</date>
            <delta_ts>2010-10-21 10:06:58 -0700</delta_ts>
            <desc>Turning on the Chromium autocomplete implementation.</desc>
            <filename>autocomplete_on.patch</filename>
            <type>text/plain</type>
            <size>1091</size>
            <attacher name="Jay Civelli">jcivelli</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv
Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3MDAwMykKKysrIFdlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMC0xOCAgSmF5
IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHVybmluZyBvbiB0aGUgQXV0b2NvbXBsZXRlIGlt
cGxlbWVudGF0aW9uIG9uIHRoZSBDaHJvbWl1bSBzaWRlLgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEyODMKKworICAgICAgICAqIHB1YmxpYy9XZWJE
b2N1bWVudC5oOgorCiAyMDEwLTEwLTE4ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5j
b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpJbmRleDogV2ViS2l0
L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2No
cm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCShyZXZpc2lvbiA2OTk5NSkKKysrIFdlYktpdC9j
aHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMs
MTEgQEAKIAogI2luY2x1ZGUgIldlYk5vZGUuaCIKIAorLy8gVHVybmluZyBvbiBDaHJvbWl1bSBz
aWRlIEF1dG9jb21wbGV0ZSBjb2RlLgorLy8gRklYTUUoamNpdmVsbGkpOiByZW1vdmUgdGhpcyBv
bmNlIHRoZSBDaHJvbWl1bSBhdXRvY29tcGxldGUgY29kZSBoYXMgYmVlbgorLy8gICAgICAgICAg
ICAgICAgICBjbGVhbmVkLXVwLgorI2RlZmluZSBXRUJLSVRfQlVHXzQxMjgzX0lTX0ZJWEVECisK
ICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIERv
Y3VtZW50Owo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>71450</attachid>
            <date>2010-10-21 10:06:58 -0700</date>
            <delta_ts>2010-10-27 23:58:42 -0700</delta_ts>
            <desc>Removed name in FIXME</desc>
            <filename>autocomplete_on.patch</filename>
            <type>text/plain</type>
            <size>1060</size>
            <attacher name="Jay Civelli">jcivelli</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv
Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3MDAwMykKKysrIFdlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMC0xOCAgSmF5
IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHVybmluZyBvbiB0aGUgQXV0b2NvbXBsZXRlIGlt
cGxlbWVudGF0aW9uIG9uIHRoZSBDaHJvbWl1bSBzaWRlLgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEyODMKKworICAgICAgICAqIHB1YmxpYy9XZWJE
b2N1bWVudC5oOgorCiAyMDEwLTEwLTE4ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5j
b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpJbmRleDogV2ViS2l0
L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2No
cm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCShyZXZpc2lvbiA2OTk5NSkKKysrIFdlYktpdC9j
aHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMs
MTAgQEAKIAogI2luY2x1ZGUgIldlYk5vZGUuaCIKIAorLy8gVHVybmluZyBvbiBDaHJvbWl1bSBz
aWRlIEF1dG9jb21wbGV0ZSBjb2RlLgorLy8gRklYTUU6IHJlbW92ZSB0aGlzIG9uY2UgdGhlIENo
cm9taXVtIGF1dG9jb21wbGV0ZSBjb2RlIGhhcyBiZWVuIGNsZWFuZWQtdXAuCisjZGVmaW5lIFdF
QktJVF9CVUdfNDEyODNfSVNfRklYRUQKKwogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogbmFt
ZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgRG9jdW1lbnQ7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>72149</attachid>
            <date>2010-10-27 23:58:46 -0700</date>
            <delta_ts>2010-10-28 00:00:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-41283-20101027235845.patch</filename>
            <type>text/plain</type>
            <size>1166</size>
            <attacher name="Jay Civelli">jcivelli</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v
Q2hhbmdlTG9nCmluZGV4IGZlNjI3ODMyY2Q2YTczMDczZTU2YTY4N2ZmMzQ5YTk1ODQyNmU0Njcu
LjU5ZDk4ZGQ0NzI0MjFhMjdhNTg2OTk0ODQxZTdmNTE1MDEwMDQ0NTEgMTAwNjQ0Ci0tLSBhL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTI3ICBKYXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9t
aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBUcnlpbmcgdG8gcmVsYW5kIHI3MDM2MS4KKyAgICAgICAgVHVybmluZyBvbiB0aGUgQXV0b2Nv
bXBsZXRlIGltcGxlbWVudGF0aW9uIG9uIHRoZSBDaHJvbWl1bSBzaWRlLgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEyODMKKworICAgICAgICAqIHB1
YmxpYy9XZWJEb2N1bWVudC5oOgorCiAyMDEwLTEwLTI1ICBUb255IENoYW5nICA8dG9ueUBjaHJv
bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0t
Z2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oIGIvV2ViS2l0L2Nocm9t
aXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCmluZGV4IGQ5ZjczODY5MTIyM2FjOTgyYzQwYjlkOGQz
ZTljNzY0MDQzNmVlNGMuLjNkOTI3NGRjNmJhMGNiNzg1YTdhOTQwNGY0YTcxNmFkZDVkMDQ4MjIg
MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaAorKysgYi9X
ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmgKQEAgLTMzLDYgKzMzLDEwIEBACiAK
ICNpbmNsdWRlICJXZWJOb2RlLmgiCiAKKy8vIFR1cm5pbmcgb24gQ2hyb21pdW0gc2lkZSBBdXRv
Y29tcGxldGUgY29kZS4KKy8vIEZJWE1FOiByZW1vdmUgdGhpcyBvbmNlIHRoZSBDaHJvbWl1bSBh
dXRvY29tcGxldGUgY29kZSBoYXMgYmVlbiBjbGVhbmVkLXVwLgorI2RlZmluZSBXRUJLSVRfQlVH
XzQxMjgzX0lTX0ZJWEVECisKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KIG5hbWVzcGFjZSBX
ZWJDb3JlIHsKIGNsYXNzIERvY3VtZW50Owo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>72150</attachid>
            <date>2010-10-28 00:00:40 -0700</date>
            <delta_ts>2010-10-29 13:02:15 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-41283-20101028000039.patch</filename>
            <type>text/plain</type>
            <size>1166</size>
            <attacher name="Jay Civelli">jcivelli</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v
Q2hhbmdlTG9nCmluZGV4IGZlNjI3ODMyY2Q2YTczMDczZTU2YTY4N2ZmMzQ5YTk1ODQyNmU0Njcu
LjU5ZDk4ZGQ0NzI0MjFhMjdhNTg2OTk0ODQxZTdmNTE1MDEwMDQ0NTEgMTAwNjQ0Ci0tLSBhL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTI3ICBKYXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9t
aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBUcnlpbmcgdG8gcmVsYW5kIHI3MDM2MS4KKyAgICAgICAgVHVybmluZyBvbiB0aGUgQXV0b2Nv
bXBsZXRlIGltcGxlbWVudGF0aW9uIG9uIHRoZSBDaHJvbWl1bSBzaWRlLgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEyODMKKworICAgICAgICAqIHB1
YmxpYy9XZWJEb2N1bWVudC5oOgorCiAyMDEwLTEwLTI1ICBUb255IENoYW5nICA8dG9ueUBjaHJv
bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0t
Z2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oIGIvV2ViS2l0L2Nocm9t
aXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCmluZGV4IGQ5ZjczODY5MTIyM2FjOTgyYzQwYjlkOGQz
ZTljNzY0MDQzNmVlNGMuLjNkOTI3NGRjNmJhMGNiNzg1YTdhOTQwNGY0YTcxNmFkZDVkMDQ4MjIg
MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaAorKysgYi9X
ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmgKQEAgLTMzLDYgKzMzLDEwIEBACiAK
ICNpbmNsdWRlICJXZWJOb2RlLmgiCiAKKy8vIFR1cm5pbmcgb24gQ2hyb21pdW0gc2lkZSBBdXRv
Y29tcGxldGUgY29kZS4KKy8vIEZJWE1FOiByZW1vdmUgdGhpcyBvbmNlIHRoZSBDaHJvbWl1bSBh
dXRvY29tcGxldGUgY29kZSBoYXMgYmVlbiBjbGVhbmVkLXVwLgorI2RlZmluZSBXRUJLSVRfQlVH
XzQxMjgzX0lTX0ZJWEVECisKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KIG5hbWVzcGFjZSBX
ZWJDb3JlIHsKIGNsYXNzIERvY3VtZW50Owo=
</data>
<flag name="review"
          id="62616"
          type_id="1"
          status="+"
          setter="levin"
    />
    <flag name="commit-queue"
          id="62354"
          type_id="3"
          status="+"
          setter="levin"
    />
          </attachment>
      

    </bug>

</bugzilla>