41266 2010-06-27 13:29:47 -0700 [Qt] dump bf history of child windows 2010-06-28 11:47:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 robert webkit-unassigned oldest_to_newest 243496 0 robert 2010-06-27 13:29:47 -0700 Fixes http/tests/navigation/new-window-redirect-history.html 243497 1 59862 robert 2010-06-27 13:33:30 -0700 Created attachment 59862 Patch 243674 2 59862 kenneth 2010-06-28 06:42:11 -0700 Comment on attachment 59862 Patch WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:804 + if (m_controller->shouldDumpBackForwardList()) { WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807 + fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData()); indentation seems wrong here, please fix before committing WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807 + fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData()); I guess this would look less confusing, if you added the cast to a separate line. 243798 3 robert 2010-06-28 11:47:44 -0700 Committed r62020: <http://trac.webkit.org/changeset/62020> 59862 2010-06-27 13:33:30 -0700 2010-06-28 06:42:11 -0700 Patch bug-41266-20100627213321.patch text/plain 4119 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4ODM2MTY5Y2UwYjQwYjU2MjNkNWIyNDNjYTdhNWE1YzhmZDhkNWNlLi42OGFjMzI0 NDgyMzFhNWUwMjczYWFkMjk5MWU2YTE1YzE3ZTNmMzAyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDYtMjcgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gZHVtcCBiZiBoaXN0 b3J5IG9mIGNoaWxkIHdpbmRvd3MKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDEyNjYKKworICAgICAgICBVbnNraXAgaHR0cC90ZXN0cy9uYXZpZ2F0 aW9uL25ldy13aW5kb3ctcmVkaXJlY3QtaGlzdG9yeS5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9y bS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA2LTI3ICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGlu Z0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vcXQvU2tpcHBlZAppbmRleCBmNjJmNjkzOTIwYWQ5YjNmNDczODY4MTA3ZDRmYjFhZjUyZTZk NDc1Li4yYTFkZDlhMWJkZTNmMTc3NzAxY2YwZTQ1NDVhOTk3NTc2YjE3YzVlIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKQEAgLTIzMSw3ICsyMzEsNiBAQCBodHRwL3Rlc3RzL25hdmlnYXRpb24v bG9ja2VkaGlzdG9yeS1pZnJhbWUuaHRtbAogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL21ldGFyZWRp cmVjdC1mcmFtZXMuaHRtbAogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL21ldGFyZWRpcmVjdC1nb2Jh Y2suaHRtbAogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL21ldGFyZWRpcmVjdC1zdWJmcmFtZWxvYWQu aHRtbAotaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL25ldy13aW5kb3ctcmVkaXJlY3QtaGlzdG9yeS5o dG1sCiBodHRwL3Rlc3RzL25hdmlnYXRpb24vbm8tcmVmZXJyZXItcmVzZXQuaHRtbAogaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL25vLXJlZmVycmVyLXRhcmdldC1ibGFuay5odG1sCiBodHRwL3Rlc3Rz L25hdmlnYXRpb24vb25sb2FkLW5hdmlnYXRpb24taWZyYW1lLTIuaHRtbApkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDkzNTJj NTRlZTlmMWVjYWQyY2JmYTJiN2Q2YjUwYmYxYzExZTM4MzcuLjRjOWIyMjRmYjM1MTE4OTFkMDJi YzdiMzI0MzhlMjgxMmIxYWNhNzggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZwor KysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNi0yNyAg Um9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBkdW1wIGJmIGhpc3Rvcnkgb2YgY2hpbGQg d2luZG93cworCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MTI2NgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpEdW1wUmVuZGVyVHJlZTo6ZHVtcEJhY2tGb3J3YXJkTGlz dCk6CisgICAgICAgIChXZWJDb3JlOjpEdW1wUmVuZGVyVHJlZTo6ZHVtcCk6CisgICAgICAgICog RHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5oOgorCiAyMDEwLTA2LTIxICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKaW5kZXggZjVmYmI1YzE4MTA1MDViNmM3ZTY2ZGNl MzJmY2VhNDFhZDUwMDJiZS4uYzc3YTg2M2NmOWUzNDcyNWIwODhmZmY1NGI0YzdjODU4NWMwNzE3 OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWVRdC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWVRdC5jcHAKQEAgLTcyOCw5ICs3MjgsOSBAQCBzdGF0aWMgUVN0cmluZyBkdW1wSGlzdG9yeUl0 ZW0oY29uc3QgUVdlYkhpc3RvcnlJdGVtJiBpdGVtLCBpbnQgaW5kZW50LCBib29sIGN1cgogICAg IHJldHVybiByZXN1bHQ7CiB9CiAKLVFTdHJpbmcgRHVtcFJlbmRlclRyZWU6OmR1bXBCYWNrRm9y d2FyZExpc3QoKQorUVN0cmluZyBEdW1wUmVuZGVyVHJlZTo6ZHVtcEJhY2tGb3J3YXJkTGlzdChR V2ViUGFnZSogcGFnZSkKIHsKLSAgICBRV2ViSGlzdG9yeSogaGlzdG9yeSA9IHdlYlBhZ2UoKS0+ aGlzdG9yeSgpOworICAgIFFXZWJIaXN0b3J5KiBoaXN0b3J5ID0gcGFnZS0+aGlzdG9yeSgpOwog CiAgICAgUVN0cmluZyByZXN1bHQ7CiAgICAgcmVzdWx0LmFwcGVuZChRTGF0aW4xU3RyaW5nKCJc bj09PT09PT09PT09PT09IEJhY2sgRm9yd2FyZCBMaXN0ID09PT09PT09PT09PT09XG4iKSk7CkBA IC04MDEsOCArODAxLDExIEBAIHZvaWQgRHVtcFJlbmRlclRyZWU6OmR1bXAoKQogICAgICAgICBm cHJpbnRmKHN0ZG91dCwgIkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpblxuIik7CiAgICAgICAgIGZw cmludGYoc3Rkb3V0LCAiJXMiLCByZXN1bHRTdHJpbmcudG9VdGY4KCkuY29uc3REYXRhKCkpOwog Ci0gICAgICAgIGlmIChtX2NvbnRyb2xsZXItPnNob3VsZER1bXBCYWNrRm9yd2FyZExpc3QoKSkK LSAgICAgICAgICAgIGZwcmludGYoc3Rkb3V0LCAiJXMiLCBkdW1wQmFja0ZvcndhcmRMaXN0KCku dG9VdGY4KCkuY29uc3REYXRhKCkpOworICAgICAgICBpZiAobV9jb250cm9sbGVyLT5zaG91bGRE dW1wQmFja0ZvcndhcmRMaXN0KCkpIHsKKyAgICAgICAgICAgIGZwcmludGYoc3Rkb3V0LCAiJXMi LCBkdW1wQmFja0ZvcndhcmRMaXN0KHdlYlBhZ2UoKSkudG9VdGY4KCkuY29uc3REYXRhKCkpOwor ICAgICAgICAgICAgZm9yZWFjaCAoUU9iamVjdCogd2lkZ2V0LCB3aW5kb3dzKQorICAgICAgICAg ICAgICBmcHJpbnRmKHN0ZG91dCwgIiVzIiwgZHVtcEJhY2tGb3J3YXJkTGlzdChxb2JqZWN0X2Nh c3Q8UVdlYlBhZ2UqPih3aWRnZXQtPmZpbmRDaGlsZDxRV2ViUGFnZSo+KCkpKS50b1V0ZjgoKS5j b25zdERhdGEoKSk7CisgICAgICAgIH0KIAogICAgIH0gZWxzZQogICAgICAgICBwcmludGYoIkVS Uk9SOiBuaWwgcmVzdWx0IGZyb20gJXMiLCBtZXRob2ROYW1lU3RyaW5nRm9yRmFpbGVkVGVzdCht X2NvbnRyb2xsZXIpKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0R1bXBSZW5kZXJUcmVlUXQuaCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBS ZW5kZXJUcmVlUXQuaAppbmRleCAyZWM5NzJhNDU5NWVkMzliYjdiZTQ5MjUwYTViNDUzODI5ZmFm OTE1Li5iNmZkMmIxZTRhNDZkMmE3NzFjNmRhYzdkODhiOTM1ZTQ2MGI1N2NjIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmgKKysrIGIv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5oCkBAIC0xMzMs NyArMTMzLDcgQEAgcHJpdmF0ZSBRX1NMT1RTOgogCiBwcml2YXRlOgogICAgIFFTdHJpbmcgZHVt cEZyYW1lc0FzVGV4dChRV2ViRnJhbWUqIGZyYW1lKTsKLSAgICBRU3RyaW5nIGR1bXBCYWNrRm9y d2FyZExpc3QoKTsKKyAgICBRU3RyaW5nIGR1bXBCYWNrRm9yd2FyZExpc3QoUVdlYlBhZ2UqIHBh Z2UpOwogICAgIExheW91dFRlc3RDb250cm9sbGVyICptX2NvbnRyb2xsZXI7CiAKICAgICBib29s IG1fZHVtcFBpeGVsczsK