41239 2010-06-25 17:30:35 -0700 We should parse <html> 2010-06-28 13:08:24 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth ap eric oldest_to_newest 243272 0 abarth 2010-06-25 17:30:35 -0700 We should parse <html> 243276 1 59816 abarth 2010-06-25 17:34:28 -0700 Created attachment 59816 Patch 243278 2 59816 eric 2010-06-25 17:39:35 -0700 Comment on attachment 59816 Patch OK. rs=me. 243285 3 59816 abarth 2010-06-25 17:48:09 -0700 Comment on attachment 59816 Patch Clearing flags on attachment: 59816 Committed r61925: <http://trac.webkit.org/changeset/61925> 243286 4 abarth 2010-06-25 17:48:14 -0700 All reviewed patches have been landed. Closing bug. 243765 5 ap 2010-06-28 10:40:41 -0700 > This patch is hard to test Why is it hard to test? Won't an iframe pointing to such a document do it? Or is it that HTMLTreeBuilder is in a state where nothing works yet? 243771 6 abarth 2010-06-28 10:46:15 -0700 > Why is it hard to test? Won't an iframe pointing to such a document do it? You're presupposing that we could parse an <iframe> tag at this point. Literally, this patch let us parse the document "<html>" and nothing else. > Or is it that HTMLTreeBuilder is in a state where nothing works yet? We're rapidly approaching the point where we can parse HTML5lib's runner.html. At that point, adding tests will be easy. 243842 7 eric 2010-06-28 13:08:24 -0700 We actually cant' run the runner yet, but we're testing it it already: https://trac.webkit.org/changeset/61989 https://trac.webkit.org/changeset/61991 59816 2010-06-25 17:34:28 -0700 2010-06-25 17:48:09 -0700 Patch bug-41239-20100625173427.patch text/plain 6113 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzhhY2U0OWYzYTBkMjM5MjhiODU0ZjMwMGM5NDQ0OTBkNTA2YTU2Zi4uMDgzNDMzZTBjNmVkOTcy ZmU0YzQ4ZGQ2ZmRlMzhkMTI1NWQwNjk2YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyNSBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFdlIHNob3VsZCBwYXJzZSA8aHRtbD4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMjM5CisK KyAgICAgICAgVGhpcyBwYXRjaCBpcyBoYXJkIHRvIHRlc3QsIGJ1dCBJIHRoaW5rIHRoaXMgcGF0 Y2ggbGV0cyB1cyBwYXJzZSBhCisgICAgICAgIGRvY3VtZW50IGNvbnNpc3Rpbmcgb2Ygb25seSBh biA8aHRtbD4gc3RhcnQgdGFnLgorCisgICAgICAgICogaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpjb25zdHJ1Y3RUcmVlRnJvbVRv a2VuKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6aW5zZXJ0SFRNTFN0YXJ0 VGFnQmVmb3JlSFRNTCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6Omluc2Vy dEhUTUxTdGFydFRhZ0luQm9keSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6 OnByb2Nlc3NTdGFydFRhZyk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnBy b2Nlc3NEZWZhdWx0Rm9yQmVmb3JlSFRNTE1vZGUpOgorICAgICAgICAqIGh0bWwvSFRNTFRyZWVC dWlsZGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OkVsZW1lbnRTdGFj azo6cHVzaCk6CisKKzIwMTAtMDYtMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBIVE1MVHJl ZUJ1aWxkZXIgc2hvdWxkIGJyYW5jaCBmaXJzdCBvbiB0b2tlbiB0eXBlIGFuZCB0aGVuIG9uIGlu c2VydGlvbiBtb2RlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MTIzMgogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNw cCBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCmluZGV4IGFmNDYwOTJhYWJlYThk NmVhMjdiMGMyZjUyYWFlZTNkMGMyZDJiMTUuLmIyMDQyZTZlMDkxNDBkZmEzNWRmZGI3YTU0MDE2 YWUzN2UwMTgzOTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3Bw CisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC0zMiw2ICszMiw3IEBA CiAjaW5jbHVkZSAiSFRNTFRva2VuaXplci5oIgogI2luY2x1ZGUgIkhUTUxUb2tlbi5oIgogI2lu Y2x1ZGUgIkhUTUxEb2N1bWVudC5oIgorI2luY2x1ZGUgIkhUTUxIdG1sRWxlbWVudC5oIgogI2lu Y2x1ZGUgIkxlZ2FjeUhUTUxEb2N1bWVudFBhcnNlci5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5o IgogI2luY2x1ZGUgIkxlZ2FjeUhUTUxUcmVlQnVpbGRlci5oIgpAQCAtMjI1LDcgKzIyNiw3IEBA IHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpjb25zdHJ1Y3RUcmVlRnJvbVRva2VuKEhUTUxUb2tlbiYg cmF3VG9rZW4pCiAgICAgfQogCiAgICAgQXRvbWljSFRNTFRva2VuIHRva2VuKHJhd1Rva2VuKTsK LSAgICByZXR1cm4gcHJvY2Vzc1Rva2VuKHRva2VuKTsKKyAgICBwcm9jZXNzVG9rZW4odG9rZW4p OwogfQogCiB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc1Rva2VuKEF0b21pY0hUTUxUb2tl biYgdG9rZW4pCkBAIC0yNjQsNiArMjY1LDE5IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpwcm9j ZXNzRG9jdHlwZVRva2VuKEF0b21pY0hUTUxUb2tlbiYgdG9rZW4pCiAgICAgcGFyc2VFcnJvcih0 b2tlbik7CiB9CiAKK3ZvaWQgSFRNTFRyZWVCdWlsZGVyOjppbnNlcnRIVE1MU3RhcnRUYWdCZWZv cmVIVE1MKEF0b21pY0hUTUxUb2tlbiYpCit7CisgICAgUmVmUHRyPEVsZW1lbnQ+IGVsZW1lbnQg PSBIVE1MSHRtbEVsZW1lbnQ6OmNyZWF0ZShtX2RvY3VtZW50KTsKKyAgICAvLyBGSVhNRTogQWRk IGF0dHJpYnV0ZXMgdG8gfGVsZW1lbnR8LgorICAgIG1fZG9jdW1lbnQtPmFkZENoaWxkKGVsZW1l bnQpOworICAgIG1fb3BlbkVsZW1lbnRzLnB1c2goZWxlbWVudC5yZWxlYXNlKCkpOworfQorCit2 b2lkIEhUTUxUcmVlQnVpbGRlcjo6aW5zZXJ0SFRNTFN0YXJ0VGFnSW5Cb2R5KEF0b21pY0hUTUxU b2tlbiYpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwogdm9pZCBIVE1MVHJlZUJ1aWxk ZXI6OnByb2Nlc3NTdGFydFRhZyhBdG9taWNIVE1MVG9rZW4mIHRva2VuKQogewogICAgIHN3aXRj aCAoaW5zZXJ0aW9uTW9kZSgpKSB7CkBAIC0yNzQsNyArMjg4LDcgQEAgdm9pZCBIVE1MVHJlZUJ1 aWxkZXI6OnByb2Nlc3NTdGFydFRhZyhBdG9taWNIVE1MVG9rZW4mIHRva2VuKQogICAgIGNhc2Ug QmVmb3JlSFRNTE1vZGU6CiAgICAgICAgIEFTU0VSVChpbnNlcnRpb25Nb2RlKCkgPT0gQmVmb3Jl SFRNTE1vZGUpOwogICAgICAgICBpZiAodG9rZW4ubmFtZSgpID09IGh0bWxUYWcpIHsKLSAgICAg ICAgICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgICAgICAgICBpbnNlcnRIVE1MU3RhcnRUYWdC ZWZvcmVIVE1MKHRva2VuKTsKICAgICAgICAgICAgIHNldEluc2VydGlvbk1vZGUoQmVmb3JlSGVh ZE1vZGUpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CkBAIC0yODMsNyArMjk3LDcg QEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFydFRhZyhBdG9taWNIVE1MVG9rZW4m IHRva2VuKQogICAgIGNhc2UgQmVmb3JlSGVhZE1vZGU6CiAgICAgICAgIEFTU0VSVChpbnNlcnRp b25Nb2RlKCkgPT0gQmVmb3JlSGVhZE1vZGUpOwogICAgICAgICBpZiAodG9rZW4ubmFtZSgpID09 IGh0bWxUYWcpIHsKLSAgICAgICAgICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgICAgICAgICBp bnNlcnRIVE1MU3RhcnRUYWdJbkJvZHkodG9rZW4pOwogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB9CiAgICAgICAgIGlmICh0b2tlbi5uYW1lKCkgPT0gaGVhZFRhZykgewpAQCAtMjk2LDcg KzMxMCw3IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzU3RhcnRUYWcoQXRvbWljSFRN TFRva2VuJiB0b2tlbikKICAgICBjYXNlIEluSGVhZE1vZGU6CiAgICAgICAgIEFTU0VSVChpbnNl cnRpb25Nb2RlKCkgPT0gSW5IZWFkTW9kZSk7CiAgICAgICAgIGlmICh0b2tlbi5uYW1lKCkgPT0g aHRtbFRhZykgewotICAgICAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgICAgIGlu c2VydEhUTUxTdGFydFRhZ0luQm9keSh0b2tlbik7CiAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgIH0KICAgICAgICAgLy8gRklYTUU6IEF0b21pemUgImNvbW1hbmQiLgpAQCAtMzQyLDcgKzM1 Niw3IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzU3RhcnRUYWcoQXRvbWljSFRNTFRv a2VuJiB0b2tlbikKICAgICBjYXNlIEFmdGVySGVhZE1vZGU6CiAgICAgICAgIEFTU0VSVChpbnNl cnRpb25Nb2RlKCkgPT0gQWZ0ZXJIZWFkTW9kZSk7CiAgICAgICAgIGlmICh0b2tlbi5uYW1lKCkg PT0gaHRtbFRhZykgewotICAgICAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgICAg IGluc2VydEhUTUxTdGFydFRhZ0luQm9keSh0b2tlbik7CiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KICAgICAgICAgaWYgKHRva2VuLm5hbWUoKSA9PSBib2R5VGFnKSB7CkBAIC0zNTgs NyArMzcyLDcgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFydFRhZyhBdG9taWNI VE1MVG9rZW4mIHRva2VuKQogICAgICAgICBpZiAodG9rZW4ubmFtZSgpID09IGJhc2VUYWcgfHwg dG9rZW4ubmFtZSgpID09IGxpbmtUYWcgfHwgdG9rZW4ubmFtZSgpID09IG1ldGFUYWcgfHwgdG9r ZW4ubmFtZSgpID09IG5vZnJhbWVzVGFnIHx8IHRva2VuLm5hbWUoKSA9PSBzY3JpcHRUYWcgfHwg dG9rZW4ubmFtZSgpID09IHN0eWxlVGFnIHx8IHRva2VuLm5hbWUoKSA9PSB0aXRsZVRhZykgewog ICAgICAgICAgICAgcGFyc2VFcnJvcih0b2tlbik7CiAgICAgICAgICAgICBBU1NFUlQobV9oZWFk RWxlbWVudCk7Ci0gICAgICAgICAgICBtX29wZW5FbGVtZW50cy5wdXNoKG1faGVhZEVsZW1lbnQu Z2V0KCkpOworICAgICAgICAgICAgbV9vcGVuRWxlbWVudHMucHVzaChtX2hlYWRFbGVtZW50KTsK ICAgICAgICAgICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgICAgICAgICBtX29wZW5FbGVtZW50 cy5yZW1vdmUobV9oZWFkRWxlbWVudC5nZXQoKSk7CiAgICAgICAgICAgICByZXR1cm47CkBAIC0z NzYsNyArMzkwLDcgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFydFRhZyhBdG9t aWNIVE1MVG9rZW4mIHRva2VuKQogICAgIGNhc2UgSW5IZWFkTm9zY3JpcHRNb2RlOgogICAgICAg ICBBU1NFUlQoaW5zZXJ0aW9uTW9kZSgpID09IEluSGVhZE5vc2NyaXB0TW9kZSk7CiAgICAgICAg IGlmICh0b2tlbi5uYW1lKCkgPT0gaHRtbFRhZykgewotICAgICAgICAgICAgbm90SW1wbGVtZW50 ZWQoKTsKKyAgICAgICAgICAgIGluc2VydEhUTUxTdGFydFRhZ0luQm9keSh0b2tlbik7CiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgaWYgKHRva2VuLm5hbWUoKSA9PSBs aW5rVGFnIHx8IHRva2VuLm5hbWUoKSA9PSBtZXRhVGFnIHx8IHRva2VuLm5hbWUoKSA9PSBub2Zy YW1lc1RhZyB8fCB0b2tlbi5uYW1lKCkgPT0gc3R5bGVUYWcpIHsKQEAgLTUyMyw3ICs1MzcsOCBA QCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0RlZmF1bHRGb3JJbml0aWFsTW9kZShBdG9t aWNIVE1MVG9rZW4mIHRva2VuKQogCiB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0RlZmF1 bHRGb3JCZWZvcmVIVE1MTW9kZShBdG9taWNIVE1MVG9rZW4mKQogewotICAgIG5vdEltcGxlbWVu dGVkKCk7CisgICAgQXRvbWljSFRNTFRva2VuIHN0YXJ0SFRNTChIVE1MVG9rZW46OlN0YXJ0VGFn LCBodG1sVGFnLmxvY2FsTmFtZSgpKTsKKyAgICBpbnNlcnRIVE1MU3RhcnRUYWdCZWZvcmVIVE1M KHN0YXJ0SFRNTCk7CiAgICAgc2V0SW5zZXJ0aW9uTW9kZShCZWZvcmVIZWFkTW9kZSk7CiB9CiAK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuaCBiL1dlYkNvcmUvaHRt bC9IVE1MVHJlZUJ1aWxkZXIuaAppbmRleCBiZGNjZDNiYmJkZThkN2M0NDVmZTg2MWI3NWQ3M2Vi ZWY5ODZkY2IzLi4wOGMzMjBmMjE0MGRlZDBiMjFkYTY2ZjgxY2M0NTVjNWFkOTc0YTA3IDEwMDY0 NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmgKKysrIGIvV2ViQ29yZS9odG1s L0hUTUxUcmVlQnVpbGRlci5oCkBAIC0xMDIsNyArMTAyLDcgQEAgcHJpdmF0ZToKICAgICBjbGFz cyBFbGVtZW50U3RhY2sgOiBwdWJsaWMgTm9uY29weWFibGUgewogICAgIHB1YmxpYzoKICAgICAg ICAgdm9pZCBwb3AoKSB7IH0KLSAgICAgICAgdm9pZCBwdXNoKEVsZW1lbnQqKSB7IH0KKyAgICAg ICAgdm9pZCBwdXNoKFBhc3NSZWZQdHI8RWxlbWVudD4pIHsgfQogICAgICAgICB2b2lkIHJlbW92 ZShFbGVtZW50KikgeyB9CiAgICAgICAgIEVsZW1lbnQqIHRvcCgpIGNvbnN0IHsgcmV0dXJuIDA7 IH0KICAgICB9OwpAQCAtMTM0LDYgKzEzNCw5IEBAIHByaXZhdGU6CiAgICAgdm9pZCBpbnNlcnRH ZW5lcmljUmF3VGV4dEVsZW1lbnQoQXRvbWljSFRNTFRva2VuJik7CiAgICAgdm9pZCBpbnNlcnRT Y3JpcHRFbGVtZW50KEF0b21pY0hUTUxUb2tlbiYpOwogCisgICAgdm9pZCBpbnNlcnRIVE1MU3Rh cnRUYWdCZWZvcmVIVE1MKEF0b21pY0hUTUxUb2tlbiYpOworICAgIHZvaWQgaW5zZXJ0SFRNTFN0 YXJ0VGFnSW5Cb2R5KEF0b21pY0hUTUxUb2tlbiYpOworCiAgICAgUmVmUHRyPEVsZW1lbnQ+IG1f aGVhZEVsZW1lbnQ7CiAgICAgRWxlbWVudFN0YWNrIG1fb3BlbkVsZW1lbnRzOwogICAgIGJvb2wg bV9mcmFtZXNldE9rOwo=