41198 2010-06-25 01:03:18 -0700 [QT][S60] build-webkit scripts picks wrong make spec for windows build 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP CLOSED FIXED Qt, QtTriaged P2 Normal --- 0 maheshk webkit-unassigned commit-queue hausmann laszlo.gombos oldest_to_newest 242882 0 maheshk 2010-06-25 01:03:18 -0700 While building webkit with "build-webkit --qt" for windows port, symbian makespec is picked by scripts. Env variable %EPOCROOT% existence is treated as symbian builds resulting in only either of build to work (windows or symbian port) 242883 1 59741 maheshk 2010-06-25 01:11:49 -0700 Created attachment 59741 remove EPOCROOT check Do not check for existence of %EPOCROOT% in determineIsSymbian(). As fails to build windows port of QtWebkit on same machine which has symbian env setup. To build for symbian, we have 1) use "build-webkit --qt --symbian" 2) \epoc32\tools comes before windows QTDIR setup in %PATH% 243009 2 laszlo.gombos 2010-06-25 07:56:52 -0700 This makes sense to me so I support this change. I think for Symbian builds most people use the "--symbian" option already. %EPOCROOT% could be set for various reasons (e.g. one installed the Symbian SDK) which does not necessary implies that one is looking for a Symbian build. I think the other valid point is that there is no way to force a windows build if %EPOCROOT% is set - yes this can be easily worked around. Simon, what do you think (as the original author if this code) ? 243419 3 59741 hausmann 2010-06-26 14:11:44 -0700 Comment on attachment 59741 remove EPOCROOT check Looks good to me. 243556 4 59741 maheshk 2010-06-27 21:32:03 -0700 Comment on attachment 59741 remove EPOCROOT check Raising check-in request 243649 5 59741 hausmann 2010-06-28 04:19:11 -0700 Comment on attachment 59741 remove EPOCROOT check Please set cq+ at patch upload time. 243653 6 59741 commit-queue 2010-06-28 04:34:23 -0700 Comment on attachment 59741 remove EPOCROOT check Rejecting patch 59741 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Simon Hausmann', u'--force']" exit_code: 1 Last 500 characters of output: g Hunk #1 succeeded at 1 with fuzz 3. (Stripping trailing CRs from patch.) can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: Scripts/webkitdirs.pm |=================================================================== |--- Scripts/webkitdirs.pm (revision 61528) |+++ Scripts/webkitdirs.pm (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Full output: http://webkit-commit-queue.appspot.com/results/3279869 243659 7 hausmann 2010-06-28 05:22:06 -0700 Committed r61995: <http://trac.webkit.org/changeset/61995> 244149 8 hausmann 2010-06-29 01:05:32 -0700 Revision r61995 cherry-picked into qtwebkit-2.0 with commit 85e7e360c2cb0653f8c6885e0f5d06743e077d11 244150 9 hausmann 2010-06-29 01:12:22 -0700 Revision r61995 cherry-picked into qtwebkit-2.0 with commit 85e7e360c2cb0653f8c6885e0f5d06743e077d11 59741 2010-06-25 01:11:49 -0700 2010-06-28 04:34:23 -0700 remove EPOCROOT check symbian_build.patch text/plain 1088 maheshk SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gNjE4 MzgpDQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpDQpAQCAtMSwzICsxLDE1IEBADQorMjAx MC0wNi0xMCAgTWFoZXNoIEt1bGthcm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUVRdW1M2MF0g YnVpbGQtd2Via2l0IHNjcmlwdHMgcGlja3Mgd3JvbmcgbWFrZSBzcGVjIGZvciB3aW5kb3dzIGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTE5 OAorCisgICAgICAgIEluc3RlYWQgb2YgY2hlY2tpbmcgZm9yIGV4aXN0ZW5jZSBvZiAlRVBPQ1JP T1QlIG9uIHdpbmRvd3MsIG1hbmRhdG9yeSB1c2Ugb2YgLS1zeW1iaWFuIGZsYWcgZm9yIHN5bWJp YW4gYnVpbGRzLiAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAg KGRldGVybWluZUlzU3ltYmlhbik6IHJlbW92ZSBjaGVjayBmb3IgJUVQT0NST09UJSBhcyBvbmUg Y2FuIGJ1aWxkIGZvciB3aW5kb3dzIHBvcnQgb2YgUVQgYXMgd2VsbAorICAgICAgICAKIDIwMTAt MDYtMjQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNjcmlwdHMvd2Via2l0ZGlycy5wbQ0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQ0KLS0tIFNjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gNjE1MjgpDQorKysgU2NyaXB0 cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpDQpAQCAtNjg3LDggKzY4Nyw2IEBADQogICAg ICAgICAkaXNTeW1iaWFuID0gMTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLQotICAgICRpc1N5 bWJpYW4gPSBkZWZpbmVkKCRFTlZ7J0VQT0NST09UJ30pOwogfQogCiBzdWIgZGV0ZXJtaW5lSXNF ZmwoKQo=