<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>41190</bug_id>
          
          <creation_ts>2010-06-24 20:55:50 -0700</creation_ts>
          <short_desc>Canvas: Don&apos;t paint with empty radial gradients</short_desc>
          <delta_ts>2010-07-01 20:03:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>HTML5</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>adele</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mdelaney7</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>242799</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-06-24 20:55:50 -0700</bug_when>
    <thetext>CanvasRenderingContext2D shouldn&apos;t paint anything with radial gradients that have x0==x1, y0==y1 and r0==r1.
Similar logic is already in place for linear gradients.

This would fix canvas/philip/tests/2d.gradient.radial.equal.html on Qt.

The test is not skipped on mac, so I suppose there&apos;s something further down the stack that prevents painting with these gradients.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>242801</commentid>
    <comment_count>1</comment_count>
      <attachid>59723</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-06-24 21:00:16 -0700</bug_when>
    <thetext>Created attachment 59723
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244840</commentid>
    <comment_count>2</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-06-30 10:47:11 -0700</bug_when>
    <thetext>Tossing in a spec link for good measure:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createradialgradient

&quot;If x0 = x1 and y0 = y1 and r0 = r1, then the radial gradient must paint nothing.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245499</commentid>
    <comment_count>3</comment_count>
      <attachid>60275</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-07-01 12:52:34 -0700</bug_when>
    <thetext>Created attachment 60275
Proposed patch v2

Style nit - s/1/true/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245504</commentid>
    <comment_count>4</comment_count>
      <attachid>60275</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-07-01 12:58:03 -0700</bug_when>
    <thetext>Comment on attachment 60275
Proposed patch v2

&gt; -        bool isZeroSize() const { return m_p0.x() == m_p1.x() &amp;&amp; m_p0.y() == m_p1.y(); }
&gt; +        bool isZeroSize() const { return m_p0.x() == m_p1.x() &amp;&amp; m_p0.y() == m_p1.y() &amp;&amp; (m_radial ? m_r0 == m_r1 : true); }

I think it would read better as:

    (!m_radial || m_r0 == m_r1)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245517</commentid>
    <comment_count>5</comment_count>
      <attachid>60280</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-07-01 13:25:35 -0700</bug_when>
    <thetext>Created attachment 60280
Proposed patch v3 (Darinized)

That looks nicer indeed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245518</commentid>
    <comment_count>6</comment_count>
      <attachid>60280</attachid>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2010-07-01 13:26:57 -0700</bug_when>
    <thetext>Comment on attachment 60280
Proposed patch v3 (Darinized)

Thanks Andreas!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245717</commentid>
    <comment_count>7</comment_count>
      <attachid>60280</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-07-01 20:03:46 -0700</bug_when>
    <thetext>Comment on attachment 60280
Proposed patch v3 (Darinized)

Clearing flags on attachment: 60280

Committed r62350: &lt;http://trac.webkit.org/changeset/62350&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245718</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-07-01 20:03:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>59723</attachid>
            <date>2010-06-24 21:00:16 -0700</date>
            <delta_ts>2010-07-01 12:52:34 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>bug-41190.diff</filename>
            <type>text/plain</type>
            <size>3456</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAzOWU5YzQwLi5hNDY1ZmZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYt
MjQgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW52YXM6IERvbid0IHBhaW50
IHdpdGggZW1wdHkgcmFkaWFsIGdyYWRpZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExOTAKKworICAgICAgICBVbnNraXAgY2FudmFzL3BoaWxp
cC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuZXF1YWwuaHRtbCBmb3IgUXQuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA2LTI0ICBKYW1lcyBSb2JpbnNvbiAgPGph
bWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkIG1hYyBwaXhlbCBi
YXNlbGluZXMgZm9yIGZhc3QvaW1hZ2VzL2ljb24tZGVjb2RpbmcgYW5kIGZpeCBFT0xzIGZvciB0
ZXh0IGJhc2VsaW5lLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl
ZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggNjVmNzlmYi4uYzdiYmZm
OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlv
dXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC01MjY4LDcgKzUyNjgsNiBAQCBjYW52YXMv
cGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmN5bGluZGVyLmh0bWwKIGNhbnZh
cy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUuZnJvbnQuaHRtbAogY2FudmFz
L3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5zaGFwZTIuaHRtbAogY2FudmFz
L3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbAotY2FudmFzL3Bo
aWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuZXF1YWwuaHRtbAogY2FudmFzL3BoaWxpcC90
ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuaW5zaWRlMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3Rz
LzJkLmdyYWRpZW50LnJhZGlhbC5pbnNpZGUzLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu
Z3JhZGllbnQucmFkaWFsLm5lZ2F0aXZlLmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl
TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg5YzVjOC4uZDU4OGFlMSAxMDA2NDQKLS0t
IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
NyBAQAorMjAxMC0wNi0yNCAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbnZh
czogRG9uJ3QgcGFpbnQgd2l0aCBlbXB0eSByYWRpYWwgZ3JhZGllbnRzCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTE5MAorCisgICAgICAgIElmIGEg
cmFkaWFsIGdyYWRpZW50IGhhcyB4MD09eDEgJiYgeTA9PXkxICYmIHIwPT1yMSwgZG9uJ3QgcGFp
bnQgd2l0aCBpdC4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRl
eHQyRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmZp
bGxSZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oOgorICAgICAg
ICAoV2ViQ29yZTo6R3JhZGllbnQ6OmlzWmVyb1NpemUpOgorCiAyMDEwLTA2LTI0ICBFcmljIFNl
aWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRo
LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0
MkQuY3BwIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3Bw
CmluZGV4IDUyMmU1MWQuLjg4OWZhYTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9jYW52YXMv
Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAorKysgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh
bnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKQEAgLTc1NSw4ICs3NTUsOSBAQCB2b2lkIENhbnZh
c1JlbmRlcmluZ0NvbnRleHQyRDo6ZmlsbFJlY3QoZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgd2lk
dGgsIGZsb2F0IGhlaQogCiAgICAgLy8gZnJvbSB0aGUgSFRNTDUgQ2FudmFzIHNwZWM6CiAgICAg
Ly8gSWYgeDAgPSB4MSBhbmQgeTAgPSB5MSwgdGhlbiB0aGUgbGluZWFyIGdyYWRpZW50IG11c3Qg
cGFpbnQgbm90aGluZworICAgIC8vIElmIHgwID0geDEgYW5kIHkwID0geTEgYW5kIHIwID0gcjEs
IHRoZW4gdGhlIHJhZGlhbCBncmFkaWVudCBtdXN0IHBhaW50IG5vdGhpbmcKICAgICBHcmFkaWVu
dCogZ3JhZGllbnQgPSBjLT5maWxsR3JhZGllbnQoKTsKLSAgICBpZiAoZ3JhZGllbnQgJiYgZ3Jh
ZGllbnQtPmlzWmVyb1NpemUoKSAmJiAhZ3JhZGllbnQtPmlzUmFkaWFsKCkpCisgICAgaWYgKGdy
YWRpZW50ICYmIGdyYWRpZW50LT5pc1plcm9TaXplKCkpCiAgICAgICAgIHJldHVybjsKIAogICAg
IEZsb2F0UmVjdCByZWN0KHgsIHksIHdpZHRoLCBoZWlnaHQpOwpkaWZmIC0tZ2l0IGEvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9HcmFkaWVudC5oCmluZGV4IDg4NzdmNmYuLjU0NjMxMGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL0dyYWRpZW50LmgKQEAgLTg5LDcgKzg5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg
ICAgICB2b2lkIGdldENvbG9yKGZsb2F0IHZhbHVlLCBmbG9hdCogciwgZmxvYXQqIGcsIGZsb2F0
KiBiLCBmbG9hdCogYSkgY29uc3Q7CiAKICAgICAgICAgYm9vbCBpc1JhZGlhbCgpIGNvbnN0IHsg
cmV0dXJuIG1fcmFkaWFsOyB9Ci0gICAgICAgIGJvb2wgaXNaZXJvU2l6ZSgpIGNvbnN0IHsgcmV0
dXJuIG1fcDAueCgpID09IG1fcDEueCgpICYmIG1fcDAueSgpID09IG1fcDEueSgpOyB9CisgICAg
ICAgIGJvb2wgaXNaZXJvU2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fcDAueCgpID09IG1fcDEueCgp
ICYmIG1fcDAueSgpID09IG1fcDEueSgpICYmIChtX3JhZGlhbCA/IG1fcjAgPT0gbV9yMSA6IDEp
OyB9CiAKICNpZiBPUyhXSU5DRSkgJiYgIVBMQVRGT1JNKFFUKQogICAgICAgICBjb25zdCBGbG9h
dFBvaW50JiBwMCgpIGNvbnN0IHsgcmV0dXJuIG1fcDA7IH0K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60275</attachid>
            <date>2010-07-01 12:52:34 -0700</date>
            <delta_ts>2010-07-01 13:28:29 -0700</delta_ts>
            <desc>Proposed patch v2</desc>
            <filename>bug-41190-v2.diff</filename>
            <type>text/plain</type>
            <size>3470</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAwNjQ0YTE4Li44YzI0M2U1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDct
MDEgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW52YXM6IERvbid0IHBhaW50
IHdpdGggZW1wdHkgcmFkaWFsIGdyYWRpZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExOTAKKworICAgICAgICBVbnNraXAgY2FudmFzL3BoaWxp
cC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuZXF1YWwuaHRtbCBmb3IgUXQuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA3LTAxICBZdXJ5IFNlbWlraGF0c2t5ICA8
eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBDaHJvbWl1
bSB0ZXN0IGV4cGVjdGF0aW9ucyBmb3Igc3ZnL1czQy1TVkctMS4xL2ZpbHRlcnMtY29udi0wMS1m
LnN2ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91
dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggOGY3Y2U2ZS4uZjBjM2E2YiAxMDA2NDQK
LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9w
bGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC01MjQ3LDcgKzUyNDcsNiBAQCBjYW52YXMvcGhpbGlwL3Rl
c3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmN5bGluZGVyLmh0bWwKIGNhbnZhcy9waGlsaXAv
dGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUuZnJvbnQuaHRtbAogY2FudmFzL3BoaWxpcC90
ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5zaGFwZTIuaHRtbAogY2FudmFzL3BoaWxpcC90
ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0
cy8yZC5ncmFkaWVudC5yYWRpYWwuZXF1YWwuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5n
cmFkaWVudC5yYWRpYWwuaW5zaWRlMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRp
ZW50LnJhZGlhbC5pbnNpZGUzLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQu
cmFkaWFsLm5lZ2F0aXZlLmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKaW5kZXggNDljZTcxMi4uYTViYjEyYSAxMDA2NDQKLS0tIGEvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx
MC0wNy0wMSAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbnZhczogRG9uJ3Qg
cGFpbnQgd2l0aCBlbXB0eSByYWRpYWwgZ3JhZGllbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTE5MAorCisgICAgICAgIElmIGEgcmFkaWFsIGdy
YWRpZW50IGhhcyB4MD09eDEgJiYgeTA9PXkxICYmIHIwPT1yMSwgZG9uJ3QgcGFpbnQgd2l0aCBp
dC4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmZpbGxSZWN0KToK
KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oOgorICAgICAgICAoV2ViQ29y
ZTo6R3JhZGllbnQ6OmlzWmVyb1NpemUpOgorCiAyMDEwLTA3LTAxICBTaGVyaWZmIEJvdCAgPHdl
YmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n
IG91dCByNjIyNDYuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRl
cmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0Nv
bnRleHQyRC5jcHAKaW5kZXggNzcyZjU5YS4uMjM5NjliMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9o
dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBiL1dlYkNvcmUvaHRt
bC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAtNzU3LDggKzc1Nyw5IEBA
IHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpmaWxsUmVjdChmbG9hdCB4LCBmbG9hdCB5
LCBmbG9hdCB3aWR0aCwgZmxvYXQgaGVpCiAKICAgICAvLyBmcm9tIHRoZSBIVE1MNSBDYW52YXMg
c3BlYzoKICAgICAvLyBJZiB4MCA9IHgxIGFuZCB5MCA9IHkxLCB0aGVuIHRoZSBsaW5lYXIgZ3Jh
ZGllbnQgbXVzdCBwYWludCBub3RoaW5nCisgICAgLy8gSWYgeDAgPSB4MSBhbmQgeTAgPSB5MSBh
bmQgcjAgPSByMSwgdGhlbiB0aGUgcmFkaWFsIGdyYWRpZW50IG11c3QgcGFpbnQgbm90aGluZwog
ICAgIEdyYWRpZW50KiBncmFkaWVudCA9IGMtPmZpbGxHcmFkaWVudCgpOwotICAgIGlmIChncmFk
aWVudCAmJiBncmFkaWVudC0+aXNaZXJvU2l6ZSgpICYmICFncmFkaWVudC0+aXNSYWRpYWwoKSkK
KyAgICBpZiAoZ3JhZGllbnQgJiYgZ3JhZGllbnQtPmlzWmVyb1NpemUoKSkKICAgICAgICAgcmV0
dXJuOwogCiAgICAgRmxvYXRSZWN0IHJlY3QoeCwgeSwgd2lkdGgsIGhlaWdodCk7CmRpZmYgLS1n
aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmggYi9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKaW5kZXggODg3N2Y2Zi4uZjBmMDdhZCAxMDA2NDQKLS0t
IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCisrKyBiL1dlYkNvcmUvcGxh
dGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaApAQCAtODksNyArODksNyBAQCBuYW1lc3BhY2UgV2Vi
Q29yZSB7CiAgICAgICAgIHZvaWQgZ2V0Q29sb3IoZmxvYXQgdmFsdWUsIGZsb2F0KiByLCBmbG9h
dCogZywgZmxvYXQqIGIsIGZsb2F0KiBhKSBjb25zdDsKIAogICAgICAgICBib29sIGlzUmFkaWFs
KCkgY29uc3QgeyByZXR1cm4gbV9yYWRpYWw7IH0KLSAgICAgICAgYm9vbCBpc1plcm9TaXplKCkg
Y29uc3QgeyByZXR1cm4gbV9wMC54KCkgPT0gbV9wMS54KCkgJiYgbV9wMC55KCkgPT0gbV9wMS55
KCk7IH0KKyAgICAgICAgYm9vbCBpc1plcm9TaXplKCkgY29uc3QgeyByZXR1cm4gbV9wMC54KCkg
PT0gbV9wMS54KCkgJiYgbV9wMC55KCkgPT0gbV9wMS55KCkgJiYgKG1fcmFkaWFsID8gbV9yMCA9
PSBtX3IxIDogdHJ1ZSk7IH0KIAogI2lmIE9TKFdJTkNFKSAmJiAhUExBVEZPUk0oUVQpCiAgICAg
ICAgIGNvbnN0IEZsb2F0UG9pbnQmIHAwKCkgY29uc3QgeyByZXR1cm4gbV9wMDsgfQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60280</attachid>
            <date>2010-07-01 13:25:35 -0700</date>
            <delta_ts>2010-07-01 20:03:46 -0700</delta_ts>
            <desc>Proposed patch v3 (Darinized)</desc>
            <filename>bug-41190-v3.diff</filename>
            <type>text/plain</type>
            <size>3465</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAwNjQ0YTE4Li44YzI0M2U1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDct
MDEgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW52YXM6IERvbid0IHBhaW50
IHdpdGggZW1wdHkgcmFkaWFsIGdyYWRpZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExOTAKKworICAgICAgICBVbnNraXAgY2FudmFzL3BoaWxp
cC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuZXF1YWwuaHRtbCBmb3IgUXQuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA3LTAxICBZdXJ5IFNlbWlraGF0c2t5ICA8
eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBDaHJvbWl1
bSB0ZXN0IGV4cGVjdGF0aW9ucyBmb3Igc3ZnL1czQy1TVkctMS4xL2ZpbHRlcnMtY29udi0wMS1m
LnN2ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91
dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggOGY3Y2U2ZS4uZjBjM2E2YiAxMDA2NDQK
LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9w
bGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC01MjQ3LDcgKzUyNDcsNiBAQCBjYW52YXMvcGhpbGlwL3Rl
c3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmN5bGluZGVyLmh0bWwKIGNhbnZhcy9waGlsaXAv
dGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUuZnJvbnQuaHRtbAogY2FudmFzL3BoaWxpcC90
ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5zaGFwZTIuaHRtbAogY2FudmFzL3BoaWxpcC90
ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0
cy8yZC5ncmFkaWVudC5yYWRpYWwuZXF1YWwuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5n
cmFkaWVudC5yYWRpYWwuaW5zaWRlMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRp
ZW50LnJhZGlhbC5pbnNpZGUzLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQu
cmFkaWFsLm5lZ2F0aXZlLmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKaW5kZXggNDljZTcxMi4uYTViYjEyYSAxMDA2NDQKLS0tIGEvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx
MC0wNy0wMSAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbnZhczogRG9uJ3Qg
cGFpbnQgd2l0aCBlbXB0eSByYWRpYWwgZ3JhZGllbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTE5MAorCisgICAgICAgIElmIGEgcmFkaWFsIGdy
YWRpZW50IGhhcyB4MD09eDEgJiYgeTA9PXkxICYmIHIwPT1yMSwgZG9uJ3QgcGFpbnQgd2l0aCBp
dC4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmZpbGxSZWN0KToK
KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oOgorICAgICAgICAoV2ViQ29y
ZTo6R3JhZGllbnQ6OmlzWmVyb1NpemUpOgorCiAyMDEwLTA3LTAxICBTaGVyaWZmIEJvdCAgPHdl
YmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n
IG91dCByNjIyNDYuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRl
cmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0Nv
bnRleHQyRC5jcHAKaW5kZXggNzcyZjU5YS4uMjM5NjliMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9o
dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBiL1dlYkNvcmUvaHRt
bC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAtNzU3LDggKzc1Nyw5IEBA
IHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpmaWxsUmVjdChmbG9hdCB4LCBmbG9hdCB5
LCBmbG9hdCB3aWR0aCwgZmxvYXQgaGVpCiAKICAgICAvLyBmcm9tIHRoZSBIVE1MNSBDYW52YXMg
c3BlYzoKICAgICAvLyBJZiB4MCA9IHgxIGFuZCB5MCA9IHkxLCB0aGVuIHRoZSBsaW5lYXIgZ3Jh
ZGllbnQgbXVzdCBwYWludCBub3RoaW5nCisgICAgLy8gSWYgeDAgPSB4MSBhbmQgeTAgPSB5MSBh
bmQgcjAgPSByMSwgdGhlbiB0aGUgcmFkaWFsIGdyYWRpZW50IG11c3QgcGFpbnQgbm90aGluZwog
ICAgIEdyYWRpZW50KiBncmFkaWVudCA9IGMtPmZpbGxHcmFkaWVudCgpOwotICAgIGlmIChncmFk
aWVudCAmJiBncmFkaWVudC0+aXNaZXJvU2l6ZSgpICYmICFncmFkaWVudC0+aXNSYWRpYWwoKSkK
KyAgICBpZiAoZ3JhZGllbnQgJiYgZ3JhZGllbnQtPmlzWmVyb1NpemUoKSkKICAgICAgICAgcmV0
dXJuOwogCiAgICAgRmxvYXRSZWN0IHJlY3QoeCwgeSwgd2lkdGgsIGhlaWdodCk7CmRpZmYgLS1n
aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmggYi9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKaW5kZXggODg3N2Y2Zi4uNjA1MmFlZiAxMDA2NDQKLS0t
IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCisrKyBiL1dlYkNvcmUvcGxh
dGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaApAQCAtODksNyArODksNyBAQCBuYW1lc3BhY2UgV2Vi
Q29yZSB7CiAgICAgICAgIHZvaWQgZ2V0Q29sb3IoZmxvYXQgdmFsdWUsIGZsb2F0KiByLCBmbG9h
dCogZywgZmxvYXQqIGIsIGZsb2F0KiBhKSBjb25zdDsKIAogICAgICAgICBib29sIGlzUmFkaWFs
KCkgY29uc3QgeyByZXR1cm4gbV9yYWRpYWw7IH0KLSAgICAgICAgYm9vbCBpc1plcm9TaXplKCkg
Y29uc3QgeyByZXR1cm4gbV9wMC54KCkgPT0gbV9wMS54KCkgJiYgbV9wMC55KCkgPT0gbV9wMS55
KCk7IH0KKyAgICAgICAgYm9vbCBpc1plcm9TaXplKCkgY29uc3QgeyByZXR1cm4gbV9wMC54KCkg
PT0gbV9wMS54KCkgJiYgbV9wMC55KCkgPT0gbV9wMS55KCkgJiYgKCFtX3JhZGlhbCB8fCBtX3Iw
ID09IG1fcjEpOyB9CiAKICNpZiBPUyhXSU5DRSkgJiYgIVBMQVRGT1JNKFFUKQogICAgICAgICBj
b25zdCBGbG9hdFBvaW50JiBwMCgpIGNvbnN0IHsgcmV0dXJuIG1fcDA7IH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>