41184 2010-06-24 17:01:06 -0700 Sketch out InHeadMode for tree builder 2010-06-24 22:33:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth eric oldest_to_newest 242735 0 abarth 2010-06-24 17:01:06 -0700 Sketch out InHeadMode for tree builder 242737 1 59711 abarth 2010-06-24 17:03:21 -0700 Created attachment 59711 Patch 242830 2 59711 eric 2010-06-24 22:22:31 -0700 Comment on attachment 59711 Patch WebCore/html/HTMLTreeBuilder.cpp:358 + // FIXME: Atomize "command". Silly fixme. DEFINE_LOCAL(AtomicString, commandAtom, "command") is all you need. :) Yeah, this is going to be the wrong design. We're going to want to switch based on tag and then on state, instead of how the spec is written which is state then tag.WebCore/html/HTMLTreeBuilder.cpp:400 + break; This break seems silly. 242838 3 59711 abarth 2010-06-24 22:33:46 -0700 Comment on attachment 59711 Patch Clearing flags on attachment: 59711 Committed r61823: <http://trac.webkit.org/changeset/61823> 242839 4 abarth 2010-06-24 22:33:51 -0700 All reviewed patches have been landed. Closing bug. 59711 2010-06-24 17:03:21 -0700 2010-06-24 22:33:45 -0700 Patch bug-41184-20100624170319.patch text/plain 6351 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGRmM2E4YjQwZDEzY2YzODdiZDA4YmZmNTE4ZmVlNGZmYWMzNTEyMS4uODhiYzc0NDY3N2E1MTlm NGYyYzk2NmRhZjAxMmYyOWU1MTgwYmRlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyOCBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFNrZXRjaCBvdXQgSW5IZWFkTW9kZSBm b3IgdHJlZSBidWlsZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MTE4NAorCisgICAgICAgIFRoaXMgc3RhdGUgaXMgcmVsYXRpdmVseSBzdHJhaWdo dGZvcndhcmQuICBXZSBpbnRyb2R1Y2UgdGhlIHN0YWNrIG9mCisgICAgICAgIG9wZW4gZWxlbWVu dHMgdG8gdHJhY2sgdGhhdCBub3Rpb24gaW4gdGhlIHNwZWMuICBUaGUgb2xkIHRyZWUgYnVpbGRl cgorICAgICAgICBoYXMgYSBuaWNlIGRhdGEgc3RydWN0dXJlIGZvciB0aGF0LCB3aGljaCB3ZSds bCBwcm9iYWJseSBzdGVhbCwgYnV0IEknZAorICAgICAgICBsaWtlIHRvIHNlZSB3aGF0IHRoZSBm dWxsIEFQSSBpcyBmaXJzdC4KKworICAgICAgICAqIGh0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc1Rva2VuKToKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6aW5zZXJ0Q2hhcmFjdGVyKToKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6aW5zZXJ0R2VuZXJpY1JDREFUQUVsZW1lbnQpOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjppbnNlcnRHZW5lcmljUmF3VGV4dEVs ZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjppbnNlcnRTY3JpcHRF bGVtZW50KToKKyAgICAgICAgKiBodG1sL0hUTUxUcmVlQnVpbGRlci5oOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTFRyZWVCdWlsZGVyOjpFbGVtZW50U3RhY2s6OnBvcCk6CisgICAgICAgIChXZWJD b3JlOjpIVE1MVHJlZUJ1aWxkZXI6OkVsZW1lbnRTdGFjazo6dG9wKToKKworMjAxMC0wNi0yNCAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCiAgICAgICAgIFNrZXRjaCBvdXQgQmVmb3JlSGVhZE1vZGUgdHJlZSBi dWlsZGVyIHN0YXRlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MTE4MwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNw cCBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCmluZGV4IGVmNzg5NzRhNzdlNWYy NDQzYjg5ZWQyZWIyMDFjZmEwZTU0NTAyODcuLmE3MWUwNTY1MGE4NDE0MWNiMWZjYjE3NGZkZDkx ZWJjY2Q5OWJkNzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3Bw CisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC0zMzcsNyArMzM3LDc0 IEBAIHJlcHJvY2Vzc1Rva2VuOgogICAgICAgICBwcm9jZXNzVG9rZW4oZmFrZUhlYWQpOwogICAg ICAgICBnb3RvIHJlcHJvY2Vzc1Rva2VuOwogICAgIH0KLSAgICBjYXNlIEluSGVhZE1vZGU6Cisg ICAgY2FzZSBJbkhlYWRNb2RlOiB7CisgICAgICAgIHN3aXRjaCAodG9rZW4udHlwZSgpKSB7Cisg ICAgICAgIGNhc2UgSFRNTFRva2VuOjpVbmluaXRpYWxpemVkOgorICAgICAgICAgICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBIVE1MVG9r ZW46OkNoYXJhY3RlcjoKKyAgICAgICAgICAgIGluc2VydENoYXJhY3RlcihjYyk7CisgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgY2FzZSBIVE1MVG9rZW46OkNvbW1lbnQ6CisgICAgICAgICAg ICByZXR1cm4gaW5zZXJ0Q29tbWVudCh0b2tlbik7CisgICAgICAgIGNhc2UgSFRNTFRva2VuOjpE T0NUWVBFOgorICAgICAgICAgICAgcGFyc2VFcnJvcih0b2tlbik7CisgICAgICAgICAgICByZXR1 cm4gMDsKKyAgICAgICAgY2FzZSBIVE1MVG9rZW46OlN0YXJ0VGFnOgorICAgICAgICAgICAgaWYg KHRva2VuLm5hbWUoKSA9PSBodG1sVGFnKSB7CisgICAgICAgICAgICAgICAgbm90SW1wbGVtZW50 ZWQoKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIC8vIEZJWE1FOiBBdG9taXplICJjb21tYW5kIi4KKyAgICAgICAgICAgIGlmICh0b2tlbi5u YW1lKCkgPT0gYmFzZVRhZyB8fCB0b2tlbi5uYW1lKCkgPT0gImNvbW1hbmQiIHx8IHRva2VuLm5h bWUoKSA9PSBsaW5rVGFnKSB7CisgICAgICAgICAgICAgICAgUGFzc1JlZlB0cjxOb2RlPiBub2Rl ID0gaW5zZXJ0RWxlbWVudCh0b2tlbik7CisgICAgICAgICAgICAgICAgbV9vcGVuRWxlbWVudHMu cG9wKCk7CisgICAgICAgICAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgICAgICAg ICByZXR1cm4gbm9kZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGlmICh0b2tlbi5uYW1l KCkgPT0gbWV0YVRhZykgeworICAgICAgICAgICAgICAgIFBhc3NSZWZQdHI8Tm9kZT4gbm9kZSA9 IGluc2VydEVsZW1lbnQodG9rZW4pOworICAgICAgICAgICAgICAgIG1fb3BlbkVsZW1lbnRzLnBv cCgpOworICAgICAgICAgICAgICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgICAgICAgICAgICAg cmV0dXJuIG5vZGU7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBpZiAodG9rZW4ubmFtZSgp ID09IHRpdGxlVGFnKQorICAgICAgICAgICAgICAgIHJldHVybiBpbnNlcnRHZW5lcmljUkNEQVRB RWxlbWVudCh0b2tlbik7CisgICAgICAgICAgICBpZiAodG9rZW4ubmFtZSgpID09IG5vc2NyaXB0 VGFnKSB7CisgICAgICAgICAgICAgICAgaWYgKGlzU2NyaXB0aW5nRmxhZ0VuYWJsZWQobV9kb2N1 bWVudC0+ZnJhbWUoKSkpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBpbnNlcnRHZW5lcmlj UmF3VGV4dEVsZW1lbnQodG9rZW4pOworICAgICAgICAgICAgICAgIFBhc3NSZWZQdHI8Tm9kZT4g bm9kZSA9IGluc2VydEVsZW1lbnQodG9rZW4pOworICAgICAgICAgICAgICAgIHNldEluc2VydGlv bk1vZGUoSW5IZWFkTm9zY3JpcHRNb2RlKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gbm9kZTsK KyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGlmICh0b2tlbi5uYW1lKCkgPT0gbm9mcmFtZXNU YWcgfHwgdG9rZW4ubmFtZSgpID09IHN0eWxlVGFnKQorICAgICAgICAgICAgICAgIHJldHVybiBp bnNlcnRHZW5lcmljUmF3VGV4dEVsZW1lbnQodG9rZW4pOworICAgICAgICAgICAgaWYgKHRva2Vu Lm5hbWUoKSA9PSBzY3JpcHRUYWcpCisgICAgICAgICAgICAgICAgcmV0dXJuIGluc2VydFNjcmlw dEVsZW1lbnQodG9rZW4pOworICAgICAgICAgICAgaWYgKHRva2VuLm5hbWUoKSA9PSBoZWFkVGFn KSB7CisgICAgICAgICAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgICAgICAgICBy ZXR1cm4gMDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNl IEhUTUxUb2tlbjo6RW5kVGFnOgorICAgICAgICAgICAgaWYgKHRva2VuLm5hbWUoKSA9PSBoZWFk VGFnKSB7CisgICAgICAgICAgICAgICAgQVNTRVJUKG1fb3BlbkVsZW1lbnRzLnRvcCgpLT50YWdR TmFtZSgpID09IGhlYWRUYWcpOworICAgICAgICAgICAgICAgIG1fb3BlbkVsZW1lbnRzLnBvcCgp OworICAgICAgICAgICAgICAgIHNldEluc2VydGlvbk1vZGUoQWZ0ZXJIZWFkTW9kZSk7CisgICAg ICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBpZiAodG9r ZW4ubmFtZSgpID09IGJvZHlUYWcgfHwgdG9rZW4ubmFtZSgpID09IGh0bWxUYWcgfHwgdG9rZW4u bmFtZSgpID09IGJyVGFnKQorICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgcGFy c2VFcnJvcih0b2tlbik7CisgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgICAgIGJyZWFr OworICAgICAgICBjYXNlIEhUTUxUb2tlbjo6RW5kT2ZGaWxlOgorICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgIH0KKyAgICAgICAgQXRvbWljSFRNTFRva2VuIGZha2VIZWFkKEhUTUxUb2tlbjo6 RW5kVGFnLCBoZWFkVGFnLmxvY2FsTmFtZSgpKTsKKyAgICAgICAgcHJvY2Vzc1Rva2VuKGZha2VI ZWFkKTsKKyAgICAgICAgZ290byByZXByb2Nlc3NUb2tlbjsKKyAgICB9CiAgICAgY2FzZSBJbkhl YWROb3NjcmlwdE1vZGU6CiAgICAgY2FzZSBBZnRlckhlYWRNb2RlOgogICAgIGNhc2UgSW5Cb2R5 TW9kZToKQEAgLTM4Miw2ICs0NDksMjkgQEAgUGFzc1JlZlB0cjxOb2RlPiBIVE1MVHJlZUJ1aWxk ZXI6Omluc2VydEVsZW1lbnQoQXRvbWljSFRNTFRva2VuJiB0b2tlbikKICAgICByZXR1cm4gMDsK IH0KIAordm9pZCBIVE1MVHJlZUJ1aWxkZXI6Omluc2VydENoYXJhY3RlcihVQ2hhciBjYykKK3sK KyAgICBBU1NFUlRfVU5VU0VEKGNjLCBjYyk7Cit9CisKK1Bhc3NSZWZQdHI8Tm9kZT4gSFRNTFRy ZWVCdWlsZGVyOjppbnNlcnRHZW5lcmljUkNEQVRBRWxlbWVudChBdG9taWNIVE1MVG9rZW4mIHRv a2VuKQoreworICAgIEFTU0VSVF9VTlVTRUQodG9rZW4sIHRva2VuLnR5cGUoKSA9PSBIVE1MVG9r ZW46OlN0YXJ0VGFnKTsKKyAgICByZXR1cm4gMDsKK30KKworUGFzc1JlZlB0cjxOb2RlPiBIVE1M VHJlZUJ1aWxkZXI6Omluc2VydEdlbmVyaWNSYXdUZXh0RWxlbWVudChBdG9taWNIVE1MVG9rZW4m IHRva2VuKQoreworICAgIEFTU0VSVF9VTlVTRUQodG9rZW4sIHRva2VuLnR5cGUoKSA9PSBIVE1M VG9rZW46OlN0YXJ0VGFnKTsKKyAgICByZXR1cm4gMDsKK30KKworUGFzc1JlZlB0cjxOb2RlPiBI VE1MVHJlZUJ1aWxkZXI6Omluc2VydFNjcmlwdEVsZW1lbnQoQXRvbWljSFRNTFRva2VuJiB0b2tl bikKK3sKKyAgICBBU1NFUlRfVU5VU0VEKHRva2VuLCB0b2tlbi50eXBlKCkgPT0gSFRNTFRva2Vu OjpTdGFydFRhZyk7CisgICAgcmV0dXJuIDA7Cit9CisKIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpm aW5pc2hlZCgpCiB7CiAgICAgLy8gV2Ugc2hvdWxkIGNhbGwgbV9kb2N1bWVudC0+ZmluaXNoZWRQ YXJzaW5nKCkgaGVyZSwgZXhjZXB0CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVC dWlsZGVyLmggYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmgKaW5kZXggYjBkYjI0NzFm MTM0OWE5YzE2MWZhMWU5ZDhhMTMzMzMxMTZlNDIxYy4uZDY3N2E0NmMyMzVhMTJkNDIwZjdmMzRl NjQzOGFmNjM3NDJmZDQ4MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRl ci5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuaApAQCAtOTksMTQgKzk5LDI1 IEBAIHByaXZhdGU6CiAgICAgICAgIEFmdGVyQWZ0ZXJGcmFtZXNldE1vZGUsCiAgICAgfTsKIAor ICAgIGNsYXNzIEVsZW1lbnRTdGFjayA6IHB1YmxpYyBOb25jb3B5YWJsZSB7CisgICAgcHVibGlj OgorICAgICAgICB2b2lkIHBvcCgpIHsgfQorICAgICAgICBFbGVtZW50KiB0b3AoKSBjb25zdCB7 IHJldHVybiAwOyB9CisgICAgfTsKKwogICAgIFBhc3NSZWZQdHI8Tm9kZT4gcGFzc1Rva2VuVG9M ZWdhY3lQYXJzZXIoSFRNTFRva2VuJik7CiAgICAgUGFzc1JlZlB0cjxOb2RlPiBwcm9jZXNzVG9r ZW4oQXRvbWljSFRNTFRva2VuJiwgVUNoYXIgY2MgPSAwKTsKIAogICAgIFBhc3NSZWZQdHI8Tm9k ZT4gaW5zZXJ0RG9jdHlwZShBdG9taWNIVE1MVG9rZW4mKTsKICAgICBQYXNzUmVmUHRyPE5vZGU+ IGluc2VydENvbW1lbnQoQXRvbWljSFRNTFRva2VuJik7CiAgICAgUGFzc1JlZlB0cjxOb2RlPiBp bnNlcnRFbGVtZW50KEF0b21pY0hUTUxUb2tlbiYpOworICAgIHZvaWQgaW5zZXJ0Q2hhcmFjdGVy KFVDaGFyIGNjKTsKKyAgICBQYXNzUmVmUHRyPE5vZGU+IGluc2VydEdlbmVyaWNSQ0RBVEFFbGVt ZW50KEF0b21pY0hUTUxUb2tlbiYpOworICAgIFBhc3NSZWZQdHI8Tm9kZT4gaW5zZXJ0R2VuZXJp Y1Jhd1RleHRFbGVtZW50KEF0b21pY0hUTUxUb2tlbiYpOworICAgIFBhc3NSZWZQdHI8Tm9kZT4g aW5zZXJ0U2NyaXB0RWxlbWVudChBdG9taWNIVE1MVG9rZW4mKTsKIAogICAgIFJlZlB0cjxOb2Rl PiBtX2hlYWRFbGVtZW50OworICAgIEVsZW1lbnRTdGFjayBtX29wZW5FbGVtZW50czsKIAogICAg IC8vIEZJWE1FOiBJbXBsZW1lbnQgZXJyb3IgcmVwb3J0aW5nLgogICAgIHZvaWQgcGFyc2VFcnJv cihBdG9taWNIVE1MVG9rZW4mKSB7IH0K