41182 2010-06-24 16:19:06 -0700 Clean up and document DocumentWriter::replaceDocument code path 2010-06-24 18:35:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth eric webkit.review.bot oldest_to_newest 242710 0 eric 2010-06-24 16:19:06 -0700 Clean up and document DocumentWriter::replaceDocument code path 242711 1 59707 eric 2010-06-24 16:20:09 -0700 Created attachment 59707 Patch 242714 2 59707 abarth 2010-06-24 16:22:32 -0700 Comment on attachment 59707 Patch Ok. 242717 3 eric 2010-06-24 16:28:23 -0700 Committed r61797: <http://trac.webkit.org/changeset/61797> 242724 4 webkit.review.bot 2010-06-24 16:36:31 -0700 http://trac.webkit.org/changeset/61797 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release 242782 5 eric 2010-06-24 18:35:02 -0700 Committed r61815: <http://trac.webkit.org/changeset/61815> 59707 2010-06-24 16:20:09 -0700 2010-06-24 16:22:31 -0700 Patch bug-41182-20100624162007.patch text/plain 3243 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDI0MGJhZDg3YWQ4ZGY3OTJhMDAzYjEyZGU2OWYwYzc5ZjA2ZTU4ZS4uMjQwMThmMTI1OWUxZmE3 ZThlNmE4OWU3NmE4MmU0NWNkMjM2NDU2MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNi0yNCAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2xlYW4gdXAgYW5kIGRvY3VtZW50IERvY3VtZW50V3JpdGVy OjpyZXBsYWNlRG9jdW1lbnQgY29kZSBwYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MTE4MgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdl LCB0aHVzIG5vIHRlc3QuCisKKyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRXcml0ZXI6OnJlcGxhY2VEb2N1bWVudCk6CisgICAg ICAgICogbG9hZGVyL0RvY3VtZW50V3JpdGVyLmg6CisKIDIwMTAtMDYtMjQgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcCBiL1dlYkNvcmUv bG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcAppbmRleCBmZTBhY2IwZDFhZWU1M2VhNTZlNTBiNTZm MTg3NWQzYjQ3ZjkyMDFkLi5mNzMwOGY3Y2ZjZDlmMzdkMzI3MDExNzc1MmEwNzljNzM1OTY3ZjFk IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdyaXRlci5jcHAKKysrIGIvV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwCkBAIC01OSwxMSArNTksMjYgQEAgRG9jdW1l bnRXcml0ZXI6OkRvY3VtZW50V3JpdGVyKEZyYW1lKiBmcmFtZSkKIHsKIH0KIAorLy8gVGhpcyBp cyBvbmx5IGNhbGxlZCBieSBTY3JpcHRDb250cm9sbGVyOjpleGVjdXRlSWZKYXZhU2NyaXB0VVJM CisvLyBhbmQgYWx3YXlzIGNvbnRhaW5zIHRoZSByZXN1bHQgb2YgZXZhbHVhdGluZyBhIGphdmFz Y3JpcHQ6IHVybC4KKy8vIFRoaXMgaXMgdGhlIDxpZnJhbWUgc3JjPSJqYXZhc2NyaXB0OidodG1s JyI+IGNhc2UuCiB2b2lkIERvY3VtZW50V3JpdGVyOjpyZXBsYWNlRG9jdW1lbnQoY29uc3QgU3Ry aW5nJiBodG1sKQogewogICAgIG1fZnJhbWUtPmxvYWRlcigpLT5zdG9wQWxsTG9hZGVycygpOwog ICAgIGJlZ2luKG1fZnJhbWUtPmxvYWRlcigpLT51cmwoKSwgdHJ1ZSwgbV9mcmFtZS0+ZG9jdW1l bnQoKS0+c2VjdXJpdHlPcmlnaW4oKSk7Ci0gICAgYWRkRGF0YShodG1sKTsKKworICAgIGlmICgh c3RyLmlzTnVsbCgpKSB7CisgICAgICAgIGlmICghbV9yZWNlaXZlZERhdGEpIHsKKyAgICAgICAg ICAgIG1fcmVjZWl2ZWREYXRhID0gdHJ1ZTsKKyAgICAgICAgICAgIG1fZnJhbWUtPmRvY3VtZW50 KCktPnNldFBhcnNlTW9kZShEb2N1bWVudDo6U3RyaWN0KTsKKyAgICAgICAgfQorCisgICAgICAg IC8vIEZJWE1FOiBJZiB3ZSB3YW50ZWQgdG8gc3VwcG9ydCB0aGUgPGltZyBzcmM9J2phdmFzY3Jp cHQ6J2ltYWdlZGF0YSc+CisgICAgICAgIC8vIGNhc2UgdGhlbiB3ZSB3b3VsZCBuZWVkIHRvIGNh bGwgYWRkRGF0YShjaGFyKiwgaW50KSBpbnN0ZWFkLgorICAgICAgICBpZiAoRG9jdW1lbnRQYXJz ZXIqIHBhcnNlciA9IG1fZnJhbWUtPmRvY3VtZW50KCktPnBhcnNlcigpKQorICAgICAgICAgICAg cGFyc2VyLT53cml0ZShzdHIsIHRydWUpOworICAgIH0KKwogICAgIGVuZCgpOwogfQogCkBAIC0x OTMsMjAgKzIwOCw2IEBAIHZvaWQgRG9jdW1lbnRXcml0ZXI6OmFkZERhdGEoY29uc3QgY2hhciog c3RyLCBpbnQgbGVuLCBib29sIGZsdXNoKQogICAgIH0KIH0KIAotdm9pZCBEb2N1bWVudFdyaXRl cjo6YWRkRGF0YShjb25zdCBTdHJpbmcmIHN0cikKLXsKLSAgICBpZiAoc3RyLmlzTnVsbCgpKQot ICAgICAgICByZXR1cm47Ci0KLSAgICBpZiAoIW1fcmVjZWl2ZWREYXRhKSB7Ci0gICAgICAgIG1f cmVjZWl2ZWREYXRhID0gdHJ1ZTsKLSAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2V0UGFy c2VNb2RlKERvY3VtZW50OjpTdHJpY3QpOwotICAgIH0KLQotICAgIGlmIChEb2N1bWVudFBhcnNl ciogcGFyc2VyID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+cGFyc2VyKCkpCi0gICAgICAgIHBhcnNl ci0+d3JpdGUoc3RyLCB0cnVlKTsKLX0KLQogdm9pZCBEb2N1bWVudFdyaXRlcjo6ZW5kKCkKIHsK ICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+ZGlkRW5kRG9jdW1lbnQoKTsKZGlmZiAtLWdpdCBhL1dl YkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmggYi9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdy aXRlci5oCmluZGV4IGEwNmZiN2Y5ODNjYTIwNTg4N2I1MWY2NTI3ZjljN2ExOTBkN2FkZjIuLjk3 N2RhMzk2YWIzNmU1NTU4MjNkNWE4NjA0YzY5ODg4NWY0OGIwM2YgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmgKKysrIGIvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRX cml0ZXIuaApAQCAtNDMsMTIgKzQzLDEzIEBAIGNsYXNzIERvY3VtZW50V3JpdGVyIDogcHVibGlj IE5vbmNvcHlhYmxlIHsKIHB1YmxpYzoKICAgICBEb2N1bWVudFdyaXRlcihGcmFtZSopOwogCisg ICAgLy8gVGhpcyBpcyBvbmx5IGNhbGxlZCBieSBTY3JpcHRDb250cm9sbGVyOjpleGVjdXRlSWZK YXZhU2NyaXB0VVJMCisgICAgLy8gYW5kIGFsd2F5cyBjb250YWlucyB0aGUgcmVzdWx0IG9mIGV2 YWx1YXRpbmcgYSBqYXZhc2NyaXB0OiB1cmwuCiAgICAgdm9pZCByZXBsYWNlRG9jdW1lbnQoY29u c3QgU3RyaW5nJik7CiAKICAgICB2b2lkIGJlZ2luKCk7CiAgICAgdm9pZCBiZWdpbihjb25zdCBL VVJMJiwgYm9vbCBkaXNwYXRjaFdpbmRvd09iamVjdEF2YWlsYWJsZSA9IHRydWUsIFNlY3VyaXR5 T3JpZ2luKiBmb3JjZWRTZWN1cml0eU9yaWdpbiA9IDApOwogICAgIHZvaWQgYWRkRGF0YShjb25z dCBjaGFyKiBzdHJpbmcsIGludCBsZW5ndGggPSAtMSwgYm9vbCBmbHVzaCA9IGZhbHNlKTsKLSAg ICB2b2lkIGFkZERhdGEoY29uc3QgU3RyaW5nJik7CiAgICAgdm9pZCBlbmQoKTsKICAgICB2b2lk IGVuZElmTm90TG9hZGluZ01haW5SZXNvdXJjZSgpOwogICAgIHZvaWQgY2xlYXIoKTsK