41181 2010-06-24 16:09:10 -0700 REGRESSION(53790): Neopets page with mismatched elements misrenders 2010-06-28 13:08:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED http://www.neopets.com/games/arcade.phtml P2 Normal --- 1 jamesr webkit-unassigned dglazkov mitz mjs oldest_to_newest 242705 0 jamesr 2010-06-24 16:09:10 -0700 The limit of 5 iterations in http://trac.webkit.org/changeset/53790 appears to be too low for the neopets page in the bug URL. Bumping the limit to 7 is sufficient to render this page correctly. 242706 1 jamesr 2010-06-24 16:11:30 -0700 Here's the time spend parsing fast/parser/residual-style-hang.html with different limits on my Mac Pro (intel xeon @ 2.26 GHz): limit / time 5 / 379ms 6 / 494ms 7 / 630ms 8 / 770ms 9 / 930ms 10 / 1073ms This looks like a pretty much worst case scenario so I'd suggest raising the limit to 10 iterations just in case there are other sites out there that are broken. 242734 2 jamesr 2010-06-24 17:00:00 -0700 Gecko manages to render this page correctly with and without their HTML5 parser enabled. 242736 3 59710 jamesr 2010-06-24 17:01:46 -0700 Created attachment 59710 Patch 242742 4 mitz 2010-06-24 17:06:12 -0700 I don’t remember how the constant 5 was chosen. Will 10 re-introduce the hang seen in bug 34059? 242745 5 jamesr 2010-06-24 17:11:38 -0700 See comment #1 for timing data from the hanging test case. A limit of 10 is slower than a limit of 5 but not by too much (it is still too low to be likely to see a beachball). 242746 6 mitz 2010-06-24 17:15:23 -0700 The bug wasn’t about the test though, it was about a hang with some real-world content. 242757 7 jamesr 2010-06-24 17:27:13 -0700 We (Maciej, Hixie and I) chatted about this a bit in IRC. We don't have any real-world websites that were seeing the hang (although we're pretty sure some did). I believe that the test case Maciej created is or is close to the worst case for the fixup algorithm and don't expect that sites in the wild will be slower than it. I hope so, anyway :) I don't think we have too much choice, fundamentally we have to make the limit large enough to handle any websites that people care about. The most recent Minefield nightly with the HTML5 parser enabled handles up to 100 nested "<b><div>" instances before it starts dropping content. 243840 8 59710 jamesr 2010-06-28 13:08:17 -0700 Comment on attachment 59710 Patch Clearing flags on attachment: 59710 Committed r62029: <http://trac.webkit.org/changeset/62029> 243841 9 jamesr 2010-06-28 13:08:21 -0700 All reviewed patches have been landed. Closing bug. 59710 2010-06-24 17:01:46 -0700 2010-06-28 13:08:17 -0700 Patch bug-41181-20100624170145.patch text/plain 1722 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmVmMTBkYTJkZjJhOWI5MzZlNjUxNTE3YTE3Zjc1ZTU2YmFkMGU0YS4uZTk0MmRhODcwNjJmODcy ZDVlZjhhZmI3YmU3YWZkNTZjYTQxZDg5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNi0yNCAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04oNTM3OTApOiBOZW9wZXRzIHBh Z2Ugd2l0aCBtaXNtYXRjaGVkIGVsZW1lbnRzIG1pc3JlbmRlcnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMTgxCisKKyAgICAgICAgTWlzbmVzdGVk IGZvcm1hdHRpbmcgdGFncyByZXF1aXJlIGZpeHVwIGluIG9yZGVyIHRvIGNyZWF0ZSBhIHZhbGlk IERPTS4gIEJlY2F1c2UgdGhpcyB0YWtlcworICAgICAgICBPKE5eMikgdGltZSBpbiBzb21lIGNh c2VzLCBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81Mzc5MCBhZGRlZCBhbiBpdGVy YXRpb24gbGltaXQKKyAgICAgICAgb2YgNSB0byB0aGlzIGFsZ29yaXRobSB0byBhdm9pZCBoYW5n cy4gIFRoaXMgbGltaXQgaXMgdG9vIGxvdyBmb3IgbmVvcGV0cywgYnV0IGEgbGltaXQgb2YKKyAg ICAgICAgNyBpcyBzdWZmaWNpZW50LiAgVGhpcyByYWlzZXMgdGhlIGxpbWl0IHRvIDEwIHRvIGhh dmUgYSBiaXQgb2YgYnJlYXRoaW5nIHJvb20uICBIVE1MNQorICAgICAgICBkZWZpbmVzIHRoZSBm aXh1cCBhbGdvcml0aG0gaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJl bnQtd29yay8jYWRvcHRpb25BZ2VuY3kKKyAgICAgICAgYnV0IGRvZXNuJ3Qgc3BlY2lmeSBhbnkg cGFydGljdWxhciBpdGVyYXRpb24gbGltaXQuCisKKyAgICAgICAgKiBodG1sL0xlZ2FjeUhUTUxU cmVlQnVpbGRlci5jcHA6CisKIDIwMTAtMDYtMjEgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvaHRtbC9MZWdhY3lIVE1MVHJlZUJ1aWxkZXIuY3BwIGIvV2ViQ29yZS9odG1sL0xlZ2Fj eUhUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggN2I0NTExOWRmYzdmZGJiODhjMTVmM2I4YmI5NDcx Y2FkZDkyMWExMS4uZjY4NjUyM2ZkYmU5ZjljYjZiM2ZmNDVmMzIyYjgyYTBmMTlhMmMzNiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9odG1sL0xlZ2FjeUhUTUxUcmVlQnVpbGRlci5jcHAKKysrIGIvV2Vi Q29yZS9odG1sL0xlZ2FjeUhUTUxUcmVlQnVpbGRlci5jcHAKQEAgLTY3LDcgKzY3LDcgQEAgdXNp bmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIAogc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNNYXhSZWR1 bmRhbnRUYWdEZXB0aCA9IDIwOwogc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNSZXNpZHVhbFN0eWxl TWF4RGVwdGggPSAyMDA7Ci1zdGF0aWMgY29uc3QgdW5zaWduZWQgY1Jlc2lkdWFsU3R5bGVJdGVy YXRpb25MaW1pdCA9IDU7CitzdGF0aWMgY29uc3QgdW5zaWduZWQgY1Jlc2lkdWFsU3R5bGVJdGVy YXRpb25MaW1pdCA9IDEwOwogCiAKIHN0YXRpYyBjb25zdCBpbnQgbWluQmxvY2tMZXZlbFRhZ1By aW9yaXR5ID0gMzsK