41162 2010-06-24 09:17:08 -0700 [GTK] Cannot change the selection via the keyboard 2010-06-24 17:29:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned xan.lopez oldest_to_newest 242541 0 mrobinson 2010-06-24 09:17:08 -0700 After selecting some text in a non-editable area, it should be possible to change the selection by holding down the shift key and arrow keys. This doesn't work in the GTK+ port. 242591 1 59679 mrobinson 2010-06-24 10:58:50 -0700 Created attachment 59679 Fix for this issue 242650 2 59679 xan.lopez 2010-06-24 13:49:03 -0700 Comment on attachment 59679 Fix for this issue So we are changing the logic a bit here, before we were allowing all kinds of events if caret mode was enabled. Are you changing that on purpose? 242677 3 mrobinson 2010-06-24 14:49:41 -0700 Yes. Before we were only allowing editor commands: 1. If the node was editable. 2. If caret browsing was enabled. This patch enables editor commands: 1. If the commands don't insert text (includes all caret browsing commands, AFAIK). 2. The command inserts text and the node is editable. I think this new logic is more precise. The only change that I can see is that previously a caret browsing command that inserted text (if such a beast existed) could operate on a non-editable node. I think disallowing that is a better behavior here. 242683 4 xan.lopez 2010-06-24 15:07:57 -0700 (In reply to comment #3) > Yes. Before we were only allowing editor commands: > > 1. If the node was editable. > 2. If caret browsing was enabled. > > This patch enables editor commands: > > 1. If the commands don't insert text (includes all caret browsing commands, AFAIK). > 2. The command inserts text and the node is editable. > > I think this new logic is more precise. The only change that I can see is that previously a caret browsing command that inserted text (if such a beast existed) could operate on a non-editable node. I think disallowing that is a better behavior here. Right, this is how I understood the patch but wanted to double-check it was intentional. I don't think there's such a thing as a text inserting caret command, no :) 242685 5 59679 xan.lopez 2010-06-24 15:08:12 -0700 Comment on attachment 59679 Fix for this issue r=me 242758 6 59679 mrobinson 2010-06-24 17:29:40 -0700 Comment on attachment 59679 Fix for this issue Clearing flags on attachment: 59679 Committed r61808: <http://trac.webkit.org/changeset/61808> 242759 7 mrobinson 2010-06-24 17:29:44 -0700 All reviewed patches have been landed. Closing bug. 59679 2010-06-24 10:58:50 -0700 2010-06-24 17:29:40 -0700 Fix for this issue bug-41162-20100624105849.patch text/plain 4222 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZTU2NTE4ZjAyMzJjZmZiNmM1MzczZThhZWRlNjRlZjM0NWQzMTRkLi5hZTgyZWQy ZGVjMjU1YmVkZmMwZjJhZTMwNTA5NzAxYmQ2NmM5ODc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDYtMjQgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIENhbm5v dCBjaGFuZ2UgdGhlIHNlbGVjdGlvbiB2aWEgdGhlIGtleWJvYXJkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTE2MgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL1NraXBwZWQ6IFVuc2tpcCBhIHRlc3Qgd2hpY2ggaXMgbm93IHBhc3NpbmcuCisKIDIw MTAtMDYtMjQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgTm90IHJldmlld2VkOiByZWJhc2VsaW5lIGltYWdlcyBmb3IgcjYxNzU5IGFuZCByNjE3NjIu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IGM3OTlhYTI0ODg4NDVhOGExYWFjNzJmMDhm N2Y4MWNiNTU5ZGQxYWUuLjhiZTJjMGI0Y2Y3ZDIyNGE0ODIwNmJiZWFmZTlhMTdjNTkyMjRiZmEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC01MjAxLDcgKzUyMDEsNiBAQCB3ZWJhcmNo aXZlL3Rlc3QteG1sLXN0eWxlc2hlZXQueG1sCiBlZGl0aW5nL2lucHV0L3Njcm9sbC12aWV3cG9y dC1wYWdlLXVwLWRvd24uaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJkL2RhdGFUcmFuc2Zlci1zZXRE YXRhLWdldERhdGEuaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJkL2ZpbGVzLWR1cmluZy1wYWdlLWRy YWdzLmh0bWwKLWVkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tYWZ0ZXItZG91Ymxl LWNsaWNrLmh0bWwKIGZhc3QvZXZlbnRzL2RyYWctdG8tbmF2aWdhdGUuaHRtbAogZmFzdC9ldmVu dHMvb25kcm9wLXRleHQtaHRtbC5odG1sCiBmYXN0L2V2ZW50cy9wcmV2ZW50LWRyYWctdG8tbmF2 aWdhdGUuaHRtbApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwppbmRleCAyZTIzNDVkZmE2MzgxZjFkNGZhNTg0ZmQ1MzViMzY5NWMxNzljYzUx Li4yYzg1OTE4MTM2NWQ0YzRhMDVmMDA1YTc0MGVjYTNiMGMzZDEzODc5IDEwMDY0NAotLS0gYS9X ZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEwLTA2LTI0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RL XSBDYW5ub3QgY2hhbmdlIHRoZSBzZWxlY3Rpb24gdmlhIHRoZSBrZXlib2FyZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExNjIKKworICAgICAgICBG aXggaXNzdWUgd2hlcmUgdGhlIHNlbGVjdGlvbiBjb3VsZCBub3QgYmUgZXh0ZW5kZWQgdmlhIHRo ZSBrZXlib2FyZCBieQorICAgICAgICBhZGp1c3RpbmcgdGhlIGxvZ2ljIGd1YXJkaW5nIGFnYWlu c3QgaW5zZXJ0aW5nIHRleHQgaW4gbm9uLWVkaXRhYmxlIG5vZGVzLgorCisgICAgICAgICogV2Vi Q29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RWRpdG9y Q2xpZW50OjpoYW5kbGVLZXlib2FyZEV2ZW50KToKKyAgICAgICAgQWxsb3cgZWRpdG9yIGNvbW1h bmRzIHRoYXQgZG8gbm90IGluc2VydCB0ZXh0IGluIG5vbi1lZGl0YWJsZSBub2Rlcy4gVGhpcwor ICAgICAgICBmaXhlcyBrZXlib2FyZCBzZWxlY3Rpb24gZXh0ZW5zaW9uIGluIG5vbi1lZGl0YWJs ZSBub2Rlcy4gTW92ZSB0aGUgZXhpc3RpbmcKKyAgICAgICAgY2hlY2sgdG8gYWZ0ZXIgdGhlIGV4 ZWN1dGlvbiBvZiBhbnkgZWRpdG9yIGNvbW1hbmRzLgorCiAyMDEwLTA2LTE1ICBEdW1pdHJ1IERh bmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50 R3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcApp bmRleCBhNWMzNmU4MzNhNjhhNzVhODhiZjE0NzIyOWViMTIyNTU0NGU2MmMxLi43N2VkOWIyY2Y2 Njc0Yjk0OWY3M2E0M2I0MzA5YTA0MjdmNjdmMWEwIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCkBAIC0zLDcgKzMsNyBAQAogICogIENvcHlyaWdo dCAoQykgMjAwOCBOdWFudGkgTHRkLgogICogIENvcHlyaWdodCAoQykgMjAwOSBEaWVnbyBFc2Nh bGFudGUgVXJyZWxvIDxkaWVnb2VAZ25vbWUub3JnPgogICogIENvcHlyaWdodCAoQykgMjAwNiwg MjAwNyBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgotICogIENvcHlyaWdodCAoQykg MjAwOSwgSWdhbGlhIFMuTC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDksIDIwMTAgSWdhbGlhIFMu TC4KICAqICBDb3B5cmlnaHQgKEMpIDIwMTAsIE1hcnRpbiBSb2JpbnNvbiA8bXJvYmluc29uQHdl YmtpdC5vcmc+CiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2Fu IHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKQEAgLTYwNCwxMSArNjA0LDYgQEAgdm9pZCBFZGl0b3JD bGllbnQ6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiAgICAgaWYg KCFwbGF0Zm9ybUV2ZW50KQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBEb24ndCBhbGxvdyBl ZGl0b3IgY29tbWFuZHMgb3IgdGV4dCBpbnNlcnRpb24gZm9yIG5vZGVzIHRoYXQKLSAgICAvLyBj YW5ub3QgZWRpdCwgdW5sZXNzIHdlIGFyZSBpbiBjYXJldCBtb2RlLgotICAgIGlmICghZnJhbWUt PmVkaXRvcigpLT5jYW5FZGl0KCkgJiYgIShmcmFtZS0+c2V0dGluZ3MoKSAmJiBmcmFtZS0+c2V0 dGluZ3MoKS0+Y2FyZXRCcm93c2luZ0VuYWJsZWQoKSkpCi0gICAgICAgIHJldHVybjsKLQogICAg IGdlbmVyYXRlRWRpdG9yQ29tbWFuZHMoZXZlbnQpOwogICAgIGlmIChtX3BlbmRpbmdFZGl0b3JD b21tYW5kcy5zaXplKCkgPiAwKSB7CiAKQEAgLTYyMiwxMiArNjE3LDE3IEBAIHZvaWQgRWRpdG9y Q2xpZW50OjpoYW5kbGVLZXlib2FyZEV2ZW50KEtleWJvYXJkRXZlbnQqIGV2ZW50KQogICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKGV4ZWN1dGVQZW5kaW5nRWRp dG9yQ29tbWFuZHMoZnJhbWUsIHRydWUpKSB7CisgICAgICAgIC8vIE9ubHkgYWxsb3cgdGV4dCBp bnNlcnRpb24gY29tbWFuZHMgaWYgdGhlIGN1cnJlbnQgbm9kZSBpcyBlZGl0YWJsZS4KKyAgICAg ICAgaWYgKGV4ZWN1dGVQZW5kaW5nRWRpdG9yQ29tbWFuZHMoZnJhbWUsIGZyYW1lLT5lZGl0b3Io KS0+Y2FuRWRpdCgpKSkgewogICAgICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7 CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9CiAKKyAgICAvLyBEb24ndCBh bGxvdyB0ZXh0IGluc2VydGlvbiBmb3Igbm9kZXMgdGhhdCBjYW5ub3QgZWRpdC4KKyAgICBpZiAo IWZyYW1lLT5lZGl0b3IoKS0+Y2FuRWRpdCgpKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBU aGlzIGlzIGp1c3QgYSBub3JtYWwgdGV4dCBpbnNlcnRpb24sIHNvIHdhaXQgdG8gZXhlY3V0ZSB0 aGUgaW5zZXJ0aW9uCiAgICAgLy8gdW50aWwgYSBrZXlwcmVzcyBldmVudCBoYXBwZW5zLiBUaGlz IHdpbGwgZW5zdXJlIHRoYXQgdGhlIGluc2VydGlvbiB3aWxsIG5vdAogICAgIC8vIGJlIHJlZmxl Y3RlZCBpbiB0aGUgY29udGVudHMgb2YgdGhlIGZpZWxkIHVudGlsIHRoZSBrZXl1cCBET00gZXZl bnQuCg==