<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>41161</bug_id>
          
          <creation_ts>2010-06-24 08:33:52 -0700</creation_ts>
          <short_desc>[Chromium] Update chromium webkit.gyp so it has option to be built as DLL</short_desc>
          <delta_ts>2010-06-25 18:16:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Victor Wang">victorw</reporter>
          <assigned_to name="Victor Wang">victorw</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>fishd</cc>
    
    <cc>maruel</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>242526</commentid>
    <comment_count>0</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-06-24 08:33:52 -0700</bug_when>
    <thetext>This is part of effort to build chromium multi dll version. Need updating gyp so chromium webkit has the option to be built as webkit.dll.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>242546</commentid>
    <comment_count>1</comment_count>
      <attachid>59662</attachid>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-06-24 09:28:14 -0700</bug_when>
    <thetext>Created attachment 59662
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>242567</commentid>
    <comment_count>2</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-06-24 10:15:52 -0700</bug_when>
    <thetext>Marc-Antoine,
Could you also take a look at this patch? you are the one who is familiar gyp...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>243299</commentid>
    <comment_count>3</comment_count>
      <attachid>59662</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-25 18:16:36 -0700</bug_when>
    <thetext>Comment on attachment 59662
Proposed Patch

Clearing flags on attachment: 59662

Committed r61929: &lt;http://trac.webkit.org/changeset/61929&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>243300</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-25 18:16:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>59662</attachid>
            <date>2010-06-24 09:28:14 -0700</date>
            <delta_ts>2010-06-25 18:16:36 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>webkit_dll.patch</filename>
            <type>text/plain</type>
            <size>3179</size>
            <attacher name="Victor Wang">victorw</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjE3NjYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh
bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDYtMjQgIFZpY3Rv
ciBXYW5nICA8dmljdG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBVcGRhdGUgY2hyb21pdW0gd2Via2l0
IGd5cCBzbyBpdCBoYXMKKyAgICAgICAgb3B0aW9uIHRvIGJlIGJ1aWx0IGFzIERMTC4KKworICAg
ICAgICBDaHJvbWl1bSB3ZWJraXQgaXMgYnVpbHQgYXMgd2Via2l0LmRsbCBvbiB3aW5kb3dzCisg
ICAgICAgIGlmIGl0IGlzIGluc2lkZSBjaHJvbWl1bSBidWlsZCBhbmQgdmFyaWFibGUgY29tcG9u
ZW50CisgICAgICAgIGlzIHNldCB0byBzaGFyZWRfbGlicmFyeS4KKworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExNjEKKworICAgICAgICAqIFdlYktp
dC5neXA6CisKIDIwMTAtMDYtMjMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5v
cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KSW5kZXg6IFdlYktp
dC9jaHJvbWl1bS9XZWJLaXQuZ3lwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9XZWJL
aXQuZ3lwCShyZXZpc2lvbiA2MTc2MykKKysrIFdlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCSh3
b3JraW5nIGNvcHkpCkBAIC01Miw3ICs1Miw2IEBACiAgICAgJ3RhcmdldHMnOiBbCiAgICAgICAg
IHsKICAgICAgICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJraXQnLAotICAgICAgICAgICAgJ3R5
cGUnOiAnPCh3ZWJraXRfdGFyZ2V0X3R5cGUpJywKICAgICAgICAgICAgICdtc3ZzX2d1aWQnOiAn
NUVDRUM5RTUtOEYyMy00N0I2LTkzRTAtQzNCMzI4QjNCRTY1JywKICAgICAgICAgICAgICdkZXBl
bmRlbmNpZXMnOiBbCiAgICAgICAgICAgICAgICAgJy4uLy4uL1dlYkNvcmUvV2ViQ29yZS5neXAv
V2ViQ29yZS5neXA6d2ViY29yZScsCkBAIC00NDcsNiArNDQ2LDM0IEBACiAgICAgICAgICAgICAg
ICAgJ3NyYy93aW4vV2ViU2NyZWVuSW5mb0ZhY3RvcnkuY3BwJywKICAgICAgICAgICAgIF0sCiAg
ICAgICAgICAgICAnY29uZGl0aW9ucyc6IFsKKyAgICAgICAgICAgICAgICBbJ2luc2lkZV9jaHJv
bWl1bV9idWlsZD09MSBhbmQgT1M9PSJ3aW4iJywgeworICAgICAgICAgICAgICAgICAgICAndHlw
ZSc6ICc8KGNvbXBvbmVudCknLAorCisgICAgICAgICAgICAgICAgICAgICdjb25kaXRpb25zJzog
WworICAgICAgICAgICAgICAgICAgICAgICAgWydjb21wb25lbnQ9PSJzaGFyZWRfbGlicmFyeSIn
LCB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2RlZmluZXMnOiBbCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICdXRUJLSVRfRExMJywKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgJ1VTSU5HX1Y4X1NIQVJFRCcsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgXSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWworICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnLi4vLi4vV2ViQ29yZS9XZWJDb3JlLmd5cC9X
ZWJDb3JlLmd5cDp3ZWJjb3JlX2JpbmRpbmdzJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvZ3B1L2dwdS5neXA6Z2xlczJfY19saWInLAorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9w
YXJ0eS9pY3UvaWN1Lmd5cDoqJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwo
Y2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbGlianBlZy9saWJqcGVnLmd5cDpsaWJqcGVn
JywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikv
dGhpcmRfcGFydHkvbGlicG5nL2xpYnBuZy5neXA6bGlicG5nJywKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbGlieG1sL2xp
YnhtbC5neXA6bGlieG1sJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hy
b21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbGlieHNsdC9saWJ4c2x0Lmd5cDpsaWJ4c2x0JywK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhp
cmRfcGFydHkvbW9kcF9iNjQvbW9kcF9iNjQuZ3lwOm1vZHBfYjY0JywKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbnNzL25z
cy5neXA6KicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3Ny
Y19kaXIpL3RoaXJkX3BhcnR5L290cy9vdHMuZ3lwOm90cycsCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L3psaWIvemxpYi5n
eXA6emxpYicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3Ny
Y19kaXIpL3Y4L3Rvb2xzL2d5cC92OC5neXA6djgnLAorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIF0sCisgICAgICAgICAgICAgICAgICAgICAgICB9XSwKKyAgICAgICAgICAgICAgICAgICAg
XSwKKyAgICAgICAgICAgICAgICB9LCB7CisgICAgICAgICAgICAgICAgICAgICd0eXBlJzogJzwo
d2Via2l0X3RhcmdldF90eXBlKScKKyAgICAgICAgICAgICAgICB9XSwKICAgICAgICAgICAgICAg
ICBbJ09TPT0ibGludXgiIG9yIE9TPT0iZnJlZWJzZCInLCB7CiAgICAgICAgICAgICAgICAgICAg
ICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9z
cmNfZGlyKS9idWlsZC9saW51eC9zeXN0ZW0uZ3lwOmZvbnRjb25maWcnLAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>