41149 2010-06-24 04:29:26 -0700 [EFL] Implement downloadURL in ContextMenuClientEfl 2010-07-06 19:58:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 40967 1 gyuyoung.kim webkit-unassigned commit-queue hyuki.kim joone.hur kenneth leandro lucas.de.marchi oldest_to_newest 242434 0 gyuyoung.kim 2010-06-24 04:29:26 -0700 I implement the downloadURL method in ContextMenuClient as well as FrameLoaderClient. BTW, in ContextMenuClient, there is a style error as below, ../WebKit-EWebLauncher/WebKit/efl/WebCoreSupport/ContextMenuClientEfl.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 1 files I fix it to avoid style error as well. 242439 1 59636 gyuyoung.kim 2010-06-24 04:32:24 -0700 Created attachment 59636 Patch Patch. 242466 2 59636 lucas.de.marchi 2010-06-24 05:29:45 -0700 Comment on attachment 59636 Patch Just an informal review: looks good. 246507 3 gyuyoung.kim 2010-07-04 22:23:05 -0700 Dear kenneth, Please review this bug as well. Thank you, Gyuyoung Kim 246719 4 59636 kenneth 2010-07-05 11:13:33 -0700 Comment on attachment 59636 Patch WebKit/ChangeLog:7 + to application. That is one long bug title! WebKit/efl/WebCoreSupport/ContextMenuClientEfl.cpp:72 + download.url = url.string().utf8().data(); shouldn't you copy it? 246725 5 lucas.de.marchi 2010-07-05 11:29:38 -0700 (In reply to comment #4) > WebKit/efl/WebCoreSupport/ContextMenuClientEfl.cpp:72 > + download.url = url.string().utf8().data(); > shouldn't you copy it? No, but this is indeed wrong. Gyuyoung Kim, you should do as in FrameLoaderClientEfl::download(ResourceHandle*, const ResourceRequest& request, const ResourceRequest&, const ResourceResponse&). That is: CString url = request.url().prettyURL().utf8(); download.url = url.data(); This way you will keep the CString object in stack until ewk_view_download_request returns. Otherwise the CString object returned by utf8() will be destroyed as soon as its .data() returns. 246810 6 60574 gyuyoung.kim 2010-07-05 17:39:13 -0700 Created attachment 60574 Patch Kenneth and Lucas, thank you for your review. I didn't think about it. If the download url is not copied, the url can be removed. This is a bug. I modify this patch according to your guidance. 246814 7 60574 kenneth 2010-07-05 18:19:41 -0700 Comment on attachment 60574 Patch WebKit/efl/WebCoreSupport/ContextMenuClientEfl.h:46 + virtual void downloadURL(const KURL& url); don't add url here, according to style guide 246819 8 gyuyoung.kim 2010-07-05 18:47:23 -0700 Should I remove url argument in virtual void downloadURL(const KURL& url); ? I referenced to gtk / qt port. ContextMenuClientGtk.h => virtual void downloadURL(const WebCore::KURL& url); ContextMenuClientQt.h => virtual void downloadURL(const KURL& url); 246820 9 kenneth 2010-07-05 18:51:53 -0700 (In reply to comment #8) > Should I remove url argument in virtual void downloadURL(const KURL& url); ? > > I referenced to gtk / qt port. > > ContextMenuClientGtk.h > => virtual void downloadURL(const WebCore::KURL& url); > > ContextMenuClientQt.h > => virtual void downloadURL(const KURL& url); Don't trust old code :-) For method definitions you should leave our duplicate information. I already know it is an url as the type is KURL, same think with setText(const String&) is better than setText(const String& string) as string doesn't add additional info. On the other hand, if it is not duplicating info feel free to add it, like setLabel(const String& label, const String& tooltip). Got it? Qt specific code used to follow Qt style, but we will clean that up over time. 246824 10 60576 gyuyoung.kim 2010-07-05 19:06:41 -0700 Created attachment 60576 Patch If parameter's type already means parameter's name, I shouldn't define parameter, right? I keep in mind this guidance. Thank you Keneeth. 246826 11 60576 kenneth 2010-07-05 19:35:43 -0700 Comment on attachment 60576 Patch Yes, you got it 246828 12 60576 commit-queue 2010-07-05 20:12:03 -0700 Comment on attachment 60576 Patch Clearing flags on attachment: 60576 Committed r62515: <http://trac.webkit.org/changeset/62515> 247268 13 gyuyoung.kim 2010-07-06 19:11:40 -0700 Hello Leandro, Could you please change status with Resolved Fixed ? 247271 14 lucas.de.marchi 2010-07-06 19:24:08 -0700 (In reply to comment #13) > Hello Leandro, > > Could you please change status with Resolved Fixed ? This should be done automatically by Commit Bot. I don't know why it didn't happen. 247274 15 leandro 2010-07-06 19:57:41 -0700 (In reply to comment #14) > (In reply to comment #13) > > Hello Leandro, > > > > Could you please change status with Resolved Fixed ? > > This should be done automatically by Commit Bot. I don't know why it didn't happen. Because there is still one non-obsolete bug. I'm clearing the flags and closing the bug in a minute. 247275 16 60574 leandro 2010-07-06 19:58:14 -0700 Comment on attachment 60574 Patch Clearing obsolete patch flags. 59636 2010-06-24 04:32:24 -0700 2010-07-05 17:39:13 -0700 Patch patch-downloadURL.txt text/plain 2547 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE3NTIpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTAtMDYtMjQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBJbXBsZW1lbnQgZG93bmxvYWRVUkwgaW4gQ29udGV4dE1lbnVDbGllbnRFZmwuCisg ICAgICAgIFdoZW4gdXNlciBzZWxlY3RzIGEgZG93bmxvYWQgbWVudSBmcm9tIGNvbnRleHQgbWVu dSwgc2VuZCB0aGUgZG93bmxvYWQgcmVxdWVzdAorICAgICAgICB0byBhcHBsaWNhdGlvbi4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMTQ5CisKKyAg ICAgICAgKiBlZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRFZmwuY3BwOiAKKyAg ICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51Q2xpZW50RWZsOjpkb3dubG9hZFVSTCk6IEdldCB1 cmwgZm9yIGRvd25sb2FkaW5nIGZpbGUgYW5kCisgICAgICAgIFNlbmQgaXQgdG8gYXBwbGljYXRp b24uCisgICAgICAgICogZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50RWZsLmg6 CisKIDIwMTAtMDYtMjMgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhIFNpbHZhLgpJbmRleDogV2Vi S2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudEVmbC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudEVmbC5jcHAJ KHJldmlzaW9uIDYxNzUyKQorKysgV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVu dUNsaWVudEVmbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwLDExICszMCwxMSBAQAogCiAjaW5j bHVkZSAiQ29udGV4dE1lbnUuaCIKICNpbmNsdWRlICJFV2ViS2l0LmgiCi0jaW5jbHVkZSAiZXdr X3ByaXZhdGUuaCIKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0LmgiCiAjaW5jbHVkZSAiS1VSTC5o IgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1NZW51RGVz Y3JpcHRpb24uaCIKKyNpbmNsdWRlICJld2tfcHJpdmF0ZS5oIgogCiB1c2luZyBuYW1lc3BhY2Ug V2ViQ29yZTsKIApAQCAtNjIsOSArNjIsMTUgQEAgdm9pZCBDb250ZXh0TWVudUNsaWVudEVmbDo6 Y29udGV4dE1lbnVJdAogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKLXZvaWQgQ29udGV4dE1l bnVDbGllbnRFZmw6OmRvd25sb2FkVVJMKGNvbnN0IEtVUkwmKQordm9pZCBDb250ZXh0TWVudUNs aWVudEVmbDo6ZG93bmxvYWRVUkwoY29uc3QgS1VSTCYgdXJsKQogewotICAgIG5vdEltcGxlbWVu dGVkKCk7CisgICAgaWYgKCFtX3ZpZXcpCisgICAgICAgIHJldHVybjsKKworICAgIEV3a19Eb3du bG9hZCBkb3dubG9hZDsKKworICAgIGRvd25sb2FkLnVybCA9IHVybC5zdHJpbmcoKS51dGY4KCku ZGF0YSgpOworICAgIGV3a192aWV3X2Rvd25sb2FkX3JlcXVlc3QobV92aWV3LCAmZG93bmxvYWQp OwogfQogCiB2b2lkIENvbnRleHRNZW51Q2xpZW50RWZsOjpzZWFyY2hXaXRoR29vZ2xlKGNvbnN0 IEZyYW1lKikKSW5kZXg6IFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGll bnRFZmwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRN ZW51Q2xpZW50RWZsLmgJKHJldmlzaW9uIDYxNzUyKQorKysgV2ViS2l0L2VmbC9XZWJDb3JlU3Vw cG9ydC9Db250ZXh0TWVudUNsaWVudEVmbC5oCSh3b3JraW5nIGNvcHkpCkBAIC00Myw3ICs0Myw3 IEBAIGNsYXNzIENvbnRleHRNZW51Q2xpZW50RWZsIDogcHVibGljIENvbnQKICAgICB2aXJ0dWFs IFBsYXRmb3JtTWVudURlc2NyaXB0aW9uIGdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKENv bnRleHRNZW51Kik7CiAgICAgdmlydHVhbCB2b2lkIGNvbnRleHRNZW51SXRlbVNlbGVjdGVkKENv bnRleHRNZW51SXRlbSosIGNvbnN0IENvbnRleHRNZW51Kik7CiAKLSAgICB2aXJ0dWFsIHZvaWQg ZG93bmxvYWRVUkwoY29uc3QgS1VSTCYpOworICAgIHZpcnR1YWwgdm9pZCBkb3dubG9hZFVSTChj b25zdCBLVVJMJiB1cmwpOwogICAgIHZpcnR1YWwgdm9pZCBzZWFyY2hXaXRoR29vZ2xlKGNvbnN0 IEZyYW1lKik7CiAgICAgdmlydHVhbCB2b2lkIGxvb2tVcEluRGljdGlvbmFyeShGcmFtZSopOwog ICAgIHZpcnR1YWwgdm9pZCBzcGVhayhjb25zdCBTdHJpbmcmKTsK 60574 2010-07-05 17:39:13 -0700 2010-07-06 19:58:14 -0700 Patch patch.txt text/plain 2606 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjI1MTApCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTAtMDctMDUgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KKworICAgICAgICBbRUZMXSBJbXBsZW1lbnQgZG93bmxvYWRVUkwgaW4gQ29udGV4dE1lbnVD bGllbnRFZmwKKyAgICAgICAgV2hlbiB1c2VyIHNlbGVjdHMgYSBkb3dubG9hZCBtZW51IGZyb20g Y29udGV4dCBtZW51LCBzZW5kIHRoZSBkb3dubG9hZCAKKyAgICAgICAgcmVxdWVzdCB0byBhcHBs aWNhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQxMTQ5CisKKyAgICAgICAgKiBlZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRF ZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnVDbGllbnRFZmw6OmRvd25sb2Fk VVJMKTogR2V0IHVybCBmb3IgZG93bmxvYWRpbmcgCisgICAgICAgIGZpbGUgYW5kIFNlbmQgaXQg dG8gYXBwbGljYXRpb24uCisgICAgICAgICogZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51 Q2xpZW50RWZsLmg6CisKIDIwMTAtMDYtMzAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbi4KSW5kZXg6IFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRF ZmwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1l bnVDbGllbnRFZmwuY3BwCShyZXZpc2lvbiA2MjUwOSkKKysrIFdlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvQ29udGV4dE1lbnVDbGllbnRFZmwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCwxMSAr MzAsMTEgQEAKIAogI2luY2x1ZGUgIkNvbnRleHRNZW51LmgiCiAjaW5jbHVkZSAiRVdlYktpdC5o IgotI2luY2x1ZGUgImV3a19wcml2YXRlLmgiCiAjaW5jbHVkZSAiSGl0VGVzdFJlc3VsdC5oIgog I2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUg IlBsYXRmb3JtTWVudURlc2NyaXB0aW9uLmgiCisjaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKIAog dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTYyLDkgKzYyLDE2IEBAIHZvaWQgQ29udGV4 dE1lbnVDbGllbnRFZmw6OmNvbnRleHRNZW51SXQKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQog Ci12b2lkIENvbnRleHRNZW51Q2xpZW50RWZsOjpkb3dubG9hZFVSTChjb25zdCBLVVJMJikKK3Zv aWQgQ29udGV4dE1lbnVDbGllbnRFZmw6OmRvd25sb2FkVVJMKGNvbnN0IEtVUkwmIHVybCkKIHsK LSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm47 CisKKyAgICBFd2tfRG93bmxvYWQgZG93bmxvYWQ7CisKKyAgICBDU3RyaW5nIGRvd25sb2FkVXJs ID0gdXJsLnByZXR0eVVSTCgpLnV0ZjgoKTsKKyAgICBkb3dubG9hZC51cmwgPSBkb3dubG9hZFVy bC5kYXRhKCk7CisgICAgZXdrX3ZpZXdfZG93bmxvYWRfcmVxdWVzdChtX3ZpZXcsICZkb3dubG9h ZCk7CiB9CiAKIHZvaWQgQ29udGV4dE1lbnVDbGllbnRFZmw6OnNlYXJjaFdpdGhHb29nbGUoY29u c3QgRnJhbWUqKQpJbmRleDogV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNs aWVudEVmbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4 dE1lbnVDbGllbnRFZmwuaAkocmV2aXNpb24gNjI1MDkpCisrKyBXZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L0NvbnRleHRNZW51Q2xpZW50RWZsLmgJKHdvcmtpbmcgY29weSkKQEAgLTQzLDcgKzQz LDcgQEAgY2xhc3MgQ29udGV4dE1lbnVDbGllbnRFZmwgOiBwdWJsaWMgQ29udAogICAgIHZpcnR1 YWwgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gZ2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRlbXMo Q29udGV4dE1lbnUqKTsKICAgICB2aXJ0dWFsIHZvaWQgY29udGV4dE1lbnVJdGVtU2VsZWN0ZWQo Q29udGV4dE1lbnVJdGVtKiwgY29uc3QgQ29udGV4dE1lbnUqKTsKIAotICAgIHZpcnR1YWwgdm9p ZCBkb3dubG9hZFVSTChjb25zdCBLVVJMJik7CisgICAgdmlydHVhbCB2b2lkIGRvd25sb2FkVVJM KGNvbnN0IEtVUkwmIHVybCk7CiAgICAgdmlydHVhbCB2b2lkIHNlYXJjaFdpdGhHb29nbGUoY29u c3QgRnJhbWUqKTsKICAgICB2aXJ0dWFsIHZvaWQgbG9va1VwSW5EaWN0aW9uYXJ5KEZyYW1lKik7 CiAgICAgdmlydHVhbCB2b2lkIHNwZWFrKGNvbnN0IFN0cmluZyYpOwo= 60576 2010-07-05 19:06:41 -0700 2010-07-05 20:12:03 -0700 Patch patch.txt text/plain 1892 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjI1MTApCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTAtMDctMDUgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KKworICAgICAgICBbRUZMXSBJbXBsZW1lbnQgZG93bmxvYWRVUkwgaW4gQ29udGV4dE1lbnVD bGllbnRFZmwKKyAgICAgICAgV2hlbiB1c2VyIHNlbGVjdHMgYSBkb3dubG9hZCBtZW51IGZyb20g Y29udGV4dCBtZW51LCBzZW5kIHRoZSBkb3dubG9hZCAKKyAgICAgICAgcmVxdWVzdCB0byBhcHBs aWNhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQxMTQ5CisKKyAgICAgICAgKiBlZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRF ZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnVDbGllbnRFZmw6OmRvd25sb2Fk VVJMKTogR2V0IHVybCBmb3IgZG93bmxvYWRpbmcgCisgICAgICAgIGZpbGUgYW5kIFNlbmQgaXQg dG8gYXBwbGljYXRpb24uCisgICAgICAgICogZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51 Q2xpZW50RWZsLmg6CisKIDIwMTAtMDYtMzAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbi4KSW5kZXg6IFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRF ZmwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1l bnVDbGllbnRFZmwuY3BwCShyZXZpc2lvbiA2MjUwOSkKKysrIFdlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvQ29udGV4dE1lbnVDbGllbnRFZmwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCwxMSAr MzAsMTEgQEAKIAogI2luY2x1ZGUgIkNvbnRleHRNZW51LmgiCiAjaW5jbHVkZSAiRVdlYktpdC5o IgotI2luY2x1ZGUgImV3a19wcml2YXRlLmgiCiAjaW5jbHVkZSAiSGl0VGVzdFJlc3VsdC5oIgog I2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUg IlBsYXRmb3JtTWVudURlc2NyaXB0aW9uLmgiCisjaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKIAog dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTYyLDkgKzYyLDE2IEBAIHZvaWQgQ29udGV4 dE1lbnVDbGllbnRFZmw6OmNvbnRleHRNZW51SXQKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQog Ci12b2lkIENvbnRleHRNZW51Q2xpZW50RWZsOjpkb3dubG9hZFVSTChjb25zdCBLVVJMJikKK3Zv aWQgQ29udGV4dE1lbnVDbGllbnRFZmw6OmRvd25sb2FkVVJMKGNvbnN0IEtVUkwmIHVybCkKIHsK LSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm47 CisKKyAgICBFd2tfRG93bmxvYWQgZG93bmxvYWQ7CisKKyAgICBDU3RyaW5nIGRvd25sb2FkVXJs ID0gdXJsLnByZXR0eVVSTCgpLnV0ZjgoKTsKKyAgICBkb3dubG9hZC51cmwgPSBkb3dubG9hZFVy bC5kYXRhKCk7CisgICAgZXdrX3ZpZXdfZG93bmxvYWRfcmVxdWVzdChtX3ZpZXcsICZkb3dubG9h ZCk7CiB9CiAKIHZvaWQgQ29udGV4dE1lbnVDbGllbnRFZmw6OnNlYXJjaFdpdGhHb29nbGUoY29u c3QgRnJhbWUqKQo=