41145 2010-06-24 04:12:23 -0700 Add plugin accessors to WebPluginContainer. 2010-06-25 22:51:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 bauerb webkit-unassigned commit-queue fishd oldest_to_newest 242420 0 bauerb 2010-06-24 04:12:23 -0700 In order to swap out a plugin placeholder for a real plugin when doing click-to-load, WebPluginContainer needs accessors. 242421 1 59630 bauerb 2010-06-24 04:16:47 -0700 Created attachment 59630 Add plugin accessor to WebPluginContainer. 242564 2 59630 levin 2010-06-24 10:10:48 -0700 Comment on attachment 59630 Add plugin accessor to WebPluginContainer. fyi WebKit/chromium/public/WebPluginContainer.h:82 + virtual void setPlugin(WebPlugin* plugin) = 0; WebKit typically doesn't include parameter names in declarations when those names add no new information, so omit "plugin". 242573 3 59668 bauerb 2010-06-24 10:20:58 -0700 Created attachment 59668 Add plugin accessor to WebPluginContainer. Removed parameter "plugin" from setPlugin(). 242600 4 59668 fishd 2010-06-24 11:16:01 -0700 Comment on attachment 59668 Add plugin accessor to WebPluginContainer. WebKit/chromium/src/WebPluginContainerImpl.h:111 + void setPlugin(WebPlugin* plugin) { m_webPlugin = plugin; } nit: please move these into the "WebPluginContainer methods" section. 242953 5 59758 bauerb 2010-06-25 04:41:29 -0700 Created attachment 59758 Add plugin accessor to WebPluginContainer. Moved accessors to WebPluginContainer methods section. 243328 6 59758 commit-queue 2010-06-25 22:51:12 -0700 Comment on attachment 59758 Add plugin accessor to WebPluginContainer. Clearing flags on attachment: 59758 Committed r61942: <http://trac.webkit.org/changeset/61942> 243329 7 commit-queue 2010-06-25 22:51:17 -0700 All reviewed patches have been landed. Closing bug. 59630 2010-06-24 04:16:47 -0700 2010-06-24 10:20:58 -0700 Add plugin accessor to WebPluginContainer. plugin_accessors.patch text/plain 1769 bauerb ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDk1NzgwYjYuLjdiMGVlMTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA2LTI0ICBCZXJuaGFyZCBCYXVlciAgPGJhdWVyYkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHBs dWdpbiBhY2Nlc3NvcnMgdG8gV2ViUGx1Z2luQ29udGFpbmVyLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExNDUKKworICAgICAgICAqIHB1YmxpYy9X ZWJQbHVnaW5Db250YWluZXIuaDoKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1w bC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBsOjpzZXRQbHVnaW4p OgorCiAyMDEwLTA1LTI2ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgY2hyb21pdW0gYnVpbGQgZml4CmRpZmYgLS1naXQgYS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaAppbmRleCA3YjIzZjA4Li5jNzAzNTc3IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCisrKyBiL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luQ29udGFpbmVyLmgKQEAgLTM2LDYgKzM2LDcg QEAgc3RydWN0IE5QT2JqZWN0OwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIFdlYkVsZW1l bnQ7CitjbGFzcyBXZWJQbHVnaW47CiBjbGFzcyBXZWJTdHJpbmc7CiBjbGFzcyBXZWJVUkw7CiBj bGFzcyBXZWJVUkxSZXF1ZXN0OwpAQCAtNzcsNiArNzgsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIGxvYWRGcmFtZVJlcXVlc3QoCiAgICAgICAgIGNvbnN0IFdlYlVSTFJlcXVlc3QmLCBj b25zdCBXZWJTdHJpbmcmIHRhcmdldCwgYm9vbCBub3RpZnlOZWVkZWQsIHZvaWQqIG5vdGlmeURh dGEpID0gMDsKIAorICAgIHZpcnR1YWwgV2ViUGx1Z2luKiBwbHVnaW4oKSA9IDA7CisgICAgdmly dHVhbCB2b2lkIHNldFBsdWdpbihXZWJQbHVnaW4qIHBsdWdpbikgPSAwOworCiBwcm90ZWN0ZWQ6 CiAgICAgfldlYlBsdWdpbkNvbnRhaW5lcigpIHsgfQogfTsKZGlmZiAtLWdpdCBhL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oIGIvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmgKaW5kZXggYWQyZmE5NS4uNTI0YTcyZCAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmgKKysrIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmgKQEAgLTEwOCw2ICsx MDgsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBUaGlzIGNhbm5vdCBiZSBudWxsLgogICAgIFdlYlBs dWdpbiogcGx1Z2luKCkgeyByZXR1cm4gbV93ZWJQbHVnaW47IH0KKyAgICB2b2lkIHNldFBsdWdp bihXZWJQbHVnaW4qIHBsdWdpbikgeyBtX3dlYlBsdWdpbiA9IHBsdWdpbjsgfQogCiAgICAgdm9p ZCB3aWxsRGVzdHJveVBsdWdpbkxvYWRPYnNlcnZlcihXZWJQbHVnaW5Mb2FkT2JzZXJ2ZXIqKTsK IAo= 59668 2010-06-24 10:20:58 -0700 2010-06-25 04:41:29 -0700 Add plugin accessor to WebPluginContainer. plugin_accessors.patch text/plain 1762 bauerb ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDk1NzgwYjYuLjdiMGVlMTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA2LTI0ICBCZXJuaGFyZCBCYXVlciAgPGJhdWVyYkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHBs dWdpbiBhY2Nlc3NvcnMgdG8gV2ViUGx1Z2luQ29udGFpbmVyLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExNDUKKworICAgICAgICAqIHB1YmxpYy9X ZWJQbHVnaW5Db250YWluZXIuaDoKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1w bC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBsOjpzZXRQbHVnaW4p OgorCiAyMDEwLTA1LTI2ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgY2hyb21pdW0gYnVpbGQgZml4CmRpZmYgLS1naXQgYS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaAppbmRleCA3YjIzZjA4Li42NmVmOWFiIDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCisrKyBiL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luQ29udGFpbmVyLmgKQEAgLTM2LDYgKzM2LDcg QEAgc3RydWN0IE5QT2JqZWN0OwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIFdlYkVsZW1l bnQ7CitjbGFzcyBXZWJQbHVnaW47CiBjbGFzcyBXZWJTdHJpbmc7CiBjbGFzcyBXZWJVUkw7CiBj bGFzcyBXZWJVUkxSZXF1ZXN0OwpAQCAtNzcsNiArNzgsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIGxvYWRGcmFtZVJlcXVlc3QoCiAgICAgICAgIGNvbnN0IFdlYlVSTFJlcXVlc3QmLCBj b25zdCBXZWJTdHJpbmcmIHRhcmdldCwgYm9vbCBub3RpZnlOZWVkZWQsIHZvaWQqIG5vdGlmeURh dGEpID0gMDsKIAorICAgIHZpcnR1YWwgV2ViUGx1Z2luKiBwbHVnaW4oKSA9IDA7CisgICAgdmly dHVhbCB2b2lkIHNldFBsdWdpbihXZWJQbHVnaW4qKSA9IDA7CisKIHByb3RlY3RlZDoKICAgICB+ V2ViUGx1Z2luQ29udGFpbmVyKCkgeyB9CiB9OwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmggYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBs dWdpbkNvbnRhaW5lckltcGwuaAppbmRleCBhZDJmYTk1Li41MjRhNzJkIDEwMDY0NAotLS0gYS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaAorKysgYi9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaApAQCAtMTA4LDYgKzEwOCw3IEBA IHB1YmxpYzoKIAogICAgIC8vIFRoaXMgY2Fubm90IGJlIG51bGwuCiAgICAgV2ViUGx1Z2luKiBw bHVnaW4oKSB7IHJldHVybiBtX3dlYlBsdWdpbjsgfQorICAgIHZvaWQgc2V0UGx1Z2luKFdlYlBs dWdpbiogcGx1Z2luKSB7IG1fd2ViUGx1Z2luID0gcGx1Z2luOyB9CiAKICAgICB2b2lkIHdpbGxE ZXN0cm95UGx1Z2luTG9hZE9ic2VydmVyKFdlYlBsdWdpbkxvYWRPYnNlcnZlciopOwogCg== 59758 2010-06-25 04:41:29 -0700 2010-06-25 22:51:12 -0700 Add plugin accessor to WebPluginContainer. plugin_accessors.patch text/plain 2328 bauerb ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGNkNDMyOTMuLmY5OTZhODEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA2LTI0ICBCZXJuaGFyZCBCYXVlciAgPGJhdWVyYkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHBs dWdpbiBhY2Nlc3NvcnMgdG8gV2ViUGx1Z2luQ29udGFpbmVyLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDExNDUKKworICAgICAgICAqIHB1YmxpYy9X ZWJQbHVnaW5Db250YWluZXIuaDoKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1w bC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBsOjpzZXRQbHVnaW4p OgorCiAyMDEwLTA2LTI0ICBWYW5nZWxpcyBLb2trZXZpcyAgPHZhbmdlbGlzQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oIGIvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaAppbmRleCA3YjIzZjA4Li42NmVmOWFiIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCisrKyBi L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luQ29udGFpbmVyLmgKQEAgLTM2LDYgKzM2 LDcgQEAgc3RydWN0IE5QT2JqZWN0OwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIFdlYkVs ZW1lbnQ7CitjbGFzcyBXZWJQbHVnaW47CiBjbGFzcyBXZWJTdHJpbmc7CiBjbGFzcyBXZWJVUkw7 CiBjbGFzcyBXZWJVUkxSZXF1ZXN0OwpAQCAtNzcsNiArNzgsOSBAQCBwdWJsaWM6CiAgICAgdmly dHVhbCB2b2lkIGxvYWRGcmFtZVJlcXVlc3QoCiAgICAgICAgIGNvbnN0IFdlYlVSTFJlcXVlc3Qm LCBjb25zdCBXZWJTdHJpbmcmIHRhcmdldCwgYm9vbCBub3RpZnlOZWVkZWQsIHZvaWQqIG5vdGlm eURhdGEpID0gMDsKIAorICAgIHZpcnR1YWwgV2ViUGx1Z2luKiBwbHVnaW4oKSA9IDA7CisgICAg dmlydHVhbCB2b2lkIHNldFBsdWdpbihXZWJQbHVnaW4qKSA9IDA7CisKIHByb3RlY3RlZDoKICAg ICB+V2ViUGx1Z2luQ29udGFpbmVyKCkgeyB9CiB9OwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmggYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlBsdWdpbkNvbnRhaW5lckltcGwuaAppbmRleCBhZDJmYTk1Li4zNDFhMzk3IDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaApAQCAtODQsNiArODQsMTAg QEAgcHVibGljOgogICAgIHZpcnR1YWwgV2ViU3RyaW5nIGV4ZWN1dGVTY3JpcHRVUkwoY29uc3Qg V2ViVVJMJiwgYm9vbCBwb3B1cHNBbGxvd2VkKTsKICAgICB2aXJ0dWFsIHZvaWQgbG9hZEZyYW1l UmVxdWVzdChjb25zdCBXZWJVUkxSZXF1ZXN0JiwgY29uc3QgV2ViU3RyaW5nJiB0YXJnZXQsIGJv b2wgbm90aWZ5TmVlZGVkLCB2b2lkKiBub3RpZnlEYXRhKTsKIAorICAgIC8vIFRoaXMgY2Fubm90 IGJlIG51bGwuCisgICAgV2ViUGx1Z2luKiBwbHVnaW4oKSB7IHJldHVybiBtX3dlYlBsdWdpbjsg fQorICAgIHZvaWQgc2V0UGx1Z2luKFdlYlBsdWdpbiogcGx1Z2luKSB7IG1fd2ViUGx1Z2luID0g cGx1Z2luOyB9CisKICAgICAvLyBQcmludGluZyBpbnRlcmZhY2UuIFRoZSBwbHVnaW4gY2FuIHN1 cHBvcnQgY3VzdG9tIHByaW50aW5nCiAgICAgLy8gKHdoaWNoIG1lYW5zIGl0IGNvbnRyb2xzIHRo ZSBsYXlvdXQsIG51bWJlciBvZiBwYWdlcyBldGMpLgogICAgIC8vIFdoZXRoZXIgdGhlIHBsdWdp biBzdXBwb3J0cyBpdHMgb3duIHBhZ2luYXRlZCBwcmludC4gVGhlIG90aGVyIHByaW50CkBAIC0x MDYsOSArMTEwLDYgQEAgcHVibGljOgogCiAgICAgTlBPYmplY3QqIHNjcmlwdGFibGVPYmplY3Qo KTsKIAotICAgIC8vIFRoaXMgY2Fubm90IGJlIG51bGwuCi0gICAgV2ViUGx1Z2luKiBwbHVnaW4o KSB7IHJldHVybiBtX3dlYlBsdWdpbjsgfQotCiAgICAgdm9pZCB3aWxsRGVzdHJveVBsdWdpbkxv YWRPYnNlcnZlcihXZWJQbHVnaW5Mb2FkT2JzZXJ2ZXIqKTsKIAogcHJpdmF0ZToK