41133 2010-06-23 23:55:23 -0700 Sketch out BeforeHTMLMode state 2010-06-24 15:40:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth dglazkov eric gustavo webkit-ews webkit.review.bot xan.lopez oldest_to_newest 242334 0 abarth 2010-06-23 23:55:23 -0700 Sketch out BeforeHTMLMode state 242335 1 59615 abarth 2010-06-23 23:57:17 -0700 Created attachment 59615 Patch 242337 2 webkit-ews 2010-06-24 00:03:09 -0700 Attachment 59615 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3314612 242338 3 eric 2010-06-24 00:03:44 -0700 Attachment 59615 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/3320651 242339 4 59615 eric 2010-06-24 00:04:18 -0700 Comment on attachment 59615 Patch OK. See the code I sent you from my previous attempt at this. 242342 5 webkit.review.bot 2010-06-24 00:06:52 -0700 Attachment 59615 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3280676 242343 6 webkit.review.bot 2010-06-24 00:08:01 -0700 Attachment 59615 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3269679 242697 7 59615 abarth 2010-06-24 15:40:12 -0700 Comment on attachment 59615 Patch Clearing flags on attachment: 59615 Committed r61793: <http://trac.webkit.org/changeset/61793> 242698 8 abarth 2010-06-24 15:40:18 -0700 All reviewed patches have been landed. Closing bug. 59615 2010-06-23 23:57:17 -0700 2010-06-24 15:40:12 -0700 Patch bug-41133-20100623235716.patch text/plain 6445 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDQwZmJjZGI1YTg4YjI5OTg5YWEzMGIwNmZlMWQ0ZDQwNjEzODM2Yy4uMTg0YzZiZWU0ZmVjNjM1 NjgzNmZjZWU5ODZmZGFhZGRkODljZjNlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyNiBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFNrZXRjaCBvdXQgQmVmb3JlSFRNTE1v ZGUgc3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQxMTMzCisKKyAgICAgICAgSW4gdGhpcyBwYXRjaCwgd2Ugc3dpdGNoIHRoZSBUcmVlQnVpZGxl ciBvdmVyIHRvIHVzaW5nIEF0b21pY0hUTUxUb2tlbnMKKyAgICAgICAgYW5kIHNrZXRjaCBvdXQg YW5vdGhlciBzdGF0ZS4gIFRoZXNlIHN0YXRlcyBkb24ndCBhY3R1YWxseSBkbyBhbnl0aGluZwor ICAgICAgICB5ZXQsIEknbSBzdGlsbCBqdXN0IGdldHRpbmcgdGhlIHN0cnVjdHVyZSBvZiB0aGUg c3BlYyBpbnRvIHRoZSBjb2RlIHNvCisgICAgICAgIHdlIGNhbiBpbXBsZW1lbnQgdGhlIGRldGFp bHMgaW5jcmVtZW50YWxseS4KKworICAgICAgICAqIGh0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6Y29uc3RydWN0VHJlZUZyb21Ub2tl bik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NUb2tlbik6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6Omluc2VydERvY3R5cGUpOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjppbnNlcnRDb21tZW50KToKKyAgICAgICAgKiBo dG1sL0hUTUxUcmVlQnVpbGRlci5oOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVy OjpwYXJzZUVycm9yKToKKworMjAxMC0wNi0yMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIEFk ZCBBdG9taWNIVE1MVG9rZW4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQxMTMxCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxk ZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggNWQzZjljMDFm YjJkYmYyMmNkNDc1Njg1MmY3NDNlMGMyNTBjY2Q5Yi4uNmZlODM0MmJhNjEzOTA1YWViOTcxOTVk ZGZhYTIyNGVkMTUzZmY3ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRl ci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAKQEAgLTIwNiwyNyAr MjA2LDI5IEBAIFBhc3NSZWZQdHI8Tm9kZT4gSFRNTFRyZWVCdWlsZGVyOjpwYXNzVG9rZW5Ub0xl Z2FjeVBhcnNlcihIVE1MVG9rZW4mIHRva2VuKQogICAgIHJldHVybiByZXN1bHQucmVsZWFzZSgp OwogfQogCi1QYXNzUmVmUHRyPE5vZGU+IEhUTUxUcmVlQnVpbGRlcjo6Y29uc3RydWN0VHJlZUZy b21Ub2tlbihIVE1MVG9rZW4mIHRva2VuKQorUGFzc1JlZlB0cjxOb2RlPiBIVE1MVHJlZUJ1aWxk ZXI6OmNvbnN0cnVjdFRyZWVGcm9tVG9rZW4oSFRNTFRva2VuJiByYXdUb2tlbikKIHsKICAgICAv LyBNYWtlIE1TVkMgaWdub3JlIG91ciB1bnJlYWNoYWJsZSBjb2RlIGZvciBub3cuCiAgICAgaWYg KHRydWUpCi0gICAgICAgIHJldHVybiBwYXNzVG9rZW5Ub0xlZ2FjeVBhcnNlcih0b2tlbik7Cisg ICAgICAgIHJldHVybiBwYXNzVG9rZW5Ub0xlZ2FjeVBhcnNlcihyYXdUb2tlbik7CisKKyAgICBB dG9taWNIVE1MVG9rZW4gdG9rZW4ocmF3VG9rZW4pOwogCiAgICAgLy8gSFRNTDUgZXhwZWN0cyB0 aGUgdG9rZW5pemVyIHRvIGNhbGwgdGhlIHBhcnNlciBldmVyeSB0aW1lIGEgY2hhcmFjdGVyIGlz CiAgICAgLy8gZW1pdHRlZC4gIFdlIGluc3RlYWQgY29sbGVjdCBjaGFyYWN0ZXJzIGFuZCBjYWxs IHRoZSBwYXJzZXIgd2l0aCBhIGJhdGNoLgogICAgIC8vIEluIG9yZGVyIHRvIG1ha2Ugb3VyIGZp cnN0LXBhc3MgcGFyc2VyIGNvZGUgc2ltcGxlLCBwcm9jZXNzVG9rZW4gbWF0Y2hlcwogICAgIC8v IHRoZSBzcGVjIGluIG9ubHkgaGFuZGxpbmcgb25lIGNoYXJhY3RlciBhdCBhIHRpbWUuCiAgICAg aWYgKHRva2VuLnR5cGUoKSA9PSBIVE1MVG9rZW46OkNoYXJhY3RlcikgewotICAgICAgICBIVE1M VG9rZW46OkRhdGFWZWN0b3IgY2hhcmFjdGVycyA9IHRva2VuLmNoYXJhY3RlcnMoKTsKLSAgICAg ICAgSFRNTFRva2VuOjpEYXRhVmVjdG9yOjpjb25zdF9pdGVyYXRvciBpdHIgPSBjaGFyYWN0ZXJz LmJlZ2luKCk7Ci0gICAgICAgIGZvciAoO2l0cjsgKytpdHIpCi0gICAgICAgICAgICBwcm9jZXNz VG9rZW4odG9rZW4sICppdHIpOworICAgICAgICBTdHJpbmdJbXBsKiBjaGFyYWN0ZXJzID0gdG9r ZW4uY2hhcmFjdGVycygpLmltcGwoKTsKKyAgICAgICAgLy8gRklYTUU6IENhbGxpbmcgcHJvY2Vz c1Rva2VuIGZvciBlYWNoIGNoYXJhY3RlciBpcyBwcm9iYWJseSBzbG93LgorICAgICAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgY2hhcmFjdGVycy0+bGVuZ3RoKCk7ICsraSkKKyAgICAgICAg ICAgIHByb2Nlc3NUb2tlbih0b2tlbiwgKCpjaGFyYWN0ZXJzKVtpXSk7CiAgICAgICAgIHJldHVy biAwOyAvLyBGSVhNRTogU2hvdWxkIHdlIGJlIHJldHVybmluZyB0aGUgVGV4dCBub2RlPwogICAg IH0KICAgICByZXR1cm4gcHJvY2Vzc1Rva2VuKHRva2VuKTsKIH0KIAotUGFzc1JlZlB0cjxOb2Rl PiBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NUb2tlbihIVE1MVG9rZW4mIHRva2VuLCBVQ2hhciBj YykKK1Bhc3NSZWZQdHI8Tm9kZT4gSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzVG9rZW4oQXRvbWlj SFRNTFRva2VuJiB0b2tlbiwgVUNoYXIgY2MpCiB7CiByZXByb2Nlc3NUb2tlbjoKICAgICBzd2l0 Y2ggKGluc2VydGlvbk1vZGUoKSkgewpAQCAtMjQyLDE4ICsyNDQsNTAgQEAgcmVwcm9jZXNzVG9r ZW46CiAgICAgICAgIGNhc2UgSFRNTFRva2VuOjpDaGFyYWN0ZXI6CiAgICAgICAgICAgICBpZiAo Y2MgPT0gJ1x0JyB8fCBjYyA9PSAnXHgwQScgfHwgY2MgPT0gJ1x4MEMnIHx8IGNjID09ICdceDBE JyB8fCBjYyA9PSAnICcpCiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Ci0gICAgICAgICAgICAv LyBGYWxsIHRocm91Z2gKKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEhUTUxUb2tl bjo6U3RhcnRUYWc6CiAgICAgICAgIGNhc2UgSFRNTFRva2VuOjpFbmRUYWc6CiAgICAgICAgIGNh c2UgSFRNTFRva2VuOjpFbmRPZkZpbGU6Ci0gICAgICAgICAgICBub3RJbXBsZW1lbnRlZCgpOwot ICAgICAgICAgICAgc2V0SW5zZXJ0aW9uTW9kZShCZWZvcmVIVE1MTW9kZSk7Ci0gICAgICAgICAg ICBnb3RvIHJlcHJvY2Vzc1Rva2VuOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAg ICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgIGJyZWFrOworICAgICAgICBub3RJ bXBsZW1lbnRlZCgpOworICAgICAgICBwYXJzZUVycm9yKHRva2VuKTsKKyAgICAgICAgc2V0SW5z ZXJ0aW9uTW9kZShCZWZvcmVIVE1MTW9kZSk7CisgICAgICAgIGdvdG8gcmVwcm9jZXNzVG9rZW47 CisgICAgfQorICAgIGNhc2UgQmVmb3JlSFRNTE1vZGU6IHsKKyAgICAgICAgc3dpdGNoICh0b2tl bi50eXBlKCkpIHsKKyAgICAgICAgY2FzZSBIVE1MVG9rZW46OlVuaW5pdGlhbGl6ZWQ6CisgICAg ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAg ICBjYXNlIEhUTUxUb2tlbjo6RE9DVFlQRToKKyAgICAgICAgICAgIHBhcnNlRXJyb3IodG9rZW4p OworICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIGNhc2UgSFRNTFRva2VuOjpDb21tZW50 OgorICAgICAgICAgICAgcmV0dXJuIGluc2VydENvbW1lbnQodG9rZW4pOworICAgICAgICBjYXNl IEhUTUxUb2tlbjo6Q2hhcmFjdGVyOgorICAgICAgICAgICAgaWYgKGNjID09ICdcdCcgfHwgY2Mg PT0gJ1x4MEEnIHx8IGNjID09ICdceDBDJyB8fCBjYyA9PSAnXHgwRCcgfHwgY2MgPT0gJyAnKQor ICAgICAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNh c2UgSFRNTFRva2VuOjpTdGFydFRhZzoKKyAgICAgICAgICAgIGlmICh0b2tlbi5uYW1lKCkgPT0g aHRtbFRhZykgeworICAgICAgICAgICAgICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgICAgICAg ICAgICAgc2V0SW5zZXJ0aW9uTW9kZShCZWZvcmVIZWFkTW9kZSk7CisgICAgICAgICAgICAgICAg cmV0dXJuIDA7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2Fz ZSBIVE1MVG9rZW46OkVuZFRhZzoKKyAgICAgICAgICAgIGlmICh0b2tlbi5uYW1lKCkgPT0gaGVh ZFRhZyB8fCB0b2tlbi5uYW1lKCkgPT0gYm9keVRhZyB8fCB0b2tlbi5uYW1lKCkgPT0gaHRtbFRh ZyB8fCB0b2tlbi5uYW1lKCkgPT0gYnJUYWcpCisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICBwYXJzZUVycm9yKHRva2VuKTsKKyAgICAgICAgICAgIHJldHVybiAwOworICAgICAg ICBjYXNlIEhUTUxUb2tlbjo6RW5kT2ZGaWxlOgorICAgICAgICAgICAgYnJlYWs7CisgICAgICAg IH0KKyAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgc2V0SW5zZXJ0aW9uTW9kZShC ZWZvcmVIZWFkTW9kZSk7CisgICAgICAgIGdvdG8gcmVwcm9jZXNzVG9rZW47CiAgICAgfQotICAg IGNhc2UgQmVmb3JlSFRNTE1vZGU6CiAgICAgY2FzZSBCZWZvcmVIZWFkTW9kZToKICAgICBjYXNl IEluSGVhZE1vZGU6CiAgICAgY2FzZSBJbkhlYWROb3NjcmlwdE1vZGU6CkBAIC0yODIsMTMgKzMx NiwxMyBAQCByZXByb2Nlc3NUb2tlbjoKICAgICByZXR1cm4gMDsKIH0KIAotUGFzc1JlZlB0cjxO b2RlPiBIVE1MVHJlZUJ1aWxkZXI6Omluc2VydERvY3R5cGUoSFRNTFRva2VuJiB0b2tlbikKK1Bh c3NSZWZQdHI8Tm9kZT4gSFRNTFRyZWVCdWlsZGVyOjppbnNlcnREb2N0eXBlKEF0b21pY0hUTUxU b2tlbiYgdG9rZW4pCiB7CiAgICAgQVNTRVJUX1VOVVNFRCh0b2tlbiwgdG9rZW4udHlwZSgpID09 IEhUTUxUb2tlbjo6RE9DVFlQRSk7CiAgICAgcmV0dXJuIDA7CiB9CiAKLVBhc3NSZWZQdHI8Tm9k ZT4gSFRNTFRyZWVCdWlsZGVyOjppbnNlcnRDb21tZW50KEhUTUxUb2tlbiYgdG9rZW4pCitQYXNz UmVmUHRyPE5vZGU+IEhUTUxUcmVlQnVpbGRlcjo6aW5zZXJ0Q29tbWVudChBdG9taWNIVE1MVG9r ZW4mIHRva2VuKQogewogICAgIEFTU0VSVF9VTlVTRUQodG9rZW4sIHRva2VuLnR5cGUoKSA9PSBI VE1MVG9rZW46OkNvbW1lbnQpOwogICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9o dG1sL0hUTUxUcmVlQnVpbGRlci5oIGIvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5oCmlu ZGV4IDQ3MTkzNWQyYzAyZDE4ZjliNGQ3ZmJmOGQ5YjE2YzVmY2NiZWVlMWQuLjEyMDMzNTlhZGM4 MTNkM2UxYzIzODAwNmEyNDNlNDM4Mjc2NzNiZjQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9I VE1MVHJlZUJ1aWxkZXIuaAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmgKQEAg LTM2LDYgKzM2LDcgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBBdG9taWNIVE1M VG9rZW47CiBjbGFzcyBEb2N1bWVudDsKIGNsYXNzIERvY3VtZW50RnJhZ21lbnQ7CiBjbGFzcyBF bGVtZW50OwpAQCAtOTksMTAgKzEwMCwxMyBAQCBwcml2YXRlOgogICAgIH07CiAKICAgICBQYXNz UmVmUHRyPE5vZGU+IHBhc3NUb2tlblRvTGVnYWN5UGFyc2VyKEhUTUxUb2tlbiYpOwotICAgIFBh c3NSZWZQdHI8Tm9kZT4gcHJvY2Vzc1Rva2VuKEhUTUxUb2tlbiYsIFVDaGFyIGNjID0gMCk7Cisg ICAgUGFzc1JlZlB0cjxOb2RlPiBwcm9jZXNzVG9rZW4oQXRvbWljSFRNTFRva2VuJiwgVUNoYXIg Y2MgPSAwKTsKIAotICAgIFBhc3NSZWZQdHI8Tm9kZT4gaW5zZXJ0RG9jdHlwZShIVE1MVG9rZW4m KTsKLSAgICBQYXNzUmVmUHRyPE5vZGU+IGluc2VydENvbW1lbnQoSFRNTFRva2VuJik7CisgICAg UGFzc1JlZlB0cjxOb2RlPiBpbnNlcnREb2N0eXBlKEF0b21pY0hUTUxUb2tlbiYpOworICAgIFBh c3NSZWZQdHI8Tm9kZT4gaW5zZXJ0Q29tbWVudChBdG9taWNIVE1MVG9rZW4mKTsKKworICAgIC8v IEZJWE1FOiBJbXBsZW1lbnQgZXJyb3IgcmVwb3J0aW5nLgorICAgIHZvaWQgcGFyc2VFcnJvcihB dG9taWNIVE1MVG9rZW4mKSB7IH0KIAogICAgIHZvaWQgaGFuZGxlU2NyaXB0U3RhcnRUYWcoKTsK ICAgICB2b2lkIGhhbmRsZVNjcmlwdEVuZFRhZyhFbGVtZW50KiwgaW50IHNjcmlwdFN0YXJ0TGlu ZSk7Cg==