41116 2010-06-23 17:55:09 -0700 Reset ENABLE_IMAGE_RESIZER to 0 2010-06-25 20:22:41 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 39905 0 sswigart webkit-unassigned commit-queue dglazkov levin tkent oldest_to_newest 242194 0 59588 sswigart 2010-06-23 17:55:09 -0700 Created attachment 59588 ENABLE_IMAGE_RESIZER=0 Someone mistakenly set this value to 1 in features.gypi, but the feature is still under development. 242366 1 59588 levin 2010-06-24 00:54:00 -0700 Comment on attachment 59588 ENABLE_IMAGE_RESIZER=0 Sorry this needs a changelog. r- for that. Typically Chromium has defines set to 1 even when the feature is under development (at least at a certain point), but at this stage I agree that it would be good for this feature to not be compiled into chromium. 242397 2 tkent 2010-06-24 02:32:56 -0700 I enabled it in http://trac.webkit.org/changeset/61547 because - it's good to check build by buidbot. - We'd like to minimize features.gypi change as possible. A change for features.gypi needs manual operation on Chromium buildbots for webkit.org. It's ok to reset it to 0 if it's hard to develop the feature with ENABLE_IMAGE_RESIZER=1. 242502 3 dglazkov 2010-06-24 07:22:02 -0700 (In reply to comment #2) > I enabled it in http://trac.webkit.org/changeset/61547 because > - it's good to check build by buidbot. > - We'd like to minimize features.gypi change as possible. > A change for features.gypi needs manual operation on Chromium buildbots for webkit.org. > > It's ok to reset it to 0 if it's hard to develop the feature with ENABLE_IMAGE_RESIZER=1. manual operation == dglazkov going to the hallway and mucking with computers made in previous century. 242574 4 59669 sswigart 2010-06-24 10:21:59 -0700 Created attachment 59669 ENABLE_IMAGE_RESIZER=0 242576 5 dglazkov 2010-06-24 10:27:26 -0700 If we're going to enable it soon, can we spare my knees from doing this? 243312 6 59669 commit-queue 2010-06-25 20:22:36 -0700 Comment on attachment 59669 ENABLE_IMAGE_RESIZER=0 Clearing flags on attachment: 59669 Committed r61936: <http://trac.webkit.org/changeset/61936> 243313 7 commit-queue 2010-06-25 20:22:41 -0700 All reviewed patches have been landed. Closing bug. 59588 2010-06-23 17:55:09 -0700 2010-06-24 10:21:59 -0700 ENABLE_IMAGE_RESIZER=0 remove-enable-patch text/plain 474 sswigart ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpIGIvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkKaW5kZXggMjU2MTkyYi4uNmM0MWQwNCAxMDA2NDQKLS0tIGEvV2Vi S2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVz Lmd5cGkKQEAgLTUyLDcgKzUyLDcgQEAKICAgICAgICAgJ0VOQUJMRV9GSUxURVJTPTEnLAogICAg ICAgICAnRU5BQkxFX0dFT0xPQ0FUSU9OPTEnLAogICAgICAgICAnRU5BQkxFX0lDT05EQVRBQkFT RT0wJywKLSAgICAgICAgJ0VOQUJMRV9JTUFHRV9SRVNJWkVSPTEnLAorICAgICAgICAnRU5BQkxF X0lNQUdFX1JFU0laRVI9MCcsCiAgICAgICAgICdFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRT0xJywK ICAgICAgICAgJ0VOQUJMRV9JTlBVVF9TUEVFQ0g9MScsCiAgICAgICAgICdFTkFCTEVfSkFWQVND UklQVF9ERUJVR0dFUj0xJywK 59669 2010-06-24 10:21:59 -0700 2010-06-25 20:22:36 -0700 ENABLE_IMAGE_RESIZER=0 remove-enable-patch text/plain 1116 sswigart ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDFhOTY1NWMuLjk4ZGM2MDMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA2LTI0ICBTdGVybGluZyBTd2lnYXJ0ICA8c3N3aWdhcnRAZ29vZ2xlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNl dHRpbmcgRU5BQkxFX0lNQUdFX1JFU0laRVIgdG8gMC4gSW1hZ2Uud2Via2l0R2V0SW1hZ2UgbmVl ZHMgdG8gYmUgZGV2ZWxvcGVkIHVuZGVyCisgICAgICAgIGEgMCB2YWx1ZSwgYXQgbGVhc3QgdW50 aWwgYm90aCB0aGUgSlNDIGFuZCBWOCBiaW5kaW5ncyBhcmUgaW4gcGxhY2UuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTExNgorCisgICAgICAgICog ZmVhdHVyZXMuZ3lwaTogRU5BQkxFX0lNQUdFX1JFU0laRVI9MAorCiAyMDEwLTA2LTIzICBZdXpv IEZ1amlzaGltYSAgPHl1em9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaGlu aWNoaXJvIEhhbWFqaS4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBp IGIvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKaW5kZXggMjU2MTkyYi4uNmM0MWQwNCAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvV2ViS2l0L2No cm9taXVtL2ZlYXR1cmVzLmd5cGkKQEAgLTUyLDcgKzUyLDcgQEAKICAgICAgICAgJ0VOQUJMRV9G SUxURVJTPTEnLAogICAgICAgICAnRU5BQkxFX0dFT0xPQ0FUSU9OPTEnLAogICAgICAgICAnRU5B QkxFX0lDT05EQVRBQkFTRT0wJywKLSAgICAgICAgJ0VOQUJMRV9JTUFHRV9SRVNJWkVSPTEnLAor ICAgICAgICAnRU5BQkxFX0lNQUdFX1JFU0laRVI9MCcsCiAgICAgICAgICdFTkFCTEVfSU5ERVhF RF9EQVRBQkFTRT0xJywKICAgICAgICAgJ0VOQUJMRV9JTlBVVF9TUEVFQ0g9MScsCiAgICAgICAg ICdFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUj0xJywK