41114 2010-06-23 17:13:45 -0700 Start to clean up DocumentParser interface 2010-06-23 23:14:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth tonyg oldest_to_newest 242168 0 eric 2010-06-23 17:13:45 -0700 Start to clean up DocumentParser interface 242171 1 59586 eric 2010-06-23 17:16:12 -0700 Created attachment 59586 Patch 242184 2 59586 abarth 2010-06-23 17:47:00 -0700 Comment on attachment 59586 Patch WebCore/dom/XMLDocumentParser.h:90 + // FIXME: Does this need isExecutingScript() for proper document.open behavior? I don't think document.open exists on XML documents. 242311 3 eric 2010-06-23 23:14:45 -0700 Committed r61736: <http://trac.webkit.org/changeset/61736> 59586 2010-06-23 17:16:12 -0700 2010-06-23 17:47:00 -0700 Patch bug-41114-20100623171611.patch text/plain 7389 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzJmZDc3Y2IxNWZjOTQ5NWE0NGMzZTI1N2ZiMWM5NzY0YzQ0ZTg1Zi4uODZmNjkyMGYwMDE2ZGVi ZjkzMTk5OTUyNjg3YjA4ZmM2YzVmZDgwNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxMC0wNi0yMyAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3RhcnQgdG8gY2xlYW4gdXAgRG9jdW1lbnRQYXJzZXIgaW50 ZXJmYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MTExNAorCisgICAgICAgIFRoZSBmaXJzdCBvZiBtYW55IGNsZWFudXBzIG5lZWRlZCB0byB0aGUg RG9jdW1lbnRQYXJzZXIKKyAgICAgICAgaW50ZXJmYWNlLiAgUmVuYW1lIGV4ZWN1dGluZ1Njcmlw dCgpIHRvIGlzRXhlY3V0aW5nU2NyaXB0KCkKKyAgICAgICAgYW5kIG1ha2UgaXQgcmV0dXJuIGEg Ym9vbCBpbnN0ZWFkIG9mIGFuIGludC4gIEFsc28gYWRkZWQgYQorICAgICAgICBGSVhNRSB0byBY TUxEb2N1bWVudFBhcnNlciBhYm91dCBpbXBsZW1lbnRpbmcgaXQgYW5kIGRpZAorICAgICAgICBz b21lIG1pbm9yIG90aGVyIGNsZWFudXAgdG8gdGhlIFhNTERvY3VtZW50UGFyc2VyIGhlYWRlci4K KworICAgICAgICBObyBmdW5jdGlvbmFsIGNoYW5nZSwgdGh1cyBubyB0ZXN0cy4KKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6b3Blbik6 CisgICAgICAgICogZG9tL0RvY3VtZW50UGFyc2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpEb2N1 bWVudFBhcnNlcjo6aXNFeGVjdXRpbmdTY3JpcHQpOgorICAgICAgICAqIGRvbS9YTUxEb2N1bWVu dFBhcnNlci5oOgorICAgICAgICAoV2ViQ29yZTo6WE1MRG9jdW1lbnRQYXJzZXI6OndlbGxGb3Jt ZWQpOgorICAgICAgICAqIGh0bWwvSFRNTERvY3VtZW50UGFyc2VyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6YXR0ZW1wdFRvRW5kKToKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6ZW5kSWZEZWxheWVkKToKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxEb2N1bWVudFBhcnNlcjo6aXNFeGVjdXRpbmdTY3JpcHQpOgorICAgICAgICAqIGh0bWwv SFRNTERvY3VtZW50UGFyc2VyLmg6CisgICAgICAgICogaHRtbC9MZWdhY3lIVE1MRG9jdW1lbnRQ YXJzZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxlZ2FjeUhUTUxEb2N1bWVudFBhcnNlcjo6aXNF eGVjdXRpbmdTY3JpcHQpOgorCiAyMDEwLTA2LTIzICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CmluZGV4IGMwMTA2Nzg2MDdhNDAwN2E1NDhiMjkwMGQ0NmZhNzNlNjcwMzgwOGIuLjM3YjM1Mzhh MjVmZTQ2NjNkMWFlOTZjNWQ3ZTM1YmQ3MGU0MGU1MjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTE3MTQsNyAr MTcxNCw3IEBAIHZvaWQgRG9jdW1lbnQ6Om9wZW4oRG9jdW1lbnQqIG93bmVyRG9jdW1lbnQpCiAg ICAgfQogCiAgICAgaWYgKG1fZnJhbWUpIHsKLSAgICAgICAgaWYgKG1fZnJhbWUtPmxvYWRlcigp LT5pc0xvYWRpbmdNYWluUmVzb3VyY2UoKSB8fCAocGFyc2VyKCkgJiYgcGFyc2VyKCktPmV4ZWN1 dGluZ1NjcmlwdCgpKSkKKyAgICAgICAgaWYgKG1fZnJhbWUtPmxvYWRlcigpLT5pc0xvYWRpbmdN YWluUmVzb3VyY2UoKSB8fCAocGFyc2VyKCkgJiYgcGFyc2VyKCktPmlzRXhlY3V0aW5nU2NyaXB0 KCkpKQogICAgICAgICAgICAgcmV0dXJuOwogICAgIAogICAgICAgICBpZiAobV9mcmFtZS0+bG9h ZGVyKCktPnN0YXRlKCkgPT0gRnJhbWVTdGF0ZVByb3Zpc2lvbmFsKQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9kb20vRG9jdW1lbnRQYXJzZXIuaCBiL1dlYkNvcmUvZG9tL0RvY3VtZW50UGFyc2VyLmgK aW5kZXggMzVlZWVkMWJmMTAxNzNjNDljODQyOGU3MjcwNmE3Y2Q2MGJiOWZhMy4uMTc1MmE3ZGQx MWY1NGMyMDg3NmQ5NmMyOWEyNjdjMDBkOGIwNjliNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20v RG9jdW1lbnRQYXJzZXIuaAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudFBhcnNlci5oCkBAIC00 MiwxMiArNDIsMTMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2aXJ0dWFsIHZvaWQg ZmluaXNoKCkgPSAwOwogICAgICAgICB2aXJ0dWFsIGJvb2wgZmluaXNoV2FzQ2FsbGVkKCkgPSAw OwogICAgICAgICB2aXJ0dWFsIGJvb2wgaXNXYWl0aW5nRm9yU2NyaXB0cygpIGNvbnN0ID0gMDsK KyAgICAgICAgdmlydHVhbCBib29sIGlzRXhlY3V0aW5nU2NyaXB0KCkgY29uc3QgeyByZXR1cm4g ZmFsc2U7IH0KKwogICAgICAgICB2aXJ0dWFsIHZvaWQgc3RvcFBhcnNpbmcoKSB7IG1fcGFyc2Vy U3RvcHBlZCA9IHRydWU7IH0KICAgICAgICAgLy8gRklYTUU6IHByb2Nlc3NpbmdEYXRhKCkgaXMg b25seSB1c2VkIGJ5IERvY3VtZW50TG9hZGVyOjppc0xvYWRpbmdJbkFQSVNlbnNlCiAgICAgICAg IC8vIGFuZCBpcyB2ZXJ5IHVuY2xlYXIgYXMgdG8gd2hhdCBpdCBhY3R1YWxseSBtZWFucy4gIE9u bHkgTGVnYWN5SFRNTERvY3VtZW50UGFyc2VyCiAgICAgICAgIC8vIGFjdHVhbGx5IGltcGxlbWVu dHMgaXQuCiAgICAgICAgIHZpcnR1YWwgYm9vbCBwcm9jZXNzaW5nRGF0YSgpIGNvbnN0IHsgcmV0 dXJuIGZhbHNlOyB9Ci0gICAgICAgIHZpcnR1YWwgaW50IGV4ZWN1dGluZ1NjcmlwdCgpIGNvbnN0 IHsgcmV0dXJuIDA7IH0KIAogICAgICAgICB2aXJ0dWFsIGJvb2wgd2FudHNSYXdEYXRhKCkgY29u c3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICAgICAgdmlydHVhbCBib29sIHdyaXRlUmF3RGF0YShj b25zdCBjaGFyKiAvKmRhdGEqLywgaW50IC8qbGVuZ3RoKi8pIHsgcmV0dXJuIGZhbHNlOyB9CmRp ZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9YTUxEb2N1bWVudFBhcnNlci5oIGIvV2ViQ29yZS9kb20v WE1MRG9jdW1lbnRQYXJzZXIuaAppbmRleCBhM2UxNjA4NTgyZjRiNGNhMTkwZDlmNGYxMmFlNmZl OWY0ZjllMTNlLi44ZjAxYzAwYjg4MTFlNjYwZWFjY2VlNDg1YWNiMGNkM2I5NDEzNThhIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2RvbS9YTUxEb2N1bWVudFBhcnNlci5oCisrKyBiL1dlYkNvcmUvZG9t L1hNTERvY3VtZW50UGFyc2VyLmgKQEAgLTc4LDEyICs3OCwxNiBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKICAgICAgICAgZW51bSBFcnJvclR5cGUgeyB3YXJuaW5nLCBub25GYXRhbCwgZmF0YWwg fTsKIAotICAgICAgICAvLyBmcm9tIERvY3VtZW50UGFyc2VyCisgICAgICAgIC8vIEZyb20gRG9j dW1lbnRQYXJzZXIKICAgICAgICAgdmlydHVhbCB2b2lkIHdyaXRlKGNvbnN0IFNlZ21lbnRlZFN0 cmluZyYsIGJvb2wgYXBwZW5kRGF0YSk7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBmaW5pc2goKTsK ICAgICAgICAgdmlydHVhbCBib29sIGZpbmlzaFdhc0NhbGxlZCgpOwogICAgICAgICB2aXJ0dWFs IGJvb2wgaXNXYWl0aW5nRm9yU2NyaXB0cygpIGNvbnN0OwogICAgICAgICB2aXJ0dWFsIHZvaWQg c3RvcFBhcnNpbmcoKTsKKyAgICAgICAgdmlydHVhbCBib29sIHdlbGxGb3JtZWQoKSBjb25zdCB7 IHJldHVybiAhbV9zYXdFcnJvcjsgfQorICAgICAgICB2aXJ0dWFsIGludCBsaW5lTnVtYmVyKCkg Y29uc3Q7CisgICAgICAgIHZpcnR1YWwgaW50IGNvbHVtbk51bWJlcigpIGNvbnN0OworICAgICAg ICAvLyBGSVhNRTogRG9lcyB0aGlzIG5lZWQgaXNFeGVjdXRpbmdTY3JpcHQoKSBmb3IgcHJvcGVy IGRvY3VtZW50Lm9wZW4gYmVoYXZpb3I/CiAKICAgICAgICAgdm9pZCBlbmQoKTsKIApAQCAtMTAz LDEzICsxMDcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8vIGZyb20gQ2FjaGVk UmVzb3VyY2VDbGllbnQKICAgICAgICAgdmlydHVhbCB2b2lkIG5vdGlmeUZpbmlzaGVkKENhY2hl ZFJlc291cmNlKiBmaW5pc2hlZE9iaik7CiAKLQotICAgICAgICB2b2lkIGhhbmRsZUVycm9yKEVy cm9yVHlwZSB0eXBlLCBjb25zdCBjaGFyKiBtLCBpbnQgbGluZU51bWJlciwgaW50IGNvbHVtbk51 bWJlcik7Ci0KLSAgICAgICAgdmlydHVhbCBib29sIHdlbGxGb3JtZWQoKSBjb25zdCB7IHJldHVy biAhbV9zYXdFcnJvcjsgfQotCi0gICAgICAgIGludCBsaW5lTnVtYmVyKCkgY29uc3Q7Ci0gICAg ICAgIGludCBjb2x1bW5OdW1iZXIoKSBjb25zdDsKKyAgICAgICAgdm9pZCBoYW5kbGVFcnJvcihF cnJvclR5cGUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UsIGludCBsaW5lTnVtYmVyLCBpbnQgY29sdW1u TnVtYmVyKTsKIAogI2lmIFVTRShRWE1MU1RSRUFNKQogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1dl YkNvcmUvaHRtbC9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxEb2N1 bWVudFBhcnNlci5jcHAKaW5kZXggNjJhMmFhZWUxYTZiM2I1MmIzNTQ1YjI2YWI0ZWI0M2EzY2Jj NWFiNi4uNDE3MmZkY2NmMDlmNTcxYWY2Yjk0NmI0ZDg4ZDBmMWE5MjVhNjNlNSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudFBhcnNlci5jcHAKKysrIGIvV2ViQ29yZS9odG1s L0hUTUxEb2N1bWVudFBhcnNlci5jcHAKQEAgLTI1NCw3ICsyNTQsNyBAQCB2b2lkIEhUTUxEb2N1 bWVudFBhcnNlcjo6YXR0ZW1wdFRvRW5kKCkKICAgICAvLyBmaW5pc2goKSBpbmRpY2F0ZXMgd2Ug d2lsbCBub3QgcmVjZWl2ZSBhbnkgbW9yZSBkYXRhLiBJZiB3ZSBhcmUgd2FpdGluZyBvbgogICAg IC8vIGFuIGV4dGVybmFsIHNjcmlwdCB0byBsb2FkLCB3ZSBjYW4ndCBmaW5pc2ggcGFyc2luZyBx dWl0ZSB5ZXQuCiAKLSAgICBpZiAoaW5Xcml0ZSgpIHx8IGlzV2FpdGluZ0ZvclNjcmlwdHMoKSB8 fCBleGVjdXRpbmdTY3JpcHQoKSB8fCBpc1NjaGVkdWxlZEZvclJlc3VtZSgpKSB7CisgICAgaWYg KGluV3JpdGUoKSB8fCBpc1dhaXRpbmdGb3JTY3JpcHRzKCkgfHwgaW5TY3JpcHRFeGVjdXRpb24o KSB8fCBpc1NjaGVkdWxlZEZvclJlc3VtZSgpKSB7CiAgICAgICAgIG1fZW5kV2FzRGVsYXllZCA9 IHRydWU7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0yNjUsNyArMjY1LDcgQEAgdm9pZCBI VE1MRG9jdW1lbnRQYXJzZXI6OmVuZElmRGVsYXllZCgpCiB7CiAgICAgLy8gV2UgZG9uJ3QgY2hl Y2sgaW5Xcml0ZSgpIGhlcmUgc2luY2UgaW5Xcml0ZSgpIHdpbGwgYmUgdHJ1ZSBpZiB0aGlzIHdh cwogICAgIC8vIGNhbGxlZCBmcm9tIHdyaXRlKCkuCi0gICAgaWYgKCFtX2VuZFdhc0RlbGF5ZWQg fHwgaXNXYWl0aW5nRm9yU2NyaXB0cygpIHx8IGV4ZWN1dGluZ1NjcmlwdCgpIHx8IGlzU2NoZWR1 bGVkRm9yUmVzdW1lKCkpCisgICAgaWYgKCFtX2VuZFdhc0RlbGF5ZWQgfHwgaXNXYWl0aW5nRm9y U2NyaXB0cygpIHx8IGluU2NyaXB0RXhlY3V0aW9uKCkgfHwgaXNTY2hlZHVsZWRGb3JSZXN1bWUo KSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9lbmRXYXNEZWxheWVkID0gZmFsc2U7CkBAIC0y ODYsNyArMjg2LDcgQEAgYm9vbCBIVE1MRG9jdW1lbnRQYXJzZXI6OmZpbmlzaFdhc0NhbGxlZCgp CiB9CiAKIC8vIFRoaXMgZnVuY3Rpb24gaXMgdmlydHVhbCBhbmQganVzdCBmb3IgdGhlIERvY3Vt ZW50UGFyc2VyIGludGVyZmFjZS4KLWludCBIVE1MRG9jdW1lbnRQYXJzZXI6OmV4ZWN1dGluZ1Nj cmlwdCgpIGNvbnN0Citib29sIEhUTUxEb2N1bWVudFBhcnNlcjo6aXNFeGVjdXRpbmdTY3JpcHQo KSBjb25zdAogewogICAgIHJldHVybiBpblNjcmlwdEV4ZWN1dGlvbigpOwogfQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudFBhcnNlci5oIGIvV2ViQ29yZS9odG1sL0hUTUxE b2N1bWVudFBhcnNlci5oCmluZGV4IGRjMGYxMmQwNjRmMDA0OGQ1ZDRjYTRjNjEzZTg4YmNlMjJi YWUwMzIuLmM3NWE3ZmJiZDc3NjI4NTExZDFiYWIzZjNiMmEwNDcwNjQxZDYxYjQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnRQYXJzZXIuaAorKysgYi9XZWJDb3JlL2h0bWwv SFRNTERvY3VtZW50UGFyc2VyLmgKQEAgLTYzLDEwICs2MywxMCBAQCBwdWJsaWM6CiAgICAgdmly dHVhbCB2b2lkIGVuZCgpOwogICAgIHZpcnR1YWwgdm9pZCBmaW5pc2goKTsKICAgICB2aXJ0dWFs IGJvb2wgZmluaXNoV2FzQ2FsbGVkKCk7Ci0gICAgdmlydHVhbCBpbnQgZXhlY3V0aW5nU2NyaXB0 KCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIHByb2Nlc3NpbmdEYXRhKCkgY29uc3Q7CiAgICAg dmlydHVhbCB2b2lkIHN0b3BQYXJzaW5nKCk7CiAgICAgdmlydHVhbCBib29sIGlzV2FpdGluZ0Zv clNjcmlwdHMoKSBjb25zdDsKKyAgICB2aXJ0dWFsIGJvb2wgaXNFeGVjdXRpbmdTY3JpcHQoKSBj b25zdDsKICAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZVNjcmlwdHNXYWl0aW5nRm9yU3R5bGVzaGVl dHMoKTsKICAgICB2aXJ0dWFsIGludCBsaW5lTnVtYmVyKCkgY29uc3Q7CiAgICAgdmlydHVhbCBp bnQgY29sdW1uTnVtYmVyKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvTGVnYWN5 SFRNTERvY3VtZW50UGFyc2VyLmggYi9XZWJDb3JlL2h0bWwvTGVnYWN5SFRNTERvY3VtZW50UGFy c2VyLmgKaW5kZXggNjdjMjUxN2QzYjNlOTNjODYzYzI4NDg4MmYyODcyMzRkYmE0NDVhMC4uNDY4 ZWY3MzNlY2RmZTc5OTlkZTc4YmQwZmM4ZTcyN2I0NmNkNjlhYiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9odG1sL0xlZ2FjeUhUTUxEb2N1bWVudFBhcnNlci5oCisrKyBiL1dlYkNvcmUvaHRtbC9MZWdh Y3lIVE1MRG9jdW1lbnRQYXJzZXIuaApAQCAtMTU1LDcgKzE1NSw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIGJvb2wgaXNXYWl0aW5nRm9yU2NyaXB0cygpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9p ZCBzdG9wUGFyc2luZygpOwogICAgIHZpcnR1YWwgYm9vbCBwcm9jZXNzaW5nRGF0YSgpIGNvbnN0 OwotICAgIHZpcnR1YWwgaW50IGV4ZWN1dGluZ1NjcmlwdCgpIGNvbnN0IHsgcmV0dXJuIG1fZXhl Y3V0aW5nU2NyaXB0OyB9CisgICAgdmlydHVhbCBib29sIGlzRXhlY3V0aW5nU2NyaXB0KCkgY29u c3QgeyByZXR1cm4gISFtX2V4ZWN1dGluZ1NjcmlwdDsgfQogCiAgICAgdmlydHVhbCBpbnQgbGlu ZU51bWJlcigpIGNvbnN0IHsgcmV0dXJuIG1fbGluZU51bWJlcjsgfQogICAgIHZpcnR1YWwgaW50 IGNvbHVtbk51bWJlcigpIGNvbnN0IHsgcmV0dXJuIDE7IH0K