41093 2010-06-23 12:39:25 -0700 fast/text/hyphenate-character.html is failing on the Leopard Commit Bot 2010-08-19 07:38:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth ap darin mitz oldest_to_newest 242021 0 eric 2010-06-23 12:39:25 -0700 fast/text/hyphenate-character.html is failing on the Leopard Commit Bot --- /tmp/layout-test-results/fast/text/hyphenate-character-expected.txt 2010-06-23 12:23:52.000000000 -0700 +++ /tmp/layout-test-results/fast/text/hyphenate-character-actual.txt 2010-06-23 12:23:52.000000000 -0700 @@ -17,18 +17,17 @@ RenderText {#text} at (7,7) size 330x220 text run at (7,7) width 245: "The chief difficulty Alice found" text run at (7,29) width 245: "at first was in managing her" - text run at (7,51) width 245: "flamingo: she succeeded in get" - text run at (7,73) width 208: "ting its body tucked away, " - text run at (215,73) width 37: "com" - text run at (7,95) width 245: "fortably enough, under her arm," - text run at (7,117) width 226: "with its legs hanging down, " - text run at (233,117) width 104: "but generally," - text run at (7,139) width 330: "just as she had got its neck nicely straight" - text run at (7,161) width 41: "ened " - text run at (48,161) width 289: "out, and was going to give the hedge" - text run at (7,183) width 204: "hog a blow with its head, it " - text run at (211,183) width 126: "would twist itself" - text run at (7,205) width 233: "round and look up in her face\x{2026}" + text run at (7,51) width 245: "flamingo: she succeeded in" + text run at (7,73) width 245: "getting its body tucked away," + text run at (7,95) width 245: "comfortably enough, under her" + text run at (7,117) width 307: "arm, with its legs hanging down, " + text run at (314,117) width 23: "but" + text run at (7,139) width 330: "generally, just as she had got its neck nicely" + text run at (7,161) width 95: "straightened " + text run at (102,161) width 235: "out, and was going to give the" + text run at (7,183) width 285: "hedgehog a blow with its head, it " + text run at (292,183) width 45: "would" + text run at (7,205) width 314: "twist itself round and look up in her face\x{2026}" RenderBlock (floating) {DIV} at (356,0) size 344x284 RenderBlock {P} at (0,16) size 344x18 RenderText {#text} at (0,0) size 81x18 @@ -43,18 +42,17 @@ RenderText {#text} at (7,7) size 330x220 text run at (7,7) width 245: "The chief difficulty Alice found" text run at (7,29) width 245: "at first was in managing her" - text run at (7,51) width 245: "flamingo: she succeeded in get" - text run at (7,73) width 208: "ting its body tucked away, " - text run at (215,73) width 37: "com" - text run at (7,95) width 245: "fortably enough, under her arm," - text run at (7,117) width 226: "with its legs hanging down, " - text run at (233,117) width 104: "but generally," - text run at (7,139) width 330: "just as she had got its neck nicely straight" - text run at (7,161) width 41: "ened " - text run at (48,161) width 289: "out, and was going to give the hedge" - text run at (7,183) width 204: "hog a blow with its head, it " - text run at (211,183) width 126: "would twist itself" - text run at (7,205) width 233: "round and look up in her face\x{2026}" + text run at (7,51) width 245: "flamingo: she succeeded in" + text run at (7,73) width 245: "getting its body tucked away," + text run at (7,95) width 245: "comfortably enough, under her" + text run at (7,117) width 307: "arm, with its legs hanging down, " + text run at (314,117) width 23: "but" + text run at (7,139) width 330: "generally, just as she had got its neck nicely" + text run at (7,161) width 95: "straightened " + text run at (102,161) width 235: "out, and was going to give the" + text run at (7,183) width 285: "hedgehog a blow with its head, it " + text run at (292,183) width 45: "would" + text run at (7,205) width 314: "twist itself round and look up in her face\x{2026}" RenderBlock (floating) {DIV} at (4,284) size 344x284 RenderBlock {P} at (0,16) size 344x18 RenderText {#text} at (0,0) size 47x18 .. and more. I suspect that this depends on a special font? 242024 1 eric 2010-06-23 12:42:24 -0700 The bot is Leopard: ProductVersion: 10.5.8 BuildVersion: 9L31a It doesn't have Safari 5 on it yet, but I can add it if that would fix the issue. 242026 2 eric 2010-06-23 12:43:03 -0700 Anyway, we now know why the commit-queue hasn't committed anything in the last 48 hours. :) 242027 3 mitz 2010-06-23 12:45:53 -0700 It appears that hyphenation is not taking place on Leopard. 242031 4 eric 2010-06-23 12:51:49 -0700 I would expect the other Leopard bots to be failing too though, no? 242037 5 mitz 2010-06-23 12:57:40 -0700 (In reply to comment #4) > I would expect the other Leopard bots to be failing too though, no? If they’re not, then my next guess would be that the machine where it’s failing is configured differently. Specifically, hyphenation will not happen unless the topmost language in System Preferences > International (as I think it was called on Leopard) > Language is not English. 242038 6 mitz 2010-06-23 12:58:28 -0700 From the command line, a way to get the language preference is defaults read -g AppleLanguages "en" should be the first element in the array for hyphenation to work. 242043 7 eric 2010-06-23 13:04:07 -0700 I don't see any hyphenate tests listed in either: http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac-leopard/Skipped or http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/Skipped So I suspect the other leopard bots must be running them and passing them. % read -g AppleLanguages 2010-06-23 13:01:08.222 defaults[87738:10b] The domain/default pair of (kCFPreferencesAnyApplication, AppleLanguages) does not exist Looks like we already set AppleLanguages during DRT execution anyway: http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L391 I'm happy to get you any other information you might need from the machine. 242060 8 mitz 2010-06-23 13:45:26 -0700 (In reply to comment #7) > Looks like we already set AppleLanguages during DRT execution anyway: > http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L391 Then I have no idea why it’s failing. Are you able to run a GUI session on that machine? 242061 9 eric 2010-06-23 13:48:46 -0700 Yup. I even have physical access to the machine if needed. Normally I VNC or SSH to it though. 242068 10 eric 2010-06-23 13:59:29 -0700 I'm forcing the machine to do a clean build in case that helps. 242071 11 abarth 2010-06-23 14:03:15 -0700 I've seen similar failures on snow leopard with safari 5 installed 242072 12 mitz 2010-06-23 14:03:41 -0700 > Yup. I even have physical access to the machine if needed. Normally I VNC or SSH to it though. Thing I would try then are: see if hyphenation ever occurs in Safari using a nightly build and specifying "-webkit-hyphens: auto"; see if hyphenation ever occurs in the system, using TextEdit and selecting Enable Hyphenation. 242073 13 eric 2010-06-23 14:04:00 -0700 FYI, the commit-queue is run inside a GUI session (otherwise DRT has kittens). 242075 14 eric 2010-06-23 14:09:06 -0700 On the Commit Bot, over VNC: I pasted "getting" about 1000 times in a TextEdit doc, and it hyphenated when I made the window small enough (I would have expected it to hyphenate at larger window sizes, but it didn't seem to). 242078 15 mitz 2010-06-23 14:13:18 -0700 (In reply to comment #7) > % read -g AppleLanguages > 2010-06-23 13:01:08.222 defaults[87738:10b] > The domain/default pair of (kCFPreferencesAnyApplication, AppleLanguages) does not exist > > Looks like we already set AppleLanguages during DRT execution anyway: > http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L391 Looking more carefully at the WebKit code <http://trac.webkit.org/browser/trunk/WebCore/platform/text/mac/TextBreakIteratorInternalICUMac.mm#L39>, I can see that the default has to be set in the global domain, so what DumpRenderTree does is ineffective here. I bet defaults write -g AppleLanguages -array en will fix it. 242081 16 eric 2010-06-23 14:15:56 -0700 On both my local SL box, as well as on the commit bot, I tested the following example: <body style="-webkit-hyphens: auto;"> getting getting getting getting (repeated 1000 or so times) I used http://builds.nightly.webkit.org/files/trunk/mac/WebKit-SVN-r61670.dmg On my local SL box, hyphenation worked. On the Commit Bot it never hyphenated. So it seems to be a problem specific to webkit, since TextEdit on the Commit Bot was able to hyphenate. 242082 17 mitz 2010-06-23 14:17:46 -0700 Please try setting the default in the global domain. 242083 18 eric 2010-06-23 14:18:48 -0700 (Sorry my previous comment was composed before I read your global domain stuff. Silly bugzilla.) Yup! "defaults write -g AppleLanguages -array en" fixed it on the Commit Bot. Now I guess we just need to fix the DRT/WebKit code to play nice together. 242111 19 ap 2010-06-23 15:12:29 -0700 I don't think that forcing a particular language is a good thing to do in DRT long-term. It's good to test different code paths, even if only some developers can do that. We were getting a lot of good bug reports from different time zones, and I think that the same applies to languages. Also long term, I don't see why English text shouldn't be hyphenated on my machine with primary Russian language. 266547 20 64808 mitz 2010-08-18 22:32:22 -0700 Created attachment 64808 Specify the locale for hyphenation in the test 266558 21 mitz 2010-08-18 22:59:08 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/65652>. 266725 22 eric 2010-08-19 07:38:31 -0700 Thank you mitz! 64808 2010-08-18 22:32:22 -0700 2010-08-18 22:39:45 -0700 Specify the locale for hyphenation in the test 41093_r1.diff text/plain 2377 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY1NjUwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMTggIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmYXN0L3RleHQvaHlwaGVuYXRlLWNoYXJhY3Rlci5odG1sIGlzIGZhaWxpbmcgb24g dGhlIExlb3BhcmQgQ29tbWl0IEJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDEwOTMKKyAgICAgICAgLWFuZCBzb21lIG9mLQorICAgICAgICBmYXN0 L3RleHQvaHlwaGVuKiB0ZXN0cyBoYXZlIGRpZmZlcmVudCByZXN1bHRzIG9uIExlb3BhcmQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMjk2CisKKyAg ICAgICAgKiBmYXN0L3RleHQvaHlwaGVuYXRlLWNoYXJhY3Rlci5odG1sOiBTcGVjaWZ5IHRoZSBo eXBoZW5hdGlvbiBsb2NhbGUsIHdoaWNoIHJlbW92ZXMgdGhlCisgICAgICAgIGRlcGVuZGVuY3kg b24gdXNlciBwcmVmZXJlbmNlcy4KKyAgICAgICAgKiBmYXN0L3RleHQvaHlwaGVucy5odG1sOiBE aXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkOiBEb27igJl0IHNr aXAgdGhlIGFib3ZlIHRlc3RzLgorCiAyMDEwLTA4LTE3ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0 YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L3RleHQvaHlwaGVuYXRlLWNoYXJhY3Rlci5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvdGV4dC9oeXBoZW5hdGUtY2hhcmFjdGVyLmh0bWwJKHJldmlz aW9uIDY1NDg0KQorKysgTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2h5cGhlbmF0ZS1jaGFyYWN0ZXIu aHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDggQEAKIDxzdHlsZT4KKyAgICBodG1sIHsK KyAgICAgICAgLXdlYmtpdC1oeXBoZW5hdGUtbG9jYWxlOiAiZW5fVVMiOworICAgIH0KKwogICAg IC50ZXh0LWJveCB7CiAgICAgICAgIGJvcmRlcjogc29saWQ7CiAgICAgICAgIHBhZGRpbmc6IDRw eDsKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC9oeXBoZW5zLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2h5cGhlbnMuaHRtbAkocmV2aXNpb24gNjU0ODQpCisr KyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvaHlwaGVucy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0x LDQgKzEsOCBAQAogPHN0eWxlPgorICAgIGh0bWwgeworICAgICAgICAtd2Via2l0LWh5cGhlbmF0 ZS1sb2NhbGU6ICJlbl9VUyI7CisgICAgfQorCiAgICAgLnRleHQtYm94IHsKICAgICAgICAgYm9y ZGVyOiBzb2xpZDsKICAgICAgICAgcGFkZGluZzogNHB4OwpJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkCShyZXZpc2lvbiA2NTQ4NCkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTgyLDEwICs4 Miw4IEBAIGZhc3QvY2FudmFzL3dlYmdsL3RleHR1cmUtbnBvdC5odG1sCiAjIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTgwOAogc3ZnL2ZpbHRlcnMvZmlsdGVyLWVt cHR5LWcuc3ZnCiAKLSMgUmVzdWx0cyBkaWZmZXIgYmV0d2VlbiBMZW9wYXJkIGFuZCBTbm93IExl b3BhcmQsIG5lZWRzIGludmVzdGlnYXRpb24uCisjIFJlc3VsdHMgZGVwZW5kIG9uIHVzZXIgZGVm YXVsdHMuCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzI5Ngot ZmFzdC90ZXh0L2h5cGhlbnMuaHRtbAotZmFzdC90ZXh0L2h5cGhlbmF0ZS1jaGFyYWN0ZXIuaHRt bAogZmFzdC90ZXh0L2h5cGhlbmF0ZS1sb2NhbGUuaHRtbAogCiAjIERpc2FibGUgbWVkaWEgdGVz dCB3aGljaCBmYWlscyBvbiB0aGUgTGVvcGFyZCBDb21taXQgQm90Cg==