41083 2010-06-23 11:05:12 -0700 fast/parser/broken-comments-vs-parsing mode no longer tests for what it used to test 2010-06-23 12:13:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap eric oldest_to_newest 241943 0 ap 2010-06-23 11:05:12 -0700 The comment should be treated as a comment, so hiding it inside <title> isn't good. 241957 1 59537 ap 2010-06-23 11:21:00 -0700 Created attachment 59537 proposed fix 242000 2 59537 eric 2010-06-23 11:53:54 -0700 Comment on attachment 59537 proposed fix So the test used to fail to go into quirks mode because of the comment? Are we sure that this placement of the comment will cause the same effect? 242009 3 ap 2010-06-23 12:13:37 -0700 Committed <http://trac.webkit.org/changeset/61704>. > So the test used to fail to go into quirks mode because of the comment? Actually, vice versa - there is no DOCTYPE, so the test shouldn't be in strict mode. Bug 8626 was about strict mode being entered in error. > Are we sure that this placement of the comment will cause the same effect? It was a long time ago, but my recollection about that bug is that yes, the modified test should still cover it. 59537 2010-06-23 11:21:00 -0700 2010-06-23 11:53:54 -0700 proposed fix BrokenComment.txt text/plain 1384 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYxNjk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMjMgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMDgz CisgICAgICAgIGZhc3QvcGFyc2VyL2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5nIG1vZGUgbm8g bGluZ2VyIHRlc3RzIGZvciB3aGF0IGl0IHVzZWQgdG8gdGVzdAorCisgICAgICAgICogZmFzdC9w YXJzZXIvYnJva2VuLWNvbW1lbnRzLXZzLXBhcnNpbmctbW9kZS5odG1sOiBNb3ZlZCBicm9rZW4g Y29tbWVudCB0byBhIHBsYWNlIHdoZXJlCisgICAgICAgIGl0IGRvZXNuJ3QgYWZmZWN0IG91dHB1 dC4KKwogMjAxMC0wNi0yMyAgSnVzdGluIFNjaHVoICA8anNjaHVoQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjE2OTUuCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L3BhcnNlci9icm9rZW4tY29tbWVudHMtdnMtcGFyc2luZy1tb2RlLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvYnJva2VuLWNvbW1lbnRzLXZzLXBhcnNp bmctbW9kZS5odG1sCShyZXZpc2lvbiA2MTY5OCkKKysrIExheW91dFRlc3RzL2Zhc3QvcGFyc2Vy L2Jyb2tlbi1jb21tZW50cy12cy1wYXJzaW5nLW1vZGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MSwxMyArMSw5IEBACiA8aHRtbD4KLTxoZWFkPgotPHRpdGxlPgotPCEtLSBBIGJyb2tlbiBjb21t ZW50IC0+Ci08L3RpdGxlPgotPC9oZWFkPgogPGJvZHk+CiA8cD48YSBocmVmPSJodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYyNiI+YnVnIDg2MjY8L2E+OiAKIFN0cmlj dCBtb2RlIGVycm9uZW91c2x5IHRyaWdnZXJlZCBieSBhIGJyb2tlbiBjb21tZW50LjwvcD4KIAog PHAgc3R5bGU9ImNvbG9yOjAwZmYwMCI+VGhpcyB0ZXh0IHNob3VsZCBiZSBncmVlbiwgbm90IGJs YWNrIChDU1MgY29sb3IgdmFsdWVzIG5vdCBiZWdpbm5pbmcgd2l0aCAnIycgYXJlIE9LIGluIHF1 aXJrcyBtb2RlKS48L3A+Cis8IS0tIEEgYnJva2VuIGNvbW1lbnQgLT48c3Bhbj48L3NwYW4+CiA8 L2JvZHk+CiA8L2h0bWw+Cg==