41079 2010-06-23 10:51:48 -0700 [Qt] Qt's DumpRenderTree formats SVG rectangles differently from other ports for no good reason 2011-04-18 10:39:23 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 jamesr webkit-unassigned benjamin eric kling krit ossy zimmermann oldest_to_newest 241932 0 jamesr 2010-06-23 10:51:48 -0700 Diff from a recent patch: --- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/repaint/svg-layout-root-style-attr-update-expected.txt 2010-06-23 10:01:08.455453400 -0700 +++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/repaint/svg-layout-root-style-attr-update-actual.txt 2010-06-23 10:01:08.455453400 -0700 @@ -11,5 +11,5 @@ RenderBlock (positioned) {DIV} at (0,0) size 500x500 layer at (8,0) size 500x500 RenderSVGRoot {svg} at (8,0) size 500x500 - RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#FF0000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 Z"] - RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#008000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 Z"] + RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#FF0000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 L250.00,10.00"] + RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#008000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 L250.00,10.00"] See http://trac.webkit.org/changeset/61696. Every other port formats the rectangle the same way except Qt. From a spot check of LayoutTests/platform/qt this appears to be causing a lot of diffs. 241995 1 krit 2010-06-23 11:48:17 -0700 (In reply to comment #0) > Diff from a recent patch: > > --- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/repaint/svg-layout-root-style-attr-update-expected.txt 2010-06-23 10:01:08.455453400 -0700 > +++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/repaint/svg-layout-root-style-attr-update-actual.txt 2010-06-23 10:01:08.455453400 -0700 > @@ -11,5 +11,5 @@ > RenderBlock (positioned) {DIV} at (0,0) size 500x500 > layer at (8,0) size 500x500 > RenderSVGRoot {svg} at (8,0) size 500x500 > - RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#FF0000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 Z"] > - RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#008000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 Z"] > + RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#FF0000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 L250.00,10.00"] > + RenderPath {rect} at (258,10) size 250x250 [fill={[type=SOLID] [color=#008000]}] [data="M250.00,10.00 L500.00,10.00 L500.00,260.00 L250.00,260.00 L250.00,10.00"] > > See http://trac.webkit.org/changeset/61696. Every other port formats the rectangle the same way except Qt. From a spot check of LayoutTests/platform/qt this appears to be causing a lot of diffs. This is caused by Qt itself. Qt closes paths automatically if a path crosses itself. Thats why DRT results will never match the results of other ports. We already have bug reports about the different results, the Qt guys told me, that they won't change this behavior. So I think we can close this bug, or if this test is broken, upload a new baseline for Qt. 241998 2 jamesr 2010-06-23 11:50:51 -0700 I've added a new baseline. That's quite unfortunate, are you sure you can't normalize this in Qt's DRT? 249006 3 zimmermann 2010-07-09 07:28:51 -0700 Changed component to SVG, so it shows up in my all-svg-bugs search. 387847 4 kling 2011-04-18 10:39:23 -0700 I fixed this with bug 46051 :)