41076 2010-06-23 09:47:29 -0700 Web Inspector: live edit doesn't work when resource tracking is off 2010-06-24 01:52:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 241893 0 yurys 2010-06-23 09:47:29 -0700 Live edit doesn't work when resource tracking is off. 241896 1 59522 yurys 2010-06-23 09:52:12 -0700 Created attachment 59522 Patch 241901 2 59522 joepeck 2010-06-23 09:57:56 -0700 Comment on attachment 59522 Patch > +++ b/WebCore/inspector/front-end/ScriptView.js= > + _sourceIDForLine: function(line) { Style: Opening brace should be on the next line. > // The follow methods are pulled from SourceView, since they are Could you also change this to "The following methods" as well. Since its in view =). 241907 3 59523 yurys 2010-06-23 10:02:58 -0700 Created attachment 59523 Patch 241908 4 yurys 2010-06-23 10:03:30 -0700 (In reply to comment #2) > (From update of attachment 59522 [details]) > > +++ b/WebCore/inspector/front-end/ScriptView.js= > > + _sourceIDForLine: function(line) { > > Style: Opening brace should be on the next line. > Done. > > > // The follow methods are pulled from SourceView, since they are > > Could you also change this to "The following methods" as well. > Since its in view =). Done. 242377 5 59523 yurys 2010-06-24 01:52:49 -0700 Comment on attachment 59523 Patch Clearing flags on attachment: 59523 Committed r61747: <http://trac.webkit.org/changeset/61747> 242378 6 yurys 2010-06-24 01:52:59 -0700 All reviewed patches have been landed. Closing bug. 59522 2010-06-23 09:52:12 -0700 2010-06-23 10:02:52 -0700 Patch bug-41076-20100623205209.patch text/plain 1466 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGI4NDk3YjdhNjhmZjIxZjIxZjEzYTQ1MmVkNTY5MTAzZDQ1ZWYwYS4uNWZjOTk0MzJmZGJjNGZh OWQ3NDRmNjRkZDQyOGE3NWQ4OWI2YzNjMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMC0wNi0yMyAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBsaXZlIGVkaXQgZG9l c24ndCB3b3JrIHdoZW4gcmVzb3VyY2UgdHJhY2tpbmcgaXMgb2ZmCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTA3NgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9TY3JpcHRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlw dFZpZXcucHJvdG90eXBlLl9zb3VyY2VJREZvckxpbmUpOiBpbXBsZW1lbnQgdGhpcyBtZXRob2Qg Zm9yIFNjcmlwdFZpZXcsCisgICAgICAgIGl0J3MgbmVlZGVkIGZvciBlZGl0TGluZSB0byB3b3Jr LgorCisyMDEwLTA2LTIzICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogSW5zcGVjdG9yQ29udHJvbGxlciBzaG91bGQgYmUgYWRkZWQgb25seSBvbmNlIGFzIFNj cmlwdERlYnVnTGlzdGVuZXIgdG8KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9TY3JpcHRWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdFZp ZXcuanMKaW5kZXggZmIwYmI0YjJiMmRlMTc5OWVlMzI2MGFkNzMzOGEzMzIzMWRkMmFmMC4uM2Yw NzA0ODYxNzIxOWYzN2E3YWUxNTUyMmFmNGMwNTMxMWRiYzNkMyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdFZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NjcmlwdFZpZXcuanMKQEAgLTEwNSw2ICsxMDUsMTAgQEAgV2ViSW5zcGVj dG9yLlNjcmlwdFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnNvdXJjZUZyYW1lLnVw ZGF0ZUNvbnRlbnQodGhpcy5fcHJlcGVuZFdoaXRlc3BhY2UobmV3Qm9keSkpOwogICAgIH0sCiAK KyAgICBfc291cmNlSURGb3JMaW5lOiBmdW5jdGlvbihsaW5lKSB7CisgICAgICAgIHJldHVybiB0 aGlzLnNjcmlwdC5zb3VyY2VJRDsKKyAgICB9LAorCiAgICAgLy8gVGhlIGZvbGxvdyBtZXRob2Rz IGFyZSBwdWxsZWQgZnJvbSBTb3VyY2VWaWV3LCBzaW5jZSB0aGV5IGFyZQogICAgIC8vIGdlbmVy aWMgYW5kIHdvcmsgd2l0aCBTY3JpcHRWaWV3IGp1c3QgZmluZS4KIAo= 59523 2010-06-23 10:02:58 -0700 2010-06-24 01:52:49 -0700 Patch bug-41076-20100623210256.patch text/plain 1595 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGI4NDk3YjdhNjhmZjIxZjIxZjEzYTQ1MmVkNTY5MTAzZDQ1ZWYwYS4uNWZjOTk0MzJmZGJjNGZh OWQ3NDRmNjRkZDQyOGE3NWQ4OWI2YzNjMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMC0wNi0yMyAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBsaXZlIGVkaXQgZG9l c24ndCB3b3JrIHdoZW4gcmVzb3VyY2UgdHJhY2tpbmcgaXMgb2ZmCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTA3NgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9TY3JpcHRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlw dFZpZXcucHJvdG90eXBlLl9zb3VyY2VJREZvckxpbmUpOiBpbXBsZW1lbnQgdGhpcyBtZXRob2Qg Zm9yIFNjcmlwdFZpZXcsCisgICAgICAgIGl0J3MgbmVlZGVkIGZvciBlZGl0TGluZSB0byB3b3Jr LgorCisyMDEwLTA2LTIzICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogSW5zcGVjdG9yQ29udHJvbGxlciBzaG91bGQgYmUgYWRkZWQgb25seSBvbmNlIGFzIFNj cmlwdERlYnVnTGlzdGVuZXIgdG8KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9TY3JpcHRWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdFZp ZXcuanMKaW5kZXggZmIwYmI0YjJiMmRlMTc5OWVlMzI2MGFkNzMzOGEzMzIzMWRkMmFmMC4uMTg4 M2ZiM2RiOWIxZTAzZjcxNDFiOTlmNzQwMzEwZDBiYzgxZjMwYyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdFZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NjcmlwdFZpZXcuanMKQEAgLTEwNSw3ICsxMDUsMTIgQEAgV2ViSW5zcGVj dG9yLlNjcmlwdFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnNvdXJjZUZyYW1lLnVw ZGF0ZUNvbnRlbnQodGhpcy5fcHJlcGVuZFdoaXRlc3BhY2UobmV3Qm9keSkpOwogICAgIH0sCiAK LSAgICAvLyBUaGUgZm9sbG93IG1ldGhvZHMgYXJlIHB1bGxlZCBmcm9tIFNvdXJjZVZpZXcsIHNp bmNlIHRoZXkgYXJlCisgICAgX3NvdXJjZUlERm9yTGluZTogZnVuY3Rpb24obGluZSkKKyAgICB7 CisgICAgICAgIHJldHVybiB0aGlzLnNjcmlwdC5zb3VyY2VJRDsKKyAgICB9LAorCisgICAgLy8g VGhlIGZvbGxvd2luZyBtZXRob2RzIGFyZSBwdWxsZWQgZnJvbSBTb3VyY2VWaWV3LCBzaW5jZSB0 aGV5IGFyZQogICAgIC8vIGdlbmVyaWMgYW5kIHdvcmsgd2l0aCBTY3JpcHRWaWV3IGp1c3QgZmlu ZS4KIAogICAgIGhpZGU6IFdlYkluc3BlY3Rvci5Tb3VyY2VWaWV3LnByb3RvdHlwZS5oaWRlLAo=