41070 2010-06-23 07:20:34 -0700 Web Inspector: InspectorController should be added only once as ScriptDebugListener 2010-06-23 09:04:55 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys abarth bweinstein eric joepeck keishi pfeldman pmuellr podivilov rik timothy webkit.review.bot yurys oldest_to_newest 241842 0 yurys 2010-06-23 07:20:34 -0700 InspectorController should be added only once as ScriptDebugListener to ScriptDebugServer. Now its added twice if debugger is always enebled: first time when InspectorController::connectFrontend is invoked and second time when ScriptsPanel is shown and InspectorController::enableDebuggerFromFrontend is called second time from there. 241844 1 59512 yurys 2010-06-23 07:30:36 -0700 Created attachment 59512 Patch 241861 2 59512 yurys 2010-06-23 08:34:31 -0700 Comment on attachment 59512 Patch Clearing flags on attachment: 59512 Committed r61688: <http://trac.webkit.org/changeset/61688> 241862 3 yurys 2010-06-23 08:34:41 -0700 All reviewed patches have been landed. Closing bug. 241873 4 webkit.review.bot 2010-06-23 09:04:55 -0700 http://trac.webkit.org/changeset/61688 might have broken GTK Linux 64-bit Debug 59512 2010-06-23 07:30:36 -0700 2010-06-23 08:34:31 -0700 Patch bug-41070-20100623183034.patch text/plain 3535 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTlhNGJkMDg5ZjM0N2FiZWQ3YTMyOGMwM2U1Yjg4N2U4ZGY5OTkyZi4uMzVhNzdlMWJjNjdlNTEz ZDc2YWUxNjBiYTZlZWExZDdhZGI4MDcyNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNi0yMyAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3JDb250 cm9sbGVyIHNob3VsZCBiZSBhZGRlZCBvbmx5IG9uY2UgYXMgU2NyaXB0RGVidWdMaXN0ZW5lciB0 bworICAgICAgICBTY3JpcHREZWJ1Z1NlcnZlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMDcwCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVy Ojpjb25uZWN0RnJvbnRlbmQpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxl cjo6ZGlzY29ubmVjdEZyb250ZW5kKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRy b2xsZXI6OmVuYWJsZURlYnVnZ2VyRnJvbUZyb250ZW5kKToKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRz UGFuZWwpOiBkb24ndCBjYWxsIEluc3BlY3RvckJhY2tlbmQuZW5hYmxlRGVidWdnZXIgaWYgZGVi dWdnZXIgaXMgYWx3YXlzIGVuYWJsZWQsCisgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIgd2ls bCBkbyB0aGlzIG9uIGl0cyBzaWRlIHdoZW4gdGhlIGZyb250IGVuZCBpcyBjb25uZWN0ZWQuCisK IDIwMTAtMDYtMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLiAgY2xlYW4taGVhZGVyLWd1YXJkcyB0aGF0IHdlcmUgbWFkZSBkaXJ0eSBieSBy ZWNlbnQKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIu Y3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXggNWVh YzkzNjBmNDgxMjYzNjA5OTMzYmYyMzUzNzlmN2JhODViYWYzYi4uNDliM2E1ZWM5ZDI1YTg3M2I2 MDVlZDU2NzMyMGI2YWY4OWI5ZTJiZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29u dHJvbGxlci5jcHAKQEAgLTQ5Miw3ICs0OTIsNyBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6 OmNvbm5lY3RGcm9udGVuZChjb25zdCBTY3JpcHRPYmplY3QmIHdlYkluc3BlY3RvcikKICAgICAg ICAgZW5hYmxlRGVidWdnZXJGcm9tRnJvbnRlbmQoZmFsc2UpOwogICAgIH0gZWxzZSB7CiAgICAg ICAgIFN0cmluZyBkZWJ1Z2dlckVuYWJsZWQgPSBzZXR0aW5nKGRlYnVnZ2VyRW5hYmxlZFNldHRp bmdOYW1lKTsKLSAgICAgICAgaWYgKGRlYnVnZ2VyRW5hYmxlZCA9PSAidHJ1ZSIpCisgICAgICAg IGlmIChkZWJ1Z2dlckVuYWJsZWQgPT0gInRydWUiIHx8IG1fYXR0YWNoRGVidWdnZXJXaGVuU2hv d24pCiAgICAgICAgICAgICBlbmFibGVEZWJ1Z2dlcigpOwogICAgICAgICBTdHJpbmcgcHJvZmls ZXJFbmFibGVkID0gc2V0dGluZyhwcm9maWxlckVuYWJsZWRTZXR0aW5nTmFtZSk7CiAgICAgICAg IGlmIChwcm9maWxlckVuYWJsZWQgPT0gInRydWUiKQpAQCAtNTA3LDEwICs1MDcsNiBAQCB2b2lk IEluc3BlY3RvckNvbnRyb2xsZXI6OmNvbm5lY3RGcm9udGVuZChjb25zdCBTY3JpcHRPYmplY3Qm IHdlYkluc3BlY3RvcikKIAogICAgIGlmIChtX25vZGVUb0ZvY3VzKQogICAgICAgICBmb2N1c05v ZGUoKTsKLSNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKLSAgICBpZiAobV9hdHRhY2hE ZWJ1Z2dlcldoZW5TaG93bikKLSAgICAgICAgZW5hYmxlRGVidWdnZXIoKTsKLSNlbmRpZgogICAg IHNob3dQYW5lbChtX3Nob3dBZnRlclZpc2libGUpOwogfQogCkBAIC01NjcsOCArNTYzLDcgQEAg dm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpkaXNjb25uZWN0RnJvbnRlbmQoKQogICAgIC8vIG9w ZW5pbmcuCiAgICAgYm9vbCBkZWJ1Z2dlcldhc0VuYWJsZWQgPSBtX2RlYnVnZ2VyRW5hYmxlZDsK ICAgICBkaXNhYmxlRGVidWdnZXIoKTsKLSAgICBpZiAoZGVidWdnZXJXYXNFbmFibGVkKQotICAg ICAgICBtX2F0dGFjaERlYnVnZ2VyV2hlblNob3duID0gdHJ1ZTsKKyAgICBtX2F0dGFjaERlYnVn Z2VyV2hlblNob3duID0gZGVidWdnZXJXYXNFbmFibGVkOwogI2VuZGlmCiAgICAgc2V0U2VhcmNo aW5nRm9yTm9kZShmYWxzZSk7CiAgICAgdW5iaW5kQWxsUmVzb3VyY2VzKCk7CkBAIC0xNjQ3LDYg KzE2NDIsNyBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnRha2VIZWFwU25hcHNob3QoKQog I2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQogdm9pZCBJbnNwZWN0b3JDb250cm9sbGVy OjplbmFibGVEZWJ1Z2dlckZyb21Gcm9udGVuZChib29sIGFsd2F5cykKIHsKKyAgICBBU1NFUlQo IW1fZGVidWdnZXJFbmFibGVkKTsKICAgICBpZiAoYWx3YXlzKQogICAgICAgICBzZXRTZXR0aW5n KGRlYnVnZ2VyRW5hYmxlZFNldHRpbmdOYW1lLCAidHJ1ZSIpOwogCmRpZmYgLS1naXQgYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCA0NTA0ZDU3NTEyOTBlNTJhOGQ2ZmQz NzY3MzRmMGEwZGIyMzAzYjkwLi5jMjNkYjE0MWQ1OTIwN2NlZjk5MDQ0NDhkNDZiNTE3NjA0YjY5 OWJlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVs LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAg LTE2OSw4ICsxNjksNiBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsID0gZnVuY3Rpb24oKQog ICAgIHRoaXMuX3JlZ2lzdGVyU2hvcnRjdXRzKCk7CiAKICAgICB0aGlzLl9kZWJ1Z2dlckVuYWJs ZWQgPSBQcmVmZXJlbmNlcy5kZWJ1Z2dlckFsd2F5c0VuYWJsZWQ7Ci0gICAgaWYgKFByZWZlcmVu Y2VzLmRlYnVnZ2VyQWx3YXlzRW5hYmxlZCkKLSAgICAgICAgdGhpcy5fYXR0YWNoRGVidWdnZXJX aGVuU2hvd24gPSB0cnVlOwogCiAgICAgV2ViSW5zcGVjdG9yLmJyZWFrcG9pbnRNYW5hZ2VyLmFk ZEV2ZW50TGlzdGVuZXIoImJyZWFrcG9pbnQtYWRkZWQiLCB0aGlzLl9icmVha3BvaW50QWRkZWQs IHRoaXMpOwogICAgIFdlYkluc3BlY3Rvci5icmVha3BvaW50TWFuYWdlci5hZGRFdmVudExpc3Rl bmVyKCJicmVha3BvaW50LXJlbW92ZWQiLCB0aGlzLl9icmVha3BvaW50UmVtb3ZlZCwgdGhpcyk7 Cg==