41065 2010-06-23 06:51:22 -0700 [Qt] tst_QWebFrame::callQtInvokable() fails 2010-07-29 07:58:42 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged, Regression P1 Normal --- 38654 1 jedrzej.nowacki webkit-qt-unassigned hausmann kling laszlo.gombos robert oldest_to_newest 241827 0 jedrzej.nowacki 2010-06-23 06:51:22 -0700 The autotest fails on my computer. Checked against git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61683 268f45cc-cd09-0410-ab3c-d52691b4dbfc FAIL! : tst_QWebFrame::callQtInvokable() Compared values are not the same Actual (vmap.keys().size()): 0 Expected (2): 2 Loc: [/home/nierob/dev/WebKit-script/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1275)] 253046 1 kling 2010-07-18 20:27:15 -0700 Regression caused by <http://trac.webkit.org/changeset/61478> (the change to WebCore/bridge/qt/qt_runtime.cpp) I don't see why getPropertyNames() would crash in that scenario, and cannot reproduce with the two mentioned tests (world-reuse.html and didClearWindowObject.html) 253047 2 61925 kling 2010-07-18 20:30:59 -0700 Created attachment 61925 Proposed patch Proposed partial revert of <http://trac.webkit.org/changeset/61478> 253107 3 robert 2010-07-19 00:48:26 -0700 (In reply to comment #2) > Created an attachment (id=61925) [details] > Proposed patch > > Proposed partial revert of <http://trac.webkit.org/changeset/61478> Note to self: make sure I pass the unit tests in future too. If you can't recreate that's fair enough - if I can still recreate when you revert I'll create a new bug for it. The two tests in question are already skipped. 255731 4 61925 kling 2010-07-24 11:48:50 -0700 Comment on attachment 61925 Proposed patch Clearing flags on attachment: 61925 Committed r64011: <http://trac.webkit.org/changeset/64011> 255732 5 kling 2010-07-24 11:49:01 -0700 All reviewed patches have been landed. Closing bug. 257674 6 hausmann 2010-07-29 07:58:00 -0700 Revision r64011 cherry-picked into qtwebkit-2.1 with commit f1ec6bfb720b632660b49880cc088084bb15175c 61925 2010-07-18 20:30:59 -0700 2010-07-24 11:48:50 -0700 Proposed patch bug-41065.diff text/plain 1494 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWQ5ZTYyNC4uNjAzZDU3MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0xOCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gdHN0X1FXZWJGcmFtZTo6Y2FsbFF0SW52b2thYmxl KCkgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQxMDY1CisKKyAgICAgICAgQ29udmVydGluZyBKUyBvYmplY3RzIHRvIFFWYXJpYW50TWFwcyB3 YXMgYnJva2VuLgorICAgICAgICBUaGlzIGlzIGEgcGFydGlhbCByZXZlcnQgb2YgPGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzYxNDc4PgorCisgICAgICAgICogYnJpZGdlL3F0L3F0 X3J1bnRpbWUuY3BwOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6Y29udmVydFZhbHVlVG9RVmFy aWFudCk6IFJlbW92ZSBlcnJvbmVvdXMgY3Jhc2ggZ3VhcmQKKyAgICAgICAgYXJvdW5kIEpTT2Jq ZWN0OjpnZXRQcm9wZXJ0eU5hbWVzKCkKKwogMjAxMC0wNy0xOCAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcCBiL1dlYkNvcmUvYnJp ZGdlL3F0L3F0X3J1bnRpbWUuY3BwCmluZGV4IDc3YTY3MTYuLjhjYmQyODIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwCisrKyBiL1dlYkNvcmUvYnJpZGdlL3F0 L3F0X3J1bnRpbWUuY3BwCkBAIC0zMzgsOCArMzM4LDcgQEAgUVZhcmlhbnQgY29udmVydFZhbHVl VG9RVmFyaWFudChFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUsIFFNZXRhVHlwZTo6VHlw ZQogICAgICAgICAgICAgaWYgKHR5cGUgPT0gT2JqZWN0IHx8IHR5cGUgPT0gQXJyYXkgfHwgdHlw ZSA9PSBSVEFycmF5KSB7CiAgICAgICAgICAgICAgICAgLy8gRW51bWVyYXRlIHRoZSBjb250ZW50 cyBvZiB0aGUgb2JqZWN0CiAgICAgICAgICAgICAgICAgUHJvcGVydHlOYW1lQXJyYXkgcHJvcGVy dGllcyhleGVjKTsKLSAgICAgICAgICAgICAgICBpZiAocHJvcGVydGllcy5zaXplKCkgPiAwKQot ICAgICAgICAgICAgICAgICAgICBvYmplY3QtPmdldFByb3BlcnR5TmFtZXMoZXhlYywgcHJvcGVy dGllcyk7CisgICAgICAgICAgICAgICAgb2JqZWN0LT5nZXRQcm9wZXJ0eU5hbWVzKGV4ZWMsIHBy b3BlcnRpZXMpOwogICAgICAgICAgICAgICAgIFByb3BlcnR5TmFtZUFycmF5Ojpjb25zdF9pdGVy YXRvciBpdCA9IHByb3BlcnRpZXMuYmVnaW4oKTsKIAogICAgICAgICAgICAgICAgIFFWYXJpYW50 TWFwIHJlc3VsdDsK