41056 2010-06-23 03:00:00 -0700 [chromium] Make page format data methods accessible from Chromium 2010-06-23 03:59:04 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yuzo yuzo abarth eric hamaji hayato webkit.review.bot oldest_to_newest 241781 0 yuzo 2010-06-23 03:00:00 -0700 Page format data methods for CSS3 Paged Media were added by https://bugs.webkit.org/show_bug.cgi?id=37538 Make them accessible from Chromium by adding methods to WebFrameImpl. 241783 1 59498 yuzo 2010-06-23 03:07:18 -0700 Created attachment 59498 Make page format data methods accessible from Chromium 241786 2 59498 hamaji 2010-06-23 03:16:56 -0700 Comment on attachment 59498 Make page format data methods accessible from Chromium Looks good, except for a nitpick in your comment. WebKit/chromium/public/WebFrame.h:411 + // Returns the page area rectangle in pixels, assuming 96 dpi. I'd say pixels per inch instead of DPI. DPI can be a confusing as points-per-inch is different from pixels-per-inch. 241788 3 59499 yuzo 2010-06-23 03:25:58 -0700 Created attachment 59499 Addressed comment. 241789 4 59499 hamaji 2010-06-23 03:26:36 -0700 Comment on attachment 59499 Addressed comment. Looks good. 241790 5 yuzo 2010-06-23 03:29:54 -0700 Committed r61680: <http://trac.webkit.org/changeset/61680> 241792 6 webkit.review.bot 2010-06-23 03:59:04 -0700 http://trac.webkit.org/changeset/61680 might have broken GTK Linux 64-bit Debug 59498 2010-06-23 03:07:18 -0700 2010-06-23 03:25:53 -0700 Make page format data methods accessible from Chromium bug-41056-20100623030716.patch text/plain 3401 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJmNWRlZjUwNTM3YjJkMjYwMmQ0OTk4NTUwZmNkZmNmZTJiM2IxYzEu LjA1NWY3MjkwYTRlMmYzYmE3NTkwMmViZTVmOTUzYjgxYjIxNDNiMDYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEwLTA2LTIzICBZdXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN YWtlIHBhZ2UgZm9ybWF0IGRhdGEgbWV0aG9kcyBhY2Nlc3NpYmxlIGZyb20gQ2hyb21pdW0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMDU2CisKKyAg ICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjppc1BhZ2VCb3hWaXNpYmxlKToKKyAg ICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpwYWdlQXJlYVJlY3RJblBpeGVscyk6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6cHJlZmVycmVkUGFnZVNpemVJblBpeGVscyk6Cisg ICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5oOgorCiAyMDEwLTA2LTIyICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRp ZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmggYi9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkZyYW1lLmgKaW5kZXggYjg5MGEwZjRiZjQ5ODY3YzhmYTAwYmQxZjFm ZGQ5Y2E4YzAyNWM1My4uZTNhM2MxYzEyYjdlNmRjMzA1ZTI0NWI2NzA2Y2QyNDAyOWExY2RhYSAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBiL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtNDAzLDYgKzQwMywxNyBAQCBwdWJsaWM6 CiAgICAgLy8gUmVmb3JtYXRzIHRoZSBXZWJGcmFtZSBmb3Igc2NyZWVuIGRpc3BsYXkuCiAgICAg dmlydHVhbCB2b2lkIHByaW50RW5kKCkgPSAwOwogCisgICAgLy8gQ1NTMyBQYWdlZCBNZWRpYSAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisKKyAg ICAvLyBSZXR1cm5zIHRydWUgaWYgcGFnZSBib3ggKG1hcmdpbiBib3hlcyBhbmQgcGFnZSBib3Jk ZXJzKSBpcyB2aXNpYmxlLgorICAgIHZpcnR1YWwgYm9vbCBpc1BhZ2VCb3hWaXNpYmxlKGludCBw YWdlSW5kZXgpID0gMDsKKworICAgIC8vIFJldHVybnMgdGhlIHBhZ2UgYXJlYSByZWN0YW5nbGUg aW4gcGl4ZWxzLCBhc3N1bWluZyA5NiBkcGkuCisgICAgdmlydHVhbCBXZWJSZWN0IHBhZ2VBcmVh UmVjdEluUGl4ZWxzKGludCBwYWdlSW5kZXgpID0gMDsKKworICAgIC8vIFJldHVybnMgdGhlIHBy ZWZlcnJlZCBwYWdlIHNpemUgaW4gcGl4ZWxzLCBhc3N1bWluZyA5NiBkcGkuCisgICAgdmlydHVh bCBXZWJTaXplIHByZWZlcnJlZFBhZ2VTaXplSW5QaXhlbHMoaW50IHBhZ2VJbmRleCkgPSAwOwor CiAKICAgICAvLyBGaW5kLWluLXBhZ2UgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3Bw CmluZGV4IDBhZmJjODA2MTIyNWFiYTllNTU1YTJiZjYyODc5MmZjZDRhMjNlMzAuLjNmOTM2MGM4 MjBjY2M0MTQ0NzQ2YzFjODYyM2Q5ZjYxYTY4ZDlkMWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZy YW1lSW1wbC5jcHAKQEAgLTEyNzksNiArMTI3OSwyMSBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6cHJp bnRFbmQoKQogICAgIG1fcHJpbnRDb250ZXh0LmNsZWFyKCk7CiB9CiAKK2Jvb2wgV2ViRnJhbWVJ bXBsOjppc1BhZ2VCb3hWaXNpYmxlKGludCBwYWdlSW5kZXgpCit7CisgICAgcmV0dXJuIGZyYW1l KCktPmRvY3VtZW50KCktPmlzUGFnZUJveFZpc2libGUocGFnZUluZGV4KTsKK30KKworV2ViUmVj dCBXZWJGcmFtZUltcGw6OnBhZ2VBcmVhUmVjdEluUGl4ZWxzKGludCBwYWdlSW5kZXgpCit7Cisg ICAgcmV0dXJuIGZyYW1lKCktPmRvY3VtZW50KCktPnBhZ2VBcmVhUmVjdEluUGl4ZWxzKHBhZ2VJ bmRleCk7Cit9CisKK1dlYlNpemUgV2ViRnJhbWVJbXBsOjpwcmVmZXJyZWRQYWdlU2l6ZUluUGl4 ZWxzKGludCBwYWdlSW5kZXgpCit7CisgICAgcmV0dXJuIGZyYW1lKCktPmRvY3VtZW50KCktPnBy ZWZlcnJlZFBhZ2VTaXplSW5QaXhlbHMocGFnZUluZGV4KTsKK30KKwogYm9vbCBXZWJGcmFtZUlt cGw6OmZpbmQoaW50IGlkZW50aWZpZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBX ZWJTdHJpbmcmIHNlYXJjaFRleHQsCiAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBXZWJG aW5kT3B0aW9ucyYgb3B0aW9ucywKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi RnJhbWVJbXBsLmggYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCmluZGV4IGU2 NTZiMzc0MTRmMTlkMmNjMzU3MDRlNDRkZDFhZWFlYjNmMjc0YzAuLmMxNGFkOWI3MmM5MmMxMzU3 NTI3YjdlMTMyNDk4MjY5Yzc2M2M1MTcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViRnJhbWVJbXBsLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaApA QCAtMTQ5LDYgKzE0OSw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGZsb2F0IHByaW50UGFnZShp bnQgcGFnZVRvUHJpbnQsIFdlYkNhbnZhcyopOwogICAgIHZpcnR1YWwgZmxvYXQgZ2V0UHJpbnRQ YWdlU2hyaW5rKGludCBwYWdlKTsKICAgICB2aXJ0dWFsIHZvaWQgcHJpbnRFbmQoKTsKKyAgICB2 aXJ0dWFsIGJvb2wgaXNQYWdlQm94VmlzaWJsZShpbnQgcGFnZUluZGV4KTsKKyAgICB2aXJ0dWFs IFdlYlJlY3QgcGFnZUFyZWFSZWN0SW5QaXhlbHMoaW50IHBhZ2VJbmRleCk7CisgICAgdmlydHVh bCBXZWJTaXplIHByZWZlcnJlZFBhZ2VTaXplSW5QaXhlbHMoaW50IHBhZ2VJbmRleCk7CiAgICAg dmlydHVhbCBib29sIGZpbmQoCiAgICAgICAgIGludCBpZGVudGlmaWVyLCBjb25zdCBXZWJTdHJp bmcmIHNlYXJjaFRleHQsIGNvbnN0IFdlYkZpbmRPcHRpb25zJiwKICAgICAgICAgYm9vbCB3cmFw V2l0aGluRnJhbWUsIFdlYlJlY3QqIHNlbGVjdGlvblJlY3QpOwo= 59499 2010-06-23 03:25:58 -0700 2010-06-23 03:26:36 -0700 Addressed comment. bug-41056-20100623032557.patch text/plain 3425 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJmNWRlZjUwNTM3YjJkMjYwMmQ0OTk4NTUwZmNkZmNmZTJiM2IxYzEu LjA1NWY3MjkwYTRlMmYzYmE3NTkwMmViZTVmOTUzYjgxYjIxNDNiMDYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEwLTA2LTIzICBZdXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN YWtlIHBhZ2UgZm9ybWF0IGRhdGEgbWV0aG9kcyBhY2Nlc3NpYmxlIGZyb20gQ2hyb21pdW0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMDU2CisKKyAg ICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjppc1BhZ2VCb3hWaXNpYmxlKToKKyAg ICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpwYWdlQXJlYVJlY3RJblBpeGVscyk6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6cHJlZmVycmVkUGFnZVNpemVJblBpeGVscyk6Cisg ICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5oOgorCiAyMDEwLTA2LTIyICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRp ZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmggYi9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkZyYW1lLmgKaW5kZXggYjg5MGEwZjRiZjQ5ODY3YzhmYTAwYmQxZjFm ZGQ5Y2E4YzAyNWM1My4uMzE5Y2UzODk3Nzk5ODRmODNlZjdiNWJhODAyNmQzODIxOTkyODU2ZCAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBiL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtNDAzLDYgKzQwMywxNyBAQCBwdWJsaWM6 CiAgICAgLy8gUmVmb3JtYXRzIHRoZSBXZWJGcmFtZSBmb3Igc2NyZWVuIGRpc3BsYXkuCiAgICAg dmlydHVhbCB2b2lkIHByaW50RW5kKCkgPSAwOwogCisgICAgLy8gQ1NTMyBQYWdlZCBNZWRpYSAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisKKyAg ICAvLyBSZXR1cm5zIHRydWUgaWYgcGFnZSBib3ggKG1hcmdpbiBib3hlcyBhbmQgcGFnZSBib3Jk ZXJzKSBpcyB2aXNpYmxlLgorICAgIHZpcnR1YWwgYm9vbCBpc1BhZ2VCb3hWaXNpYmxlKGludCBw YWdlSW5kZXgpID0gMDsKKworICAgIC8vIFJldHVybnMgdGhlIHBhZ2UgYXJlYSByZWN0YW5nbGUg aW4gcGl4ZWxzLCBhc3N1bWluZyA5NiBwaXhlbHMgcGVyIGluY2guCisgICAgdmlydHVhbCBXZWJS ZWN0IHBhZ2VBcmVhUmVjdEluUGl4ZWxzKGludCBwYWdlSW5kZXgpID0gMDsKKworICAgIC8vIFJl dHVybnMgdGhlIHByZWZlcnJlZCBwYWdlIHNpemUgaW4gcGl4ZWxzLCBhc3N1bWluZyA5NiBwaXhl bHMgcGVyIGluY2guCisgICAgdmlydHVhbCBXZWJTaXplIHByZWZlcnJlZFBhZ2VTaXplSW5QaXhl bHMoaW50IHBhZ2VJbmRleCkgPSAwOworCiAKICAgICAvLyBGaW5kLWluLXBhZ2UgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0t Z2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IDBhZmJjODA2MTIyNWFiYTllNTU1YTJiZjYy ODc5MmZjZDRhMjNlMzAuLjNmOTM2MGM4MjBjY2M0MTQ0NzQ2YzFjODYyM2Q5ZjYxYTY4ZDlkMWUg MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTEyNzksNiArMTI3OSwyMSBA QCB2b2lkIFdlYkZyYW1lSW1wbDo6cHJpbnRFbmQoKQogICAgIG1fcHJpbnRDb250ZXh0LmNsZWFy KCk7CiB9CiAKK2Jvb2wgV2ViRnJhbWVJbXBsOjppc1BhZ2VCb3hWaXNpYmxlKGludCBwYWdlSW5k ZXgpCit7CisgICAgcmV0dXJuIGZyYW1lKCktPmRvY3VtZW50KCktPmlzUGFnZUJveFZpc2libGUo cGFnZUluZGV4KTsKK30KKworV2ViUmVjdCBXZWJGcmFtZUltcGw6OnBhZ2VBcmVhUmVjdEluUGl4 ZWxzKGludCBwYWdlSW5kZXgpCit7CisgICAgcmV0dXJuIGZyYW1lKCktPmRvY3VtZW50KCktPnBh Z2VBcmVhUmVjdEluUGl4ZWxzKHBhZ2VJbmRleCk7Cit9CisKK1dlYlNpemUgV2ViRnJhbWVJbXBs OjpwcmVmZXJyZWRQYWdlU2l6ZUluUGl4ZWxzKGludCBwYWdlSW5kZXgpCit7CisgICAgcmV0dXJu IGZyYW1lKCktPmRvY3VtZW50KCktPnByZWZlcnJlZFBhZ2VTaXplSW5QaXhlbHMocGFnZUluZGV4 KTsKK30KKwogYm9vbCBXZWJGcmFtZUltcGw6OmZpbmQoaW50IGlkZW50aWZpZXIsCiAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIHNlYXJjaFRleHQsCiAgICAgICAgICAg ICAgICAgICAgICAgICBjb25zdCBXZWJGaW5kT3B0aW9ucyYgb3B0aW9ucywKZGlmZiAtLWdpdCBh L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmggYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkZyYW1lSW1wbC5oCmluZGV4IGU2NTZiMzc0MTRmMTlkMmNjMzU3MDRlNDRkZDFhZWFlYjNm Mjc0YzAuLmMxNGFkOWI3MmM5MmMxMzU3NTI3YjdlMTMyNDk4MjY5Yzc2M2M1MTcgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKKysrIGIvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuaApAQCAtMTQ5LDYgKzE0OSw5IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIGZsb2F0IHByaW50UGFnZShpbnQgcGFnZVRvUHJpbnQsIFdlYkNhbnZhcyopOwogICAg IHZpcnR1YWwgZmxvYXQgZ2V0UHJpbnRQYWdlU2hyaW5rKGludCBwYWdlKTsKICAgICB2aXJ0dWFs IHZvaWQgcHJpbnRFbmQoKTsKKyAgICB2aXJ0dWFsIGJvb2wgaXNQYWdlQm94VmlzaWJsZShpbnQg cGFnZUluZGV4KTsKKyAgICB2aXJ0dWFsIFdlYlJlY3QgcGFnZUFyZWFSZWN0SW5QaXhlbHMoaW50 IHBhZ2VJbmRleCk7CisgICAgdmlydHVhbCBXZWJTaXplIHByZWZlcnJlZFBhZ2VTaXplSW5QaXhl bHMoaW50IHBhZ2VJbmRleCk7CiAgICAgdmlydHVhbCBib29sIGZpbmQoCiAgICAgICAgIGludCBp ZGVudGlmaWVyLCBjb25zdCBXZWJTdHJpbmcmIHNlYXJjaFRleHQsIGNvbnN0IFdlYkZpbmRPcHRp b25zJiwKICAgICAgICAgYm9vbCB3cmFwV2l0aGluRnJhbWUsIFdlYlJlY3QqIHNlbGVjdGlvblJl Y3QpOwo=