41026 2010-06-22 17:38:53 -0700 GraphicsContext3D doesn't define platformLayer() method any platform other than PLATFORM(MAC) 2010-06-23 10:39:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 vangelis webkit-unassigned abarth cmarrin dglazkov eric hclam kbr tkent vangelis webkit.review.bot oldest_to_newest 241565 0 vangelis 2010-06-22 17:38:53 -0700 This breaks any non PLATFORM(MAC) build (including Chromium and Qt) that define ACCELERATED_COMPOSITING and 3D_CANVAS 241576 1 59450 vangelis 2010-06-22 18:05:34 -0700 Created attachment 59450 Proposed patch 241596 2 59450 tkent 2010-06-22 18:56:03 -0700 Comment on attachment 59450 Proposed patch Clearing flags on attachment: 59450 Committed r61648: <http://trac.webkit.org/changeset/61648> 241597 3 tkent 2010-06-22 18:56:10 -0700 All reviewed patches have been landed. Closing bug. 241602 4 webkit.review.bot 2010-06-22 19:06:26 -0700 http://trac.webkit.org/changeset/61648 might have broken Chromium Linux Release 241930 5 vangelis 2010-06-23 10:39:33 -0700 The build break was taken care of by: http://trac.webkit.org/changeset/61649 Thanks, Kent! 59450 2010-06-22 18:05:34 -0700 2010-06-22 18:56:03 -0700 Proposed patch platformLayer_41026.txt text/plain 1978 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTY0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMjIgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERlZmluZSBHcmFwaGljc0NvbnRleHQzRDo6cGxhdGZvcm1MYXllcigpIGZvciBhbGwg cmVtYWluaW5nIChub24gUExBVEZPUk0oTUFDKSkKKyAgICAgICAgcG9ydHMgdG8gZ2V0IFJlbmRl ckxheWVyQmFja2luZy5jcHAgY29tcGlsaW5nIGFnYWluLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEwMjYKKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmg6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQzRDo6cGxhdGZvcm1MYXllcik6CisKIDIwMTAtMDYtMjIgIFRvbnkgR2VudGlsY29yZSAg PHRvbnlnQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgJ KHJldmlzaW9uIDYxNjMxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQzRC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIEdyYXBo aWNzQ29udGV4dDNEX2gKICNkZWZpbmUgR3JhcGhpY3NDb250ZXh0M0RfaAogCisjaW5jbHVkZSAi R3JhcGhpY3NMYXllci5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKICNpbmNsdWRl IDx3dGYvTGlzdEhhc2hTZXQuaD4KQEAgLTQzNCwxMiArNDM1LDE3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICNlbGlmIFBMQVRGT1JNKENIUk9NSVVNKQogICAgICAgICBQbGF0Zm9ybUdyYXBoaWNz Q29udGV4dDNEIHBsYXRmb3JtR3JhcGhpY3NDb250ZXh0M0QoKSBjb25zdDsKICAgICAgICAgUGxh dGZvcm0zRE9iamVjdCBwbGF0Zm9ybVRleHR1cmUoKSBjb25zdDsKKyAgICAgICAgLy8gRklYTUU6 IFN0dWJiZWQgb3V0IGZvciBub3cuIE11c3QgYmUgaW1wbGVtZW50ZWQgdG8gZ2V0IFdlYkdMIHdv cmtpbmcgd2l0aAorICAgICAgICAvLyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZy4KKyAgICAgICAg UGxhdGZvcm1MYXllciogcGxhdGZvcm1MYXllcigpIGNvbnN0IHsgcmV0dXJuIDA7IH0KICNlbGlm IFBMQVRGT1JNKFFUKQogICAgICAgICBQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dDNEIHBsYXRmb3Jt R3JhcGhpY3NDb250ZXh0M0QoKTsKICAgICAgICAgUGxhdGZvcm0zRE9iamVjdCBwbGF0Zm9ybVRl eHR1cmUoKSBjb25zdDsKKyAgICAgICAgUGxhdGZvcm1MYXllciogcGxhdGZvcm1MYXllcigpIGNv bnN0IHsgcmV0dXJuIDA7IH0KICNlbHNlCiAgICAgICAgIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0 M0QgcGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCgpIGNvbnN0IHsgcmV0dXJuIE51bGxQbGF0Zm9y bUdyYXBoaWNzQ29udGV4dDNEOyB9CiAgICAgICAgIFBsYXRmb3JtM0RPYmplY3QgcGxhdGZvcm1U ZXh0dXJlKCkgY29uc3QgeyByZXR1cm4gTnVsbFBsYXRmb3JtM0RPYmplY3Q7IH0KKyAgICAgICAg UGxhdGZvcm1MYXllciogcGxhdGZvcm1MYXllcigpIGNvbnN0IHsgcmV0dXJuIDA7IH0KICNlbmRp ZgogICAgICAgICB2b2lkIG1ha2VDb250ZXh0Q3VycmVudCgpOwogCg==