41012 2010-06-22 14:19:03 -0700 REGRESSION (r61548): PLT is almost 1.5% slower, Google page cycler slower 2010-06-22 15:12:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned dglazkov jamesr oldest_to_newest 241455 0 mitz 2010-06-22 14:19:03 -0700 As discussed extensively in bug 10228, r61548 has caused a measurable regression in layout performance. Patch forthcoming. 241457 1 mitz 2010-06-22 14:20:11 -0700 <rdar://problem/8119403> 241466 2 59417 mitz 2010-06-22 14:51:37 -0700 Created attachment 59417 Remove a redundant call to RenderText::width() 241475 3 mitz 2010-06-22 15:12:24 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/61629>. 59417 2010-06-22 14:51:37 -0700 2010-06-22 14:53:10 -0700 Remove a redundant call to RenderText::width() 8119403_r1.diff text/plain 3151 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTYyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMjIgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRh cjovL3Byb2JsZW0vODExOTQwMz4gUkVHUkVTU0lPTiAocjYxNTQ4KTogUExUIGlzIGFsbW9zdCAx LjUlIHNsb3dlciwgR29vZ2xlIHBhZ2UgY3ljbGVyIHNsb3dlcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEwMTIKKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxv Y2s6OmNvbXB1dGVIb3Jpem9udGFsUG9zaXRpb25zRm9yTGluZSk6IFJlbW92ZWQgYSByZWR1bmRh bnQgc3RhdGVtZW50IHRoYXQgd2FzCisgICAgICAgIGxlZnQgb3ZlciBpbiB0aGUgb3JpZ2luYWwg cGF0Y2ggYW5kIHJlc3VsdGVkIGluIGRvdWJsZSB0aGUgY2FsbHMgdG8gUmVuZGVyVGV4dDo6d2lk dGgoKSBoZXJlLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmZpbmROZXh0TGluZUJy ZWFrKTogQ2hhbmdlZCB0aGUgb3JkZXIgb2YgZXZhbHVhdGluZyBjb25kaXRpb25zIGZvciBhCisg ICAgICAgIHBvdGVudGlhbCBzcGVlZHVwLgorCiAyMDEwLTA2LTIyICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292 LgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCShy ZXZpc2lvbiA2MTYyNykKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91 dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1MSw3ICszNTEsNiBAQCB2b2lkIFJlbmRlckJsb2Nr Ojpjb21wdXRlSG9yaXpvbnRhbFBvc2l0CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBIYXNo U2V0PGNvbnN0IFNpbXBsZUZvbnREYXRhKj4gZmFsbGJhY2tGb250czsKICAgICAgICAgICAgIEds eXBoT3ZlcmZsb3cgZ2x5cGhPdmVyZmxvdzsKLSAgICAgICAgICAgIHItPm1fYm94LT5zZXRXaWR0 aChydC0+d2lkdGgoci0+bV9zdGFydCwgci0+bV9zdG9wIC0gci0+bV9zdGFydCwgdG90V2lkdGgs IGZpcnN0TGluZSwgJmZhbGxiYWNrRm9udHMsICZnbHlwaE92ZXJmbG93KSk7CiAgICAgICAgICAg ICBpbnQgaHlwaGVuV2lkdGggPSAwOwogICAgICAgICAgICAgaWYgKHN0YXRpY19jYXN0PElubGlu ZVRleHRCb3gqPihyLT5tX2JveCktPmhhc0h5cGhlbigpKSB7CiAgICAgICAgICAgICAgICAgY29u c3QgQXRvbWljU3RyaW5nJiBoeXBoZW5TdHJpbmcgPSBydC0+c3R5bGUoKS0+aHlwaGVuU3RyaW5n KCk7CkBAIC0xNzE2LDEyICsxNzE1LDEyIEBAIElubGluZUl0ZXJhdG9yIFJlbmRlckJsb2NrOjpm aW5kTmV4dExpbmUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2tpcFRyYWlsaW5n V2hpdGVzcGFjZShsQnJlYWssIGlzTGluZUVtcHR5LCBwcmV2aW91c0xpbmVCcm9rZUNsZWFubHkp OwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgICAg IH0KLSAgICAgICAgICAgICAgICAgICAgICAgIGlmIChjYW5IeXBoZW5hdGUgJiYgdyArIHRtcFcg PiB3aWR0aCkgewotICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRyeUh5cGhlbmF0aW5nKHQs IGYsIGxhc3RTcGFjZSwgcG9zLCB3ICsgdG1wVyAtIGFkZGl0aW9uYWxUbXBXLCB3aWR0aCwgaXNG aXhlZFBpdGNoLCBjb2xsYXBzZVdoaXRlU3BhY2UsIGxhc3RTcGFjZVdvcmRTcGFjaW5nLCBsQnJl YWssIG5leHRCcmVha2FibGUsIGh5cGhlbmF0ZWQpOwotICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGlmIChoeXBoZW5hdGVkKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3Rv IGVuZDsKLSAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgICAg IGlmIChsaW5lV2FzVG9vV2lkZSB8fCB3ICsgdG1wVyA+IHdpZHRoKSB7CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgaWYgKGNhbkh5cGhlbmF0ZSAmJiB3ICsgdG1wVyA+IHdpZHRoKSB7Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRyeUh5cGhlbmF0aW5nKHQsIGYsIGxhc3RT cGFjZSwgcG9zLCB3ICsgdG1wVyAtIGFkZGl0aW9uYWxUbXBXLCB3aWR0aCwgaXNGaXhlZFBpdGNo LCBjb2xsYXBzZVdoaXRlU3BhY2UsIGxhc3RTcGFjZVdvcmRTcGFjaW5nLCBsQnJlYWssIG5leHRC cmVha2FibGUsIGh5cGhlbmF0ZWQpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp ZiAoaHlwaGVuYXRlZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8g ZW5kOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpZiAobEJyZWFrLm9iaiAmJiBzaG91bGRQcmVzZXJ2ZU5ld2xpbmUobEJyZWFrLm9i aikgJiYgbEJyZWFrLm9iai0+aXNUZXh0KCkgJiYgdG9SZW5kZXJUZXh0KGxCcmVhay5vYmopLT50 ZXh0TGVuZ3RoKCkgJiYgIXRvUmVuZGVyVGV4dChsQnJlYWsub2JqKS0+aXNXb3JkQnJlYWsoKSAm JiB0b1JlbmRlclRleHQobEJyZWFrLm9iaiktPmNoYXJhY3RlcnMoKVtsQnJlYWsucG9zXSA9PSAn XG4nKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghc3RvcHBlZElnbm9y aW5nU3BhY2VzICYmIHBvcyA+IDApIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC8vIFdlIG5lZWQgdG8gc3RvcCByaWdodCBiZWZvcmUgdGhlIG5ld2xpbmUgYW5kIHRoZW4g c3RhcnQgdXAgYWdhaW4uCg==