41011 2010-06-22 13:43:57 -0700 Incremental build failed on Chromium ews 2010-07-19 11:13:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 5861 1 zherczeg webkit-unassigned abarth dglazkov eric evan tony oldest_to_newest 241432 0 zherczeg 2010-06-22 13:43:57 -0700 In this bug, the ews bot incorrectly reports an error, which is not happen for clean builds: https://bugs.webkit.org/show_bug.cgi?id=5861 Probably the incremental build fails. Can we force a clean build on patches? 242987 1 zherczeg 2010-06-25 06:17:45 -0700 Evan please help. 243068 2 evan 2010-06-25 10:30:52 -0700 EWS masters, can we do clean builds on the EWS? 243071 3 dglazkov 2010-06-25 10:42:22 -0700 Will clean up in a sec. #webkit is also a good venue for this. 243073 4 abarth 2010-06-25 10:44:38 -0700 The problem is that build-webkit --chromium doesn't understand how to deal with changes to WebCore/WebCore.gypi. 243074 5 dglazkov 2010-06-25 10:46:24 -0700 (In reply to comment #3) > Will clean up in a sec. #webkit is also a good venue for this. Apologies, I don't know how to read. As punishment, adding myself to Skipped tests lists. 243082 6 59780 abarth 2010-06-25 11:10:44 -0700 Created attachment 59780 Patch 243151 7 abarth 2010-06-25 12:55:08 -0700 Let see how badly this borks things. 243154 8 59780 abarth 2010-06-25 12:57:28 -0700 Comment on attachment 59780 Patch Clearing flags on attachment: 59780 Committed r61883: <http://trac.webkit.org/changeset/61883> 243155 9 abarth 2010-06-25 12:57:34 -0700 All reviewed patches have been landed. Closing bug. 243652 10 zherczeg 2010-06-28 04:33:36 -0700 This patch do miracles! Excellent work guys :) 253288 11 tony 2010-07-19 10:53:12 -0700 This patch is kind of annoying. Every time I run build-webkit --chromium, gclient runs. Is it not possible to modify just the ews bot step instead of modifying build-webkit? The other option is to make a build-webkit --chromium --force, and have --force trigger gclient. Also, on this slows down the waterfall bots because now we run gclient twice (once during the update chromium dependencies step and once during the compile step). 253295 12 abarth 2010-07-19 11:13:26 -0700 Maybe the solution is better dependency checking? Other ports pick up changes to their build system when you run build-webkit. 59780 2010-06-25 11:10:44 -0700 2010-06-25 12:57:28 -0700 Patch bug-41011-20100625111043.patch text/plain 1608 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYxODczKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDYtMjUgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbmNyZW1lbnRhbCBidWlsZCBmYWlsZWQgb24gQ2hyb21pdW0gZXdzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTAxMQorCisgICAgICAg IFRoZSBkaXZpc2lvbiBvZiByZXNwb25zaWJpbGl0eSBiZXR3ZWVuIHVwZGF0ZS13ZWJraXQgLS1j aHJvbWl1bSBhbmQKKyAgICAgICAgYnVpbGQtd2Via2l0IC0tY2hyb21pdW0gaXMgc2xpZ2h0bHkg dW5jbGVhci4gIEluIHRoaXMgcGF0Y2gsIHdlIG1ha2UKKyAgICAgICAgYnVpbGQtd2Via2l0IC0t Y2hyb21pdW0gYWxzbyB1cGRhdGUgREVQUyBhbmQgcmUtcnVuIEdZUCBpbiBjYXNlIHRoZQorICAg ICAgICBkZXZlbG9wZXIgaGFzIGNoYW5nZWQgZWl0aGVyIHNpbmNlIHRoZXkgdXBkYXRlZC4KKwor ICAgICAgICBUaGlzIGNoYW5nZSBpcyBhbHNvIGhlbHBmdWwgZm9yIHRoZSBFV1MsIHdoaWNoIHdh bnRzIHRvIHVwZGF0ZSBERVBTIGFuZAorICAgICAgICByZS1ydW4gR1lQIGFmdGVyIGFwcGx5aW5n IHBhdGNoZXMsIGJ1dCB0aGUgRVdTIGRvZXNuJ3Qgd2FudCB0byBydW4KKyAgICAgICAgdXBkYXRl LXdlYmtpdCAtLWNocm9taXVtIGJlY2F1c2UgaXQgaGFzIGEgZGlydHkgd29ya2luZyBjb3B5Lgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorCiAyMDEwLTA2LTI1ICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0IGFjY2lkZW50 YWwgcGFydCBhbmQgYWRkIGEgbmV3bGluZS4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0JKHJldmlzaW9uIDYxODI0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CSh3b3JraW5nIGNvcHkpCkBAIC0xNDkzLDYgKzE0OTMsOSBAQCBzdWIgYnVpbGRDaHJvbWl1bSgk QCkKIHsKICAgICBteSAoJGNsZWFuLCBAb3B0aW9ucykgPSBAXzsKIAorICAgICMgV2UgbWlnaHQg bmVlZCB0byB1cGRhdGUgREVQUyBvciByZS1ydW4gR1lQIGlmIHRoaW5ncyBoYXZlIGNoYW5nZWQu CisgICAgc3lzdGVtKCJwZXJsIiwgIldlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1j aHJvbWl1bSIpID09IDAgb3IgZGllICQhOworCiAgICAgbXkgJHJlc3VsdCA9IDE7CiAgICAgaWYg KGlzRGFyd2luKCkpIHsKICAgICAgICAgIyBNYWMgYnVpbGQgLSBidWlsZHMgdGhlIHJvb3QgeGNv ZGUgcHJvamVjdC4K