40990 2010-06-22 09:39:33 -0700 [GTK] Bots are showing lots of GTK_IS_CONTAINER critical warnings 2010-08-18 16:18:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned abarth eric webkit.review.bot xan.lopez oldest_to_newest 241293 0 mrobinson 2010-06-22 09:39:33 -0700 This seems to be an issue with ScrollViewGtk creating native scrollbars too late in the lifetime of a view. For now we can simply not add the scrollbar in that case. I think the real long term solution is to entirely remove native scrollbars and rely on the theme drawing code to render them. 241339 1 59391 mrobinson 2010-06-22 11:03:05 -0700 Created attachment 59391 Patch for this issue 242611 2 59391 xan.lopez 2010-06-24 11:56:39 -0700 Comment on attachment 59391 Patch for this issue As commented on jabber, relying on a dead widget to do something or other is not a good idea. We have to find other solution. 266349 3 64764 mrobinson 2010-08-18 13:42:57 -0700 Created attachment 64764 Another approach to this issue 266355 4 64764 gustavo 2010-08-18 13:48:16 -0700 Comment on attachment 64764 Another approach to this issue This looks sane to me, please run the API tests too. Some going around in build.webkit.org would be a plus, given how fragile this code still seems to be =( 266428 5 mrobinson 2010-08-18 15:45:36 -0700 Committed r65635: <http://trac.webkit.org/changeset/65635> 266438 6 webkit.review.bot 2010-08-18 16:18:45 -0700 http://trac.webkit.org/changeset/65635 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/65635 http://trac.webkit.org/changeset/65636 http://trac.webkit.org/changeset/65637 59391 2010-06-22 11:03:05 -0700 2010-08-18 13:42:54 -0700 Patch for this issue bug-40990-20100622110303.patch text/plain 1411 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTkwOWRlNzljMTE1YTFhMzgxNDIwOGZkN2ZiMDAxYmU0NTg3YjM1Yi4uNWI3ZDZkMzZjMzNhYThl NjA2YzBiOThiM2U1ZGFiYzI3MWFmZTRmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0yMiAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQm90cyBhcmUgc2hvd2luZyBsb3Rz IG9mIEdUS19JU19DT05UQUlORVIgY3JpdGljYWwgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwOTkwCisKKyAgICAgICAgT25seSBhZGQg YSBuYXRpdmUgc2Nyb2xsYmFyIHRvIHRoZSBwYXJlbnQgaWYgdGhlIHBhcmVudCBpcyBhIEdUSysg Y29udGFpbmVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6cGxhdGZvcm1BZGRDaGlsZCk6CisKIDIwMTAt MDYtMDQgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL1Njcm9sbFZpZXdHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0 ay5jcHAKaW5kZXggNWMyNThhZDIxYmNkN2YzMzQzMWQwNDM1NzQ5MzNjNzk4ZTY5MmRmNi4uNmQ4 NDA3NTRkMzllM2JlY2U5YzM0NDE1MTQ1ZjRhNTA5MDM0NmY2MCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvU2Nyb2xsVmlld0d0ay5jcHAKQEAgLTE1Niw3ICsxNTYsNyBAQCB2b2lkIFNjcm9sbFZpZXc6 OnNldEd0a0FkanVzdG1lbnRzKEd0a0FkanVzdG1lbnQqIGhhZGosIEd0a0FkanVzdG1lbnQqIHZh ZGosIGJvbwogCiB2b2lkIFNjcm9sbFZpZXc6OnBsYXRmb3JtQWRkQ2hpbGQoV2lkZ2V0KiBjaGls ZCkKIHsKLSAgICBpZiAoIUdUS19JU19TT0NLRVQoY2hpbGQtPnBsYXRmb3JtV2lkZ2V0KCkpKQor ICAgIGlmIChHVEtfSVNfQ09OVEFJTkVSKGhvc3RXaW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xpZW50 KCkpICYmICFHVEtfSVNfU09DS0VUKGNoaWxkLT5wbGF0Zm9ybVdpZGdldCgpKSkKICAgICAgICAg Z3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUihob3N0V2luZG93KCktPnBsYXRmb3JtUGFn ZUNsaWVudCgpKSwgY2hpbGQtPnBsYXRmb3JtV2lkZ2V0KCkpOwogfQogCg== 64764 2010-08-18 13:42:57 -0700 2010-08-18 13:48:16 -0700 Another approach to this issue bug-40990-20100818134245.patch text/plain 4900 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmI0MTU1ZTc3NmNiNzFlZGY2MDkwZWQzMzdiMDg4OGExMTgyZDI4ZS4uMTMyMGRhYTk3MDdkOTY5 ZDlhMTEzNTg2MTZhNGQ2MmExMGY4ZWFmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMC0wOC0xOCAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQm90cyBhcmUgc2hvd2luZyBsb3Rz IG9mIEdUS19JU19DT05UQUlORVIgY3JpdGljYWwgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwOTkwCisKKyAgICAgICAgSW5zdGVhZCBv ZiByZWx5aW5nIG9uIHRoZSBTY3JvbGxWaWV3J3MgYWRqdXN0bWVudCBtZW1iZXJzIHRvIGRldGVy bWluZSBpZiBhCisgICAgICAgIFNjcm9sbGJhciBzaG91bGQgYmUgbmF0aXZlIG9yIGp1c3QgYSBz aGVsbCBvZiB0aGUgcGFyZW50J3Mgc2Nyb2xsYmFyIChtYWluIGZyYW1lCisgICAgICAgIHNjcm9s bGJhciksIGp1c3QgY2hlY2sgaWYgdGhpcyBTY3JvbGxWaWV3IGhhcyBhIHBhcmVudC4gVGhpcyB3 aWxsIGVuc3VyZSB0aGUKKyAgICAgICAgY29ycmVjdCBiZWhhdmlvciB3aGVuIG1haW4gZnJhbWUg c2Nyb2xsYmFyJ3MgYXJlIGNyZWF0ZWQgYWZ0ZXIgdGhlIFNjcm9sbFZpZXcncworICAgICAgICBj b250YWluaW5nIGFkanVzdG1lbnRzIGdvIGF3YXkuCisKKyAgICAgICAgTGFjayBvZiB3YXJuaW5n cyBkdXJpbmcgdGVzdHMgYXJlIHRoZSB0ZXN0IGZvciB0aGlzIGZpeC4KKworICAgICAgICAqIHBs YXRmb3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZp ZXc6OmNyZWF0ZVNjcm9sbGJhcik6IERlY2lkZSB3aGF0IHR5cGUgb2Ygc2Nyb2xsYmFyIHRvIG1h a2UgYmFzZWQKKyAgICAgICAgb24gdGhlIHJlc3VsdCBvZiB0aGUgcGFyZW50KCkgbWV0aG9kLgor ICAgICAgICAqIHBsYXRmb3JtL2d0ay9TY3JvbGxiYXJHdGsuY3BwOgorICAgICAgICAoU2Nyb2xs YmFyR3RrOjpTY3JvbGxiYXJHdGspOiBBbGxvdyBmb3IgYW4gbV9hZGp1c3RtZW50IHdoaWNoIGlz IG51bGwuCisgICAgICAgIChTY3JvbGxiYXJHdGs6OmF0dGFjaEFkanVzdG1lbnQpOiBEaXR0by4K KyAgICAgICAgKFNjcm9sbGJhckd0azo6dXBkYXRlVGh1bWJQb3NpdGlvbik6IERpdHRvLgorICAg ICAgICAoU2Nyb2xsYmFyR3RrOjp1cGRhdGVUaHVtYlByb3BvcnRpb24pOiBEaXR0by4KKwogMjAx MC0wOC0xNyAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbFZp ZXdHdGsuY3BwCmluZGV4IDg3MWEwYmYyNjY1OTg3YzY0OGM2YjQ1ZmI1M2Q0NDFmZGU4MWUwNDYu LjU2NTEyM2NhOTE3OTc1NDZjMTY2NjIwZGU4Nzg1ZDc4ZTgyMWQwMGYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwCkBAIC02NSwxMiArNjUsMjAgQEAgdm9pZCBTY3JvbGxW aWV3OjpwbGF0Zm9ybURlc3Ryb3koKQogCiBQYXNzUmVmUHRyPFNjcm9sbGJhcj4gU2Nyb2xsVmll dzo6Y3JlYXRlU2Nyb2xsYmFyKFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9uKQogewot ICAgIGlmIChvcmllbnRhdGlvbiA9PSBIb3Jpem9udGFsU2Nyb2xsYmFyICYmIG1faG9yaXpvbnRh bEFkanVzdG1lbnQpCi0gICAgICAgIHJldHVybiBTY3JvbGxiYXJHdGs6OmNyZWF0ZVNjcm9sbGJh cih0aGlzLCBvcmllbnRhdGlvbiwgbV9ob3Jpem9udGFsQWRqdXN0bWVudCk7Ci0gICAgZWxzZSBp ZiAob3JpZW50YXRpb24gPT0gVmVydGljYWxTY3JvbGxiYXIgJiYgbV92ZXJ0aWNhbEFkanVzdG1l bnQpCi0gICAgICAgIHJldHVybiBTY3JvbGxiYXJHdGs6OmNyZWF0ZVNjcm9sbGJhcih0aGlzLCBv cmllbnRhdGlvbiwgbV92ZXJ0aWNhbEFkanVzdG1lbnQpOwotICAgIGVsc2UKKyAgICAvLyBJZiB0 aGlzIGlzIGFuIGludGVyaW9yIGZyYW1lIHNjcm9sbGJhciwgd2Ugd2FudCB0byBjcmVhdGUgYSBz Y3JvbGxiYXIgd2l0aG91dAorICAgIC8vIHBhc3NpbmcgYSBHdGtBZGp1c3RtZW50LiBUaGlzIHdp bGwgY2F1c2UgdGhlIFNjcm9sbGJhciB0byBjcmVhdGUgYSBuYXRpdmUgR1RLKworICAgIC8vIHNj cm9sbGJhci4KKyAgICBpZiAocGFyZW50KCkpCiAgICAgICAgIHJldHVybiBTY3JvbGxiYXI6OmNy ZWF0ZU5hdGl2ZVNjcm9sbGJhcih0aGlzLCBvcmllbnRhdGlvbiwgUmVndWxhclNjcm9sbGJhcik7 CisKKyAgICAvLyBJZiB0aGlzIGlzIHRoZSBtYWluIGZyYW1lLCB3ZSB3YW50IHRvIGNyZWF0ZSBh IFNjcm9sbGJhciB0aGF0IGRvZXMgbm8gIHBhaW50aW5nCisgICAgLy8gYW5kIGRlZmVycyB0byBv dXIgR3RrQWRqdXN0bWVudCBmb3IgYWxsIG9mIGl0cyBzdGF0ZS4gTm90ZSB0aGF0IHRoZSBHdGtB ZGp1c3RtZW50CisgICAgLy8gbWF5IGJlIG51bGwgaGVyZS4KKyAgICBpZiAob3JpZW50YXRpb24g PT0gSG9yaXpvbnRhbFNjcm9sbGJhcikKKyAgICAgICAgcmV0dXJuIFNjcm9sbGJhckd0azo6Y3Jl YXRlU2Nyb2xsYmFyKHRoaXMsIG9yaWVudGF0aW9uLCBtX2hvcml6b250YWxBZGp1c3RtZW50KTsK KworICAgIC8vIFZlcnRpY2FsU2Nyb2xsYmFyCisgICAgcmV0dXJuIFNjcm9sbGJhckd0azo6Y3Jl YXRlU2Nyb2xsYmFyKHRoaXMsIG9yaWVudGF0aW9uLCBtX3ZlcnRpY2FsQWRqdXN0bWVudCk7CiB9 CiAKIC8qCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJHdGsuY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyR3RrLmNwcAppbmRleCAzYjg2ZWM5NmVh OWZlZmE2NTEyZjZlZDEzMTk3OTNiNDRmMGE5YzQ1Li44YTFjNGZhMjhjM2JkN2Y1MDAzOTVhNWE5 YTAwN2M4OGZkN2ZlZTZiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxi YXJHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhckd0ay5jcHAKQEAg LTgxLDggKzgxLDEwIEBAIFNjcm9sbGJhckd0azo6U2Nyb2xsYmFyR3RrKFNjcm9sbGJhckNsaWVu dCogY2xpZW50LCBTY3JvbGxiYXJPcmllbnRhdGlvbiBvcmllbnRhCiAgICAgOiBTY3JvbGxiYXIo Y2xpZW50LCBvcmllbnRhdGlvbiwgUmVndWxhclNjcm9sbGJhcikKICAgICAsIG1fYWRqdXN0bWVu dChhZGp1c3RtZW50KQogewotICAgIGdfb2JqZWN0X3JlZihtX2FkanVzdG1lbnQpOwotICAgIGdf c2lnbmFsX2Nvbm5lY3QobV9hZGp1c3RtZW50LCAidmFsdWUtY2hhbmdlZCIsIEdfQ0FMTEJBQ0so U2Nyb2xsYmFyR3RrOjpndGtWYWx1ZUNoYW5nZWQpLCB0aGlzKTsKKyAgICBpZiAobV9hZGp1c3Rt ZW50KSB7CisgICAgICAgIGdfb2JqZWN0X3JlZihtX2FkanVzdG1lbnQpOworICAgICAgICBnX3Np Z25hbF9jb25uZWN0KG1fYWRqdXN0bWVudCwgInZhbHVlLWNoYW5nZWQiLCBHX0NBTExCQUNLKFNj cm9sbGJhckd0azo6Z3RrVmFsdWVDaGFuZ2VkKSwgdGhpcyk7CisgICAgfQogCiAgICAgLy8gV2Ug aGF2ZSBub3RoaW5nIHRvIHNob3cgYXMgd2UgYXJlIHNvbGVseSBvcGVyYXRpbmcgb24gdGhlIEd0 a0FkanVzdG1lbnQKICAgICByZXNpemUoMCwgMCk7CkBAIC0xMDQsOCArMTA2LDEwIEBAIHZvaWQg U2Nyb2xsYmFyR3RrOjphdHRhY2hBZGp1c3RtZW50KEd0a0FkanVzdG1lbnQqIGFkanVzdG1lbnQp CiAKICAgICBtX2FkanVzdG1lbnQgPSBhZGp1c3RtZW50OwogCi0gICAgZ19vYmplY3RfcmVmKG1f YWRqdXN0bWVudCk7Ci0gICAgZ19zaWduYWxfY29ubmVjdChtX2FkanVzdG1lbnQsICJ2YWx1ZS1j aGFuZ2VkIiwgR19DQUxMQkFDSyhTY3JvbGxiYXJHdGs6Omd0a1ZhbHVlQ2hhbmdlZCksIHRoaXMp OworICAgIGlmIChtX2FkanVzdG1lbnQpIHsKKyAgICAgICAgZ19vYmplY3RfcmVmKG1fYWRqdXN0 bWVudCk7CisgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3QobV9hZGp1c3RtZW50LCAidmFsdWUtY2hh bmdlZCIsIEdfQ0FMTEJBQ0soU2Nyb2xsYmFyR3RrOjpndGtWYWx1ZUNoYW5nZWQpLCB0aGlzKTsK KyAgICB9CiAKICAgICB1cGRhdGVUaHVtYlByb3BvcnRpb24oKTsKICAgICB1cGRhdGVUaHVtYlBv c2l0aW9uKCk7CkBAIC0xNTYsMTIgKzE2MCwxOCBAQCB2b2lkIFNjcm9sbGJhckd0azo6ZnJhbWVS ZWN0c0NoYW5nZWQoKQogCiB2b2lkIFNjcm9sbGJhckd0azo6dXBkYXRlVGh1bWJQb3NpdGlvbigp CiB7CisgICAgaWYgKCFtX2FkanVzdG1lbnQpCisgICAgICAgIHJldHVybjsKKwogICAgIGlmIChn dGtfYWRqdXN0bWVudF9nZXRfdmFsdWUobV9hZGp1c3RtZW50KSAhPSBtX2N1cnJlbnRQb3MpCiAg ICAgICAgIGd0a19hZGp1c3RtZW50X3NldF92YWx1ZShtX2FkanVzdG1lbnQsIG1fY3VycmVudFBv cyk7CiB9CiAKIHZvaWQgU2Nyb2xsYmFyR3RrOjp1cGRhdGVUaHVtYlByb3BvcnRpb24oKQogewor ICAgIGlmICghbV9hZGp1c3RtZW50KQorICAgICAgICByZXR1cm47CisKICAgICBndGtfYWRqdXN0 bWVudF9jb25maWd1cmUobV9hZGp1c3RtZW50LAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBndGtfYWRqdXN0bWVudF9nZXRfdmFsdWUobV9hZGp1c3RtZW50KSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ3RrX2FkanVzdG1lbnRfZ2V0X2xvd2VyKG1fYWRqdXN0bWVudCksCg==