40972 2010-06-21 23:57:22 -0700 Fix the Windows build bots 2010-06-22 08:46:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 dumi dumi aroben bweinstein eric oldest_to_newest 241147 0 dumi 2010-06-21 23:57:22 -0700 It looks like ImageDiff.vcproj is missing a dependency on JavaScriptCore.lib, which makes the Windows bots fail. 241149 1 59345 dumi 2010-06-22 00:00:28 -0700 Created attachment 59345 patch Should fix the Windows build, at least in a clean client. 241152 2 59345 eric 2010-06-22 00:01:25 -0700 Comment on attachment 59345 patch Looks sane to me. 241155 3 dumi 2010-06-22 00:05:31 -0700 Landed as r61603. If you see anything wrong with this patch, please let me know and I'll be happy to fix the problem. 241240 4 aroben 2010-06-22 06:56:25 -0700 The patch looks fine. Thanks for fixing it! I wish we knew why this error started happening in the first place, though. 241271 5 aroben 2010-06-22 08:43:12 -0700 (In reply to comment #4) > I wish we knew why this error started happening in the first place, though. Looks like the culprit is <http://trac.webkit.org/changeset/61576>, which must have caused FastMalloc.h to get pulled into ImageDiff. 241273 6 aroben 2010-06-22 08:46:40 -0700 Another option would have been to define USE_SYSTEM_MALLOC=1. 59345 2010-06-22 00:00:28 -0700 2010-06-22 00:01:49 -0700 patch patch text/plain 2372 dumi SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYxNjAyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDYtMjEgIER1bWl0cnUgRGFuaWxpdWMg IDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggdGhlIFdpbmRvd3MgYnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDk3MgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvd2luL0ltYWdlRGlmZi52Y3Byb2o6CisKIDIwMTAtMDYtMjEgIFByYXNhZCBUYW1tYW5h ICA8cHJhc2FkdEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIsIERtaXRyeSBUaXRvdi4KSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9J bWFnZURpZmYudmNwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L3dpbi9JbWFnZURpZmYudmNwcm9qCShyZXZpc2lvbiA2MTYwMikKKysrIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3dpbi9JbWFnZURpZmYudmNwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC01MSw3 ICs1MSw3IEBACiAJCQkvPg0KIAkJCTxUb29sDQogCQkJCU5hbWU9IlZDTGlua2VyVG9vbCINCi0J CQkJQWRkaXRpb25hbERlcGVuZGVuY2llcz0iQ29yZUdyYXBoaWNzJChMaWJyYXJ5Q29uZmlnU3Vm Zml4KS5saWIgQ29yZUZvdW5kYXRpb24kKExpYnJhcnlDb25maWdTdWZmaXgpLmxpYiINCisJCQkJ QWRkaXRpb25hbERlcGVuZGVuY2llcz0iSmF2YVNjcmlwdENvcmUkKFdlYktpdERMTENvbmZpZ1N1 ZmZpeCkubGliIENvcmVHcmFwaGljcyQoTGlicmFyeUNvbmZpZ1N1ZmZpeCkubGliIENvcmVGb3Vu ZGF0aW9uJChMaWJyYXJ5Q29uZmlnU3VmZml4KS5saWIiDQogCQkJCUFkZGl0aW9uYWxMaWJyYXJ5 RGlyZWN0b3JpZXM9IiINCiAJCQkJU3ViU3lzdGVtPSIxIg0KIAkJCS8+DQpAQCAtMTE5LDcgKzEx OSw3IEBACiAJCQkvPg0KIAkJCTxUb29sDQogCQkJCU5hbWU9IlZDTGlua2VyVG9vbCINCi0JCQkJ QWRkaXRpb25hbERlcGVuZGVuY2llcz0iQ29yZUdyYXBoaWNzJChMaWJyYXJ5Q29uZmlnU3VmZml4 KS5saWIgQ29yZUZvdW5kYXRpb24kKExpYnJhcnlDb25maWdTdWZmaXgpLmxpYiINCisJCQkJQWRk aXRpb25hbERlcGVuZGVuY2llcz0iSmF2YVNjcmlwdENvcmUkKFdlYktpdERMTENvbmZpZ1N1ZmZp eCkubGliIENvcmVHcmFwaGljcyQoTGlicmFyeUNvbmZpZ1N1ZmZpeCkubGliIENvcmVGb3VuZGF0 aW9uJChMaWJyYXJ5Q29uZmlnU3VmZml4KS5saWIiDQogCQkJCUFkZGl0aW9uYWxMaWJyYXJ5RGly ZWN0b3JpZXM9IiINCiAJCQkJU3ViU3lzdGVtPSIxIg0KIAkJCS8+DQpAQCAtMTg2LDcgKzE4Niw3 IEBACiAJCQkvPg0KIAkJCTxUb29sDQogCQkJCU5hbWU9IlZDTGlua2VyVG9vbCINCi0JCQkJQWRk aXRpb25hbERlcGVuZGVuY2llcz0iQ29yZUdyYXBoaWNzJChMaWJyYXJ5Q29uZmlnU3VmZml4KS5s aWIgQ29yZUZvdW5kYXRpb24kKExpYnJhcnlDb25maWdTdWZmaXgpLmxpYiINCisJCQkJQWRkaXRp b25hbERlcGVuZGVuY2llcz0iSmF2YVNjcmlwdENvcmUkKFdlYktpdERMTENvbmZpZ1N1ZmZpeCku bGliIENvcmVHcmFwaGljcyQoTGlicmFyeUNvbmZpZ1N1ZmZpeCkubGliIENvcmVGb3VuZGF0aW9u JChMaWJyYXJ5Q29uZmlnU3VmZml4KS5saWIiDQogCQkJCUFkZGl0aW9uYWxMaWJyYXJ5RGlyZWN0 b3JpZXM9IiINCiAJCQkJU3ViU3lzdGVtPSIxIg0KIAkJCS8+DQpAQCAtMjUzLDcgKzI1Myw3IEBA CiAJCQkvPg0KIAkJCTxUb29sDQogCQkJCU5hbWU9IlZDTGlua2VyVG9vbCINCi0JCQkJQWRkaXRp b25hbERlcGVuZGVuY2llcz0iQ29yZUdyYXBoaWNzJChMaWJyYXJ5Q29uZmlnU3VmZml4KS5saWIg Q29yZUZvdW5kYXRpb24kKExpYnJhcnlDb25maWdTdWZmaXgpLmxpYiINCisJCQkJQWRkaXRpb25h bERlcGVuZGVuY2llcz0iSmF2YVNjcmlwdENvcmUkKFdlYktpdERMTENvbmZpZ1N1ZmZpeCkubGli IENvcmVHcmFwaGljcyQoTGlicmFyeUNvbmZpZ1N1ZmZpeCkubGliIENvcmVGb3VuZGF0aW9uJChM aWJyYXJ5Q29uZmlnU3VmZml4KS5saWIiDQogCQkJCUFkZGl0aW9uYWxMaWJyYXJ5RGlyZWN0b3Jp ZXM9IiINCiAJCQkJU3ViU3lzdGVtPSIxIg0KIAkJCS8+DQo=