40963 2010-06-21 19:20:18 -0700 [EFL] Remove warning message during the EFLWebKit build 2010-06-21 21:32:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 40965 P2 Trivial --- 0 gyuyoung.kim webkit-unassigned lucas.de.marchi oldest_to_newest 241060 0 gyuyoung.kim 2010-06-21 19:20:18 -0700 There are warning message when EFLWebKit is built. [100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view.cpp.o [100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view_single.c.o /home/gyuyoung/webkit/WebKit-EWebLauncher/WebKit/efl/ewk/ewk_view.cpp: In function ‘uint64_t ewk_view_exceeded_database_quota(Evas_Object*, Evas_Object*, const char*, uint64_t, uint64_t)’: /home/gyuyoung/webkit/WebKit-EWebLauncher/WebKit/efl/ewk/ewk_view.cpp:3452: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 7 has type ‘uint64_t’ /home/gyuyoung/webkit/WebKit-EWebLauncher/WebKit/efl/ewk/ewk_view.cpp:3452: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 8 has type ‘uint64_t’ Linking CXX shared library libewebkit.so [100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view_single.c.o /home/gyuyoung/webkit/WebKit-EWebLauncher/WebKit/efl/ewk/ewk_view.cpp: In function ‘uint64_t ewk_view_exceeded_database_quota(Evas_Object*, Evas_Object*, const char*, uint64_t, uint64_t)’: /home/gyuyoung/webkit/WebKit-EWebLauncher/WebKit/efl/ewk/ewk_view.cpp:3452: warning: format ‘%u’ expects type ‘unsigned int’, but argument 7 has type ‘uint64_t’ /home/gyuyoung/webkit/WebKit-EWebLauncher/WebKit/efl/ewk/ewk_view.cpp:3452: warning: format ‘%u’ expects type ‘unsigned int’, but argument 8 has type ‘uint64_t’ 241062 1 59324 gyuyoung.kim 2010-06-21 19:24:14 -0700 Created attachment 59324 Patch It seems that uint64_t is defined as "unsigned long long". So, I change the %lu with %llu. 241074 2 gyuyoung.kim 2010-06-21 19:45:35 -0700 Opps, Lukas already made a bug for this. *** This bug has been marked as a duplicate of bug 40965 *** 241079 3 lucas.de.marchi 2010-06-21 20:21:00 -0700 (In reply to comment #1) > Created an attachment (id=59324) [details] > Patch > > It seems that uint64_t is defined as "unsigned long long". So, I change the %lu with %llu. %llu will be wrong in 64-bit systems. To improve portability, we will need inttypes.h. 59324 2010-06-21 19:24:14 -0700 2010-06-21 21:32:50 -0700 Patch patch.txt text/plain 1114 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE1OTcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMDYtMjEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBSZW1vdmUgd2FybmluZyBtZXNzYWdlIGR1cmluZyB0aGUgRUZMV2ViS2l0IGJ1aWxk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA5NjMK KworICAgICAgICAqIGVmbC9ld2svZXdrX3ZpZXcuY3BwOiAKKyAgICAgICAgKGV3a192aWV3X2V4 Y2VlZGVkX2RhdGFiYXNlX3F1b3RhKToKKwogMjAxMC0wNi0xOCAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCklu ZGV4OiBXZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuY3BwCShyZXZpc2lvbiA2MTUzNikKKysrIFdlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ0OSw3ICszNDQ5LDcgQEAgdWludDY0X3Qg ZXdrX3ZpZXdfZXhjZWVkZWRfZGF0YWJhc2VfcXVvdAogICAgIGlmICghc2QtPmFwaS0+ZXhjZWVk ZWRfZGF0YWJhc2VfcXVvdGEpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgRVJSKCIjIyMjIyAl bHUgJWx1IiwgY3VycmVudF9zaXplLCBleHBlY3RlZF9zaXplKTsKKyAgICBFUlIoIiMjIyMjICVs bHUgJWxsdSIsIGN1cnJlbnRfc2l6ZSwgZXhwZWN0ZWRfc2l6ZSk7CiAgICAgcmV0dXJuIHNkLT5h cGktPmV4Y2VlZGVkX2RhdGFiYXNlX3F1b3RhKHNkLCBmcmFtZSwgZGF0YWJhc2VOYW1lLCBjdXJy ZW50X3NpemUsIGV4cGVjdGVkX3NpemUpOwogfQogCg==