40962 2010-06-21 19:08:16 -0700 webkit-patch should refuse to run under Win32 Python 2010-08-11 06:14:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth commit-queue eric levin webkit.review.bot oldest_to_newest 241052 0 dpranke 2010-06-21 19:08:16 -0700 webkit-patch should refuse to run under Win32 Python 241054 1 59322 dpranke 2010-06-21 19:09:59 -0700 Created attachment 59322 Patch 241056 2 dpranke 2010-06-21 19:11:25 -0700 Given that there are lots of places in webkit-patch's code that assume unix-style filenames (forward slashes), webkit-patch fails with weird file-not-found errors when run under a native windows Python. It would be nice if we just trapped this and errored out at the beginning, rather than producing unpredictable errors. 241070 3 59326 dpranke 2010-06-21 19:39:21 -0700 Created attachment 59326 Patch 250264 4 59326 eric 2010-07-12 20:12:14 -0700 Comment on attachment 59326 Patch OK. 263008 5 59326 abarth 2010-08-10 22:24:52 -0700 Comment on attachment 59326 Patch That's too bad. 263062 6 59326 commit-queue 2010-08-10 23:19:51 -0700 Comment on attachment 59326 Patch Clearing flags on attachment: 59326 Committed r65126: <http://trac.webkit.org/changeset/65126> 263063 7 commit-queue 2010-08-10 23:19:56 -0700 All reviewed patches have been landed. Closing bug. 263209 8 webkit.review.bot 2010-08-11 06:14:17 -0700 http://trac.webkit.org/changeset/65126 might have broken Leopard Intel Debug (Tests) 59322 2010-06-21 19:09:59 -0700 2010-06-21 19:39:18 -0700 Patch bug-40962-20100621190958.patch text/plain 1625 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiM2YzMzM1MGY1MWI0ZDQwNDNmMDFhZGJjOGNkNzFjZjA2NmYzNzQ5Li45NmQyMDNk ZTQ2MzNjZjYxMGE4MGIzMDcyNWIxMmY1M2U0ZDExZGYyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDYtMjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0LXBhdGNoIHNo b3VsZCByZWZ1c2UgdG8gcnVuIHVuZGVyIFdpbjMyIFB5dGhvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA5NjIKKworICAgICAgICBHaXZlbiB0aGF0 IHRoZXJlIGFyZSBsb3RzIG9mIHBsYWNlcyBpbiB3ZWJraXQtcGF0Y2gncyBjb2RlIHRoYXQKKyAg ICAgICAgYXNzdW1lIHVuaXgtc3R5bGUgZmlsZW5hbWVzIChmb3J3YXJkIHNsYXNoZXMpLCB3ZWJr aXQtcGF0Y2ggZmFpbHMKKyAgICAgICAgd2l0aCB3ZWlyZCBmaWxlLW5vdC1mb3VuZCBlcnJvcnMg d2hlbiBydW4gdW5kZXIgYSBuYXRpdmUgd2luZG93cworICAgICAgICBQeXRob24uIEl0IHdvdWxk IGJlIG5pY2UgaWYgd2UganVzdCB0cmFwcGVkIHRoaXMgYW5kIGVycm9yZWQgb3V0CisgICAgICAg IGF0IHRoZSBiZWdpbm5pbmcsIHJhdGhlciB0aGFuIHByb2R1Y2luZyB1bnByZWRpY3RhYmxlIGVy cm9ycy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0LXBhdGNoOgorCiAyMDEwLTA2LTIxICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0LXBhdGNoIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKaW5kZXggODMwMGI5 ZmFmMTZhZTYzNjcwODYyNzFkNDlkMTQ3ZjM0N2U4MThiMS4uMGJhZWQ0NjJjYTdlNmEwNGE3MDk2 Yzg3ZjYyNDg4ZGFhYTk0NGM4YSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXQtcGF0Y2gKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKQEAgLTUwLDYg KzUwLDExIEBAIGRlZiBtYWluKCk6CiAgICAgY29uZmlndXJlX2xvZ2dpbmcobG9nZ2luZ19sZXZl bD1sb2dnaW5nX2xldmVsKQogCiAgICAgdmVyc2lvbmluZy5jaGVja192ZXJzaW9uKCkKKyAgICAK KyAgICBpZiBzeXMucGxhdGZvcm0gPT0gIndpbjMyIjoKKyAgICAgICAgbG9nLmVycm9yKCJ3ZWJr aXQtcGF0Y2ggaXMgb25seSBzdXBwb3J0ZWQgdW5kZXIgQ3lnd2luIFB5dGhvbiwgbm90ICIKKyAg ICAgICAgICAgICAgICAgICJXaW4zMiBQeXRob24iKSAgICAgICAgCisgICAgICAgIHN5cy5leGl0 KDEpCiAKICAgICAjIEltcG9ydCB3ZWJraXQtcGF0Y2ggY29kZSBvbmx5IGFmdGVyIHZlcnNpb24t Y2hlY2tpbmcgc28gdGhhdAogICAgICMgc2NyaXB0IGRvZXNuJ3QgZXJyb3Igb3V0IGJlZm9yZSBo YXZpbmcgYSBjaGFuY2UgdG8gcmVwb3J0IHRoZQo= 59326 2010-06-21 19:39:21 -0700 2010-08-10 23:19:51 -0700 Patch bug-40962-20100621193920.patch text/plain 1896 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiM2YzMzM1MGY1MWI0ZDQwNDNmMDFhZGJjOGNkNzFjZjA2NmYzNzQ5Li45NmQyMDNk ZTQ2MzNjZjYxMGE4MGIzMDcyNWIxMmY1M2U0ZDExZGYyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDYtMjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0LXBhdGNoIHNo b3VsZCByZWZ1c2UgdG8gcnVuIHVuZGVyIFdpbjMyIFB5dGhvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA5NjIKKworICAgICAgICBHaXZlbiB0aGF0 IHRoZXJlIGFyZSBsb3RzIG9mIHBsYWNlcyBpbiB3ZWJraXQtcGF0Y2gncyBjb2RlIHRoYXQKKyAg ICAgICAgYXNzdW1lIHVuaXgtc3R5bGUgZmlsZW5hbWVzIChmb3J3YXJkIHNsYXNoZXMpLCB3ZWJr aXQtcGF0Y2ggZmFpbHMKKyAgICAgICAgd2l0aCB3ZWlyZCBmaWxlLW5vdC1mb3VuZCBlcnJvcnMg d2hlbiBydW4gdW5kZXIgYSBuYXRpdmUgd2luZG93cworICAgICAgICBQeXRob24uIEl0IHdvdWxk IGJlIG5pY2UgaWYgd2UganVzdCB0cmFwcGVkIHRoaXMgYW5kIGVycm9yZWQgb3V0CisgICAgICAg IGF0IHRoZSBiZWdpbm5pbmcsIHJhdGhlciB0aGFuIHByb2R1Y2luZyB1bnByZWRpY3RhYmxlIGVy cm9ycy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0LXBhdGNoOgorCiAyMDEwLTA2LTIxICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0LXBhdGNoIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKaW5kZXggODMwMGI5 ZmFmMTZhZTYzNjcwODYyNzFkNDlkMTQ3ZjM0N2U4MThiMS4uMDA3ZjkxOWRlYThmODM1MjkzYWY1 MDFiNmFhNTExYzE3MTg3MTU2MSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXQtcGF0Y2gKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2gKQEAgLTM4LDYg KzM4LDcgQEAgaW1wb3J0IHN5cwogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmxvZ3V0aWxz IGltcG9ydCBjb25maWd1cmVfbG9nZ2luZwogaW1wb3J0IHdlYmtpdHB5LnB5dGhvbjI0LnZlcnNp b25pbmcgYXMgdmVyc2lvbmluZwogCitfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoIndlYmtpdC1w YXRjaCIpCiAKIGRlZiBtYWluKCk6CiAgICAgIyBUaGlzIGlzIGEgaGFjayB0byBsZXQgdXMgZW5h YmxlIERFQlVHIGxvZ2dpbmcgYXMgZWFybHkgYXMgcG9zc2libGUuCkBAIC01MCw2ICs1MSwxMSBA QCBkZWYgbWFpbigpOgogICAgIGNvbmZpZ3VyZV9sb2dnaW5nKGxvZ2dpbmdfbGV2ZWw9bG9nZ2lu Z19sZXZlbCkKIAogICAgIHZlcnNpb25pbmcuY2hlY2tfdmVyc2lvbigpCisgICAgCisgICAgaWYg c3lzLnBsYXRmb3JtID09ICJ3aW4zMiI6CisgICAgICAgIF9sb2cuZmF0YWwoIndlYmtpdC1wYXRj aCBpcyBvbmx5IHN1cHBvcnRlZCB1bmRlciBDeWd3aW4gUHl0aG9uLCAiCisgICAgICAgICAgICAg ICAgICAgIm5vdCBXaW4zMiBQeXRob24iKQorICAgICAgICBzeXMuZXhpdCgxKQogCiAgICAgIyBJ bXBvcnQgd2Via2l0LXBhdGNoIGNvZGUgb25seSBhZnRlciB2ZXJzaW9uLWNoZWNraW5nIHNvIHRo YXQKICAgICAjIHNjcmlwdCBkb2Vzbid0IGVycm9yIG91dCBiZWZvcmUgaGF2aW5nIGEgY2hhbmNl IHRvIHJlcG9ydCB0aGUK