40931 2010-06-21 11:56:22 -0700 [CMake] Remove unused variable in EFL build system 2010-06-25 05:13:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi barbieri commit-queue leandro lucas.de.marchi oldest_to_newest 240797 0 lucas.de.marchi 2010-06-21 11:56:22 -0700 [CMake] Remove unused variable in EFL build system 240799 1 59270 lucas.de.marchi 2010-06-21 11:58:27 -0700 Created attachment 59270 Patch 240855 2 leandro 2010-06-21 13:39:29 -0700 I'm not a reviewer, this is an informal review. LGTM. 241841 3 59270 gustavo 2010-06-23 07:19:06 -0700 Comment on attachment 59270 Patch IMO Leandro should commit these build fixes with no or just informal review, for you. Build changes only need review if they are changing something in the way the build works, or how the library is built, or affecting other ports. Build fixes should be just committed. 242964 4 59270 commit-queue 2010-06-25 05:13:35 -0700 Comment on attachment 59270 Patch Clearing flags on attachment: 59270 Committed r61852: <http://trac.webkit.org/changeset/61852> 242966 5 commit-queue 2010-06-25 05:13:40 -0700 All reviewed patches have been landed. Closing bug. 59270 2010-06-21 11:58:27 -0700 2010-06-25 05:13:35 -0700 Patch bug-40931-20100621155912.patch text/plain 1312 lucas.de.marchi ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiMThkNTViNGI2ZTYzNjQyMDhkNDljY2YyNTg4ZjJiMjQ3ZmE4MTg1Li43 OTZhNGM3MTE0N2ViM2E0MDY4ZmM0ZTFmMTEwZWFmZGI3ZGNiNWQzIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDYtMjEgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hp QHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtDTWFrZV0gUmVtb3ZlIHVudXNlZCB2YXJpYWJsZSBpbiBFRkwgYnVpbGQgc3lz dGVtLiBJdCB3YXMgcHJldmlvdXNseQorICAgICAgICBiZWluZyB1c2VkIHRvIHNldCB0aGUgZmxh Z3Mgb2YgZWFjaCBwb3J0IGJ1dCBpdCB3YXMgc3VwZXJzZWRlZCBieQorICAgICAgICBvdGhlciBm bGFncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQw OTMxCisKKyAgICAgICAgKiBqc2MvQ01ha2VMaXN0cy50eHQ6CisKIDIwMTAtMDYtMTggIEpvY2Vs eW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2pzYy9D TWFrZUxpc3RzLnR4dCBiL0phdmFTY3JpcHRDb3JlL2pzYy9DTWFrZUxpc3RzLnR4dAppbmRleCBj YzM5ZTE0MTlhNWYzYjhjYThmODIwODc1N2U5NDU0ZDEyODljMWNiLi45NzBjMjBmNDBiYWNjZjNl YzBjZWUxNjA5ZjViMGY4MDc5ZGFkNTEzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qc2Mv Q01ha2VMaXN0cy50eHQKKysrIGIvSmF2YVNjcmlwdENvcmUvanNjL0NNYWtlTGlzdHMudHh0CkBA IC05LDExICs5LDggQEAgU0VUKEpTQ19MSUJSQVJJRVMKICAgICAke0phdmFTY3JpcHRDb3JlX0xJ QlJBUllfTkFNRX0KICkKIAotCi1TRVQoSlNDX1BPUlRfRkxBR1MgKQogSU5DTFVERV9JRl9FWElT VFMoJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L2pzYy9DTWFrZUxpc3RzJHtQT1JUfS50eHQpCiAKLQog V0VCS0lUX1dSQVBfU09VUkNFTElTVCgke0pTQ19TT1VSQ0VTfSkKIElOQ0xVREVfRElSRUNUT1JJ RVMoLi8gJHtKYXZhU2NyaXB0Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKIEFERF9FWEVDVVRB QkxFKCR7SlNDX0VYRUNVVEFCTEVfTkFNRX0gJHtKU0NfSEVBREVSU30gJHtKU0NfU09VUkNFU30p Cg==