40928 2010-06-21 10:54:01 -0700 Remove unused dictionary ivars from WebBasePluginPackage 2010-06-21 11:02:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 240778 0 andersca 2010-06-21 10:54:01 -0700 Remove now unused dictionary ivars 240780 1 59264 andersca 2010-06-21 10:55:38 -0700 Created attachment 59264 Patch 240781 2 59264 sam 2010-06-21 10:57:35 -0700 Comment on attachment 59264 Patch r=me. Nice. 240783 3 andersca 2010-06-21 11:02:50 -0700 Committed r61558: <http://trac.webkit.org/changeset/61558> 59264 2010-06-21 10:55:38 -0700 2010-06-21 10:57:35 -0700 Patch bug-40928-20100621105536.patch text/plain 7279 andersca SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2MTU1NykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMjEgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW1vdmUgdW51c2VkIGRpY3Rpb25hcnkgaXZhcnMgZnJvbSBXZWJCYXNlUGx1 Z2luUGFja2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDA5MjgKKworICAgICAgICAqIFBsdWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2UuaDoKKyAg ICAgICAgKiBQbHVnaW5zL1dlYkJhc2VQbHVnaW5QYWNrYWdlLm1tOgorICAgICAgICAoLVtXZWJC YXNlUGx1Z2luUGFja2FnZSBnZXRQbHVnaW5JbmZvRnJvbVBMaXN0c10pOgorICAgICAgICAoLVtX ZWJCYXNlUGx1Z2luUGFja2FnZSBkZWFsbG9jXSk6CisgICAgICAgICogUGx1Z2lucy9XZWJOZXRz Y2FwZVBsdWdpblBhY2thZ2UubW06CisgICAgICAgICgtW1dlYk5ldHNjYXBlUGx1Z2luUGFja2Fn ZSBnZXRQbHVnaW5JbmZvRnJvbVJlc291cmNlc10pOgorCiAyMDEwLTA2LTIxICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4CkluZGV4OiBXZWJLaXQv bWFjL1BsdWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv bWFjL1BsdWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2UuaAkocmV2aXNpb24gNjE1NTApCisrKyBX ZWJLaXQvbWFjL1BsdWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2UuaAkod29ya2luZyBjb3B5KQpA QCAtNjQsOSArNjQsNiBAQCBAaW50ZXJmYWNlIFdlYkJhc2VQbHVnaW5QYWNrYWdlIDogTlNPYmpl CiAKICAgICBDRkJ1bmRsZVJlZiBjZkJ1bmRsZTsKIAotICAgIE5TRGljdGlvbmFyeSAqTUlNRVRv RGVzY3JpcHRpb247Ci0gICAgTlNEaWN0aW9uYXJ5ICpNSU1FVG9FeHRlbnNpb25zOwotICAgIAog ICAgIEJQX0NyZWF0ZVBsdWdpbk1JTUVUeXBlc1ByZWZlcmVuY2VzRnVuY1B0ciBCUF9DcmVhdGVQ bHVnaW5NSU1FVHlwZXNQcmVmZXJlbmNlczsKIH0KIApAQCAtOTAsMTIgKzg3LDggQEAgQGludGVy ZmFjZSBXZWJCYXNlUGx1Z2luUGFja2FnZSA6IE5TT2JqZQogLSAoQk9PTClzdXBwb3J0c0V4dGVu c2lvbjooY29uc3QgV2ViQ29yZTo6U3RyaW5nJilleHRlbnNpb247CiAtIChCT09MKXN1cHBvcnRz TUlNRVR5cGU6KGNvbnN0IFdlYkNvcmU6OlN0cmluZyYpTUlNRVR5cGU7CiAKLS0gKE5TU3RyaW5n ICopZGVzY3JpcHRpb25Gb3JNSU1FVHlwZTooTlNTdHJpbmcgKilNSU1FVHlwZTsKIC0gKE5TU3Ry aW5nICopTUlNRVR5cGVGb3JFeHRlbnNpb246KGNvbnN0IFdlYkNvcmU6OlN0cmluZyYpZXh0ZW5z aW9uOwogCi0tICh2b2lkKXNldE1JTUVUb0Rlc2NyaXB0aW9uRGljdGlvbmFyeTooTlNEaWN0aW9u YXJ5ICopTUlNRVRvRGVzY3JpcHRpb25EaWN0aW9uYXJ5OwotLSAodm9pZClzZXRNSU1FVG9FeHRl bnNpb25zRGljdGlvbmFyeTooTlNEaWN0aW9uYXJ5ICopTUlNRVRvRXh0ZW5zaW9uc0RpY3Rpb25h cnk7Ci0KIC0gKEJPT0wpaXNRdWlja1RpbWVQbHVnSW47CiAtIChCT09MKWlzSmF2YVBsdWdJbjsK IApJbmRleDogV2ViS2l0L21hYy9QbHVnaW5zL1dlYkJhc2VQbHVnaW5QYWNrYWdlLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlUGx1Z2luUGFja2FnZS5tbQkocmV2 aXNpb24gNjE1NTApCisrKyBXZWJLaXQvbWFjL1BsdWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2Uu bW0JKHdvcmtpbmcgY29weSkKQEAgLTIwNiw4ICsyMDYsNiBAQCAtIChCT09MKWdldFBsdWdpbklu Zm9Gcm9tUExpc3RzCiAgICAgICAgICAgICByZXR1cm4gTk87CiAgICAgfQogCi0gICAgTlNNdXRh YmxlRGljdGlvbmFyeSAqTUlNRVRvRXh0ZW5zaW9uc0RpY3Rpb25hcnkgPSBbTlNNdXRhYmxlRGlj dGlvbmFyeSBkaWN0aW9uYXJ5XTsKLSAgICBOU011dGFibGVEaWN0aW9uYXJ5ICpNSU1FVG9EZXNj cmlwdGlvbkRpY3Rpb25hcnkgPSBbTlNNdXRhYmxlRGljdGlvbmFyeSBkaWN0aW9uYXJ5XTsKICAg ICBOU0VudW1lcmF0b3IgKmtleUVudW1lcmF0b3IgPSBbTUlNRVR5cGVzIGtleUVudW1lcmF0b3Jd OwogICAgIE5TRGljdGlvbmFyeSAqTUlNRURpY3Rpb25hcnk7CiAgICAgTlNTdHJpbmcgKk1JTUUs ICpkZXNjcmlwdGlvbjsKQEAgLTIzMSw5ICsyMjksNiBAQCAtIChCT09MKWdldFBsdWdpbkluZm9G cm9tUExpc3RzCiAgICAgICAgICAgICBleHRlbnNpb25zID0gW05TQXJyYXkgYXJyYXlXaXRoT2Jq ZWN0OkAiIl07CiAKICAgICAgICAgbWltZUNsYXNzSW5mby50eXBlID0gU3RyaW5nKE1JTUUpLmxv d2VyKCk7Ci0gICAgICAgIE1JTUUgPSBbTUlNRSBsb3dlcmNhc2VTdHJpbmddOwotCi0gICAgICAg IFtNSU1FVG9FeHRlbnNpb25zRGljdGlvbmFyeSBzZXRPYmplY3Q6ZXh0ZW5zaW9ucyBmb3JLZXk6 TUlNRV07CiAKICAgICAgICAgZGVzY3JpcHRpb24gPSBbTUlNRURpY3Rpb25hcnkgb2JqZWN0Rm9y S2V5OldlYlBsdWdpblR5cGVEZXNjcmlwdGlvbktleV07CiAgICAgICAgIG1pbWVDbGFzc0luZm8u ZGVzYyA9IGRlc2NyaXB0aW9uOwpAQCAtMjQxLDEzICsyMzYsOCBAQCAtIChCT09MKWdldFBsdWdp bkluZm9Gcm9tUExpc3RzCiAgICAgICAgIG1pbWVUeXBlcy5hcHBlbmQobWltZUNsYXNzSW5mbyk7 CiAgICAgICAgIGlmICghZGVzY3JpcHRpb24pCiAgICAgICAgICAgICBkZXNjcmlwdGlvbiA9IEAi IjsKLQotICAgICAgICBbTUlNRVRvRGVzY3JpcHRpb25EaWN0aW9uYXJ5IHNldE9iamVjdDpkZXNj cmlwdGlvbiBmb3JLZXk6TUlNRV07CiAgICAgfQogCi0gICAgW3NlbGYgc2V0TUlNRVRvRXh0ZW5z aW9uc0RpY3Rpb25hcnk6TUlNRVRvRXh0ZW5zaW9uc0RpY3Rpb25hcnldOwotICAgIFtzZWxmIHNl dE1JTUVUb0Rlc2NyaXB0aW9uRGljdGlvbmFyeTpNSU1FVG9EZXNjcmlwdGlvbkRpY3Rpb25hcnld OwotCiAgICAgTlNTdHJpbmcgKmZpbGVuYW1lID0gW3NlbGYgZmlsZW5hbWVdOwogCiAgICAgTlNT dHJpbmcgKnRoZU5hbWUgPSBbc2VsZiBfb2JqZWN0Rm9ySW5mb0RpY3Rpb25hcnlLZXk6V2ViUGx1 Z2luTmFtZUtleV07CkBAIC0yNzYsOSArMjY2LDYgQEAgLSAodm9pZClkZWFsbG9jCiAgICAgQVNT RVJUKCFwbHVnaW5EYXRhYmFzZXMgfHwgW3BsdWdpbkRhdGFiYXNlcyBjb3VudF0gPT0gMCk7CiAg ICAgW3BsdWdpbkRhdGFiYXNlcyByZWxlYXNlXTsKICAgICAKLSAgICBbTUlNRVRvRGVzY3JpcHRp b24gcmVsZWFzZV07Ci0gICAgW01JTUVUb0V4dGVuc2lvbnMgcmVsZWFzZV07Ci0KICAgICBpZiAo Y2ZCdW5kbGUpCiAgICAgICAgIENGUmVsZWFzZShjZkJ1bmRsZSk7CiAgICAgCkBAIC0zMjIsMTEg KzMwOSw2IEBAIC0gKGNvbnN0IFZlY3RvcjxXZWJDb3JlOjpNaW1lQ2xhc3NJbmZvPiYKICAgICBy ZXR1cm4gbWltZVR5cGVzOwogfQogCi0tIChOU0FycmF5ICopTUlNRVR5cGVzCi17Ci0gICAgcmV0 dXJuIFtNSU1FVG9FeHRlbnNpb25zIGFsbEtleXNdOwotfQotCiAtIChCT09MKXN1cHBvcnRzRXh0 ZW5zaW9uOihjb25zdCBTdHJpbmcmKWV4dGVuc2lvbgogewogICAgIEFTU0VSVChleHRlbnNpb24u bG93ZXIoKSA9PSBleHRlbnNpb24pOwpAQCAtMzUzLDExICszMzUsNiBAQCAtIChCT09MKXN1cHBv cnRzTUlNRVR5cGU6KGNvbnN0IFdlYkNvcmU6CiAgICAgcmV0dXJuIE5POwogfQogCi0tIChOU1N0 cmluZyAqKWRlc2NyaXB0aW9uRm9yTUlNRVR5cGU6KE5TU3RyaW5nICopTUlNRVR5cGUKLXsKLSAg ICByZXR1cm4gW01JTUVUb0Rlc2NyaXB0aW9uIG9iamVjdEZvcktleTpNSU1FVHlwZV07Ci19Ci0K IC0gKE5TU3RyaW5nICopTUlNRVR5cGVGb3JFeHRlbnNpb246KGNvbnN0IFN0cmluZyYpZXh0ZW5z aW9uCiB7CiAgICAgQVNTRVJUKGV4dGVuc2lvbi5sb3dlcigpID09IGV4dGVuc2lvbik7CkBAIC0z NzMsMjkgKzM1MCw2IEBAIC0gKE5TU3RyaW5nICopTUlNRVR5cGVGb3JFeHRlbnNpb246KGNvbnMK ICAgICByZXR1cm4gbmlsOwogfQogCi0tIChOU0FycmF5ICopZXh0ZW5zaW9uc0Zvck1JTUVUeXBl OihOU1N0cmluZyAqKU1JTUVUeXBlCi17Ci0gICAgcmV0dXJuIFtNSU1FVG9FeHRlbnNpb25zIG9i amVjdEZvcktleTpNSU1FVHlwZV07Ci19Ci0KLS0gKHZvaWQpc2V0TUlNRVRvRGVzY3JpcHRpb25E aWN0aW9uYXJ5OihOU0RpY3Rpb25hcnkgKilNSU1FVG9EZXNjcmlwdGlvbkRpY3Rpb25hcnkKLXsK LSAgICBbTUlNRVRvRGVzY3JpcHRpb24gcmVsZWFzZV07Ci0gICAgTUlNRVRvRGVzY3JpcHRpb24g PSBbTUlNRVRvRGVzY3JpcHRpb25EaWN0aW9uYXJ5IHJldGFpbl07Ci19Ci0KLS0gKHZvaWQpc2V0 TUlNRVRvRXh0ZW5zaW9uc0RpY3Rpb25hcnk6KE5TRGljdGlvbmFyeSAqKU1JTUVUb0V4dGVuc2lv bnNEaWN0aW9uYXJ5Ci17Ci0gICAgW01JTUVUb0V4dGVuc2lvbnMgcmVsZWFzZV07Ci0gICAgTUlN RVRvRXh0ZW5zaW9ucyA9IFtNSU1FVG9FeHRlbnNpb25zRGljdGlvbmFyeSByZXRhaW5dOwotfQot Ci0tIChOU1N0cmluZyAqKWRlc2NyaXB0aW9uCi17Ci0gICAgcmV0dXJuIFtOU1N0cmluZyBzdHJp bmdXaXRoRm9ybWF0OkAibmFtZTogJUBcbnBhdGg6ICVAXG5taW1lVHlwZXM6XG4lQFxucGx1Z2lu RGVzY3JpcHRpb246JUAiLAotICAgICAgICAoTlNTdHJpbmcgKiluYW1lLCAoTlNTdHJpbmcgKilw YXRoLCBbTUlNRVRvRXh0ZW5zaW9ucyBkZXNjcmlwdGlvbl0sIFtNSU1FVG9EZXNjcmlwdGlvbiBk ZXNjcmlwdGlvbl0sIChOU1N0cmluZyAqKXBsdWdpbkRlc2NyaXB0aW9uXTsKLX0KLQogLSAoQk9P TClpc1F1aWNrVGltZVBsdWdJbgogewogICAgIGNvbnN0IFN0cmluZyYgYnVuZGxlSWRlbnRpZmll ciA9IFtzZWxmIGJ1bmRsZUlkZW50aWZpZXJdOwpJbmRleDogV2ViS2l0L21hYy9QbHVnaW5zL1dl Yk5ldHNjYXBlUGx1Z2luUGFja2FnZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL1BsdWdp bnMvV2ViTmV0c2NhcGVQbHVnaW5QYWNrYWdlLm1tCShyZXZpc2lvbiA2MTU1MCkKKysrIFdlYktp dC9tYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblBhY2thZ2UubW0JKHdvcmtpbmcgY29weSkK QEAgLTE2MCw5ICsxNjAsNiBAQCAtIChCT09MKWdldFBsdWdpbkluZm9Gcm9tUmVzb3VyY2VzCiAg ICAgTlNBcnJheSAqZXh0ZW5zaW9uczsKICAgICB1bnNpZ25lZCBpOwogICAgIAotICAgIE5TTXV0 YWJsZURpY3Rpb25hcnkgKk1JTUVUb0V4dGVuc2lvbnNEaWN0aW9uYXJ5ID0gW05TTXV0YWJsZURp Y3Rpb25hcnkgZGljdGlvbmFyeV07Ci0gICAgTlNNdXRhYmxlRGljdGlvbmFyeSAqTUlNRVRvRGVz Y3JpcHRpb25EaWN0aW9uYXJ5ID0gW05TTXV0YWJsZURpY3Rpb25hcnkgZGljdGlvbmFyeV07Ci0K ICAgICBmb3IgKGk9MTsgMTsgaSs9MikgewogICAgICAgICBNSU1FID0gW1tzZWxmIHN0cmluZ0Zv clN0cmluZ0xpc3RJRDpNSU1FTGlzdFN0cmluZ1N0cmluZ051bWJlcgogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBhbmRJbmRleDppXSBsb3dlcmNhc2VTdHJpbmddOwpAQCAtMTc3 LDI3ICsxNzQsMTUgQEAgLSAoQk9PTClnZXRQbHVnaW5JbmZvRnJvbVJlc291cmNlcwogICAgICAg ICAgICAgZXh0ZW5zaW9ucyA9IFtleHRlbnNpb25zTGlzdCBjb21wb25lbnRzU2VwYXJhdGVkQnlT dHJpbmc6QCIsIl07CiAgICAgICAgICAgICBmb3IgKE5TVUludGVnZXIgaiA9IDA7IGogPCBbZXh0 ZW5zaW9ucyBjb3VudF07ICsraikKICAgICAgICAgICAgICAgICBtaW1lQ2xhc3NJbmZvLmV4dGVu c2lvbnMuYXBwZW5kKChOU1N0cmluZyAqKVtleHRlbnNpb25zIG9iamVjdEF0SW5kZXg6al0pOwot Ci0gICAgICAgICAgICBbTUlNRVRvRXh0ZW5zaW9uc0RpY3Rpb25hcnkgc2V0T2JqZWN0OmV4dGVu c2lvbnMgZm9yS2V5Ok1JTUVdOwotICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIC8vIERSTSBh bmQgV01QIGNsYWltIE1JTUVzIHdpdGhvdXQgZXh0ZW5zaW9ucy4gVXNlIGEgQCIiIGV4dGVuc2lv biBpbiB0aGlzIGNhc2UuCi0gICAgICAgICAgICBbTUlNRVRvRXh0ZW5zaW9uc0RpY3Rpb25hcnkg c2V0T2JqZWN0OltOU0FycmF5IGFycmF5V2l0aE9iamVjdDpAIiJdIGZvcktleTpNSU1FXTsKKyAg ICAgICAgfQogICAgICAgICAKICAgICAgICAgZGVzY3JpcHRpb24gPSBbc2VsZiBzdHJpbmdGb3JT dHJpbmdMaXN0SUQ6TUlNRURlc2NyaXB0aW9uU3RyaW5nTnVtYmVyCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGFuZEluZGV4OltNSU1FVG9FeHRlbnNpb25zRGljdGlv bmFyeSBjb3VudF1dOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBh bmRJbmRleDptaW1lVHlwZXMuc2l6ZSgpXTsKICAgICAgICAgbWltZUNsYXNzSW5mby5kZXNjID0g ZGVzY3JpcHRpb247CiAKLSAgICAgICAgaWYgKGRlc2NyaXB0aW9uKQotICAgICAgICAgICAgW01J TUVUb0Rlc2NyaXB0aW9uRGljdGlvbmFyeSBzZXRPYmplY3Q6ZGVzY3JpcHRpb24gZm9yS2V5Ok1J TUVdOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBbTUlNRVRvRGVzY3JpcHRpb25EaWN0aW9u YXJ5IHNldE9iamVjdDpAIiIgZm9yS2V5Ok1JTUVdOwotICAgICAgICAKICAgICAgICAgbWltZVR5 cGVzLmFwcGVuZChtaW1lQ2xhc3NJbmZvKTsKICAgICB9CiAKLSAgICBbc2VsZiBzZXRNSU1FVG9E ZXNjcmlwdGlvbkRpY3Rpb25hcnk6TUlNRVRvRGVzY3JpcHRpb25EaWN0aW9uYXJ5XTsKLSAgICBb c2VsZiBzZXRNSU1FVG9FeHRlbnNpb25zRGljdGlvbmFyeTpNSU1FVG9FeHRlbnNpb25zRGljdGlv bmFyeV07Ci0KICAgICBOU1N0cmluZyAqZmlsZW5hbWUgPSBbc2VsZiBmaWxlbmFtZV07CiAgICAg CiAgICAgZGVzY3JpcHRpb24gPSBbc2VsZiBzdHJpbmdGb3JTdHJpbmdMaXN0SUQ6UGx1Z2luTmFt ZU9yRGVzY3JpcHRpb25TdHJpbmdOdW1iZXIgYW5kSW5kZXg6MV07Cg==