40923 2010-06-21 08:36:50 -0700 [EFL] Implement runOpenPanel method 2010-06-25 04:28:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi barbieri commit-queue gyuyoung.kim leandro lucas.de.marchi oldest_to_newest 240728 0 lucas.de.marchi 2010-06-21 08:36:50 -0700 FL] Implement runOpenPanel method 240729 1 59253 lucas.de.marchi 2010-06-21 08:37:45 -0700 Created attachment 59253 Patch 240862 2 leandro 2010-06-21 13:49:42 -0700 I'm not a reviewer, this is an informal review. LGTM. 242947 3 59253 commit-queue 2010-06-25 04:28:13 -0700 Comment on attachment 59253 Patch Clearing flags on attachment: 59253 Committed r61848: <http://trac.webkit.org/changeset/61848> 242948 4 commit-queue 2010-06-25 04:28:17 -0700 All reviewed patches have been landed. Closing bug. 59253 2010-06-21 08:37:45 -0700 2010-06-25 04:28:13 -0700 Patch bug-40923-20100621123830.patch text/plain 3685 lucas.de.marchi ZGlmZiAtLWdpdCBhL1dlYktpdC9DaGFuZ2VMb2cgYi9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDll YmRiNzgzZDRiZTM5NTRhMTEyZjEyZDE4NWQyN2RmYTRlNDQ3ZDMuLjY5ODI3ZmIwMTY2ZThhOGM5 NGU2NjBmNmQwNzk3ZGQ3ZTQ0ZjhkZTkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA2LTIxICBMdWNhcyBE ZSBNYXJjaGkgIDxsdWNhcy5kZW1hcmNoaUBwcm9mdXNpb24ubW9iaT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBJbXBsZW1lbnQgcnVuT3Bl blBhbmVsIG1ldGhvZC4gVGhlIGludGVyZmFjZSB3aXRoIGJyb3dzZXIgd2FzCisgICAgICAgIGFs cmVhZHkgaW1wbGVtZW50ZWQuIE5vdyB3ZSBhcmUgYWN0dWFsbHkgY2FsbGluZyBpdC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwOTIzCisKKyAgICAg ICAgKiBlZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNocm9tZUNsaWVudEVmbDo6cnVuT3BlblBhbmVsKTogaW1wbGVtZW50IG1ldGhvZC4K KyAgICAgICAgKiBlZmwvZXdrL2V3a19wcml2YXRlLmg6IGV4cG9ydCB0byBXZWJDb3JlU3VwcG9y dCB0aGUgbmVlZGVkIG1ldGhvZAorCiAyMDEwLTA2LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAt LWdpdCBhL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcCBiL1dl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAppbmRleCBiYzc1ZGRi ZDQwNGIzYmY4MTA1MjU4ZGFlMzMxMzAxYmZjNjkyYTJkLi41YzE0NzI5YmQ0YzQ3Nzc1ZTBlODJi ODM4MmUyNWM5MWJkYmZhZjRjIDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0 L0Nocm9tZUNsaWVudEVmbC5jcHAKKysrIGIvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJv bWVDbGllbnRFZmwuY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5jbHVkZSAiRGF0YWJhc2VUcmFj a2VyLmgiCiAjZW5kaWYKICNpbmNsdWRlICJFV2ViS2l0LmgiCisjaW5jbHVkZSAiRmlsZUNob29z ZXIuaCIKICNpbmNsdWRlICJGbG9hdFJlY3QuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRlci5oIgog I2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50RWZsLmgiCkBAIC0zNzgsNyArMzc5LDM1IEBAIHZv aWQgQ2hyb21lQ2xpZW50RWZsOjpleGNlZWRlZERhdGFiYXNlUXVvdGEoRnJhbWUqIGZyYW1lLCBj b25zdCBTdHJpbmcmIGRhdGFiYXNlCiAKIHZvaWQgQ2hyb21lQ2xpZW50RWZsOjpydW5PcGVuUGFu ZWwoRnJhbWUqIGZyYW1lLCBQYXNzUmVmUHRyPEZpbGVDaG9vc2VyPiBwcnBGaWxlQ2hvb3NlcikK IHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIFJlZlB0cjxGaWxlQ2hvb3Nlcj4gY2hvb3Nl ciA9IHBycEZpbGVDaG9vc2VyOworICAgIGJvb2wgY29uZmlybTsKKyAgICBFaW5hX0xpc3QqIHNl bGVjdGVkRmlsZW5hbWVzID0gMDsKKyAgICBFaW5hX0xpc3QqIHN1Z2dlc3RlZEZpbGVuYW1lcyA9 IDA7CisgICAgdm9pZCogZmlsZW5hbWU7CisgICAgVmVjdG9yPFN0cmluZz4gZmlsZW5hbWVzOwor CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGNob29zZXItPmZpbGVuYW1lcygpLnNpemUo KTsgaSsrKSB7CisgICAgICAgIENTdHJpbmcgc3RyID0gY2hvb3Nlci0+ZmlsZW5hbWVzKClbaV0u dXRmOCgpOworICAgICAgICBmaWxlbmFtZSA9IHN0cmR1cChzdHIuZGF0YSgpKTsKKyAgICAgICAg c3VnZ2VzdGVkRmlsZW5hbWVzID0gZWluYV9saXN0X2FwcGVuZChzdWdnZXN0ZWRGaWxlbmFtZXMs IGZpbGVuYW1lKTsKKyAgICB9CisKKyAgICBjb25maXJtID0gZXdrX3ZpZXdfcnVuX29wZW5fcGFu ZWwobV92aWV3LCBraXQoZnJhbWUpLCBjaG9vc2VyLT5hbGxvd3NNdWx0aXBsZUZpbGVzKCksIHN1 Z2dlc3RlZEZpbGVuYW1lcywgJnNlbGVjdGVkRmlsZW5hbWVzKTsKKyAgICBFSU5BX0xJU1RfRlJF RShzdWdnZXN0ZWRGaWxlbmFtZXMsIGZpbGVuYW1lKQorICAgICAgICBmcmVlKGZpbGVuYW1lKTsK KworICAgIGlmICghY29uZmlybSkKKyAgICAgICAgcmV0dXJuOworCisgICAgRUlOQV9MSVNUX0ZS RUUoc2VsZWN0ZWRGaWxlbmFtZXMsIGZpbGVuYW1lKSB7CisgICAgICAgIGZpbGVuYW1lcy5hcHBl bmQoKGNoYXIgKilmaWxlbmFtZSk7CisgICAgICAgIGZyZWUoZmlsZW5hbWUpOworICAgIH0KKwor ICAgIGlmIChjaG9vc2VyLT5hbGxvd3NNdWx0aXBsZUZpbGVzKCkpCisgICAgICAgIGNob29zZXIt PmNob29zZUZpbGVzKGZpbGVuYW1lcyk7CisgICAgZWxzZQorICAgICAgICBjaG9vc2VyLT5jaG9v c2VGaWxlKGZpbGVuYW1lc1swXSk7CiB9CiAKIHZvaWQgQ2hyb21lQ2xpZW50RWZsOjpmb3JtU3Rh dGVEaWRDaGFuZ2UoY29uc3QgTm9kZSopCmRpZmYgLS1naXQgYS9XZWJLaXQvZWZsL2V3ay9ld2tf cHJpdmF0ZS5oIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaAppbmRleCA1ZjY2ZmQ4NjI3 MDBkZmEwZTU0ZTU1MGE1YmU3NGVhNGQ3NjA5ZjNmLi5jMjE2MGIzZjU3NzhiMmEyOTVjMGU2Yjk0 YmM0NmIzYjNkZTJiY2E1IDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5o CisrKyBiL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTgzLDYgKzgzLDggQEAgRWlu YV9Cb29sICAgICAgICBld2tfdmlld19ydW5famF2YXNjcmlwdF9wcm9tcHQoRXZhc19PYmplY3Qg Km8sIEV2YXNfT2JqZWN0ICpmcmEKIEVpbmFfQm9vbCAgICAgICAgZXdrX3ZpZXdfc2hvdWxkX2lu dGVycnVwdF9qYXZhc2NyaXB0KEV2YXNfT2JqZWN0ICpvKTsKIHVpbnQ2NF90ICAgICAgICAgZXdr X3ZpZXdfZXhjZWVkZWRfZGF0YWJhc2VfcXVvdGEoRXZhc19PYmplY3QgKm8sIEV2YXNfT2JqZWN0 ICpmcmFtZSwgY29uc3QgY2hhciAqZGF0YWJhc2VOYW1lLCB1aW50NjRfdCBjdXJyZW50X3NpemUs IHVpbnQ2NF90IGV4cGVjdGVkX3NpemUpOwogCitFaW5hX0Jvb2wgICAgICAgIGV3a192aWV3X3J1 bl9vcGVuX3BhbmVsKEV2YXNfT2JqZWN0ICpvLCBFdmFzX09iamVjdCAqZnJhbWUsIEVpbmFfQm9v bCBhbGxvd3NfbXVsdGlwbGVfZmlsZXMsIGNvbnN0IEVpbmFfTGlzdCAqc3VnZ2VzdGVkX2ZpbGVu YW1lcywgRWluYV9MaXN0ICoqc2VsZWN0ZWRfZmlsZW5hbWVzKTsKKwogdm9pZCAgICAgICAgICAg ICBld2tfdmlld19yZXBhaW50KEV2YXNfT2JqZWN0ICpvLCBFdmFzX0Nvb3JkIHgsIEV2YXNfQ29v cmQgeSwgRXZhc19Db29yZCB3LCBFdmFzX0Nvb3JkIGgpOwogdm9pZCAgICAgICAgICAgICBld2tf dmlld19zY3JvbGwoRXZhc19PYmplY3QgKm8sIEV2YXNfQ29vcmQgZHgsIEV2YXNfQ29vcmQgZHks IEV2YXNfQ29vcmQgc3gsIEV2YXNfQ29vcmQgc3ksIEV2YXNfQ29vcmQgc3csIEV2YXNfQ29vcmQg c2gsIEV2YXNfQ29vcmQgY3gsIEV2YXNfQ29vcmQgY3ksIEV2YXNfQ29vcmQgY3csIEV2YXNfQ29v cmQgY2gsIEVpbmFfQm9vbCBtYWluX2ZyYW1lKTsKIFdlYkNvcmU6OlBhZ2UgICAqZXdrX3ZpZXdf Y29yZV9wYWdlX2dldChjb25zdCBFdmFzX09iamVjdCAqbyk7Cg==