40917 2010-06-21 07:53:54 -0700 [Chromium] Add a sanity test for heap profiler 2010-06-22 05:12:40 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov pfeldman yurys oldest_to_newest 240707 0 mnaganov 2010-06-21 07:53:54 -0700 This is to avoid breaking it next time you switch to a new debugging protocol. 240709 1 59251 mnaganov 2010-06-21 07:56:01 -0700 Created attachment 59251 patch The corresponding Chromium code is here: http://codereview.chromium.org/2846019 241163 2 59251 yurys 2010-06-22 00:43:06 -0700 Comment on attachment 59251 patch WebKit/chromium/src/js/Tests.js:486 + test.releaseControl(); Also return from the function, owtherwise test.fail will be called as well. WebKit/chromium/ChangeLog:5 + [Chromium] Add a sanity test for heap profiler. Can you implement it as a layout test instead? 241213 3 59359 mnaganov 2010-06-22 04:29:44 -0700 Created attachment 59359 return added Added a 'return'. But I must note, that I ran the tests, and it looks like after it reports success, reporting a failure just doesn't count. It seems currently impossible to implement it as a layout test, because the panel is Chromium-only, and resides in chromium platform code. 241221 4 mnaganov 2010-06-22 05:12:40 -0700 Manually committed as http://trac.webkit.org/changeset/61613 2010-06-21 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. [Chromium] Add a sanity test for heap profiler. https://bugs.webkit.org/show_bug.cgi?id=40917 * src/js/Tests.js: (.TestSuite.prototype.testHeapProfiler.findDisplayedNode): (.TestSuite.prototype.testHeapProfiler.findVisibleView): (.TestSuite.prototype.testHeapProfiler): 59251 2010-06-21 07:56:01 -0700 2010-06-22 04:29:44 -0700 patch heap-profiler-test-patch text/plain 2271 mnaganov ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJlYTJkYTYuLjkxZTQwZGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEwLTA2LTIxICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBBZGQgYSBzYW5pdHkgdGVzdCBmb3IgaGVhcCBwcm9maWxlci4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA5MTcKKworICAgICAgICAq IHNyYy9qcy9UZXN0cy5qczoKKyAgICAgICAgKC5UZXN0U3VpdGUucHJvdG90eXBlLnRlc3RIZWFw UHJvZmlsZXIuZmluZERpc3BsYXllZE5vZGUpOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5 cGUudGVzdEhlYXBQcm9maWxlci5maW5kVmlzaWJsZVZpZXcpOgorICAgICAgICAoLlRlc3RTdWl0 ZS5wcm90b3R5cGUudGVzdEhlYXBQcm9maWxlcik6CisKIDIwMTAtMDYtMjAgIFl1cnkgU2VtaWto YXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwg RmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMgYi9X ZWJLaXQvY2hyb21pdW0vc3JjL2pzL1Rlc3RzLmpzCmluZGV4IDAzNzVmMTAuLjU4NjNhYTQgMTAw NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMKKysrIGIvV2ViS2l0L2No cm9taXVtL3NyYy9qcy9UZXN0cy5qcwpAQCAtNDYyLDYgKzQ2Miw0OSBAQCBUZXN0U3VpdGUucHJv dG90eXBlLnRlc3RQcm9maWxlclRhYiA9IGZ1bmN0aW9uKCkKIAogCiAvKioKKyAqIFRlc3RzIHRo YXQgaGVhcCBwcm9maWxlciB3b3Jrcy4KKyAqLworVGVzdFN1aXRlLnByb3RvdHlwZS50ZXN0SGVh cFByb2ZpbGVyID0gZnVuY3Rpb24oKQoreworICAgIHRoaXMuc2hvd1BhbmVsKCJwcm9maWxlcyIp OworCisgICAgdmFyIHBhbmVsID0gV2ViSW5zcGVjdG9yLnBhbmVscy5wcm9maWxlczsKKyAgICB2 YXIgdGVzdCA9IHRoaXM7CisKKyAgICBmdW5jdGlvbiBmaW5kRGlzcGxheWVkTm9kZSgpIHsKKyAg ICAgICAgdmFyIG5vZGUgPSBwYW5lbC52aXNpYmxlVmlldy5kYXRhR3JpZC5jaGlsZHJlblswXTsK KyAgICAgICAgaWYgKCFub2RlKSB7CisgICAgICAgICAgICAvLyBQcm9maWxlIGhhZG4ndCBiZWVu IHF1ZXJpZWQgeWV0LCByZS1zY2hlZHVsZS4KKyAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0 KGZpbmREaXNwbGF5ZWROb2RlLCAxMDApOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9 CisKKyAgICAgICAgLy8gSXRlcmF0ZSBvdmVyIGRpc3BsYXllZCBmdW5jdGlvbnMgYW5kIGZpbmQg bm9kZSBjYWxsZWQgIkEiCisgICAgICAgIC8vIElmIGZvdW5kLCB0aGlzIHdpbGwgbWVhbiB0aGF0 IHdlIGFjdHVhbGx5IGhhdmUgdGFrZW4gaGVhcCBzbmFwc2hvdC4KKyAgICAgICAgd2hpbGUgKG5v ZGUpIHsKKyAgICAgICAgICAgIGlmIChub2RlLmNvbnN0cnVjdG9yTmFtZS5pbmRleE9mKCJBIikg IT09IC0xKQorICAgICAgICAgICAgICAgIHRlc3QucmVsZWFzZUNvbnRyb2woKTsKKyAgICAgICAg ICAgIG5vZGUgPSBub2RlLnRyYXZlcnNlTmV4dE5vZGUoZmFsc2UsIG51bGwsIHRydWUpOworICAg ICAgICB9CisKKyAgICAgICAgdGVzdC5mYWlsKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gZmlu ZFZpc2libGVWaWV3KCkgeworICAgICAgICBpZiAoIXBhbmVsLnZpc2libGVWaWV3KSB7CisgICAg ICAgICAgICBzZXRUaW1lb3V0KGZpbmRWaXNpYmxlVmlldywgMCk7CisgICAgICAgICAgICByZXR1 cm47CisgICAgICAgIH0KKyAgICAgICAgc2V0VGltZW91dChmaW5kRGlzcGxheWVkTm9kZSwgMCk7 CisgICAgfQorCisgICAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFByb2ZpbGVUeXBlLnByb3Rv dHlwZS5idXR0b25DbGlja2VkKCk7CisgICAgZmluZFZpc2libGVWaWV3KCk7CisgICAgdGhpcy50 YWtlQ29udHJvbCgpOworfTsKKworCisvKioKICAqIFRlc3RzIHRoYXQgc2NyaXB0cyB0YWIgY2Fu IGJlIG9wZW4gYW5kIHBvcHVsYXRlZCB3aXRoIGluc3BlY3RlZCBzY3JpcHRzLgogICovCiBUZXN0 U3VpdGUucHJvdG90eXBlLnRlc3RTaG93U2NyaXB0c1RhYiA9IGZ1bmN0aW9uKCkK 59359 2010-06-22 04:29:44 -0700 2010-06-22 05:00:19 -0700 return added heap-profiler-test-patch text/plain 2313 mnaganov ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJlYTJkYTYuLjkxZTQwZGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEwLTA2LTIxICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBBZGQgYSBzYW5pdHkgdGVzdCBmb3IgaGVhcCBwcm9maWxlci4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA5MTcKKworICAgICAgICAq IHNyYy9qcy9UZXN0cy5qczoKKyAgICAgICAgKC5UZXN0U3VpdGUucHJvdG90eXBlLnRlc3RIZWFw UHJvZmlsZXIuZmluZERpc3BsYXllZE5vZGUpOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5 cGUudGVzdEhlYXBQcm9maWxlci5maW5kVmlzaWJsZVZpZXcpOgorICAgICAgICAoLlRlc3RTdWl0 ZS5wcm90b3R5cGUudGVzdEhlYXBQcm9maWxlcik6CisKIDIwMTAtMDYtMjAgIFl1cnkgU2VtaWto YXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwg RmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMgYi9X ZWJLaXQvY2hyb21pdW0vc3JjL2pzL1Rlc3RzLmpzCmluZGV4IDAzNzVmMTAuLjg5M2JjNTYgMTAw NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMKKysrIGIvV2ViS2l0L2No cm9taXVtL3NyYy9qcy9UZXN0cy5qcwpAQCAtNDYyLDYgKzQ2Miw1MSBAQCBUZXN0U3VpdGUucHJv dG90eXBlLnRlc3RQcm9maWxlclRhYiA9IGZ1bmN0aW9uKCkKIAogCiAvKioKKyAqIFRlc3RzIHRo YXQgaGVhcCBwcm9maWxlciB3b3Jrcy4KKyAqLworVGVzdFN1aXRlLnByb3RvdHlwZS50ZXN0SGVh cFByb2ZpbGVyID0gZnVuY3Rpb24oKQoreworICAgIHRoaXMuc2hvd1BhbmVsKCJwcm9maWxlcyIp OworCisgICAgdmFyIHBhbmVsID0gV2ViSW5zcGVjdG9yLnBhbmVscy5wcm9maWxlczsKKyAgICB2 YXIgdGVzdCA9IHRoaXM7CisKKyAgICBmdW5jdGlvbiBmaW5kRGlzcGxheWVkTm9kZSgpIHsKKyAg ICAgICAgdmFyIG5vZGUgPSBwYW5lbC52aXNpYmxlVmlldy5kYXRhR3JpZC5jaGlsZHJlblswXTsK KyAgICAgICAgaWYgKCFub2RlKSB7CisgICAgICAgICAgICAvLyBQcm9maWxlIGhhZG4ndCBiZWVu IHF1ZXJpZWQgeWV0LCByZS1zY2hlZHVsZS4KKyAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0 KGZpbmREaXNwbGF5ZWROb2RlLCAxMDApOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9 CisKKyAgICAgICAgLy8gSXRlcmF0ZSBvdmVyIGRpc3BsYXllZCBmdW5jdGlvbnMgYW5kIGZpbmQg bm9kZSBjYWxsZWQgIkEiCisgICAgICAgIC8vIElmIGZvdW5kLCB0aGlzIHdpbGwgbWVhbiB0aGF0 IHdlIGFjdHVhbGx5IGhhdmUgdGFrZW4gaGVhcCBzbmFwc2hvdC4KKyAgICAgICAgd2hpbGUgKG5v ZGUpIHsKKyAgICAgICAgICAgIGlmIChub2RlLmNvbnN0cnVjdG9yTmFtZS5pbmRleE9mKCJBIikg IT09IC0xKSB7CisgICAgICAgICAgICAgICAgdGVzdC5yZWxlYXNlQ29udHJvbCgpOworICAgICAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIG5vZGUgPSBub2Rl LnRyYXZlcnNlTmV4dE5vZGUoZmFsc2UsIG51bGwsIHRydWUpOworICAgICAgICB9CisKKyAgICAg ICAgdGVzdC5mYWlsKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gZmluZFZpc2libGVWaWV3KCkg eworICAgICAgICBpZiAoIXBhbmVsLnZpc2libGVWaWV3KSB7CisgICAgICAgICAgICBzZXRUaW1l b3V0KGZpbmRWaXNpYmxlVmlldywgMCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0K KyAgICAgICAgc2V0VGltZW91dChmaW5kRGlzcGxheWVkTm9kZSwgMCk7CisgICAgfQorCisgICAg V2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFByb2ZpbGVUeXBlLnByb3RvdHlwZS5idXR0b25DbGlj a2VkKCk7CisgICAgZmluZFZpc2libGVWaWV3KCk7CisgICAgdGhpcy50YWtlQ29udHJvbCgpOwor fTsKKworCisvKioKICAqIFRlc3RzIHRoYXQgc2NyaXB0cyB0YWIgY2FuIGJlIG9wZW4gYW5kIHBv cHVsYXRlZCB3aXRoIGluc3BlY3RlZCBzY3JpcHRzLgogICovCiBUZXN0U3VpdGUucHJvdG90eXBl LnRlc3RTaG93U2NyaXB0c1RhYiA9IGZ1bmN0aW9uKCkK