40910 2010-06-21 05:14:46 -0700 [Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill() 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC All CLOSED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kbalazs webkit-unassigned benjamin commit-queue hausmann oldest_to_newest 240655 0 kbalazs 2010-06-21 05:14:46 -0700 It is totally useless to converting the QImage for the QPixmap and then fill the pixmap with zero. Instead of this we can create an empty pixmap with the appropriate dimensions and fill that. 240657 1 59242 kbalazs 2010-06-21 05:18:49 -0700 Created attachment 59242 proposed patch 240663 2 benjamin 2010-06-21 05:49:54 -0700 You are right, I did an unfortunate copy-paste there. 240687 3 59242 commit-queue 2010-06-21 07:08:48 -0700 Comment on attachment 59242 proposed patch Clearing flags on attachment: 59242 Committed r61540: <http://trac.webkit.org/changeset/61540> 240688 4 commit-queue 2010-06-21 07:08:53 -0700 All reviewed patches have been landed. Closing bug. 240691 5 hausmann 2010-06-21 07:21:51 -0700 Revision r61540 cherry-picked into qtwebkit-2.0 with commit 45d1c9149ef8940081fa8dd35854d2b95ebaf3cd 59242 2010-06-21 05:18:49 -0700 2010-06-21 07:08:48 -0700 proposed patch noconv.diff text/plain 1178 kbalazs ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzMzNzRlYS4uZmU0NzBmMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0yMSAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBBdm9pZCB1bm5lY2Vzc2FyeSBpbWFnZSBjb252ZXJzaW9u IGluIFJHQkEzMkJ1ZmZlcjo6emVyb0ZpbGwoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA5MTAKKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL3F0L1JHQkEzMkJ1ZmZlclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJHQkEzMkJ1 ZmZlcjo6emVyb0ZpbGwpOgorCiAyMDEwLTA2LTIxICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFt aW4ucG91bGFpbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL3F0L1JHQkEzMkJ1ZmZlclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2Rl cnMvcXQvUkdCQTMyQnVmZmVyUXQuY3BwCmluZGV4IGFjNGM5NTIuLjA0NDUxNWEgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvUkdCQTMyQnVmZmVyUXQuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvUkdCQTMyQnVmZmVyUXQu Y3BwCkBAIC02OSw3ICs2OSw3IEBAIHZvaWQgUkdCQTMyQnVmZmVyOjpjbGVhcigpCiB2b2lkIFJH QkEzMkJ1ZmZlcjo6emVyb0ZpbGwoKQogewogICAgIGlmIChtX3BpeG1hcC5pc051bGwoKSAmJiAh bV9pbWFnZS5pc051bGwoKSkgewotICAgICAgICBtX3BpeG1hcCA9IFFQaXhtYXA6OmZyb21JbWFn ZShtX2ltYWdlKTsKKyAgICAgICAgbV9waXhtYXAgPSBRUGl4bWFwKG1faW1hZ2Uud2lkdGgoKSwg bV9pbWFnZS5oZWlnaHQoKSk7CiAgICAgICAgIG1faW1hZ2UgPSBRSW1hZ2UoKTsKICAgICB9CiAg ICAgbV9waXhtYXAuZmlsbChRQ29sb3IoMCwgMCwgMCwgMCkpOwo=