40893 2010-06-20 14:10:33 -0700 CLEANUP: Take care of the comments in bug 40084 2010-06-23 16:32:44 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED INVALID P2 Minor --- 40184 39021 1 dglazkov dglazkov darin oldest_to_newest 240527 0 dglazkov 2010-06-20 14:10:33 -0700 The comments here need to be addressed: https://bugs.webkit.org/show_bug.cgi?id=40084#c14 241296 1 59380 dglazkov 2010-06-22 09:49:39 -0700 Created attachment 59380 Patch 241340 2 59380 darin 2010-06-22 11:03:10 -0700 Comment on attachment 59380 Patch > -FormSubmission::FormSubmission(Method method, const KURL& action, const String& target, const String& contentType, PassRefPtr<FormState> state, PassRefPtr<FormData> data, const String& boundary, bool lockHistory, PassRefPtr<Event> event) I suggest just adding the "inline" keyword in front of this constructor definition. Since it's only used in the create function, there's no need to move it to the header. Also, the version in the header uses formatting that is not standard for WebKit, not indenting the member initializer list. r=me 241625 3 dglazkov 2010-06-22 20:45:33 -0700 Ha! My clean-up patch manages to need its own fixups. Sorry for such a rush job. Will fix and land as you suggested. 242145 4 dglazkov 2010-06-23 16:32:44 -0700 Folded into bug 41110. 59380 2010-06-22 09:49:39 -0700 2010-06-22 11:03:10 -0700 Patch bug-40893-20100622094937.patch text/plain 5236 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTkwOWRlNzljMTE1YTFhMzgxNDIwOGZkN2ZiMDAxYmU0NTg3YjM1Yi4uZjQxNzAyNzcwMmU0OGE2 MTE2NDVlMTUyZWEwNmEyNzBjNGQ2ZThhNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wNi0yMiAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFuIHVwIGZvcm0gc3VibWlzc2lvbiBj b2RlLCBhZGRyZXNzaW5nIHJldmlldyBjb21tZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODkzCisKKyAgICAgICAgTm8gbmV3IGJlaGF2aW9y LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxlbWVudC5jcHA6 IEFkZGVkIGEgRklYTUUuCisgICAgICAgICogbG9hZGVyL0Zvcm1TdWJtaXNzaW9uLmNwcDogTW92 ZWQgY29uc3RydWN0b3IgdG8gaGVhZGVyLgorICAgICAgICAqIGxvYWRlci9Gb3JtU3VibWlzc2lv bi5oOgorICAgICAgICAoV2ViQ29yZTo6Rm9ybVN1Ym1pc3Npb246Oik6IE1hZGUgTWV0aG9kIGVu dW0gYSBvbmUtbGluZXIuCisgICAgICAgIChXZWJDb3JlOjpGb3JtU3VibWlzc2lvbjo6dGFyZ2V0 KTogQ2hhbmdlZCByZXR1cm4gdHlwZSB0byBjb25zdCBTdHJpbmcmLgorICAgICAgICAoV2ViQ29y ZTo6Rm9ybVN1Ym1pc3Npb246OmNvbnRlbnRUeXBlKTogRGl0dG8uCisgICAgICAgIChXZWJDb3Jl OjpGb3JtU3VibWlzc2lvbjo6Ym91bmRhcnkpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkZv cm1TdWJtaXNzaW9uOjpGb3JtU3VibWlzc2lvbik6IElubGluZWQgdGhlIGNvbnN0cnVjdG9yLgor CiAyMDEwLTA2LTA0ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0 bWwvSFRNTEZvcm1FbGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3Bw CmluZGV4IDlkNTg5MzQyYTMyNjM0M2ZmZWYyNzhiMDQxMjhjMWU1MzBmNjYwZjkuLjdlM2M3Y2Q4 M2MxMzIwNDc4NzhmYjEyMTU0OTA4OGI0ZTM2ZGUwOWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQu Y3BwCkBAIC0yMTMsNiArMjEzLDcgQEAgc3RhdGljIHZvaWQgYXBwZW5kTWFpbHRvUG9zdEZvcm1E YXRhVG9VUkwoS1VSTCYgdXJsLCBjb25zdCBGb3JtRGF0YSYgZGF0YSwgY29uc3QKICAgICB1cmwu c2V0UXVlcnkocXVlcnkpOwogfQogCisvLyBGSVhNRTogRm9sZCB0aGlzIGludG8gRm9ybVN1Ym1p c3Npb246OmNyZWF0ZSgpLgogUGFzc1JlZlB0cjxGb3JtU3VibWlzc2lvbj4gSFRNTEZvcm1FbGVt ZW50OjpwcmVwYXJlRm9ybVN1Ym1pc3Npb24oRXZlbnQqIGV2ZW50LCBib29sIGxvY2tIaXN0b3J5 LCBGb3JtU3VibWlzc2lvblRyaWdnZXIgdHJpZ2dlcikKIHsKICAgICBLVVJMIGFjdGlvblVSTCA9 IGRvY3VtZW50KCktPmNvbXBsZXRlVVJMKG1fZm9ybURhdGFCdWlsZGVyLmFjdGlvbigpLmlzRW1w dHkoKSA/IGRvY3VtZW50KCktPnVybCgpLnN0cmluZygpIDogbV9mb3JtRGF0YUJ1aWxkZXIuYWN0 aW9uKCkpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRm9ybVN1Ym1pc3Npb24uY3BwIGIv V2ViQ29yZS9sb2FkZXIvRm9ybVN1Ym1pc3Npb24uY3BwCmluZGV4IDRkNDQxNzQyZjI4ODVkNjc3 Y2M4N2QxY2FiYzRkMmMyM2FhZjBmYTkuLjRlYmIxMTNiMWViZWJjY2JjOTU2MTFlMDhkZjhjYjUz OWE1ZWJkNTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9hZGVyL0Zvcm1TdWJtaXNzaW9uLmNwcAor KysgYi9XZWJDb3JlL2xvYWRlci9Gb3JtU3VibWlzc2lvbi5jcHAKQEAgLTQyLDE5ICs0Miw2IEBA CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotRm9ybVN1Ym1pc3Npb246OkZvcm1TdWJtaXNzaW9u KE1ldGhvZCBtZXRob2QsIGNvbnN0IEtVUkwmIGFjdGlvbiwgY29uc3QgU3RyaW5nJiB0YXJnZXQs IGNvbnN0IFN0cmluZyYgY29udGVudFR5cGUsIFBhc3NSZWZQdHI8Rm9ybVN0YXRlPiBzdGF0ZSwg UGFzc1JlZlB0cjxGb3JtRGF0YT4gZGF0YSwgY29uc3QgU3RyaW5nJiBib3VuZGFyeSwgYm9vbCBs b2NrSGlzdG9yeSwgUGFzc1JlZlB0cjxFdmVudD4gZXZlbnQpCi0gICAgOiBtX21ldGhvZChtZXRo b2QpCi0gICAgLCBtX2FjdGlvbihhY3Rpb24pCi0gICAgLCBtX3RhcmdldCh0YXJnZXQpCi0gICAg LCBtX2NvbnRlbnRUeXBlKGNvbnRlbnRUeXBlKQotICAgICwgbV9mb3JtU3RhdGUoc3RhdGUpCi0g ICAgLCBtX2Zvcm1EYXRhKGRhdGEpCi0gICAgLCBtX2JvdW5kYXJ5KGJvdW5kYXJ5KQotICAgICwg bV9sb2NrSGlzdG9yeShsb2NrSGlzdG9yeSkKLSAgICAsIG1fZXZlbnQoZXZlbnQpCi17Ci19Ci0K IFBhc3NSZWZQdHI8Rm9ybVN1Ym1pc3Npb24+IEZvcm1TdWJtaXNzaW9uOjpjcmVhdGUoTWV0aG9k IG1ldGhvZCwgY29uc3QgS1VSTCYgYWN0aW9uLCBjb25zdCBTdHJpbmcmIHRhcmdldCwgY29uc3Qg U3RyaW5nJiBjb250ZW50VHlwZSwgUGFzc1JlZlB0cjxGb3JtU3RhdGU+IHN0YXRlLCBQYXNzUmVm UHRyPEZvcm1EYXRhPiBkYXRhLCBjb25zdCBTdHJpbmcmIGJvdW5kYXJ5LCBib29sIGxvY2tIaXN0 b3J5LCBQYXNzUmVmUHRyPEV2ZW50PiBldmVudCkKIHsKICAgICByZXR1cm4gYWRvcHRSZWYobmV3 IEZvcm1TdWJtaXNzaW9uKG1ldGhvZCwgYWN0aW9uLCB0YXJnZXQsIGNvbnRlbnRUeXBlLCBzdGF0 ZSwgZGF0YSwgYm91bmRhcnksIGxvY2tIaXN0b3J5LCBldmVudCkpOwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9sb2FkZXIvRm9ybVN1Ym1pc3Npb24uaCBiL1dlYkNvcmUvbG9hZGVyL0Zvcm1TdWJtaXNz aW9uLmgKaW5kZXggNjQ3YzZjNjkzYmI5ZDEwNWMwN2MxYjdjYmQ2YjhjYzczZmRhMGZhOS4uN2Jh ODM1ODI0ZGE2MzMwY2RhMDVjMmZhOWRiZjk0ODc0YmI4ODllYiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9sb2FkZXIvRm9ybVN1Ym1pc3Npb24uaAorKysgYi9XZWJDb3JlL2xvYWRlci9Gb3JtU3VibWlz c2lvbi5oCkBAIC00MiwxMCArNDIsNyBAQCBzdHJ1Y3QgRnJhbWVMb2FkUmVxdWVzdDsKIAogY2xh c3MgRm9ybVN1Ym1pc3Npb24gOiBwdWJsaWMgUmVmQ291bnRlZDxGb3JtU3VibWlzc2lvbj4gewog cHVibGljOgotICAgIGVudW0gTWV0aG9kIHsKLSAgICAgICAgR2V0TWV0aG9kLAotICAgICAgICBQ b3N0TWV0aG9kCi0gICAgfTsKKyAgICBlbnVtIE1ldGhvZCB7IEdldE1ldGhvZCwgUG9zdE1ldGhv ZCB9OwogCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8Rm9ybVN1Ym1pc3Npb24+IGNyZWF0ZShNZXRo b2QsIGNvbnN0IEtVUkwmIGFjdGlvbiwgY29uc3QgU3RyaW5nJiB0YXJnZXQsIGNvbnN0IFN0cmlu ZyYgY29udGVudFR5cGUsIFBhc3NSZWZQdHI8Rm9ybVN0YXRlPiwgUGFzc1JlZlB0cjxGb3JtRGF0 YT4sIGNvbnN0IFN0cmluZyYgYm91bmRhcnksIGJvb2wgbG9ja0hpc3RvcnksIFBhc3NSZWZQdHI8 RXZlbnQ+KTsKIApAQCAtNTMsMTIgKzUwLDEyIEBAIHB1YmxpYzoKIAogICAgIE1ldGhvZCBtZXRo b2QoKSBjb25zdCB7IHJldHVybiBtX21ldGhvZDsgfQogICAgIGNvbnN0IEtVUkwmIGFjdGlvbigp IGNvbnN0IHsgcmV0dXJuIG1fYWN0aW9uOyB9Ci0gICAgU3RyaW5nIHRhcmdldCgpIGNvbnN0IHsg cmV0dXJuIG1fdGFyZ2V0OyB9CisgICAgY29uc3QgU3RyaW5nJiB0YXJnZXQoKSBjb25zdCB7IHJl dHVybiBtX3RhcmdldDsgfQogICAgIHZvaWQgY2xlYXJUYXJnZXQoKSB7IG1fdGFyZ2V0ID0gU3Ry aW5nKCk7IH0KLSAgICBTdHJpbmcgY29udGVudFR5cGUoKSBjb25zdCB7IHJldHVybiBtX2NvbnRl bnRUeXBlOyB9CisgICAgY29uc3QgU3RyaW5nJiBjb250ZW50VHlwZSgpIGNvbnN0IHsgcmV0dXJu IG1fY29udGVudFR5cGU7IH0KICAgICBGb3JtU3RhdGUqIHN0YXRlKCkgY29uc3QgeyByZXR1cm4g bV9mb3JtU3RhdGUuZ2V0KCk7IH0KICAgICBGb3JtRGF0YSogZGF0YSgpIGNvbnN0IHsgcmV0dXJu IG1fZm9ybURhdGEuZ2V0KCk7IH0KLSAgICBTdHJpbmcgYm91bmRhcnkoKSBjb25zdCB7IHJldHVy biBtX2JvdW5kYXJ5OyB9CisgICAgY29uc3QgU3RyaW5nJiBib3VuZGFyeSgpIGNvbnN0IHsgcmV0 dXJuIG1fYm91bmRhcnk7IH0KICAgICBib29sIGxvY2tIaXN0b3J5KCkgY29uc3QgeyByZXR1cm4g bV9sb2NrSGlzdG9yeTsgfQogICAgIEV2ZW50KiBldmVudCgpIGNvbnN0IHsgcmV0dXJuIG1fZXZl bnQuZ2V0KCk7IH0KIApAQCAtNjgsNyArNjUsMTggQEAgcHVibGljOgogICAgIHZvaWQgc2V0T3Jp Z2luKGNvbnN0IFN0cmluZyYgb3JpZ2luKSB7IG1fb3JpZ2luID0gb3JpZ2luOyB9CiAKIHByaXZh dGU6Ci0gICAgRm9ybVN1Ym1pc3Npb24oTWV0aG9kLCBjb25zdCBLVVJMJiBhY3Rpb24sIGNvbnN0 IFN0cmluZyYgdGFyZ2V0LCBjb25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlLCBQYXNzUmVmUHRyPEZv cm1TdGF0ZT4sIFBhc3NSZWZQdHI8Rm9ybURhdGE+LCBjb25zdCBTdHJpbmcmIGJvdW5kYXJ5LCBi b29sIGxvY2tIaXN0b3J5LCBQYXNzUmVmUHRyPEV2ZW50Pik7CisgICAgRm9ybVN1Ym1pc3Npb24o TWV0aG9kIG1ldGhvZCwgY29uc3QgS1VSTCYgYWN0aW9uLCBjb25zdCBTdHJpbmcmIHRhcmdldCwg Y29uc3QgU3RyaW5nJiBjb250ZW50VHlwZSwgUGFzc1JlZlB0cjxGb3JtU3RhdGU+IHN0YXRlLCBQ YXNzUmVmUHRyPEZvcm1EYXRhPiBkYXRhLCBjb25zdCBTdHJpbmcmIGJvdW5kYXJ5LCBib29sIGxv Y2tIaXN0b3J5LCBQYXNzUmVmUHRyPEV2ZW50PiBldmVudCkKKyAgICA6IG1fbWV0aG9kKG1ldGhv ZCkKKyAgICAsIG1fYWN0aW9uKGFjdGlvbikKKyAgICAsIG1fdGFyZ2V0KHRhcmdldCkKKyAgICAs IG1fY29udGVudFR5cGUoY29udGVudFR5cGUpCisgICAgLCBtX2Zvcm1TdGF0ZShzdGF0ZSkKKyAg ICAsIG1fZm9ybURhdGEoZGF0YSkKKyAgICAsIG1fYm91bmRhcnkoYm91bmRhcnkpCisgICAgLCBt X2xvY2tIaXN0b3J5KGxvY2tIaXN0b3J5KQorICAgICwgbV9ldmVudChldmVudCkKKyAgICB7Cisg ICAgfQogCiAgICAgTWV0aG9kIG1fbWV0aG9kOwogICAgIEtVUkwgbV9hY3Rpb247Cg==