40889 2010-06-20 12:16:06 -0700 Sheriffbot: Should allow "r" in SVN_REVISION 2010-06-20 15:51:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned abarth commit-queue eric joepeck ojan tonyg oldest_to_newest 240500 0 joepeck 2010-06-20 12:16:06 -0700 Situation I just had: JoePeck: sheriffbot: rollout r61506 Causes crash. Will take a different approach. sheriffbot: Preparing rollout for rr61506... sheriffbot: JoePeck: Failed to create rollout patch: sheriffbot: Invalid svn revision number "r61506". =(. Bot could be more lenient. 240501 1 59209 joepeck 2010-06-20 12:19:20 -0700 Created attachment 59209 Strip a Leading "r" if its there. NOTE: I didn't run the tests! How do I run the python tests for the irc bot? 240502 2 joepeck 2010-06-20 12:23:10 -0700 CC'ing a bunch of people who have worked in the WebKitTools/Scripts/webkitpy/tool directory. The patch is simple enough, but see my question above about running the tests for the tools. Thanks! 240503 3 abarth 2010-06-20 12:34:43 -0700 You can run test-webkitpy 240507 4 59209 abarth 2010-06-20 12:41:47 -0700 Comment on attachment 59209 Strip a Leading "r" if its there. Lgtm 240510 5 joepeck 2010-06-20 12:49:11 -0700 (In reply to comment #3) > You can run test-webkitpy Excellent, that worked perfectly! Has it been considered that this be renamed to match the usual run-*-tests pattern? I see there are a few like this, all for scripts: WebKitTools/Scripts/test-webkit-scripts WebKitTools/Scripts/test-webkitperl WebKitTools/Scripts/test-webkitpy 240511 6 abarth 2010-06-20 13:04:51 -0700 You can look at the discussion on the bug where thoses were added. I think various folks preferred the test-* pattern for reasons I don't remember. 240514 7 joepeck 2010-06-20 13:08:54 -0700 (In reply to comment #6) > You can look at the discussion on the bug where thoses were added. > I think various folks preferred the test-* pattern for reasons I don't > remember. Ahh, okay. Thanks! 240540 8 59209 commit-queue 2010-06-20 15:51:25 -0700 Comment on attachment 59209 Strip a Leading "r" if its there. Clearing flags on attachment: 59209 Committed r61515: <http://trac.webkit.org/changeset/61515> 240541 9 commit-queue 2010-06-20 15:51:30 -0700 All reviewed patches have been landed. Closing bug. 59209 2010-06-20 12:19:20 -0700 2010-06-20 15:51:24 -0700 Strip a Leading "r" if its there. svnrev.patch text/plain 2518 joepeck ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzMTkyMDEzLi5jZjYwNjY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYt MjAgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaGVyaWZmYm90OiBTaG91bGQgYWxs b3cgInIiIGluIFNWTl9SRVZJU0lPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDA4ODkKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9i b3QvaXJjX2NvbW1hbmQucHk6IHJlbW92ZSBhIGxlYWRpbmcgInIiIGZyb20gU1ZOX1JFVklTSU9O IGlmIGl0IGV4aXN0cworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlm ZmlyY2JvdF91bml0dGVzdC5weTogdGVzdCBhbiBTVk5fUkVWSVNJT04gd2l0aCBhIGxlYWRpbmcg ci4KKwogMjAxMC0wNi0xOSAgSnVzdGluIFNjaHVoICA8anNjaHVoQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHkKaW5kZXggZWU4YzY2OS4uYTg0ODQ3MiAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5k LnB5CkBAIC01Nyw3ICs1Nyw3IEBAIGNsYXNzIFJvbGxvdXQoSVJDQ29tbWFuZCk6CiAgICAgICAg IGlmIGxlbihhcmdzKSA8IDI6CiAgICAgICAgICAgICB0b29sLmlyYygpLnBvc3QoIiVzOiBVc2Fn ZTogU1ZOX1JFVklTSU9OIFJFQVNPTiIgJSBuaWNrKQogICAgICAgICAgICAgcmV0dXJuCi0gICAg ICAgIHN2bl9yZXZpc2lvbiA9IGFyZ3NbMF0KKyAgICAgICAgc3ZuX3JldmlzaW9uID0gYXJnc1sw XS5sc3RyaXAoInIiKQogICAgICAgICByb2xsb3V0X3JlYXNvbiA9ICIgIi5qb2luKGFyZ3NbMTpd KQogICAgICAgICB0b29sLmlyYygpLnBvc3QoIlByZXBhcmluZyByb2xsb3V0IGZvciByJXMuLi4i ICUgc3ZuX3JldmlzaW9uKQogICAgICAgICB0cnk6CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3RfdW5pdHRlc3QucHkgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3RfdW5pdHRlc3Qu cHkKaW5kZXggMjFiZmYxMi4uMDgwMjNiZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0dGVzdC5w eQpAQCAtNjIsNiArNjIsMTAgQEAgY2xhc3MgU2hlcmlmZklSQ0JvdFRlc3QodW5pdHRlc3QuVGVz dENhc2UpOgogICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IFByZXBh cmluZyByb2xsb3V0IGZvciByMjE2NTQuLi5cbk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2s6IENy ZWF0ZWQgcm9sbG91dDogaHR0cDovL2V4YW1wbGUuY29tLzM2OTM2XG4iCiAgICAgICAgIE91dHB1 dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBydW4sIGFyZ3M9WyJyb2xsb3V0IDIxNjU0 IFRoaXMgcGF0Y2ggYnJva2UgdGhlIHdvcmxkIl0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9z dGRlcnIpCiAKKyAgICBkZWYgdGVzdF9yb2xsb3V0X3dpdGhfcl9pbl9zdm5fcmV2aXNpb24oc2Vs Zik6CisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogUHJlcGFyaW5n IHJvbGxvdXQgZm9yIHIyMTY1NC4uLlxuTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogQ3JlYXRl ZCByb2xsb3V0OiBodHRwOi8vZXhhbXBsZS5jb20vMzY5MzZcbiIKKyAgICAgICAgT3V0cHV0Q2Fw dHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJvbGxvdXQgcjIxNjU0IFRo aXMgcGF0Y2ggYnJva2UgdGhlIHdvcmxkIl0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRl cnIpCisKICAgICBkZWYgdGVzdF9yb2xsb3V0X2JhbmFuYXMoc2VsZik6CiAgICAgICAgIGV4cGVj dGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBVc2FnZTogU1ZOX1JFVklT SU9OIFJFQVNPTlxuIgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2Vs ZiwgcnVuLCBhcmdzPVsicm9sbG91dCBiYW5hbmFzIl0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3Rl ZF9zdGRlcnIpCg==