40876 2010-06-19 01:48:55 -0700 [EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp 2010-06-30 18:07:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim webkit-unassigned antognolli+webkit barbieri commit-queue gyuyoung hyuki.kim joone kenneth leandro lucas.de.marchi webkit.review.bot oldest_to_newest 240293 0 gyuyoung.kim 2010-06-19 01:48:55 -0700 There are no implementation in windowRect() and setWindowRect() of ChromeClientEfl.cpp yet. 240295 1 59181 gyuyoung.kim 2010-06-19 01:55:43 -0700 Created attachment 59181 patch for windowRect/setWindowRect I try to make a patch for this. 240296 2 webkit.review.bot 2010-06-19 01:57:08 -0700 Attachment 59181 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:54: Alphabetical sorting problem. [build/include_order] [4] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:55: Alphabetical sorting problem. [build/include_order] [4] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:92: Declaration has space between type name and * in Ecore_Evas *ee [whitespace/declaration] [3] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:92: Use 0 instead of NULL. [readability/null] [5] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:95: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:95: Use 0 instead of NULL. [readability/null] [5] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:102: Use 0 instead of NULL. [readability/null] [5] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:109: Declaration has space between type name and * in Ecore_Evas *ee [whitespace/declaration] [3] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:109: Use 0 instead of NULL. [readability/null] [5] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:112: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:112: Use 0 instead of NULL. [readability/null] [5] Total errors found: 11 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 240305 3 59183 gyuyoung.kim 2010-06-19 02:51:00 -0700 Created attachment 59183 patch for windowRect/setWindowRect I modified this patch to fix style errors. 240306 4 webkit.review.bot 2010-06-19 02:55:41 -0700 Attachment 59183 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 240609 5 gyuyoung.kim 2010-06-20 23:58:05 -0700 (In reply to comment #4) > Attachment 59183 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 > WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 1 in 2 files The style bot points me out lines below, 53 : + #include <Ecore_Evas.h> 54 : + #include <Ecore_X.h> I don't know what is wrong. Could you please let me know what is wrong ? 240649 6 59240 gyuyoung.kim 2010-06-21 03:50:04 -0700 Created attachment 59240 patch for windowRect and setWindowRect I modified this patch. 240718 7 lucas.de.marchi 2010-06-21 08:27:12 -0700 (In reply to comment #6) > Created an attachment (id=59240) [details] > patch for windowRect and setWindowRect > > I modified this patch. For future reference, you could either run WebKitTools/Scripts/check-webkit-style or use webkit-patch, that will check the style automatically for you before actually sending the patch. 240908 8 antognolli+webkit 2010-06-21 14:53:30 -0700 (In reply to comment #6) > Created an attachment (id=59240) [details] > patch for windowRect and setWindowRect > > I modified this patch. Hi Gyuyoung, Do you have a good reason for using Ecore_X_Window instead of just Ecore_Evas? I think you could just get the window size as ecore_evas_geometry_get(). It would be more portable and give you the correct values anyway. Of course, if Ecore_X_Window is necessary, you should put some #ifdef's as in http://trac.webkit.org/browser/trunk/WebCore/platform/efl/WidgetEfl.cpp#L209 (and the same for the header Ecore_X.h) 241055 9 59323 gyuyoung.kim 2010-06-21 19:10:28 -0700 Created attachment 59323 patch for windowRect and setWindowRect Rafael, thank you for your comment. At latst, there are no style error. The reason I use Ecore_X_Window is to change window size. When I tested setWindowRect() on WebKitGTK, window size was changed. So, I need to use Ecore_X_Window in order to change window size. Of course, I also think that windowRect() can use Ecore_Evas. But, I used same efl object. If I have any misunderstanding, please let me know. Thanks. 241076 10 antognolli+webkit 2010-06-21 19:50:30 -0700 Well, sorry for keep saying this, but I still highly recommend you to use ecore_evas_geometry_get, ecore_evas_move and ecore_evas_resize. It's almost the same API, so the changes are minimal, but you'll get the portability. And you still will be able to resize the window as requested. As for the current patch, you are still missing #ifdef HAVE_ECORE_X inside the functions. But you don't need them or the header Ecore_X.h if you change to those ecore_evas_* functions as I told you. 241085 11 59332 gyuyoung.kim 2010-06-21 21:29:39 -0700 Created attachment 59332 patch for windowRect and setWindowRect Ecore_Evas also supports to change window size. I use Ecore_Evas instead of Ecore_X. Thanks. 241087 12 webkit.review.bot 2010-06-21 21:32:07 -0700 Attachment 59332 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 241090 13 gyuyoung.kim 2010-06-21 21:37:37 -0700 (In reply to comment #12) > Attachment 59332 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 > WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Hi Rafael, I don't understand why style error happen. According to the url you let me know, they use to include <Ecore_Evas.h> without the macro as below, 43 #include <Ecore.h> 44 #include <Ecore_Evas.h> 45 #include <Edje.h> 46 #include <Evas.h> Do you know the reason ? Should do I use the macro for this? 241310 14 antognolli+webkit 2010-06-22 10:07:56 -0700 (In reply to comment #13) > I don't understand why style error happen. According to the url you let me know, they use to include <Ecore_Evas.h> without the macro as below, > > 43 #include <Ecore.h> > 44 #include <Ecore_Evas.h> > 45 #include <Edje.h> > 46 #include <Evas.h> > > Do you know the reason ? Should do I use the macro for this? Yes, you are right, you don't need the macro for this. But the problem now is the alphabetical order (as the Review Bot said). You should include Ecore_Evas.h just before <wtf/text/CString.h>, to keep it correct. Even the last header, Evas.h, is wrong, because it should be before <wtf/text/CString.h> as well. For more information about this, check http://webkit.org/coding/coding-style.html, session #include Statements. 241613 15 59466 gyuyoung.kim 2010-06-22 19:44:00 -0700 Created attachment 59466 patch for windowRect and setWindowRect Thank you Rafael, I fix the style errors with the <Evas.h> include. 241916 16 antognolli+webkit 2010-06-23 10:21:42 -0700 (In reply to comment #15) > Created an attachment (id=59466) [details] > patch for windowRect and setWindowRect > > Thank you Rafael, > > I fix the style errors with the <Evas.h> include. Hi Gyuyoung, The patch seems ok to me now. And thank you for fixing Evas.h too. 241967 17 leandro 2010-06-23 11:27:22 -0700 (In reply to comment #16) > > The patch seems ok to me now. And thank you for fixing Evas.h too. My only gripe are the ChangeLog comments: they're as generic as it gets and don't state briefly what was performed. Either leave them empty or use something more descriptive (preferred). 242249 18 59601 gyuyoung.kim 2010-06-23 19:06:14 -0700 Created attachment 59601 patch for windowRect and setWindowRect Thanks, I fix the comment in changelog. 243668 19 lucas.de.marchi 2010-06-28 05:54:38 -0700 It seems good to me, too. 244274 20 59601 kenneth 2010-06-29 07:13:35 -0700 Comment on attachment 59601 patch for windowRect and setWindowRect Please read the comment in the Qt implementation. I believe this is supposed to be the device rect, as it is used by the viewport meta tag. 244308 21 antognolli+webkit 2010-06-29 08:19:53 -0700 (In reply to comment #20) > (From update of attachment 59601 [details]) > Please read the comment in the Qt implementation. I believe this is supposed to be the device rect, as it is used by the viewport meta tag. Hmm... sorry Kenneth but I didn't get it. From what I understood, it's exactly what his patch is doing. 244310 22 59601 kenneth 2010-06-29 08:23:50 -0700 Comment on attachment 59601 patch for windowRect and setWindowRect Might be, I don't remember well the EFL API. so you are getting the size of the canvas? That seems right then. If not, please tell me. 244311 23 antognolli+webkit 2010-06-29 08:29:44 -0700 Yes. Actually, this is the size of the window, which in all current backends also means the size of the canvas. 244318 24 59601 commit-queue 2010-06-29 09:04:27 -0700 Comment on attachment 59601 patch for windowRect and setWindowRect Rejecting patch 59601 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 59601, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: webkitpy/tool/commands/stepsequence.py", line 60, in _run step(tool, options).run(state) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 68, in run if self._has_valid_reviewer(changelog_entry): File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' 244740 25 60112 gyuyoung.kim 2010-06-30 05:37:15 -0700 Created attachment 60112 patch for windowRect/setWindowRect It seems to me that there is no review in changelog. I add reviewer to changelog. Should I request review again ? 244748 26 60112 commit-queue 2010-06-30 06:03:51 -0700 Comment on attachment 60112 patch for windowRect/setWindowRect Clearing flags on attachment: 60112 Committed r62180: <http://trac.webkit.org/changeset/62180> 245039 27 59601 leandro 2010-06-30 18:07:52 -0700 Comment on attachment 59601 patch for windowRect and setWindowRect Newer patch was applied; clearing flags on this one. 59181 2010-06-19 01:55:43 -0700 2010-06-19 02:51:00 -0700 patch for windowRect/setWindowRect patch.txt text/plain 2131 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE0NzEpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDYtMTkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dSZWN0KCkgaW4gQ2hy b21lQ2xpZW50RWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA4NzYKKworICAgICAgICAqIGVmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZsOjp3aW5kb3dSZWN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdCk6CisK IDIwMTAtMDYtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViS2l0L2VmbC9XZWJDb3JlU3Vw cG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAkocmV2aXNpb24gNjE0NjUpCisrKyBXZWJLaXQv ZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTUxLDYgKzUxLDggQEAKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKICNpbmNsdWRl IDxFdmFzLmg+CisjaW5jbHVkZSA8RWNvcmVfWC5oPgorI2luY2x1ZGUgPEVjb3JlX0V2YXMuaD4K IAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTg2LDEzICs4OCwzNiBAQCB2b2lkIENo cm9tZUNsaWVudEVmbDo6Zm9jdXNlZE5vZGVDaGFuZ2VkCiAKIEZsb2F0UmVjdCBDaHJvbWVDbGll bnRFZmw6OndpbmRvd1JlY3QoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJu IEZsb2F0UmVjdCgpOworICAgIEVjb3JlX1hfV2luZG93IHh3aW4gPSAwOworICAgIEVjb3JlX0V2 YXMgKmVlID0gTlVMTDsKKyAgICBpbnQgeCwgeSwgdywgaDsKKworICAgIGlmIChtX3ZpZXcgPT0g TlVMTCkKKyAgICAgICAgcmV0dXJuIEZsb2F0UmVjdCgpOworCisgICAgZWUgPSBlY29yZV9ldmFz X2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KG1fdmlldykpOworICAgIGlmIChl ZSkgCisgICAgICAgIHh3aW4gPSAoRWNvcmVfWF9XaW5kb3cpZWNvcmVfZXZhc193aW5kb3dfZ2V0 KGVlKTsKKworICAgIGVjb3JlX3hfd2luZG93X2dlb21ldHJ5X2dldCh4d2luLCAmeCwgJnksIE5V TEwsIE5VTEwpOworICAgIHJldHVybiBGbG9hdFJlY3QoeCwgeSwgdywgaCk7CiB9CiAKIHZvaWQg Q2hyb21lQ2xpZW50RWZsOjpzZXRXaW5kb3dSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKIHsK LSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIEVjb3JlX1hfV2luZG93IHh3aW4gPSAwOworICAg IEVjb3JlX0V2YXMgKmVlID0gTlVMTDsKKyAgICBJbnRSZWN0IGludHJlY3QgPSBJbnRSZWN0KHJl Y3QpOworCisgICAgaWYgKG1fdmlldyA9PSBOVUxMKQorICAgICAgICByZXR1cm47CisKKyAgICBl ZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3 KSk7CisgICAgaWYgKGVlKSAKKyAgICAgICAgeHdpbiA9IChFY29yZV9YX1dpbmRvdyllY29yZV9l dmFzX3dpbmRvd19nZXQoZWUpOworCisgICAgZWNvcmVfeF93aW5kb3dfbW92ZSh4d2luLCBpbnRy ZWN0LngoKSwgaW50cmVjdC55KCkpOworICAgIGVjb3JlX3hfd2luZG93X3Jlc2l6ZSh4d2luLCBp bnRyZWN0LndpZHRoKCksIGludHJlY3QuaGVpZ2h0KCkpOwogfQogCiBGbG9hdFJlY3QgQ2hyb21l Q2xpZW50RWZsOjpwYWdlUmVjdCgpCg== 59183 2010-06-19 02:51:00 -0700 2010-06-21 03:50:04 -0700 patch for windowRect/setWindowRect patch.txt text/plain 2119 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE0NzEpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDYtMTkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dSZWN0KCkgaW4gQ2hy b21lQ2xpZW50RWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA4NzYKKworICAgICAgICAqIGVmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZsOjp3aW5kb3dSZWN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdCk6CisK IDIwMTAtMDYtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViS2l0L2VmbC9XZWJDb3JlU3Vw cG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAkocmV2aXNpb24gNjE0NjUpCisrKyBXZWJLaXQv ZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTUwLDYgKzUwLDggQEAKICNpbmNsdWRlICJld2tfcHJpdmF0ZS5oIgogI2luY2x1ZGUgPHd0Zi90 ZXh0L0NTdHJpbmcuaD4KIAorI2luY2x1ZGUgPEVjb3JlX0V2YXMuaD4KKyNpbmNsdWRlIDxFY29y ZV9YLmg+CiAjaW5jbHVkZSA8RXZhcy5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKQEAg LTg2LDEzICs4OCwzNiBAQCB2b2lkIENocm9tZUNsaWVudEVmbDo6Zm9jdXNlZE5vZGVDaGFuZ2Vk CiAKIEZsb2F0UmVjdCBDaHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QoKQogewotICAgIG5vdElt cGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIEZsb2F0UmVjdCgpOworICAgIEVjb3JlX1hfV2luZG93 IHh3aW4gPSAwOworICAgIEVjb3JlX0V2YXMqIGVlID0gMDsKKyAgICBpbnQgeCwgeSwgdywgaDsK KworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm4gMDsKKworICAgIGVlID0gZWNvcmVf ZXZhc19lY29yZV9ldmFzX2dldChldmFzX29iamVjdF9ldmFzX2dldChtX3ZpZXcpKTsKKyAgICBp ZiAoZWUpIAorICAgICAgICB4d2luID0gKEVjb3JlX1hfV2luZG93KWVjb3JlX2V2YXNfd2luZG93 X2dldChlZSk7CisKKyAgICBlY29yZV94X3dpbmRvd19nZW9tZXRyeV9nZXQoeHdpbiwgJngsICZ5 LCAwLCAwKTsKKyAgICByZXR1cm4gRmxvYXRSZWN0KHgsIHksIHcsIGgpOwogfQogCiB2b2lkIENo cm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7Ci0g ICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBFY29yZV9YX1dpbmRvdyB4d2luID0gMDsKKyAgICBF Y29yZV9FdmFzKiBlZSA9IDA7CisgICAgSW50UmVjdCBpbnRyZWN0ID0gSW50UmVjdChyZWN0KTsK KworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm47CisKKyAgICBlZSA9IGVjb3JlX2V2 YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3KSk7CisgICAgaWYg KGVlKSAKKyAgICAgICAgeHdpbiA9IChFY29yZV9YX1dpbmRvdyllY29yZV9ldmFzX3dpbmRvd19n ZXQoZWUpOworCisgICAgZWNvcmVfeF93aW5kb3dfbW92ZSh4d2luLCBpbnRyZWN0LngoKSwgaW50 cmVjdC55KCkpOworICAgIGVjb3JlX3hfd2luZG93X3Jlc2l6ZSh4d2luLCBpbnRyZWN0LndpZHRo KCksIGludHJlY3QuaGVpZ2h0KCkpOwogfQogCiBGbG9hdFJlY3QgQ2hyb21lQ2xpZW50RWZsOjpw YWdlUmVjdCgpCg== 59240 2010-06-21 03:50:04 -0700 2010-06-21 19:10:28 -0700 patch for windowRect and setWindowRect patch-for-windowrect.txt text/plain 2205 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE1MzYpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDYtMjEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dSZWN0KCkgaW4gQ2hy b21lQ2xpZW50RWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA4NzYgCisKKyAgICAgICAgKiBlZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50RWZsLmNwcDogSW1wbGVtZW50cyB0d28gZnVuY3Rpb25zCisgICAgICAgIChXZWJDb3JlOjpD aHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QpOiBJbXBsZW1lbnRzIHRoaXMgZnVuY3Rpb24KKyAg ICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdCk6IEltcGxlbWVu dHMgdGhpcyBmdW5jdGlvbgorCiAyMDEwLTA2LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAJKHJldmlzaW9u IDYxNTM2KQorKysgV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01MCw2ICs1MCw4IEBACiAjaW5jbHVkZSAiZXdrX3ByaXZhdGUu aCIKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKKyNpbmNsdWRlIDxFY29yZV9FdmFz Lmg+CisjaW5jbHVkZSA8RWNvcmVfWC5oPgogI2luY2x1ZGUgPEV2YXMuaD4KIAogdXNpbmcgbmFt ZXNwYWNlIFdlYkNvcmU7CkBAIC04NiwxMyArODgsMzYgQEAgdm9pZCBDaHJvbWVDbGllbnRFZmw6 OmZvY3VzZWROb2RlQ2hhbmdlZAogCiBGbG9hdFJlY3QgQ2hyb21lQ2xpZW50RWZsOjp3aW5kb3dS ZWN0KCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBGbG9hdFJlY3QoKTsK KyAgICBFY29yZV9YX1dpbmRvdyB4d2luID0gMDsKKyAgICBFY29yZV9FdmFzKiBlZSA9IDA7Cisg ICAgaW50IHgsIHksIHcsIGg7CisKKyAgICBpZiAoIW1fdmlldykKKyAgICAgICAgcmV0dXJuIEZs b2F0UmVjdCgpOworCisgICAgZWUgPSBlY29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2Jq ZWN0X2V2YXNfZ2V0KG1fdmlldykpOworICAgIGlmIChlZSkKKyAgICAgICAgeHdpbiA9IChFY29y ZV9YX1dpbmRvdyllY29yZV9ldmFzX3dpbmRvd19nZXQoZWUpOworCisgICAgZWNvcmVfeF93aW5k b3dfZ2VvbWV0cnlfZ2V0KHh3aW4sICZ4LCAmeSwgJncsICZoKTsKKyAgICByZXR1cm4gRmxvYXRS ZWN0KHgsIHksIHcsIGgpOwogfQogCiB2b2lkIENocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVj dChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBF Y29yZV9YX1dpbmRvdyB4d2luID0gMDsKKyAgICBFY29yZV9FdmFzKiBlZSA9IDA7CisgICAgSW50 UmVjdCBpbnRyZWN0ID0gSW50UmVjdChyZWN0KTsKKworICAgIGlmICghbV92aWV3KQorICAgICAg ICByZXR1cm47CisKKyAgICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmpl Y3RfZXZhc19nZXQobV92aWV3KSk7CisgICAgaWYgKGVlKQorICAgICAgICB4d2luID0gKEVjb3Jl X1hfV2luZG93KWVjb3JlX2V2YXNfd2luZG93X2dldChlZSk7CisKKyAgICBlY29yZV94X3dpbmRv d19tb3ZlKHh3aW4sIGludHJlY3QueCgpLCBpbnRyZWN0LnkoKSk7CisgICAgZWNvcmVfeF93aW5k b3dfcmVzaXplKHh3aW4sIGludHJlY3Qud2lkdGgoKSwgaW50cmVjdC5oZWlnaHQoKSk7CiB9CiAK IEZsb2F0UmVjdCBDaHJvbWVDbGllbnRFZmw6OnBhZ2VSZWN0KCkK 59323 2010-06-21 19:10:28 -0700 2010-06-21 21:29:39 -0700 patch for windowRect and setWindowRect patch-for-windowrect.txt text/plain 2235 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE1MzYpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDYtMjEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dSZWN0KCkgaW4gQ2hy b21lQ2xpZW50RWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA4NzYgCisKKyAgICAgICAgKiBlZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50RWZsLmNwcDogSW1wbGVtZW50cyB0d28gZnVuY3Rpb25zCisgICAgICAgIChXZWJDb3JlOjpD aHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QpOiBJbXBsZW1lbnRzIHRoaXMgZnVuY3Rpb24KKyAg ICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdCk6IEltcGxlbWVu dHMgdGhpcyBmdW5jdGlvbgorCiAyMDEwLTA2LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAJKHJldmlzaW9u IDYxNTM2KQorKysgV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01MCw2ICs1MCwxMCBAQAogI2luY2x1ZGUgImV3a19wcml2YXRl LmgiCiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCisjaWZkZWYgSEFWRV9FQ09SRV9Y CisjaW5jbHVkZSA8RWNvcmVfRXZhcy5oPgorI2luY2x1ZGUgPEVjb3JlX1guaD4KKyNlbmRpZgog I2luY2x1ZGUgPEV2YXMuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC04NiwxMyAr OTAsMzYgQEAgdm9pZCBDaHJvbWVDbGllbnRFZmw6OmZvY3VzZWROb2RlQ2hhbmdlZAogCiBGbG9h dFJlY3QgQ2hyb21lQ2xpZW50RWZsOjp3aW5kb3dSZWN0KCkKIHsKLSAgICBub3RJbXBsZW1lbnRl ZCgpOwotICAgIHJldHVybiBGbG9hdFJlY3QoKTsKKyAgICBFY29yZV9YX1dpbmRvdyB4d2luID0g MDsKKyAgICBFY29yZV9FdmFzKiBlZSA9IDA7CisgICAgaW50IHgsIHksIHcsIGg7CisKKyAgICBp ZiAoIW1fdmlldykKKyAgICAgICAgcmV0dXJuIEZsb2F0UmVjdCgpOworCisgICAgZWUgPSBlY29y ZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KG1fdmlldykpOworICAg IGlmIChlZSkKKyAgICAgICAgeHdpbiA9IChFY29yZV9YX1dpbmRvdyllY29yZV9ldmFzX3dpbmRv d19nZXQoZWUpOworCisgICAgZWNvcmVfeF93aW5kb3dfZ2VvbWV0cnlfZ2V0KHh3aW4sICZ4LCAm eSwgJncsICZoKTsKKyAgICByZXR1cm4gRmxvYXRSZWN0KHgsIHksIHcsIGgpOwogfQogCiB2b2lk IENocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7 Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBFY29yZV9YX1dpbmRvdyB4d2luID0gMDsKKyAg ICBFY29yZV9FdmFzKiBlZSA9IDA7CisgICAgSW50UmVjdCBpbnRyZWN0ID0gSW50UmVjdChyZWN0 KTsKKworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm47CisKKyAgICBlZSA9IGVjb3Jl X2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3KSk7CisgICAg aWYgKGVlKQorICAgICAgICB4d2luID0gKEVjb3JlX1hfV2luZG93KWVjb3JlX2V2YXNfd2luZG93 X2dldChlZSk7CisKKyAgICBlY29yZV94X3dpbmRvd19tb3ZlKHh3aW4sIGludHJlY3QueCgpLCBp bnRyZWN0LnkoKSk7CisgICAgZWNvcmVfeF93aW5kb3dfcmVzaXplKHh3aW4sIGludHJlY3Qud2lk dGgoKSwgaW50cmVjdC5oZWlnaHQoKSk7CiB9CiAKIEZsb2F0UmVjdCBDaHJvbWVDbGllbnRFZmw6 OnBhZ2VSZWN0KCkK 59332 2010-06-21 21:29:39 -0700 2010-06-22 19:44:00 -0700 patch for windowRect and setWindowRect patch-for-windowrect.txt text/plain 1960 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE1OTcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDYtMjEgR3l1eW91bmcgS2ltIDxneXV5b3VuZy5raW1Ac2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dSZWN0KCkgaW4gQ2hy b21lQ2xpZW50RWZsLmNwcAorICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwODc2CisKKyAgICAgICAgICogZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEVmbC5jcHA6IEltcGxlbWVudHMgdHdvIGZ1bmN0aW9ucworICAgICAgICAgKFdlYkNvcmU6 OkNocm9tZUNsaWVudEVmbDo6d2luZG93UmVjdCk6IEltcGxlbWVudHMgdGhpcyBmdW5jdGlvbgor ICAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdCk6IEltcGxl bWVudHMgdGhpcyBmdW5jdGlvbgorCiAyMDEwLTA2LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6 IFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAJKHJldmlz aW9uIDYxNTM2KQorKysgV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MCw2ICs1MCw3IEBACiAjaW5jbHVkZSAiZXdrX3ByaXZh dGUuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKKyNpbmNsdWRlIDxFY29yZV9F dmFzLmg+CiAjaW5jbHVkZSA8RXZhcy5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKQEAg LTg2LDEzICs4NywyOCBAQCB2b2lkIENocm9tZUNsaWVudEVmbDo6Zm9jdXNlZE5vZGVDaGFuZ2Vk CiAKIEZsb2F0UmVjdCBDaHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QoKQogewotICAgIG5vdElt cGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIEZsb2F0UmVjdCgpOworICAgIEVjb3JlX0V2YXMqIGVl ID0gMDsKKyAgICBpbnQgeCwgeSwgdywgaDsKKworICAgIGlmICghbV92aWV3KQorICAgICAgICBy ZXR1cm4gRmxvYXRSZWN0KCk7CisKKyAgICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQo ZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3KSk7CisgICAgZWNvcmVfZXZhc19nZW9tZXRyeV9n ZXQoZWUsICZ4LCAmeSwgJncsICZoKTsKKyAgICByZXR1cm4gRmxvYXRSZWN0KHgsIHksIHcsIGgp OwogfQogCiB2b2lkIENocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdChjb25zdCBGbG9hdFJl Y3QmIHJlY3QpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBFY29yZV9FdmFzKiBlZSA9 IDA7CisgICAgSW50UmVjdCBpbnRyZWN0ID0gSW50UmVjdChyZWN0KTsKKworICAgIGlmICghbV92 aWV3KQorICAgICAgICByZXR1cm47CisKKyAgICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19n ZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3KSk7CisgICAgZWNvcmVfZXZhc19tb3ZlKGVl LCBpbnRyZWN0LngoKSwgaW50cmVjdC55KCkpOworICAgIGVjb3JlX2V2YXNfcmVzaXplKGVlLCBp bnRyZWN0LndpZHRoKCksIGludHJlY3QuaGVpZ2h0KCkpOwogfQogCiBGbG9hdFJlY3QgQ2hyb21l Q2xpZW50RWZsOjpwYWdlUmVjdCgpCg== 59466 2010-06-22 19:44:00 -0700 2010-06-23 19:06:14 -0700 patch for windowRect and setWindowRect patch-for-windowrect.txt text/plain 2042 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE2MDcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKyAgICAgICAgMjAxMC0wNi0yMSBHeXV5b3VuZyBLaW0gPGd5dXlvdW5nLmtp bUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dSZWN0KCkg aW4gQ2hyb21lQ2xpZW50RWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDA4NzYKKworICAgICAgICAqIGVmbC9XZWJDb3JlU3VwcG9ydC9DaHJv bWVDbGllbnRFZmwuY3BwOiBJbXBsZW1lbnRzIHR3byBmdW5jdGlvbnMKKyAgICAgICAgKFdlYkNv cmU6OkNocm9tZUNsaWVudEVmbDo6d2luZG93UmVjdCk6IEltcGxlbWVudHMgdGhpcyBmdW5jdGlv bgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZsOjpzZXRXaW5kb3dSZWN0KTogSW1w bGVtZW50cyB0aGlzIGZ1bmN0aW9uCisKIDIwMTAtMDYtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRl eDogV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAkocmV2 aXNpb24gNjE1MzYpCisrKyBXZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVm bC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDkgKzQ4LDEwIEBACiAjaW5jbHVkZSAiUGxhdGZv cm1TdHJpbmcuaCIKICNpbmNsdWRlICJXaW5kb3dGZWF0dXJlcy5oIgogI2luY2x1ZGUgImV3a19w cml2YXRlLmgiCisjaW5jbHVkZSA8RWNvcmVfRXZhcy5oPgorI2luY2x1ZGUgPEV2YXMuaD4KICNp bmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKLSNpbmNsdWRlIDxFdmFzLmg+CiAKIHVzaW5n IG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC04NiwxMyArODcsMjggQEAgdm9pZCBDaHJvbWVDbGll bnRFZmw6OmZvY3VzZWROb2RlQ2hhbmdlZAogCiBGbG9hdFJlY3QgQ2hyb21lQ2xpZW50RWZsOjp3 aW5kb3dSZWN0KCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBGbG9hdFJl Y3QoKTsKKyAgICBFY29yZV9FdmFzKiBlZSA9IDA7CisgICAgaW50IHgsIHksIHcsIGg7CisKKyAg ICBpZiAoIW1fdmlldykKKyAgICAgICAgcmV0dXJuIEZsb2F0UmVjdCgpOworCisgICAgZWUgPSBl Y29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KG1fdmlldykpOwor ICAgIGVjb3JlX2V2YXNfZ2VvbWV0cnlfZ2V0KGVlLCAmeCwgJnksICZ3LCAmaCk7CisgICAgcmV0 dXJuIEZsb2F0UmVjdCh4LCB5LCB3LCBoKTsKIH0KIAogdm9pZCBDaHJvbWVDbGllbnRFZmw6OnNl dFdpbmRvd1JlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogewotICAgIG5vdEltcGxlbWVudGVk KCk7CisgICAgRWNvcmVfRXZhcyogZWUgPSAwOworICAgIEludFJlY3QgaW50cmVjdCA9IEludFJl Y3QocmVjdCk7CisKKyAgICBpZiAoIW1fdmlldykKKyAgICAgICAgcmV0dXJuOworCisgICAgZWUg PSBlY29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KG1fdmlldykp OworICAgIGVjb3JlX2V2YXNfbW92ZShlZSwgaW50cmVjdC54KCksIGludHJlY3QueSgpKTsKKyAg ICBlY29yZV9ldmFzX3Jlc2l6ZShlZSwgaW50cmVjdC53aWR0aCgpLCBpbnRyZWN0LmhlaWdodCgp KTsKIH0KIAogRmxvYXRSZWN0IENocm9tZUNsaWVudEVmbDo6cGFnZVJlY3QoKQo= 59601 2010-06-23 19:06:14 -0700 2010-06-30 18:08:11 -0700 patch for windowRect and setWindowRect patch-for-windowrect.txt text/plain 2023 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjE2MDcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTUgQEAKKyAgICAgICAgMjAxMC0wNi0yMSBHeXV5b3VuZyBLaW0gPGd5dXlvdW5nLmtp bUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dSZWN0KCkg aW4gQ2hyb21lQ2xpZW50RWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDA4NzYKKworICAgICAgICAqIGVmbC9XZWJDb3JlU3VwcG9ydC9DaHJv bWVDbGllbnRFZmwuY3BwOiBJbXBsZW1lbnRzIHR3byBtZXRob2RzCisgICAgICAgIHRvIGNoYW5n ZSB3aW5kb3cgc2l6ZS4KKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6d2luZG93 UmVjdCk6IAorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZsOjpzZXRXaW5kb3dSZWN0 KToKKwogMjAxMC0wNi0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJLaXQvZWZsL1dlYkNv cmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCShyZXZpc2lvbiA2MTUzNikKKysrIFdl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDgsOSArNDgsMTAgQEAKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgogI2luY2x1 ZGUgIldpbmRvd0ZlYXR1cmVzLmgiCiAjaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKKyNpbmNsdWRl IDxFY29yZV9FdmFzLmg+CisjaW5jbHVkZSA8RXZhcy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NT dHJpbmcuaD4KIAotI2luY2x1ZGUgPEV2YXMuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 CiAKQEAgLTg2LDEzICs4NywyOCBAQCB2b2lkIENocm9tZUNsaWVudEVmbDo6Zm9jdXNlZE5vZGVD aGFuZ2VkCiAKIEZsb2F0UmVjdCBDaHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QoKQogewotICAg IG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIEZsb2F0UmVjdCgpOworICAgIEVjb3JlX0V2 YXMqIGVlID0gMDsKKyAgICBpbnQgeCwgeSwgdywgaDsKKworICAgIGlmICghbV92aWV3KQorICAg ICAgICByZXR1cm4gRmxvYXRSZWN0KCk7CisKKyAgICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZh c19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3KSk7CisgICAgZWNvcmVfZXZhc19nZW9t ZXRyeV9nZXQoZWUsICZ4LCAmeSwgJncsICZoKTsKKyAgICByZXR1cm4gRmxvYXRSZWN0KHgsIHks IHcsIGgpOwogfQogCiB2b2lkIENocm9tZUNsaWVudEVmbDo6c2V0V2luZG93UmVjdChjb25zdCBG bG9hdFJlY3QmIHJlY3QpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBFY29yZV9FdmFz KiBlZSA9IDA7CisgICAgSW50UmVjdCBpbnRyZWN0ID0gSW50UmVjdChyZWN0KTsKKworICAgIGlm ICghbV92aWV3KQorICAgICAgICByZXR1cm47CisKKyAgICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVf ZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3KSk7CisgICAgZWNvcmVfZXZhc19t b3ZlKGVlLCBpbnRyZWN0LngoKSwgaW50cmVjdC55KCkpOworICAgIGVjb3JlX2V2YXNfcmVzaXpl KGVlLCBpbnRyZWN0LndpZHRoKCksIGludHJlY3QuaGVpZ2h0KCkpOwogfQogCiBGbG9hdFJlY3Qg Q2hyb21lQ2xpZW50RWZsOjpwYWdlUmVjdCgpCg== 60112 2010-06-30 05:37:15 -0700 2010-06-30 06:03:51 -0700 patch for windowRect/setWindowRect patch.txt text/plain 2050 gyuyoung.kim SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNjIxNzgpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTAtMDYtMzAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KKworICAgICAgICBbRUZMXSBJbXBsZW1lbnQgd2luZG93UmVjdCgpIGFuZCBzZXRXaW5kb3dS ZWN0KCkgaW4gQ2hyb21lQ2xpZW50RWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA4NzYKKworICAgICAgICAqIGVmbC9XZWJDb3JlU3VwcG9y dC9DaHJvbWVDbGllbnRFZmwuY3BwOiBJbXBsZW1lbnRzIHR3byBtZXRob2RzCisgICAgICAgIHRv IGNoYW5nZSB3aW5kb3cgc2l6ZS4KKworICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZs Ojp3aW5kb3dSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6c2V0V2lu ZG93UmVjdCk6CisKIDIwMTAtMDYtMjggIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hp QHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpJbmRleDog V2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAkocmV2aXNp b24gNjIxNzgpCisrKyBXZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDkgKzQ5LDkgQEAKICNpbmNsdWRlICJQbGF0Zm9ybVN0 cmluZy5oIgogI2luY2x1ZGUgIldpbmRvd0ZlYXR1cmVzLmgiCiAjaW5jbHVkZSAiZXdrX3ByaXZh dGUuaCIKLSNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+Ci0KKyNpbmNsdWRlIDxFY29yZV9F dmFzLmg+CiAjaW5jbHVkZSA8RXZhcy5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4K IAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTg3LDEzICs4NywyOCBAQCB2b2lkIENo cm9tZUNsaWVudEVmbDo6Zm9jdXNlZE5vZGVDaGFuZ2VkCiAKIEZsb2F0UmVjdCBDaHJvbWVDbGll bnRFZmw6OndpbmRvd1JlY3QoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJu IEZsb2F0UmVjdCgpOworICAgIEVjb3JlX0V2YXMqIGVlID0gMDsKKyAgICBpbnQgeCwgeSwgdywg aDsKKworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm4gRmxvYXRSZWN0KCk7CisKKyAg ICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92 aWV3KSk7CisgICAgZWNvcmVfZXZhc19nZW9tZXRyeV9nZXQoZWUsICZ4LCAmeSwgJncsICZoKTsK KyAgICByZXR1cm4gRmxvYXRSZWN0KHgsIHksIHcsIGgpOwogfQogCiB2b2lkIENocm9tZUNsaWVu dEVmbDo6c2V0V2luZG93UmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7Ci0gICAgbm90SW1w bGVtZW50ZWQoKTsKKyAgICBFY29yZV9FdmFzKiBlZSA9IDA7CisgICAgSW50UmVjdCBpbnRyZWN0 ID0gSW50UmVjdChyZWN0KTsKKworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm47CisK KyAgICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQo bV92aWV3KSk7CisgICAgZWNvcmVfZXZhc19tb3ZlKGVlLCBpbnRyZWN0LngoKSwgaW50cmVjdC55 KCkpOworICAgIGVjb3JlX2V2YXNfcmVzaXplKGVlLCBpbnRyZWN0LndpZHRoKCksIGludHJlY3Qu aGVpZ2h0KCkpOwogfQogCiBGbG9hdFJlY3QgQ2hyb21lQ2xpZW50RWZsOjpwYWdlUmVjdCgpCg==