4086 2005-07-20 15:21:22 -0700 fast_malloc should work on Windows 2007-07-04 22:48:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ PC Windows XP RESOLVED FIXED P2 Normal --- 3356 1 jhaygood mjs bugs-webkit ian webkit oldest_to_newest 14980 0 jhaygood 2005-07-20 15:21:22 -0700 fast_malloc should work on Windows. Patch to do so attached to this. 14981 1 3033 jhaygood 2005-07-20 15:22:59 -0700 Created attachment 3033 Fixes fast_malloc for Windows Fixes fast_malloc for Windows. 14982 2 3033 jhaygood 2005-07-20 15:23:44 -0700 Comment on attachment 3033 Fixes fast_malloc for Windows Fixes fast_malloc for Windows 15146 3 3033 mjs 2005-07-24 16:54:00 -0700 Comment on attachment 3033 Fixes fast_malloc for Windows A couple of comments: +#if WIN32 +#include <assert.h> +#endif Seems like it would be better to include assert.h unconditionally, if it is truly needed. The extra conditional declaration of malloc_init_state seems wrong - wouldn't the definition of __STD_C fall into the proper code path already? +static void *sbrk (int size){ + + return sbrk((long)size); +} Why is this required? Any call passing an int should call through just fine to the version that takes a long. +#ifdef WIN32 +#define NDEBUG +#endif It's incorrect to define NDEBUG unconditionally on Windows. This should be based on whether the build is debug or release. Please addresse these comments and submit a new patch. 3033 2005-07-20 15:22:59 -0700 2005-07-24 16:54:14 -0700 Fixes fast_malloc for Windows fast_malloc.patch text/plain 2389 jhaygood SW5kZXg6IGtqcy9mYXN0X21hbGxvYy5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3Jv b3QvSmF2YVNjcmlwdENvcmUva2pzL2Zhc3RfbWFsbG9jLmNwcCx2DQpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMQ0KZGlmZiAtdSAtcjEuMSBmYXN0X21hbGxvYy5jcHANCi0tLSBranMvZmFzdF9tYWxs b2MuY3BwCTE1IEFwciAyMDA1IDAxOjI2OjI2IC0wMDAwCTEuMQ0KKysrIGtqcy9mYXN0X21hbGxv Yy5jcHAJMjAgSnVsIDIwMDUgMjE6NDM6MDAgLTAwMDANCkBAIC0yMzgsNiArMjM4LDEwIEBADQog I2RlZmluZSBXSU4zMl9MRUFOX0FORF9NRUFODQogI2luY2x1ZGUgPHdpbmRvd3MuaD4NCiANCisv KiBTdGQgQy4uLi4gKi8NCisNCisjZGVmaW5lIF9fU1REX0MgMQ0KKw0KIC8qIFdpbjMyIGRvZXNu J3Qgc3VwcGx5IG9yIG5lZWQgdGhlIGZvbGxvd2luZyBoZWFkZXJzICovDQogI2RlZmluZSBMQUNL U19VTklTVERfSA0KICNkZWZpbmUgTEFDS1NfU1lTX1BBUkFNX0gNCkBAIC0yNDU5LDExICsyNDYz LDE4IEBADQogICBvcHRpbWl6YXRpb24gYXQgYWxsLiAoSW5saW5pbmcgaXQgaW4gbWFsbG9jX2Nv bnNvbGlkYXRlIGlzIGZpbmUgdGhvdWdoLikNCiAqLw0KIA0KKyNpZiBXSU4zMg0KKyNpbmNsdWRl IDxhc3NlcnQuaD4NCisjZW5kaWYNCisjaWZuZGVmIFdJTjMyDQogI2lmIF9fU1REX0MNCiBzdGF0 aWMgdm9pZCBtYWxsb2NfaW5pdF9zdGF0ZShtc3RhdGUgYXYpDQogI2Vsc2UNCiBzdGF0aWMgdm9p ZCBtYWxsb2NfaW5pdF9zdGF0ZShhdikgbXN0YXRlIGF2Ow0KICNlbmRpZg0KKyNlbHNlDQorc3Rh dGljIHZvaWQgbWFsbG9jX2luaXRfc3RhdGUobXN0YXRlIGF2KQ0KKyNlbmRpZg0KIHsNCiAgIGlu dCAgICAgaTsNCiAgIG1iaW5wdHIgYmluOw0KQEAgLTQ5ODAsNiArNDk5MSw3IEBADQogfQ0KIA0K IC8qIEEgcmVnaW9uIGxpc3QgZW50cnkgKi8NCisNCiB0eXBlZGVmIHN0cnVjdCBfcmVnaW9uX2xp c3RfZW50cnkgew0KICAgICB2b2lkICp0b3BfYWxsb2NhdGVkOw0KICAgICB2b2lkICp0b3BfY29t bWl0dGVkOw0KQEAgLTQ5OTAsNyArNTAwMiw3IEBADQogDQogLyogQWxsb2NhdGUgYW5kIGxpbmsg YSByZWdpb24gZW50cnkgaW4gdGhlIHJlZ2lvbiBsaXN0ICovDQogc3RhdGljIGludCByZWdpb25f bGlzdF9hcHBlbmQgKHJlZ2lvbl9saXN0X2VudHJ5ICoqbGFzdCwgdm9pZCAqYmFzZV9yZXNlcnZl ZCwgbG9uZyByZXNlcnZlX3NpemUpIHsNCi0gICAgcmVnaW9uX2xpc3RfZW50cnkgKm5leHQgPSBI ZWFwQWxsb2MgKEdldFByb2Nlc3NIZWFwICgpLCAwLCBzaXplb2YgKHJlZ2lvbl9saXN0X2VudHJ5 KSk7DQorICAgIHJlZ2lvbl9saXN0X2VudHJ5ICpuZXh0ID0gKHJlZ2lvbl9saXN0X2VudHJ5ICop SGVhcEFsbG9jIChHZXRQcm9jZXNzSGVhcCAoKSwgMCwgc2l6ZW9mIChyZWdpb25fbGlzdF9lbnRy eSkpOw0KICAgICBpZiAoISBuZXh0KQ0KICAgICAgICAgcmV0dXJuIEZBTFNFOw0KICAgICBuZXh0 LT50b3BfYWxsb2NhdGVkID0gKGNoYXIgKikgYmFzZV9yZXNlcnZlZDsNCkBAIC01MDE5LDYgKzUw MzEsMTIgQEANCiAvKiAjZGVmaW5lIFNCUktfU0NBTEUgIDQgICovDQogDQogLyogc2JyayBmb3Ig d2luZG93cyAqLw0KKw0KK3N0YXRpYyB2b2lkICpzYnJrIChpbnQgc2l6ZSl7DQorDQorICAgIHJl dHVybiBzYnJrKChsb25nKXNpemUpOw0KK30NCisNCiBzdGF0aWMgdm9pZCAqc2JyayAobG9uZyBz aXplKSB7DQogICAgIHN0YXRpYyBsb25nIGdfcGFnZXNpemUsIGdfbXlfcGFnZXNpemU7DQogICAg IHN0YXRpYyBsb25nIGdfcmVnaW9uc2l6ZSwgZ19teV9yZWdpb25zaXplOw0KSW5kZXg6IGtqcy9m YXN0X21hbGxvYy5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFTY3JpcHRD b3JlL2tqcy9mYXN0X21hbGxvYy5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xDQpkaWZmIC11 IC1yMS4xIGZhc3RfbWFsbG9jLmgNCi0tLSBranMvZmFzdF9tYWxsb2MuaAkxNSBBcHIgMjAwNSAw MToyNjoyNiAtMDAwMAkxLjENCisrKyBranMvZmFzdF9tYWxsb2MuaAkyMCBKdWwgMjAwNSAxOTo1 Njo0NSAtMDAwMA0KQEAgLTMwLDYgKzMwLDEwIEBADQogLy8gd2hpbGUgaG9sZGluZyB0aGUgY29s bGVjdG9yIGxvY2sgKHRoaXMgaXMgdHJ1ZSB3aGVuZW5ldmVyIHRoZSBpbnRlcnByZXRlciBpcw0K IC8vIGV4ZWN1dGluZyBvciBHQyBpcyB0YWtpbmcgcGxhY2UpLg0KIA0KKyNpZmRlZiBXSU4zMg0K KyNkZWZpbmUgTkRFQlVHDQorI2VuZGlmDQorDQogDQogI2lmbmRlZiBOREVCVUcNCiANCg==