40852 2010-06-18 13:29:59 -0700 Limit simultaneous DNS prefetch request number 2010-06-18 14:06:38 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 ap ap darin levin psolanki oldest_to_newest 240102 0 ap 2010-06-18 13:29:59 -0700 We currently queue up to 64 requests, and fire them all at once. Making 64 requests at once can overwhelm some routers. <rdar://problem/8105498> 240112 1 59150 ap 2010-06-18 13:46:12 -0700 Created attachment 59150 proposed fix 240114 2 59150 darin 2010-06-18 13:48:16 -0700 Comment on attachment 59150 proposed fix Using a HashSet means the order of the names is based on hash table ordering, essentially random. Should we do something to preserve the order? 240117 3 59150 ggaren 2010-06-18 13:55:44 -0700 Comment on attachment 59150 proposed fix r=me How did you test that this scheme does not overwhelm important gateways? 240118 4 levin 2010-06-18 13:57:07 -0700 Since you are fixing the comment on line 58 of WebCore/platform/network/cf/DNSCFNet.cpp, maybe you can fix a spelling error as well "appications'". 240122 5 ap 2010-06-18 13:59:32 -0700 I am not aware of a strong reason why ordering would be important (my comment in code about dropping newer names notwithstanding). > How did you test that this scheme does not overwhelm important gateways? We know that chromium uses 8 parallel requests (because it has 8 loader threads), so I'm relying on matching them. Also, a co-worker seems to be able to reproduce the problem, so we'll test to see if a nightly resolves it. 240128 6 ap 2010-06-18 14:06:38 -0700 Committed <http://trac.webkit.org/changeset/61435>. 59150 2010-06-18 13:46:12 -0700 2010-06-18 13:55:44 -0700 proposed fix 8requests.txt text/plain 3801 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTQzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDYtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODUyCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS84MTA1NDk4PiBMaW1pdCBzaW11bHRhbmVvdXMgRE5TIHByZWZldGNoIHJl cXVlc3QgbnVtYmVyICg0MDg1MikKKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0 eSwgc28gbm8gdGVzdHMuCisKKyAgICAgICAgV2Ugc3RpbGwgcXVldWUgdXAgdG8gNjQgbmFtZXMs IGJ1dCBvbmx5IG1ha2UgdXAgdG8gOCByZXF1ZXN0cyBhdCBvbmNlLiBJZiB0aGVyZSBhcmUgbmFt ZXMKKyAgICAgICAgcmVtYWluaW5nIGluIHF1ZXVlLCB3ZSByZXRyeSBhZnRlciBhIHNob3J0IHRp bWVvdXQgKHdoaWNoIGlzIGVhc2llciB0aGFuIHBvc3RpbmcKKyAgICAgICAgbm90aWZpY2F0aW9u cyBmcm9tIGNsaWVudCBjYWxsYmFjaykuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2Nm L0ROU0NGTmV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkROU1Jlc29sdmVRdWV1ZTo6YWRkKToK KyAgICAgICAgKFdlYkNvcmU6OkROU1Jlc29sdmVRdWV1ZTo6ZmlyZWQpOgorCiAyMDEwLTA2LTE4 ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9ETlND Rk5ldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0ROU0NG TmV0LmNwcAkocmV2aXNpb24gNjE0MTQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2Yv RE5TQ0ZOZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSwxMiArNDksMTggQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogY29uc3QgaW50IG5hbWVzVG9SZXNvbHZlSW1tZWRpYXRlbHkgPSA0OwogCiAv LyBDb2FsZXNjZSBwcmVmZXRjaCByZXF1ZXN0cyBmb3IgdGhpcyBsb25nIGJlZm9yZSBzZW5kaW5n IHRoZW0gb3V0LgotY29uc3QgZG91YmxlIGNvYWxlc2NlRGVsYXkgPSAxLjA7Citjb25zdCBkb3Vi bGUgY29hbGVzY2VEZWxheUluU2Vjb25kcyA9IDEuMDsKKworLy8gU2VuZGluZyBtYW55IEROUyBy ZXF1ZXN0cyBhdCBvbmNlIGNhbiBvdmVyd2hlbG0gc29tZSBnYXRld2F5cy4gQ0ZIb3N0IGRvZXNu J3QgY3VycmVudGx5IHRocm90dGxlIGZvciB1cywgc2VlIDxyZGFyOi8vODEwNTU1MD4uCitjb25z dCBpbnQgbWF4U2ltdWx0YW5lb3VzUmVxdWVzdHMgPSA4OwogCiAvLyBGb3IgYSBwYWdlIGhhcyBs aW5rcyB0byBtYW55IG91dHNpZGUgc2l0ZXMsIGl0IGlzIGxpa2VseSB0aGF0IHRoZSBzeXN0ZW0g RE5TIHJlc29sdmVyIHdvbid0IGJlIGFibGUgdG8gY2FjaGUgdGhlbSBhbGwgYW55d2F5LCBhbmQg d2UgZG9uJ3Qgd2FudAotLy8gdG8gbmVnYXRpdmVseSBhZmZlY3Qgb3RoZXIgYXBwaWNhdGlvbnMn IHBlcmZvcm1hbmNlLCBieSBwdXNoaW5nIHRoZWlyIGNhY2hlZCBlbnRyaWVzIG91dCwgdG9vLgor Ly8gdG8gbmVnYXRpdmVseSBhZmZlY3Qgb3RoZXIgYXBwaWNhdGlvbnMnIHBlcmZvcm1hbmNlIGJ5 IHB1c2hpbmcgdGhlaXIgY2FjaGVkIGVudHJpZXMgb3V0LgogLy8gSWYgd2UgZW5kIHVwIHdpdGgg bG90cyBvZiBuYW1lcyB0byBwcmVmZXRjaCwgc29tZSB3aWxsIGJlIGRyb3BwZWQuCi1jb25zdCBp bnQgbWF4UmVxdWVzdHNUb1NlbmQgPSA2NDsKK2NvbnN0IGludCBtYXhSZXF1ZXN0c1RvUXVldWUg PSA2NDsKKworLy8gSWYgdGhlcmUgd2VyZSBxdWV1ZWQgbmFtZXMgdGhhdCBjb3VsZG4ndCBiZSBz ZW50IHNpbXVsdGFuZW91c2x5LCBjaGVjayB0aGUgc3RhdGUgb2YgcmVzb2x2ZXJzIGFmdGVyIHRo aXMgZGVsYXkuCitjb25zdCBkb3VibGUgcmV0cnlSZXNvbHZpbmdJblNlY29uZHMgPSAwLjE7CiAK IGNsYXNzIEROU1Jlc29sdmVRdWV1ZSA6IHB1YmxpYyBUaW1lckJhc2UgewogcHVibGljOgpAQCAt OTIsOSArOTgsMTQgQEAgdm9pZCBETlNSZXNvbHZlUXVldWU6OmFkZChjb25zdCBTdHJpbmcmIAog ICAgICAgICB9CiAgICAgICAgIGF0b21pY0RlY3JlbWVudCgmbV9yZXF1ZXN0c0luRmxpZ2h0KTsK ICAgICB9Ci0gICAgbV9uYW1lcy5hZGQobmFtZSk7Ci0gICAgaWYgKCFpc0FjdGl2ZSgpKQotICAg ICAgICBzdGFydE9uZVNob3QoY29hbGVzY2VEZWxheSk7CisKKyAgICAvLyBJdCdzIGJldHRlciB0 byBub3QgcHJlZmV0Y2ggc29tZSBuYW1lcyB0aGFuIHRvIGNsb2cgdGhlIHF1ZXVlLgorICAgIC8v IERyb3BwaW5nIHRoZSBuZXdlc3QgbmFtZXMsIGJlY2F1c2Ugb24gYSBzaW5nbGUgcGFnZSwgdGhl c2UgYXJlIGxpa2VseSB0byBiZSBiZWxvdyBvbGRlc3Qgb25lcy4KKyAgICBpZiAobV9uYW1lcy5z aXplKCkgPCBtYXhSZXF1ZXN0c1RvUXVldWUpIHsKKyAgICAgICAgbV9uYW1lcy5hZGQobmFtZSk7 CisgICAgICAgIGlmICghaXNBY3RpdmUoKSkKKyAgICAgICAgICAgIHN0YXJ0T25lU2hvdChjb2Fs ZXNjZURlbGF5SW5TZWNvbmRzKTsKKyAgICB9CiB9CiAKIHZvaWQgRE5TUmVzb2x2ZVF1ZXVlOjpk ZWNyZW1lbnRSZXF1ZXN0Q291bnQoKQpAQCAtMTA0LDE1ICsxMTUsMTcgQEAgdm9pZCBETlNSZXNv bHZlUXVldWU6OmRlY3JlbWVudFJlcXVlc3RDbwogCiB2b2lkIEROU1Jlc29sdmVRdWV1ZTo6Zmly ZWQoKQogewotICAgIGludCByZXF1ZXN0c0FsbG93ZWQgPSBtYXhSZXF1ZXN0c1RvU2VuZCAtIG1f cmVxdWVzdHNJbkZsaWdodDsKKyAgICBpbnQgcmVxdWVzdHNBbGxvd2VkID0gbWF4U2ltdWx0YW5l b3VzUmVxdWVzdHMgLSBtX3JlcXVlc3RzSW5GbGlnaHQ7CiAKLSAgICBmb3IgKEhhc2hTZXQ8U3Ry aW5nPjo6aXRlcmF0b3IgaXRlciA9IG1fbmFtZXMuYmVnaW4oKTsgaXRlciAhPSBtX25hbWVzLmVu ZCgpICYmIHJlcXVlc3RzQWxsb3dlZCA+IDA7ICsraXRlciwgLS1yZXF1ZXN0c0FsbG93ZWQpIHsK KyAgICBmb3IgKDsgIW1fbmFtZXMuaXNFbXB0eSgpICYmIHJlcXVlc3RzQWxsb3dlZCA+IDA7IC0t cmVxdWVzdHNBbGxvd2VkKSB7CiAgICAgICAgIGF0b21pY0luY3JlbWVudCgmbV9yZXF1ZXN0c0lu RmxpZ2h0KTsKLSAgICAgICAgcmVzb2x2ZSgqaXRlcik7CisgICAgICAgIEhhc2hTZXQ8U3RyaW5n Pjo6aXRlcmF0b3IgY3VycmVudE5hbWUgPSBtX25hbWVzLmJlZ2luKCk7CisgICAgICAgIHJlc29s dmUoKmN1cnJlbnROYW1lKTsKKyAgICAgICAgbV9uYW1lcy5yZW1vdmUoY3VycmVudE5hbWUpOwog ICAgIH0KIAotICAgIC8vIEl0J3MgYmV0dGVyIHRvIHNraXAgc29tZSBuYW1lcyB0aGFuIHRvIGNs b2cgdGhlIHF1ZXVlLgotICAgIG1fbmFtZXMuY2xlYXIoKTsKKyAgICBpZiAoIW1fbmFtZXMuaXNF bXB0eSgpKQorICAgICAgICBzdGFydE9uZVNob3QocmV0cnlSZXNvbHZpbmdJblNlY29uZHMpOwog fQogCiBzdGF0aWMgdm9pZCBjbGllbnRDYWxsYmFjayhDRkhvc3RSZWYgdGhlSG9zdCwgQ0ZIb3N0 SW5mb1R5cGUsIGNvbnN0IENGU3RyZWFtRXJyb3IqLCB2b2lkKikK