40844 2010-06-18 10:01:40 -0700 [v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debugging is on 2010-06-20 23:44:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yurys yurys pfeldman timothy oldest_to_newest 239995 0 yurys 2010-06-18 10:01:40 -0700 [v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debugging is on 239997 1 59128 yurys 2010-06-18 10:05:07 -0700 Created attachment 59128 Patch 240310 2 59128 pfeldman 2010-06-19 03:21:34 -0700 Comment on attachment 59128 Patch WebCore/bindings/v8/ScriptDebugServer.cpp:314 + return m_enabled; If you get front-end accidentally opened, you will still be able to set the listener from within the front-end code, right? 240597 3 yurys 2010-06-20 22:42:35 -0700 (In reply to comment #2) > (From update of attachment 59128 [details]) > WebCore/bindings/v8/ScriptDebugServer.cpp:314 > + return m_enabled; > If you get front-end accidentally opened, you will still be able to set the listener from within the front-end code, right? Correct. 240605 4 59128 yurys 2010-06-20 23:44:33 -0700 Comment on attachment 59128 Patch Clearing flags on attachment: 59128 Committed r61529: <http://trac.webkit.org/changeset/61529> 240606 5 yurys 2010-06-20 23:44:42 -0700 All reviewed patches have been landed. Closing bug. 59128 2010-06-18 10:05:07 -0700 2010-06-20 23:44:33 -0700 Patch bug-40844-20100618210504.patch text/plain 4185 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzQ1ZmNmODMyNGEwMWEzMDBmZDNjYzkxNjRkZTBkZmRlYTdiMjExMC4uYTEzOGI2ZjQ1ODIxNWJm OWZkYWE0MzFjNzkyNDIyOTNlNWRkNjExZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNi0xOCAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIFdlYiBJbnNwZWN0b3I6IGRvbid0IGFk ZCBTY3JpcHREZWJ1Z1NlcnZlciBhcyB2OCBsaXN0ZW5lciBpZiBicm93c2VyIGV4cG9zZXMKKyAg ICAgICAgdjggZGVidWdnaW5nIHByb3RvY29sLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA4NDQKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Njcmlw dERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdERlYnVnU2VydmVyOjpT Y3JpcHREZWJ1Z1NlcnZlcik6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHREZWJ1Z1NlcnZlcjo6 YWRkTGlzdGVuZXIpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RGVidWdTZXJ2ZXI6OnNldEVu YWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RGVidWdTZXJ2ZXI6OmlzRGVidWdnZXJB bHdheXNFbmFibGVkKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5o OgorCiAyMDEwLTA2LTE4ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmNwcCBiL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCmluZGV4IGI4ZTVlYzQyNDQzODcwNWU1ZDhjNTY2 ODgwNzE0MTQxNWFkYzRhMGIuLjM4ZmNkOGE4NDhjMzg2OTA5OWU1N2EyZWZlMmVjMWU4YmZjMGUw YjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2ZXIuY3Bw CisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCkBAIC03Miw2 ICs3Miw3IEBAIFNjcmlwdERlYnVnU2VydmVyJiBTY3JpcHREZWJ1Z1NlcnZlcjo6c2hhcmVkKCkK IFNjcmlwdERlYnVnU2VydmVyOjpTY3JpcHREZWJ1Z1NlcnZlcigpCiAgICAgOiBtX3BhdXNlT25F eGNlcHRpb25zU3RhdGUoRG9udFBhdXNlT25FeGNlcHRpb25zKQogICAgICwgbV9wYXVzZWRQYWdl KDApCisgICAgLCBtX2VuYWJsZWQodHJ1ZSkKIHsKIH0KIApAQCAtODMsNiArODQsOCBAQCB2b2lk IFNjcmlwdERlYnVnU2VydmVyOjpzZXREZWJ1Z2dlclNjcmlwdFNvdXJjZShjb25zdCBTdHJpbmcm IHNjcmlwdFNvdXJjZSkKIHZvaWQgU2NyaXB0RGVidWdTZXJ2ZXI6OmFkZExpc3RlbmVyKFNjcmlw dERlYnVnTGlzdGVuZXIqIGxpc3RlbmVyLCBQYWdlKiBwYWdlKQogewogI2lmIEVOQUJMRShWOF9T Q1JJUFRfREVCVUdfU0VSVkVSKQorICAgIGlmICghbV9lbmFibGVkKQorICAgICAgICByZXR1cm47 CiAgICAgdjg6OkhhbmRsZVNjb3BlIHNjb3BlOwogICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4g ZGVidWdnZXJDb250ZXh0ID0gdjg6OkRlYnVnOjpHZXREZWJ1Z0NvbnRleHQoKTsKICAgICB2ODo6 Q29udGV4dDo6U2NvcGUgY29udGV4dFNjb3BlKGRlYnVnZ2VyQ29udGV4dCk7CkBAIC0zMDEsOSAr MzA0LDE0IEBAIFBhc3NSZWZQdHI8SmF2YVNjcmlwdENhbGxGcmFtZT4gU2NyaXB0RGVidWdTZXJ2 ZXI6OmN1cnJlbnRDYWxsRnJhbWUoKQogICAgIHJldHVybiBtX2N1cnJlbnRDYWxsRnJhbWU7CiB9 CiAKK3ZvaWQgU2NyaXB0RGVidWdTZXJ2ZXI6OnNldEVuYWJsZWQoYm9vbCB2YWx1ZSkKK3sKKyAg ICAgbV9lbmFibGVkID0gdmFsdWU7Cit9CisKIGJvb2wgU2NyaXB0RGVidWdTZXJ2ZXI6OmlzRGVi dWdnZXJBbHdheXNFbmFibGVkKCkKIHsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gbV9l bmFibGVkOwogfQogCiAjaWYgRU5BQkxFKFY4X1NDUklQVF9ERUJVR19TRVJWRVIpCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmggYi9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmgKaW5kZXggOTQzOWMxNjI3MDNhNDMwZGM3ZjFk ODgxZTlmZWQxNzc4ZTBiYjgyMC4uYjQ2ZjY3MzZiNmQ5YjAzYzRiOTNmYWQ4NmViNTNlMTk3NWE0 YjRlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5o CisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2ZXIuaApAQCAtOTQsNiAr OTQsNyBAQCBwdWJsaWM6CiAKICAgICBQYXNzUmVmUHRyPEphdmFTY3JpcHRDYWxsRnJhbWU+IGN1 cnJlbnRDYWxsRnJhbWUoKTsKIAorICAgIHZvaWQgc2V0RW5hYmxlZChib29sKTsKICAgICBib29s IGlzRGVidWdnZXJBbHdheXNFbmFibGVkKCk7CiAKIHByaXZhdGU6CkBAIC0xMTksNiArMTIwLDcg QEAgcHJpdmF0ZToKICAgICBPd25IYW5kbGU8djg6Ok9iamVjdD4gbV9leGVjdXRpb25TdGF0ZTsK ICAgICBPd25QdHI8Q2xpZW50TWVzc2FnZUxvb3A+IG1fY2xpZW50TWVzc2FnZUxvb3A7CiAgICAg UGFnZSogbV9wYXVzZWRQYWdlOworICAgIGJvb2wgbV9lbmFibGVkOwogfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNjNlNTQ2NDUyMjY3NDJkMmZmMTc5MzQ2ZGZk M2NmNzhkZGUzYTE0Ny4uNWQxMWMyMDU4YmJlYjFlNTE3MTkxOTZkMTY4NjQ4ZDJmMmMxM2Y5MyAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMTggIFl1cnkgU2VtaWtoYXRz a3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW3Y4XSBXZWIgSW5zcGVjdG9yOiBkb24ndCBhZGQgU2NyaXB0RGVi dWdTZXJ2ZXIgYXMgdjggbGlzdGVuZXIgaWYgYnJvd3NlciBleHBvc2VzCisgICAgICAgIHY4IGRl YnVnZ2luZyBwcm90b2NvbC4KKworICAgICAgICAqIHNyYy9EZWJ1Z2dlckFnZW50TWFuYWdlci5j cHA6CisgICAgICAgIChXZWJLaXQ6OkRlYnVnZ2VyQWdlbnRNYW5hZ2VyOjpzZXRFeHBvc2VWOERl YnVnZ2VyUHJvdG9jb2wpOgorCiAyMDEwLTA2LTE4ICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5v dkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4K ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvRGVidWdnZXJBZ2VudE1hbmFnZXIuY3Bw IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9EZWJ1Z2dlckFnZW50TWFuYWdlci5jcHAKaW5kZXggYTMw Njc1ZDMxZjhiM2I5M2E1MGJhOTEwMTBhODJhMjY2ZWQwNjMyMS4uOTM5ZjRlZDVhMjFiYjQ0Y2Nh NDc1YWM2YmI4NWVhZDE4ZWQ1OTk0YyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9E ZWJ1Z2dlckFnZW50TWFuYWdlci5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9EZWJ1Z2dl ckFnZW50TWFuYWdlci5jcHAKQEAgLTI2NSw5ICsyNjUsOSBAQCB2b2lkIERlYnVnZ2VyQWdlbnRN YW5hZ2VyOjpzZXRNZXNzYWdlTG9vcERpc3BhdGNoSGFuZGxlcihXZWJEZXZUb29sc0FnZW50OjpN ZXNzYQogdm9pZCBEZWJ1Z2dlckFnZW50TWFuYWdlcjo6c2V0RXhwb3NlVjhEZWJ1Z2dlclByb3Rv Y29sKGJvb2wgdmFsdWUpCiB7CiAgICAgc19leHBvc2VWOERlYnVnZ2VyUHJvdG9jb2wgPSB2YWx1 ZTsKKyAgICBXZWJDb3JlOjpTY3JpcHREZWJ1Z1NlcnZlcjo6c2hhcmVkKCkuc2V0RW5hYmxlZCgh c19leHBvc2VWOERlYnVnZ2VyUHJvdG9jb2wpOwogfQogCi0KIHZvaWQgRGVidWdnZXJBZ2VudE1h bmFnZXI6OnNldEhvc3RJZChXZWJGcmFtZUltcGwqIHdlYmZyYW1lLCBpbnQgaG9zdElkKQogewog ICAgIEFTU0VSVChob3N0SWQgPiAwKTsK