40843 2010-06-18 09:35:55 -0700 [GTK] Clean up the use of gdk_window_get_root_coords in EventSender 2010-06-24 17:23:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 239982 0 mrobinson 2010-06-18 09:35:55 -0700 The logic for the backward compatible version is little bit more complex than necessary and it can be defined in such a way as to not pepper #ifdef's through the file. 239984 1 59125 mrobinson 2010-06-18 09:38:33 -0700 Created attachment 59125 Cleanup patch 242622 2 59125 xan.lopez 2010-06-24 12:20:18 -0700 Comment on attachment 59125 Cleanup patch Good. 242750 3 59125 mrobinson 2010-06-24 17:23:08 -0700 Comment on attachment 59125 Cleanup patch Clearing flags on attachment: 59125 Committed r61805: <http://trac.webkit.org/changeset/61805> 242751 4 mrobinson 2010-06-24 17:23:13 -0700 All reviewed patches have been landed. Closing bug. 59125 2010-06-18 09:38:33 -0700 2010-06-24 17:23:08 -0700 Cleanup patch bug-40843-20100618093831.patch text/plain 3395 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxYjk5MzZkNDJhMWQwYmE0MzU0YWQyM2M0YjQ1NjU0OWVkOGYwNmI1Li41NDdkYTJi ZjMwNTJlNGJlZjM5YjkwZTk0NzZiOGVlNzcxZTkxNmViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDYtMTggIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIENsZWFu IHVwIHRoZSB1c2Ugb2YgZ2RrX3dpbmRvd19nZXRfcm9vdF9jb29yZHMgaW4gRXZlbnRTZW5kZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODQzCisK KyAgICAgICAgRGVmaW5lIHRoZSB2ZXJzaW9uIGZvciBvbGQgR1RLK3MgaW4gYSB3YXkgdGhhdCBp cyBmb3J3YXJkLWNvbXBhdGlibGUKKyAgICAgICAgYW5kIGNsZWFuIHVwIHRoZSBsb2dpYyBhIGJp dC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHA6CisgICAg ICAgIChnZGtfd2luZG93X2dldF9yb290X2Nvb3Jkcyk6IFJlbmFtZWQgYW5kIGNsZWFuZWQgdXAu CisgICAgICAgIChwcmVwYXJlTW91c2VCdXR0b25FdmVudCk6IFJlbW92ZSAjaWZkZWZzLgorICAg ICAgICAobW91c2VNb3ZlVG9DYWxsYmFjayk6IFJlbW92ZSAjaWZkZWZzLgorCiAyMDEwLTA2LTE3 ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg S2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RXZlbnRTZW5kZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2Vu ZGVyLmNwcAppbmRleCBiYjc3YjY3ZTNlY2I4NDVhNjcxMzUzNzZjYTIwYzc5YjdiY2RiM2M1Li43 ODM2ZmYwYTZjZjVmOGNhZTk4YTQ4ZDFhMjU1MGEzZDJmMDQ0YjkzIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKQEAgLTg3LDYgKzg3LDE1IEBA IHN0YXRpYyB2b2lkIHNlbmRPclF1ZXVlRXZlbnQoR2RrRXZlbnQsIGJvb2wgPSB0cnVlKTsKIHN0 YXRpYyB2b2lkIGRpc3BhdGNoRXZlbnQoR2RrRXZlbnQgZXZlbnQpOwogc3RhdGljIGd1aW50IGdl dFN0YXRlRmxhZ3MoKTsKIAorI2lmICFHVEtfQ0hFQ0tfVkVSU0lPTigyLCAxNywgMykKK3N0YXRp YyB2b2lkIGdka193aW5kb3dfZ2V0X3Jvb3RfY29vcmRzKEdka1dpbmRvdyogd2luZG93LCBnaW50 IHgsIGdpbnQgeSwgZ2ludCogcm9vdFgsIGdpbnQqIHJvb3RZKQoreworICAgIGdka193aW5kb3df Z2V0X3Jvb3Rfb3JpZ2luKHdpbmRvdywgcm9vdFgsIHJvb3RZKTsKKyAgICAqcm9vdFggPSAqcm9v dFggKyB4OworICAgICpyb290WSA9ICpyb290WSArIHk7Cit9CisjZW5kaWYKKwogc3RhdGljIEpT VmFsdWVSZWYgZ2V0RHJhZ01vZGVDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmpl Y3RSZWYgb2JqZWN0LCBKU1N0cmluZ1JlZiBwcm9wZXJ0eU5hbWUsIEpTVmFsdWVSZWYqIGV4Y2Vw dGlvbikKIHsKICAgICByZXR1cm4gSlNWYWx1ZU1ha2VCb29sZWFuKGNvbnRleHQsIGRyYWdNb2Rl KTsKQEAgLTEwOSwyMSArMTE4LDYgQEAgc3RhdGljIEpTVmFsdWVSZWYgbGVhcEZvcndhcmRDYWxs YmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24KICAgICByZXR1 cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CiB9CiAKLSNpZiAhR1RLX0NIRUNLX1ZF UlNJT04oMiwxNywzKQotc3RhdGljIHZvaWQgZ2V0Um9vdENvb3JkcyhHdGtXaWRnZXQqIHZpZXcs IGludCogcm9vdFgsIGludCogcm9vdFkpCi17Ci0gICAgR3RrV2lkZ2V0KiB3aW5kb3cgPSBndGtf d2lkZ2V0X2dldF90b3BsZXZlbChHVEtfV0lER0VUKHZpZXcpKTsKLSAgICBpbnQgdG1wWCwgdG1w WTsKLQotICAgIGd0a193aWRnZXRfdHJhbnNsYXRlX2Nvb3JkaW5hdGVzKHZpZXcsIHdpbmRvdywg bGFzdE1vdXNlUG9zaXRpb25YLCBsYXN0TW91c2VQb3NpdGlvblksICZ0bXBYLCAmdG1wWSk7Ci0K LSAgICBnZGtfd2luZG93X2dldF9vcmlnaW4od2luZG93LT53aW5kb3csIHJvb3RYLCByb290WSk7 Ci0KLSAgICAqcm9vdFggKz0gdG1wWDsKLSAgICAqcm9vdFkgKz0gdG1wWTsKLX0KLSNlbmRpZgot CiBib29sIHByZXBhcmVNb3VzZUJ1dHRvbkV2ZW50KEdka0V2ZW50KiBldmVudCwgaW50IGV2ZW50 U2VuZGVyQnV0dG9uTnVtYmVyKQogewogICAgIFdlYktpdFdlYlZpZXcqIHZpZXcgPSB3ZWJraXRf d2ViX2ZyYW1lX2dldF93ZWJfdmlldyhtYWluRnJhbWUpOwpAQCAtMTUxLDExICsxNDUsNyBAQCBi b29sIHByZXBhcmVNb3VzZUJ1dHRvbkV2ZW50KEdka0V2ZW50KiBldmVudCwgaW50IGV2ZW50U2Vu ZGVyQnV0dG9uTnVtYmVyKQogICAgIGV2ZW50LT5idXR0b24udGltZSA9IEdES19DVVJSRU5UX1RJ TUU7CiAKICAgICBpbnQgeFJvb3QsIHlSb290OwotI2lmIEdUS19DSEVDS19WRVJTSU9OKDIsIDE3 LCAzKQogICAgIGdka193aW5kb3dfZ2V0X3Jvb3RfY29vcmRzKEdUS19XSURHRVQodmlldyktPndp bmRvdywgbGFzdE1vdXNlUG9zaXRpb25YLCBsYXN0TW91c2VQb3NpdGlvblksICZ4Um9vdCwgJnlS b290KTsKLSNlbHNlCi0gICAgZ2V0Um9vdENvb3JkcyhHVEtfV0lER0VUKHZpZXcpLCAmeFJvb3Qs ICZ5Um9vdCk7Ci0jZW5kaWYKICAgICBldmVudC0+YnV0dG9uLnhfcm9vdCA9IHhSb290OwogICAg IGV2ZW50LT5idXR0b24ueV9yb290ID0geVJvb3Q7CiAKQEAgLTI4MSwxMSArMjcxLDcgQEAgc3Rh dGljIEpTVmFsdWVSZWYgbW91c2VNb3ZlVG9DYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwg SlNPYmplY3RSZWYgZnVuY3Rpb24KICAgICBldmVudC5tb3Rpb24uc3RhdGUgPSBnZXRTdGF0ZUZs YWdzKCk7CiAKICAgICBpbnQgeFJvb3QsIHlSb290OwotI2lmIEdUS19DSEVDS19WRVJTSU9OKDIs MTcsMykKICAgICBnZGtfd2luZG93X2dldF9yb290X2Nvb3JkcyhHVEtfV0lER0VUKHZpZXcpLT53 aW5kb3csIGxhc3RNb3VzZVBvc2l0aW9uWCwgbGFzdE1vdXNlUG9zaXRpb25ZLCAmeFJvb3QsICZ5 Um9vdCk7Ci0jZWxzZQotICAgIGdldFJvb3RDb29yZHMoR1RLX1dJREdFVCh2aWV3KSwgJnhSb290 LCAmeVJvb3QpOwotI2VuZGlmCiAgICAgZXZlbnQubW90aW9uLnhfcm9vdCA9IHhSb290OwogICAg IGV2ZW50Lm1vdGlvbi55X3Jvb3QgPSB5Um9vdDsKIAo=