40840 2010-06-18 09:07:28 -0700 [Qt] Symbian builds in release sometimes try to link with the debug JavaScriptCore static lib. 2010-06-21 07:21:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) S60 Hardware Other CLOSED FIXED Qt, QtTriaged P2 Normal --- 35784 1 jturcotte webkit-unassigned hausmann koshuin oldest_to_newest 239960 0 jturcotte 2010-06-18 09:07:28 -0700 Sbsv2 sometimes have problems with debug/release configuration determination causing QtWebKit in release to link with the debug JavaScriptCore static library. 239968 1 59120 jturcotte 2010-06-18 09:18:54 -0700 Created attachment 59120 Patch I made that patch a while ago and I don't know if it would fix the problem or is still needed. Janne, would you have any thought? 240143 2 59120 hausmann 2010-06-18 14:30:47 -0700 Comment on attachment 59120 Patch I recall we spoke about this a while ago. I think the patch is fine. Feel free to set cq+ when you'd like to land it. 240631 3 59120 commit-queue 2010-06-21 01:45:35 -0700 Comment on attachment 59120 Patch Rejecting patch 59120 from commit-queue. jocelyn.turcotte@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 240637 4 59120 jturcotte 2010-06-21 02:41:33 -0700 Comment on attachment 59120 Patch Committed as http://trac.webkit.org/changeset/61536. 240689 5 hausmann 2010-06-21 07:18:05 -0700 <Cherry-pick-for-backport: r61536> 240690 6 hausmann 2010-06-21 07:20:27 -0700 Revision r61536 cherry-picked into qtwebkit-2.0 with commit 98552a8cecd7b7c5c292727d81875ba0534a1a6f 59120 2010-06-18 09:18:54 -0700 2010-06-21 02:41:32 -0700 Patch symbian_jscored_fix.patch text/plain 1831 jturcotte ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA3NTYzNThmLi42ZWQwOGVjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMDYtMTggIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIFdvcmsgYXJvdW5kIGEgYnVpbGQgcHJvYmxlbSBvbiBTeW1iaWFuLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA4NDAKKworICAgICAgICBTYnN2 MiBzb21ldGltZXMgaGF2ZSBwcm9ibGVtcyB3aXRoIGRlYnVnL3JlbGVhc2UgY29uZmlndXJhdGlv bgorICAgICAgICBkZXRlcm1pbmF0aW9uIGNhdXNpbmcgUXRXZWJLaXQgaW4gcmVsZWFzZSB0byBs aW5rIHdpdGggdGhlIGRlYnVnCisgICAgICAgIEphdmFTY3JpcHRDb3JlIHN0YXRpYyBsaWJyYXJ5 LiBUaGlzIHBhdGNoIGxpbWl0IHRoZSBqc2NvcmUvanNjb3JlZAorICAgICAgICBmaXggbmVjZXNz YXJ5IGZvciBtYWMgYnVpbGRzIG9ubHkgdG8gdGhlIG1hYyBwbGF0Zm9ybS4KKworICAgICAgICAq IEphdmFTY3JpcHRDb3JlLnByaToKKwogMjAxMC0wNi0xNyAgU2h1IENoYW5nICA8Y2hhbmcuc2h1 QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaSBiL0ph dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQppbmRleCBjYWNiYWYyLi44ZWY5YjMwIDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKKysrIGIvSmF2YVNj cmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCkBAIC0zLDE1ICszLDE1IEBACiBpbmNsdWRlKC4u L2NvbW1vbi5wcmkpCiAKIFZQQVRIICs9ICQkUFdECi0hQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJl bGVhc2UpIHsKLSAgICAjIE91dHB1dCBpbiBKYXZhU2NyaXB0Q29yZS88Y29uZmlnPgotICAgIEpB VkFTQ1JJUFRDT1JFX0RFU1RESVIgPSBkZWJ1ZwotICAgICMgVXNlIGEgY29uZmlnLXNwZWNpZmlj IHRhcmdldCB0byBwcmV2ZW50IHBhcmFsbGVsIGJ1aWxkcyBmaWxlIGNsYXNoZXMgb24gTWFjCi0g ICAgSkFWQVNDUklQVENPUkVfVEFSR0VUID0ganNjb3JlZAotfSBlbHNlIHsKLSAgICBKQVZBU0NS SVBUQ09SRV9ERVNURElSID0gcmVsZWFzZQotICAgIEpBVkFTQ1JJUFRDT1JFX1RBUkdFVCA9IGpz Y29yZQotfQorCisjIFVzZSBhIGNvbmZpZy1zcGVjaWZpYyB0YXJnZXQgdG8gcHJldmVudCBwYXJh bGxlbCBidWlsZHMgZmlsZSBjbGFzaGVzIG9uIE1hYworbWFjOiBDT05GSUcoZGVidWcsIGRlYnVn fHJlbGVhc2UpOiBKQVZBU0NSSVBUQ09SRV9UQVJHRVQgPSBqc2NvcmVkCitlbHNlOiBKQVZBU0NS SVBUQ09SRV9UQVJHRVQgPSBqc2NvcmUKKworIyBPdXRwdXQgaW4gSmF2YVNjcmlwdENvcmUvPGNv bmZpZz4KK0NPTkZJRyhkZWJ1ZywgZGVidWd8cmVsZWFzZSkgOiBKQVZBU0NSSVBUQ09SRV9ERVNU RElSID0gZGVidWcKK2Vsc2U6IEpBVkFTQ1JJUFRDT1JFX0RFU1RESVIgPSByZWxlYXNlCisKIENP TkZJRyhzdGFuZGFsb25lX3BhY2thZ2UpIHsKICAgICBpc0VtcHR5KEpTQ19HRU5FUkFURURfU09V UkNFU19ESVIpOkpTQ19HRU5FUkFURURfU09VUkNFU19ESVIgPSAkJFBXRC9nZW5lcmF0ZWQKIH0g ZWxzZSB7Cg==