40831 2010-06-18 07:32:15 -0700 REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element 2010-06-18 09:27:28 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned darin oldest_to_newest 239905 0 mitz 2010-06-18 07:32:15 -0700 Patch forthcoming. 239910 1 59106 mitz 2010-06-18 07:39:14 -0700 Created attachment 59106 Fix an apparent typo in HTMLScriptElement::isURLAttribute() 239952 2 59106 andersca 2010-06-18 08:52:18 -0700 Comment on attachment 59106 Fix an apparent typo in HTMLScriptElement::isURLAttribute() r=me! 239955 3 mitz 2010-06-18 08:56:11 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/61410>. 239978 4 darin 2010-06-18 09:27:28 -0700 I am reworking r61379, which I guess I had not tested sufficiently before! My patch included this fix, and I am glad it has been separately dealt with. Along with this problem, I discovered that HTMLMediaElement is also missing isURLAttribute for the src attribute on <video> and <audio> elements. 59106 2010-06-18 07:39:14 -0700 2010-06-18 08:52:18 -0700 Fix an apparent typo in HTMLScriptElement::isURLAttribute() 40831_r1.diff text/plain 3026 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTQwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYtMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyNjEzNzk/KTogQXNzZXJ0aW9uIGZhaWx1cmUgaW4gRWxlbWVudDo6Z2V0VVJMQXR0 cmlidXRlKCkgd2hlbiBhY2Nlc3NpbmcgdGhlIHNyYyBhdHRyaWJ1dGUgb2YgYSBzY3JpcHQgZWxl bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA4 MzEKKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MU2NyaXB0RWxlbWVudC9pc1VSTEF0dHJp YnV0ZS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxTY3JpcHRFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxTY3JpcHRFbGVtZW50Ojppc1VSTEF0dHJpYnV0ZSk6IENoZWNrIGZv ciB0aGUgJ3NyYycgYXR0cmlidXRlLgorCiAyMDEwLTA2LTE4ICBBbnRvbiBNdWhpbiAgPGFudG9u bUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJ bmRleDogV2ViQ29yZS9odG1sL0hUTUxTY3JpcHRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2h0bWwvSFRNTFNjcmlwdEVsZW1lbnQuY3BwCShyZXZpc2lvbiA2MTM4MikKKysrIFdl YkNvcmUvaHRtbC9IVE1MU2NyaXB0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUwLDcg KzUwLDcgQEAgUGFzc1JlZlB0cjxIVE1MU2NyaXB0RWxlbWVudD4gSFRNTFNjcmlwdAogCiBib29s IEhUTUxTY3JpcHRFbGVtZW50Ojppc1VSTEF0dHJpYnV0ZShBdHRyaWJ1dGUqIGF0dHIpIGNvbnN0 CiB7Ci0gICAgcmV0dXJuIGF0dHItPm5hbWUoKSA9PSBzb3VyY2VBdHRyaWJ1dGVWYWx1ZSgpOwor ICAgIHJldHVybiBhdHRyLT5uYW1lKCkgPT0gc3JjQXR0cjsKIH0KIAogYm9vbCBIVE1MU2NyaXB0 RWxlbWVudDo6c2hvdWxkRXhlY3V0ZUFzSmF2YVNjcmlwdCgpIGNvbnN0CkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiA2MTQwNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDEzIEBACisyMDEwLTA2LTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVT U0lPTiAocjYxMzc5Pyk6IEFzc2VydGlvbiBmYWlsdXJlIGluIEVsZW1lbnQ6OmdldFVSTEF0dHJp YnV0ZSgpIHdoZW4gYWNjZXNzaW5nIHRoZSBzcmMgYXR0cmlidXRlIG9mIGEgc2NyaXB0IGVsZW1l bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODMx CisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MU2NyaXB0RWxlbWVudC9pc1VSTEF0dHJpYnV0ZS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxTY3JpcHRFbGVtZW50 L2lzVVJMQXR0cmlidXRlLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA2LTE4ICBEaXJrIFNjaHVsemUg IDxrcml0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBSZWJhc2VsaW5lIGd0 ayByZXN1bHRzLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNjcmlwdEVsZW1lbnQv aXNVUkxBdHRyaWJ1dGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvZG9tL0hUTUxTY3JpcHRFbGVtZW50L2lzVVJMQXR0cmlidXRlLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTY3JpcHRFbGVtZW50L2lzVVJM QXR0cmlidXRlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorVGhpcyB0 ZXN0cyB0aGF0IGFjY2Vzc2luZyB0aGUgc3JjIGF0dHJpYnV0ZSBvZiBhIHNjcmlwdCBlbGVtZW50 IGRvZXMgbm90IGNhdXNlIGFuIGFzc2VydGlvbiB0byBmYWlsLgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9kb20vSFRNTFNjcmlwdEVsZW1lbnQvaXNVUkxBdHRyaWJ1dGUuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2NyaXB0RWxlbWVudC9pc1VSTEF0dHJpYnV0 ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNjcmlwdEVs ZW1lbnQvaXNVUkxBdHRyaWJ1dGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAor PHNjcmlwdCBzcmM9ImRhdGE6dGV4dC9qYXZhc2NyaXB0LCIgaWQ9InRhcmdldCI+PC9zY3JpcHQ+ Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0YXJnZXQiKS5zcmM7Cis8L3NjcmlwdD4KKzxwPgorICAgIFRoaXMgdGVzdHMg dGhhdCBhY2Nlc3NpbmcgdGhlIDx0dD5zcmM8L3R0PiBhdHRyaWJ1dGUgb2YgYSA8dHQ+c2NyaXB0 PC90dD4gZWxlbWVudCBkb2VzIG5vdAorICAgIGNhdXNlIGFuIGFzc2VydGlvbiB0byBmYWlsLgor PC9wPgo=