40817 2010-06-18 01:34:36 -0700 Web Inspector: REGRESSION (Safari 5.0-r61382): Image heights are displayed as 0 2010-11-02 11:08:43 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P1 Normal --- 1 mitz pfeldman bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 239806 0 mitz 2010-06-18 01:34:36 -0700 In the resources pane of the inspector, when inspecting an image resource, the height displayed below the image is always 0. 303413 1 72679 pfeldman 2010-11-02 09:38:44 -0700 Created attachment 72679 [PATCH] Proposed change. 303483 2 72679 timothy 2010-11-02 11:02:11 -0700 Comment on attachment 72679 [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=72679&action=review > WebCore/inspector/front-end/ImageView.js:92 > + imagePreviewElement.onload = onImageLoad.bind(this); Use addEventListener. .onLoad is ugh... 303491 3 pfeldman 2010-11-02 11:08:43 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ImageView.js Committed r71133 72679 2010-11-02 09:38:44 -0700 2010-11-02 11:02:10 -0700 [PATCH] Proposed change. image_dims text/plain 3986 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTc0NjNhMi4uMmRlYzI3NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0wMiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbWFnZSBoZWlnaHRzIGFyZSBkaXNw bGF5ZWQgYXMgMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQwODE3CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0ltYWdlVmlldy5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5JbWFnZVZpZXcucHJvdG90eXBlLmNvbnRlbnRUYWJTZWxl Y3RlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSW1hZ2VWaWV3LnByb3RvdHlwZS5jb250ZW50 VGFiU2VsZWN0ZWQub25JbWFnZUxvYWQpOgorCiAyMDEwLTExLTAxICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXou CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VWaWV3LmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ltYWdlVmlldy5qcwppbmRleCA3Y2ZmMDU2Li5l YWJlNjQxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VWaWV3 LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbWFnZVZpZXcuanMKQEAgLTQ3 LDE1ICs0Nyw5IEBAIFdlYkluc3BlY3Rvci5JbWFnZVZpZXcucHJvdG90eXBlID0gewogICAgICAg ICB0aGlzLl9jb250YWluZXIuY2xhc3NOYW1lID0gImltYWdlIjsKICAgICAgICAgdGhpcy5jb250 ZW50RWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9jb250YWluZXIpOwogCi0gICAgICAgIHRoaXMu aW1hZ2VQcmV2aWV3RWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImltZyIpOwotICAg ICAgICB0aGlzLmltYWdlUHJldmlld0VsZW1lbnQuYWRkU3R5bGVDbGFzcygicmVzb3VyY2UtaW1h Z2UtdmlldyIpOwotICAgICAgICB0aGlzLl9jb250YWluZXIuYXBwZW5kQ2hpbGQodGhpcy5pbWFn ZVByZXZpZXdFbGVtZW50KTsKLQotICAgICAgICBmdW5jdGlvbiBvblJlc291cmNlQ29udGVudChl bGVtZW50LCBjb250ZW50KQotICAgICAgICB7Ci0gICAgICAgICAgICB0aGlzLmltYWdlUHJldmll d0VsZW1lbnQuc2V0QXR0cmlidXRlKCJzcmMiLCB0aGlzLnJlc291cmNlLmNvbnRlbnRVUkwpOwot ICAgICAgICB9Ci0gICAgICAgIHRoaXMucmVzb3VyY2UuZ2V0Q29udGVudChvblJlc291cmNlQ29u dGVudC5iaW5kKHRoaXMpKTsKKyAgICAgICAgdmFyIGltYWdlUHJldmlld0VsZW1lbnQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCJpbWciKTsKKyAgICAgICAgaW1hZ2VQcmV2aWV3RWxlbWVudC5h ZGRTdHlsZUNsYXNzKCJyZXNvdXJjZS1pbWFnZS12aWV3Iik7CisgICAgICAgIHRoaXMuX2NvbnRh aW5lci5hcHBlbmRDaGlsZChpbWFnZVByZXZpZXdFbGVtZW50KTsKIAogICAgICAgICB0aGlzLl9j b250YWluZXIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAgdGhpcy5f Y29udGFpbmVyLmNsYXNzTmFtZSA9ICJpbmZvIjsKQEAgLTY5LDE4ICs2MywzMyBAQCBXZWJJbnNw ZWN0b3IuSW1hZ2VWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGluZm9MaXN0RWxlbWVu dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRsIik7CiAgICAgICAgIGluZm9MaXN0RWxlbWVu dC5jbGFzc05hbWUgPSAiaW5mb0xpc3QiOwogCi0gICAgICAgIHZhciBpbWFnZVByb3BlcnRpZXMg PSBbCi0gICAgICAgICAgICB7IG5hbWU6IFdlYkluc3BlY3Rvci5VSVN0cmluZygiRGltZW5zaW9u cyIpLCB2YWx1ZTogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlZCDDlyAlZCIsIHRoaXMuaW1hZ2VQ cmV2aWV3RWxlbWVudC5uYXR1cmFsV2lkdGgsIHRoaXMuaW1hZ2VQcmV2aWV3RWxlbWVudC5oZWln aHQpIH0sCi0gICAgICAgICAgICB7IG5hbWU6IFdlYkluc3BlY3Rvci5VSVN0cmluZygiRmlsZSBz aXplIiksIHZhbHVlOiBOdW1iZXIuYnl0ZXNUb1N0cmluZyh0aGlzLnJlc291cmNlLnJlc291cmNl U2l6ZSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKSB9LAotICAgICAgICAgICAgeyBuYW1lOiBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIk1JTUUgdHlwZSIpLCB2YWx1ZTogdGhpcy5yZXNvdXJjZS5taW1l VHlwZSB9Ci0gICAgICAgIF07CisgICAgICAgIGZ1bmN0aW9uIG9uUmVzb3VyY2VDb250ZW50KGVs ZW1lbnQsIGNvbnRlbnQpCisgICAgICAgIHsKKyAgICAgICAgICAgIGltYWdlUHJldmlld0VsZW1l bnQuc2V0QXR0cmlidXRlKCJzcmMiLCB0aGlzLnJlc291cmNlLmNvbnRlbnRVUkwpOworICAgICAg ICB9CisgICAgICAgIHRoaXMucmVzb3VyY2UuZ2V0Q29udGVudChvblJlc291cmNlQ29udGVudC5i aW5kKHRoaXMpKTsKIAotICAgICAgICB2YXIgbGlzdEhUTUwgPSAnJzsKLSAgICAgICAgZm9yICh2 YXIgaSA9IDA7IGkgPCBpbWFnZVByb3BlcnRpZXMubGVuZ3RoOyArK2kpCi0gICAgICAgICAgICBs aXN0SFRNTCArPSAiPGR0PiIgKyBpbWFnZVByb3BlcnRpZXNbaV0ubmFtZSArICI8L2R0PjxkZD4i ICsgaW1hZ2VQcm9wZXJ0aWVzW2ldLnZhbHVlICsgIjwvZGQ+IjsKIAotICAgICAgICBpbmZvTGlz dEVsZW1lbnQuaW5uZXJIVE1MID0gbGlzdEhUTUw7Ci0gICAgICAgIHRoaXMuX2NvbnRhaW5lci5h cHBlbmRDaGlsZChpbmZvTGlzdEVsZW1lbnQpOworICAgICAgICBmdW5jdGlvbiBvbkltYWdlTG9h ZCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhciBpbWFnZVByb3BlcnRpZXMgPSBbCisgICAg ICAgICAgICAgICAgeyBuYW1lOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkRpbWVuc2lvbnMiKSwg dmFsdWU6IFdlYkluc3BlY3Rvci5VSVN0cmluZygiJWQgw5cgJWQiLCBpbWFnZVByZXZpZXdFbGVt ZW50Lm5hdHVyYWxXaWR0aCwgaW1hZ2VQcmV2aWV3RWxlbWVudC5oZWlnaHQpIH0sCisgICAgICAg ICAgICAgICAgeyBuYW1lOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkZpbGUgc2l6ZSIpLCB2YWx1 ZTogTnVtYmVyLmJ5dGVzVG9TdHJpbmcodGhpcy5yZXNvdXJjZS5yZXNvdXJjZVNpemUsIFdlYklu c3BlY3Rvci5VSVN0cmluZykgfSwKKyAgICAgICAgICAgICAgICB7IG5hbWU6IFdlYkluc3BlY3Rv ci5VSVN0cmluZygiTUlNRSB0eXBlIiksIHZhbHVlOiB0aGlzLnJlc291cmNlLm1pbWVUeXBlIH0K KyAgICAgICAgICAgIF07CisgICAgCisgICAgICAgICAgICBpbmZvTGlzdEVsZW1lbnQucmVtb3Zl Q2hpbGRyZW4oKTsKKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgaW1hZ2VQcm9wZXJ0 aWVzLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICAgICAgdmFyIGR0ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiZHQiKTsKKyAgICAgICAgICAgICAgICBkdC50ZXh0Q29udGVudCA9IGltYWdl UHJvcGVydGllc1tpXS5uYW1lOworICAgICAgICAgICAgICAgIGluZm9MaXN0RWxlbWVudC5hcHBl bmRDaGlsZChkdCk7CisgICAgICAgICAgICAgICAgdmFyIGRkID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiZGQiKTsKKyAgICAgICAgICAgICAgICBkZC50ZXh0Q29udGVudCA9IGltYWdlUHJvcGVy dGllc1tpXS52YWx1ZTsKKyAgICAgICAgICAgICAgICBpbmZvTGlzdEVsZW1lbnQuYXBwZW5kQ2hp bGQoZGQpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgdGhpcy5fY29udGFpbmVyLmFwcGVu ZENoaWxkKGluZm9MaXN0RWxlbWVudCk7CisgICAgICAgIH0KKyAgICAgICAgaW1hZ2VQcmV2aWV3 RWxlbWVudC5vbmxvYWQgPSBvbkltYWdlTG9hZC5iaW5kKHRoaXMpOwogICAgIH0KIH0KIAo=