40816 2010-06-18 01:30:50 -0700 WebKit API: Undo static hooks into V8 when WebKit is shut down 2013-05-02 11:46:26 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 aa webkit-unassigned andersca fishd oldest_to_newest 239805 0 aa 2010-06-18 01:30:50 -0700 V8DOMWindowShell lazily sets static hooks in V8 that call back into WebCore. WebKit::shutdown() should clear these, so that V8 doesn't crash if it continues being used after that time. 239811 1 59082 aa 2010-06-18 01:39:26 -0700 Created attachment 59082 Patch 240054 2 fishd 2010-06-18 11:23:11 -0700 I'm concerned that the pattern of shutting down WebKit and re-initializing it is going to be hard to support in the future since no other port requires it. It will be fragile to support. We don't need it for Chrome. We only need it because our unit_tests are constructed to initialize, shutdown, and re-initialize WebKit. Perhaps our unit_tests should change instead. Note that webkit_unit_tests initializes WebKit once for the entire process. That is the only currently supported usage. I notice that the comments in WebKit.h do not make this clear, and the implementation of WebKit::initialize does not assert that initialization is a one-time deal. It probably should have had such a check to prevent abuse. 240091 3 aa 2010-06-18 13:14:23 -0700 Ok, thanks. I will track down the paths that are causing initialization in Chrome's unit tests. 240277 4 aa 2010-06-18 23:54:46 -0700 Committed r61466: <http://trac.webkit.org/changeset/61466> 240278 5 aa 2010-06-19 00:06:04 -0700 Reverted r61466 for reason: Landed wrong change Committed r61467: <http://trac.webkit.org/changeset/61467> 240386 6 59082 abarth 2010-06-19 16:51:06 -0700 Comment on attachment 59082 Patch As discussed on chromium-dev, I think our current plan is to make the unit tests not assume they can restart WebKit. 883861 7 andersca 2013-05-02 11:46:26 -0700 V8 is gone from WebKit. 59082 2010-06-18 01:39:26 -0700 2010-06-19 16:51:06 -0700 Patch bug-40816-20100618013925.patch text/plain 5929 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWMxNGMxNmU5MmIzOTI4NTEzNzE2MmQyZGQ2NzcwNmY2YWZkOWVmNS4uNWY0M2Q0ZmZjM2NjZTAy OTBmZWU5NTA0YTlkODM1NmRlYjM0NmIzMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNi0xOCAgQWFy b24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQgQVBJOiBVbmRvIHN0YXRpYyBob29rcyBpbnRv IFY4IHdoZW4gV2ViS2l0IGlzIHNodXQgZG93bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODE2CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERP TVdpbmRvd1NoZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV2luZG93U2hlbGw6Omlu aXRDb250ZXh0SWZOZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XaW5kb3dTaGVsbDo6 aW5pdGlhbGl6ZVY4SWZOZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XaW5kb3dTaGVs bDo6dW5pbml0aWFsaXplVjhJZk5lZWRlZCk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01X aW5kb3dTaGVsbC5oOgorCiAyMDEwLTA2LTE4ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBicmVha2FnZSBmaXguCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAppbmRleCA3MDA2MGJjNGQwMTAxNzE4ZTEz MTVkMjEyZTZkNGM3ZDY5OWRmYjMwLi5mMjRhNWNmYzIzYzk3MmQxYWNhZDRhZDlkYzk2NDQwMTU3 MWFiYjRhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwu Y3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKQEAgLTEx Nyw2ICsxMTcsOCBAQCBzdGF0aWMgdm9pZCByZXBvcnRVbnNhZmVKYXZhU2NyaXB0QWNjZXNzKHY4 OjpMb2NhbDx2ODo6T2JqZWN0PiBob3N0LCB2ODo6QWNjZXNzVAogICAgICAgICBWOFByb3h5Ojpy ZXBvcnRVbnNhZmVBY2Nlc3NUbyh0YXJnZXQsIFY4UHJveHk6OlJlcG9ydExhdGVyKTsKIH0KIAor Ym9vbCBWOERPTVdpbmRvd1NoZWxsOjpzX2lzVjhJbml0aWFsaXplZCA9IGZhbHNlOworCiBQYXNz UmVmUHRyPFY4RE9NV2luZG93U2hlbGw+IFY4RE9NV2luZG93U2hlbGw6OmNyZWF0ZShGcmFtZSog ZnJhbWUpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBWOERPTVdpbmRvd1NoZWxsKGZyYW1l KSk7CkBAIC0yNDcsMjUgKzI0OSw3IEBAIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6aW5pdENvbnRl eHRJZk5lZWRlZCgpCiAgICAgLy8gQ3JlYXRlIGEgaGFuZGxlIHNjb3BlIGZvciBhbGwgbG9jYWwg aGFuZGxlcy4KICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CiAKLSAgICAvLyBTZXR1 cCB0aGUgc2VjdXJpdHkgaGFuZGxlcnMgYW5kIG1lc3NhZ2UgbGlzdGVuZXIuIFRoaXMgb25seSBo YXMKLSAgICAvLyB0byBiZSBkb25lIG9uY2UuCi0gICAgc3RhdGljIGJvb2wgaXNWOEluaXRpYWxp emVkID0gZmFsc2U7Ci0gICAgaWYgKCFpc1Y4SW5pdGlhbGl6ZWQpIHsKLSAgICAgICAgLy8gVGVs bHMgVjggbm90IHRvIGNhbGwgdGhlIGRlZmF1bHQgT09NIGhhbmRsZXIsIGJpbmRpbmcgY29kZQot ICAgICAgICAvLyB3aWxsIGhhbmRsZSBpdC4KLSAgICAgICAgdjg6OlY4OjpJZ25vcmVPdXRPZk1l bW9yeUV4Y2VwdGlvbigpOwotICAgICAgICB2ODo6Vjg6OlNldEZhdGFsRXJyb3JIYW5kbGVyKHJl cG9ydEZhdGFsRXJyb3JJblY4KTsKLQotICAgICAgICB2ODo6Vjg6OlNldEdsb2JhbEdDUHJvbG9n dWVDYWxsYmFjaygmVjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUpOwotICAgICAgICB2ODo6Vjg6 OlNldEdsb2JhbEdDRXBpbG9ndWVDYWxsYmFjaygmVjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUp OwotCi0gICAgICAgIHY4OjpWODo6QWRkTWVzc2FnZUxpc3RlbmVyKCZWOENvbnNvbGVNZXNzYWdl OjpoYW5kbGVyKTsKLQotICAgICAgICB2ODo6Vjg6OlNldEZhaWxlZEFjY2Vzc0NoZWNrQ2FsbGJh Y2tGdW5jdGlvbihyZXBvcnRVbnNhZmVKYXZhU2NyaXB0QWNjZXNzKTsKLQotICAgICAgICBpc1Y4 SW5pdGlhbGl6ZWQgPSB0cnVlOwotICAgIH0KLQorICAgIGluaXRpYWxpemVWOElmTmVlZGVkKCk7 CiAKICAgICBtX2NvbnRleHQgPSBjcmVhdGVOZXdDb250ZXh0KG1fZ2xvYmFsLCAwKTsKICAgICBp ZiAobV9jb250ZXh0LklzRW1wdHkoKSkKQEAgLTMwOCw2ICsyOTIsNDMgQEAgdm9pZCBWOERPTVdp bmRvd1NoZWxsOjppbml0Q29udGV4dElmTmVlZGVkKCkKICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+ ZGlzcGF0Y2hEaWRDbGVhcldpbmRvd09iamVjdEluV29ybGQoMCk7CiB9CiAKK3ZvaWQgVjhET01X aW5kb3dTaGVsbDo6aW5pdGlhbGl6ZVY4SWZOZWVkZWQoKQoreworICAgIGlmIChzX2lzVjhJbml0 aWFsaXplZCkKKyAgICAgIHJldHVybjsKKworICAgIC8vIFRlbGxzIFY4IG5vdCB0byBjYWxsIHRo ZSBkZWZhdWx0IE9PTSBoYW5kbGVyLCBiaW5kaW5nIGNvZGUKKyAgICAvLyB3aWxsIGhhbmRsZSBp dC4KKyAgICB2ODo6Vjg6Oklnbm9yZU91dE9mTWVtb3J5RXhjZXB0aW9uKCk7CisgICAgdjg6OlY4 OjpTZXRGYXRhbEVycm9ySGFuZGxlcihyZXBvcnRGYXRhbEVycm9ySW5WOCk7CisKKyAgICB2ODo6 Vjg6OlNldEdsb2JhbEdDUHJvbG9ndWVDYWxsYmFjaygmVjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9n dWUpOworICAgIHY4OjpWODo6U2V0R2xvYmFsR0NFcGlsb2d1ZUNhbGxiYWNrKCZWOEdDQ29udHJv bGxlcjo6Z2NFcGlsb2d1ZSk7CisKKyAgICB2ODo6Vjg6OkFkZE1lc3NhZ2VMaXN0ZW5lcigmVjhD b25zb2xlTWVzc2FnZTo6aGFuZGxlcik7CisKKyAgICB2ODo6Vjg6OlNldEZhaWxlZEFjY2Vzc0No ZWNrQ2FsbGJhY2tGdW5jdGlvbihyZXBvcnRVbnNhZmVKYXZhU2NyaXB0QWNjZXNzKTsKKworICAg IHNfaXNWOEluaXRpYWxpemVkID0gdHJ1ZTsKK30KKwordm9pZCBWOERPTVdpbmRvd1NoZWxsOjp1 bmluaXRpYWxpemVWOElmTmVlZGVkKCkKK3sKKyAgICBpZiAoIXNfaXNWOEluaXRpYWxpemVkKQor ICAgICAgcmV0dXJuOworCisgICAgdjg6OlY4OjpTZXRGYXRhbEVycm9ySGFuZGxlcigwKTsKKyAg ICB2ODo6Vjg6OlNldEdsb2JhbEdDUHJvbG9ndWVDYWxsYmFjaygwKTsKKyAgICB2ODo6Vjg6OlNl dEdsb2JhbEdDRXBpbG9ndWVDYWxsYmFjaygwKTsKKyAgICB2ODo6Vjg6OlNldEZhaWxlZEFjY2Vz c0NoZWNrQ2FsbGJhY2tGdW5jdGlvbigwKTsKKyAgICB2ODo6Vjg6OlJlbW92ZU1lc3NhZ2VMaXN0 ZW5lcnMoJlY4Q29uc29sZU1lc3NhZ2U6OmhhbmRsZXIpOworCisgICAgLy8gRklYTUU6IFRoaXMg b25lIGNhbm5vdCBiZSB1bmRvbmUgeWV0LgorICAgIC8vIHY4OjpWODo6SWdub3JlT3V0T2ZNZW1v cnlFeGNlcHRpb24oKTsKKworICAgIHNfaXNWOEluaXRpYWxpemVkID0gZmFsc2U7Cit9CisKIHY4 OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0PiBWOERPTVdpbmRvd1NoZWxsOjpjcmVhdGVOZXdDb250 ZXh0KHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZ2xvYmFsLCBpbnQgZXh0ZW5zaW9uR3JvdXApCiB7 CiAgICAgdjg6OlBlcnNpc3RlbnQ8djg6OkNvbnRleHQ+IHJlc3VsdDsKZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5oIGIvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdpbmRvd1NoZWxsLmgKaW5kZXggM2NmMWI1MmZhOTYzYzgzZjBkYzkyYTBlZGU4MjY2 MjZiZmUzZjFhYS4uMDc1YWM3YThhNDNjN2VjYzUwMjgwNTY1MTJmM2FhMDgyMGVlYjk2MSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmgKKysrIGIvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmgKQEAgLTUwLDYgKzUwLDggQEAgY2xh c3MgU3RyaW5nOwogY2xhc3MgVjhET01XaW5kb3dTaGVsbCA6IHB1YmxpYyBSZWZDb3VudGVkPFY4 RE9NV2luZG93U2hlbGw+IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxWOERPTVdp bmRvd1NoZWxsPiBjcmVhdGUoRnJhbWUqKTsKKyAgICBzdGF0aWMgdm9pZCBpbml0aWFsaXplVjhJ Zk5lZWRlZCgpOworICAgIHN0YXRpYyB2b2lkIHVuaW5pdGlhbGl6ZVY4SWZOZWVkZWQoKTsKIAog ICAgIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQoKSBjb25zdCB7IHJldHVybiBtX2Nv bnRleHQ7IH0KIApAQCAtMTE5LDYgKzEyMSw4IEBAIHByaXZhdGU6CiAgICAgdjg6OlBlcnNpc3Rl bnQ8djg6OkNvbnRleHQ+IG1fY29udGV4dDsKICAgICB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0 PiBtX2dsb2JhbDsKICAgICB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBtX2RvY3VtZW50Owor CisgICAgc3RhdGljIGJvb2wgc19pc1Y4SW5pdGlhbGl6ZWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA4NmUyYWJlMGMyOWI0Y2IwNDc4MTIzYTQyNzMxZTc3 ZmRhYTk4NjhhLi4yOGQ1ZmYzYjFkNGE1ZTRkZjA0M2Q3OTdlZGJkM2ZmMjY2NmQyNzU5IDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xOCAgQWFyb24gQm9vZG1hbiAgPGFh QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXZWJLaXQgQVBJOiBVbmRvIHN0YXRpYyBob29rcyBpbnRvIFY4IHdoZW4gV2ViS2l0 IGlzIHNodXQgZG93bm0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQwODE2CisKKyAgICAgICAgKiBzcmMvV2ViS2l0LmNwcDoKKyAgICAgICAgKFdlYktp dDo6c2h1dGRvd24pOiBDYWxsIG5ldyBXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjp1bmluaXRp YWxpemVWOElmTmVlZGVkKCkuCisKIDIwMTAtMDYtMTcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAtLWdpdCBh L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi S2l0LmNwcAppbmRleCA4MzQ2ZWY4OGRlZGZmYjI2N2EzNjg5YTlkYzBlNmRkZTg4NTQxMjE2Li4y YTllZjVkMTcxY2Y0ZmUxMTU4ZjdkMThmODE1M2NmNmJiOGYxNzk4IDEwMDY0NAotLS0gYS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJL aXQuY3BwCkBAIC00MSw2ICs0MSwxMCBAQAogI2luY2x1ZGUgIldlYlNvY2tldC5oIgogI2luY2x1 ZGUgIldvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5oIgogCisjaWYgVVNFKFY4KQorI2luY2x1 ZGUgIlY4RE9NV2luZG93U2hlbGwuaCIKKyNlbmRpZgorCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlv bnMuaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAKQEAgLTc4LDYgKzgyLDkgQEAgdm9p ZCBpbml0aWFsaXplKFdlYktpdENsaWVudCogd2ViS2l0Q2xpZW50KQogCiB2b2lkIHNodXRkb3du KCkKIHsKKyNpZiBVU0UoVjgpCisgICAgV2ViQ29yZTo6VjhET01XaW5kb3dTaGVsbDo6dW5pbml0 aWFsaXplVjhJZk5lZWRlZCgpOworI2VuZGlmCiAgICAgc193ZWJLaXRDbGllbnQgPSAwOwogfQog Cg==