40810 2010-06-17 21:44:16 -0700 [EFL] Build break on Debug build 2010-06-21 06:23:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned abarth eric hyuki.kim joone.hur leandro lucas.de.marchi webkit.review.bot oldest_to_newest 239750 0 gyuyoung.kim 2010-06-17 21:44:16 -0700 I cannot found options related to DEBUG. In my opinion, EFLWebKit needs to enable debug option as well. When I added ENABLE_DEBUG option to cmake/OptionsEfl.cmake, there were "undefined references" as below, Conservative compression summary: Wrote total 47834 bytes (47Kb) from 134514 (131Kb) input data Output file is 35.6% the size of the input data Saved 86680 bytes (85Kb) Raw compression summary: Wrote total 47834 bytes (47Kb) from 807076 (788Kb) raw input data Output file is 5.9% the size of the raw input data Saved 759242 bytes (741Kb) Scanning dependencies of target EWebLauncher [100%] Building C object WebKit/CMakeFiles/../Programs/EWebLauncher.dir/efl/EWebLauncher/main.c.o Linking CXX executable ../Programs/EWebLauncher libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::CSSPreloadScanner(WebCore::Document*)' libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::scan(WebCore::HTML5Token const&, bool)' libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::reset()' collect2: ld returned 1 exit status There are no "html/CSSPreloadScanner.cpp / h" in WebCore/CMakeList.txt. I added them to WebCore/CMakeList.txt. 239752 1 59071 gyuyoung.kim 2010-06-17 21:49:42 -0700 Created attachment 59071 Patch for debug option 239790 2 gyuyoung.kim 2010-06-18 00:30:40 -0700 Wrote total 47834 bytes (47Kb) from 807076 (788Kb) raw input data Output file is 5.9% the size of the raw input data Saved 759242 bytes (741Kb) Scanning dependencies of target EWebLauncher [100%] Building C object WebKit/CMakeFiles/../Programs/EWebLauncher.dir/efl/EWebLauncher/main.c.o Linking CXX executable ../Programs/EWebLauncher libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::CSSPreloadScanner(WebCore::Document*)' libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::scan(WebCore::HTML5Token const&, bool)' libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::reset()' collect2: ld returned 1 exit status make[2]: *** [WebKit/../Programs/EWebLauncher] error 1 239791 3 59075 gyuyoung.kim 2010-06-18 00:33:25 -0700 Created attachment 59075 patch for build break It seems that lukas already made a patch for debug build as below, Bug 40566 - [EFL] Build system is forcing build type to Release (https://bugs.webkit.org/show_bug.cgi?id=40566) However, there are still build breaks when no Release build. [100%] Building C object WebKit/CMakeFiles/../Programs/EWebLauncher.dir/efl/EWebLauncher/main.c.o Linking CXX executable ../Programs/EWebLauncher libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::CSSPreloadScanner(WebCore::Document*)' libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::scan(WebCore::HTML5Token const&, bool)' libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::reset()' collect2: ld returned 1 exit status make[2]: *** [WebKit/../Programs/EWebLauncher] error 1 239886 4 lucas.de.marchi 2010-06-18 05:55:23 -0700 The issue is fixed on r61163 and partially on r61323. Now the only thing that is missing is on #40566. To enable debug it will suffice to do the following in a build directory: cmake .. -DPORT=Efl -DCMAKE_BUILD_TYPE=Debug For future updates on CMake, remember that we don't keep track of .h files since they are automatically detected at compilation time. 239939 5 lucas.de.marchi 2010-06-18 08:37:09 -0700 Ah, sorry about previous comment, I was cheated by the file name. This is another problem. It has been broken again by r61366. I'm CCing Leandro who is able to fix this without going through commit queue. 239954 6 leandro 2010-06-18 08:55:23 -0700 Looks good to me. Just change the ChangeLog entry to "Reviewed by NOBODY (OOPS!)" to "Unreviewed build fix" and I'll land it. 240005 7 59075 leandro 2010-06-18 10:19:25 -0700 Comment on attachment 59075 patch for build break Committed as r61416. 240008 8 webkit.review.bot 2010-06-18 10:21:10 -0700 http://trac.webkit.org/changeset/61416 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/61416 http://trac.webkit.org/changeset/61414 http://trac.webkit.org/changeset/61415 240015 9 leandro 2010-06-18 10:25:10 -0700 (In reply to comment #8) > http://trac.webkit.org/changeset/61416 might have broken Qt Linux Release minimal > The following changes are on the blame list: > http://trac.webkit.org/changeset/61416 > http://trac.webkit.org/changeset/61414 > http://trac.webkit.org/changeset/61415 Looks like a false alarm. 59071 2010-06-17 21:49:42 -0700 2010-06-18 00:33:25 -0700 Patch for debug option debug-option.txt text/plain 2345 gyuyoung.kim SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYxMzcz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYt MTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBBZGQgRU5BQkxFX0RF QlVHIG9wdGlvbiB0byBjbWFrZSBmaWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDA4MTAKKyAgICAgICAgVGhlcmUgaXMgbm8gZGVidWcgb3B0aW9u IGluIEVGTFdlYktpdC4KKworICAgICAgICAqIGNtYWtlL09wdGlvbnNFZmwuY21ha2U6IEFkZCBF TkFCTEVfREVCVUcgb3B0aW9uLgorCiAyMDEwLTA2LTE3ICBTaHUgQ2hhbmcgIDxjaGFuZy5zaHVA bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuLgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFu Z2VMb2cJKHJldmlzaW9uIDYxMzcxKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xNyAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcu a2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtFRkxdIEFkZCBFTkFCTEVfREVCVUcgb3B0aW9uIHRvIGNtYWtlIGZpbGUuCisg ICAgICAgIFRoZXJlIGlzIG5vIGRlYnVnIG9wdGlvbiBpbiBFRkxXZWJLaXQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDgxMAorCisgICAgICAgICog Q01ha2VMaXN0cy50eHQ6IEFkZCBDU1NQcmVsb2FkU2Nhbm5lci5oIGFuZCBDU1NQcmVsb2FkU2Nh bm5lci5jcHAKKwogMjAxMC0wNi0xNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViQ29yZS9DTWFrZUxp c3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NNYWtlTGlzdHMudHh0CShyZXZpc2lvbiA2 MTM2NikKKysrIFdlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTg5NSw2 ICs4OTUsOCBAQCBTRVQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgaHRtbC9CbG9iLmNwcAogICAgIGh0 bWwvQmxvYkJ1aWxkZXIuY3BwCiAgICAgaHRtbC9Db2xsZWN0aW9uQ2FjaGUuY3BwCisgICAgaHRt bC9DU1NQcmVsb2FkU2Nhbm5lci5jcHAKKyAgICBodG1sL0NTU1ByZWxvYWRTY2FubmVyLmgKICAg ICBodG1sL0RPTURhdGFHcmlkRGF0YVNvdXJjZS5jcHAKICAgICBodG1sL0RPTUZvcm1EYXRhLmNw cAogICAgIGh0bWwvRGF0YUdyaWRDb2x1bW4uY3BwCkluZGV4OiBjbWFrZS9PcHRpb25zRWZsLmNt YWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGNtYWtlL09wdGlvbnNFZmwuY21ha2UJKHJldmlzaW9uIDYxMzY2 KQorKysgY21ha2UvT3B0aW9uc0VmbC5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtNTYsNiArNTYs NyBAQCBXRUJLSVRfRkVBVFVSRShFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkcgCiBXRUJLSVRfRkVB VFVSRShFTkFCTEVfREFUQUJBU0UgIkVuYWJsZSBkYXRhYmFzZSIgREVGQVVMVCBPTikKIFdFQktJ VF9GRUFUVVJFKEVOQUJMRV9EQVRBR1JJRCAiRW5hYmxlIGRhdGFncmlkIiBERUZBVUxUIE9GRikK IFdFQktJVF9GRUFUVVJFKEVOQUJMRV9EQVRBTElTVCAiRW5hYmxlIGRhdGFsaXN0IiBERUZBVUxU IE9OIEhUTUwpCitXRUJLSVRfRkVBVFVSRShFTkFCTEVfREVCVUcgIkVuYWJsZSBEZWJ1ZyIgREVG QVVMVCBPRkYgKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0RPTV9TVE9SQUdFICJFbmFibGUgRE9N IHN0b3JhZ2UiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfRVZFTlRTT1VSQ0Ug IkVuYWJsZSBldmVudCBzb3VyY2UiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVf RkFTVF9NT0JJTEVfU0NST0xMSU5HICJFbmFibGUgZmFzdCBtb2JpbGUgc2Nyb2xsaW5nIiBERUZB VUxUIE9OKQo= 59075 2010-06-18 00:33:25 -0700 2010-06-18 10:19:25 -0700 patch for build break patch.txt text/plain 939 gyuyoung.kim SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTM3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDYtMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBCdWlsZCBicmVhayBvbiBEZWJ1ZyBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODEwCisKKyAgICAgICAgKiBDTWFrZUxp c3RzLnR4dDogQWRkIENTU1ByZWxvYWRTY2FubmVyLmNwcAorCiAyMDEwLTA2LTE3ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCkluZGV4OiBXZWJDb3JlL0NNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv Q01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDYxMzY2KQorKysgV2ViQ29yZS9DTWFrZUxpc3RzLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtODk1LDYgKzg5NSw3IEBAIFNFVChXZWJDb3JlX1NPVVJDRVMK ICAgICBodG1sL0Jsb2IuY3BwCiAgICAgaHRtbC9CbG9iQnVpbGRlci5jcHAKICAgICBodG1sL0Nv bGxlY3Rpb25DYWNoZS5jcHAKKyAgICBodG1sL0NTU1ByZWxvYWRTY2FubmVyLmNwcAogICAgIGh0 bWwvRE9NRGF0YUdyaWREYXRhU291cmNlLmNwcAogICAgIGh0bWwvRE9NRm9ybURhdGEuY3BwCiAg ICAgaHRtbC9EYXRhR3JpZENvbHVtbi5jcHAK