40807 2010-06-17 19:58:54 -0700 [EFL] add support for logging 2010-07-22 10:48:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 joone.hur webkit-unassigned antognolli+webkit barbieri commit-queue gustavo gyuyoung gyuyoung.kim hyuki.kim joone leandro lucas.de.marchi tonikitoo oldest_to_newest 239723 0 joone.hur 2010-06-17 19:58:54 -0700 Logging is not fully implemented for EFL port. WebKit/WebCore/platform/efl/LoggingEfl.cpp namespace WebCore { void InitializeLoggingChannelsIfNecessary() { LogNotYetImplemented.state = WTFLogChannelOn; } } 239727 1 59066 joone.hur 2010-06-17 20:20:25 -0700 Created attachment 59066 patch 239879 2 59066 lucas.de.marchi 2010-06-18 05:32:01 -0700 Comment on attachment 59066 patch Patch looks good. I'm not an official reviewer, so I'll give an informal review. >diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog >+ char* logv = strtok(logEnv, " "); I'd prefer a "," separator as QT guys do because: 1) It's how eina sets log levels with EINA_LOG_LEVELS 2) It allows to pass log levels without quoting However, it's just my preference. I'm CCing the author of eina_log to have his opinion on this. >+ >+ while (logv) { >+ if (WTFLogChannel* channel = getChannelFromName(String(logv))) >+ channel->state = WTFLogChannelOn; >+ logv = strtok(0, " "); >+ } >+ >+ // to disable logging notImplemented set the DISABLE_NI_WARNING >+ // environment variable to 1 Comments start with capital letter and ends with a dot/punctuation mark. (taken from a review I received on #39821). 239931 3 lucas.de.marchi 2010-06-18 08:31:59 -0700 (In reply to comment #0) > Logging is not fully implemented for EFL port. > > WebKit/WebCore/platform/efl/LoggingEfl.cpp > > > namespace WebCore { > > void InitializeLoggingChannelsIfNecessary() > { > LogNotYetImplemented.state = WTFLogChannelOn; > } > > } Ohh.. Re-thinking about this and the function's name ("IfNecessary"): it's not needed at all because eina_log was already initialized in ewk_main(). With this patch you are justing creating another environment variable to re-implement what is done in eina_log. You should just use EINA_LOG_LEVELS=<your_log_channel_1>:<your_log_level_1> Using this environment variable, each log channel is separated by "," like in: EINA_LOG_LEVELS=ewebkit:2,ewebkit-demo:5 ewebkit-demo 239992 4 joone 2010-06-18 09:54:30 -0700 (In reply to comment #3) > (In reply to comment #0) > > Logging is not fully implemented for EFL port. > > > > WebKit/WebCore/platform/efl/LoggingEfl.cpp > > > > > > namespace WebCore { > > > > void InitializeLoggingChannelsIfNecessary() > > { > > LogNotYetImplemented.state = WTFLogChannelOn; > > } > > > > } > > Ohh.. Re-thinking about this and the function's name ("IfNecessary"): it's not needed at all because eina_log was already initialized in ewk_main(). With this patch you are justing creating another environment variable to re-implement what is done in eina_log. You should just use > > EINA_LOG_LEVELS=<your_log_channel_1>:<your_log_level_1> > > Using this environment variable, each log channel is separated by "," like in: > > EINA_LOG_LEVELS=ewebkit:2,ewebkit-demo:5 ewebkit-demo This logging feature is used for printing log information of WebCore. It is not relevant to ewk stuff. Regarding "," separator, GTK port uses " " separator. It seems no problem because all log channel names of WebCore don't have space About the comment rule you guided, I will follow it. Thanks for the review :-) 240013 5 barbieri 2010-06-18 10:23:58 -0700 Hi Joone Hur, Thanks for your patch, but it is not the way to go. EFL provides Eina Logging, and we should use it as it is appropriate. We must register all the known WTFLogChannel (WebCore/platform/Logging.h) as eina log domains with the eina_log primitives being used in JavaScriptCore/wtf/Assertions.h and JavaScriptCore/wtf/Assertions.cpp as done for Symbian, Mac, Windows and others. From a quick look Eina is fully capable of providing the requirements, if not just let me know and I'll extend eina to provide it, or explain another solution. Your point about "it's webkit and not ewk" log is not fine, as it should behave as a single component, and replicating environment variables will not help. With a very minor effort in the above mentioned files we can make it fully integrated and consistent. I hope you understand our point. 240268 6 joone 2010-06-18 21:34:49 -0700 (In reply to comment #5) > Hi Joone Hur, > > Thanks for your patch, but it is not the way to go. EFL provides Eina Logging, and we should use it as it is appropriate. We must register all the known WTFLogChannel (WebCore/platform/Logging.h) as eina log domains with the eina_log primitives being used in JavaScriptCore/wtf/Assertions.h and JavaScriptCore/wtf/Assertions.cpp as done for Symbian, Mac, Windows and others. From a quick look Eina is fully capable of providing the requirements, if not just let me know and I'll extend eina to provide it, or explain another solution. > > Your point about "it's webkit and not ewk" log is not fine, as it should behave as a single component, and replicating environment variables will not help. With a very minor effort in the above mentioned files we can make it fully integrated and consistent. > > I hope you understand our point. Hi Gustavo, We couldn't add eina_log primitives in Assertion.h, Assertion.cpp because other ports just try to keep compatibility with WebCore logging. They didn't add their logging primitives. WebKitGtk is also using WebCore logging without any changes. 241589 7 59457 joone 2010-06-22 18:39:01 -0700 Created attachment 59457 The comment was fixed @gustavo, do you agree with my opinion? 241621 8 barbieri 2010-06-22 20:33:47 -0700 Hi Joone Hur, Sorry taking long to reply, but I'm on a trip so quite busy and with restricted access to internet during the day. The only observation is that I prefer "," instead of " " for separator for the same reasons Lucas said, particularly for consistency with Eina's log variable. From the EFL-port point-of-view I disagree with it and think we should go eina-log fully. But I'm not a reviewer and will not try to block your patch getting it if you find a reviewer to get your r+/cq+, I'm fine. I'd WebKit reviewers might correct me, but I'd do an AssertionsEfl.cpp that is linked instead of Assertions.cpp and it should implement WTFLogVerbose and friends using eina_log primitives directly. Another, bit worse solution, is to replace vprintf_stderr_common() implementation for EFL with eina_log_print(), as done for Windows, Symbian and others. However the output will not look as good as Eina will replicate the some formatting, it is better to feed function, line number, file name straight to Eina then everything works fine and matches what user (developer) would expect. As added benefit of using Eina is that one might add different logging systems, like syslog, network log or even to serial to help debug in different scenarios. 241667 9 joone.hur 2010-06-22 22:15:58 -0700 We need to get reviewed by maintainers. If they agree with using eina_log primitives, it could be used for enabling logging of EFL port. 245460 10 59457 gustavo 2010-07-01 12:00:52 -0700 Comment on attachment 59457 The comment was fixed WebCore/platform/efl/LoggingEfl.cpp:48 + char* logv = strtok(logEnv, " "); This is wrong. strtok modifies the string it is given, while getenv returns a pointer to a string that is part of the actual environment, so modifying it modifies the environment. Isn't the EFL port using glib for some other stuff already? Why not share the same implementation with GTK+, since for now you're going with the same approach? r- for the reason above; in a later patch you may want to set the commit-queue flag to ?, to indicate you wish it to be automatically committed, unless you want one of the committers to do it manually =) 245528 11 barbieri 2010-07-01 13:52:32 -0700 Kov, the only thing we use from glib so far is the integration with its main loop and that's due libSoup, maybe it will go away when we have time to change that networking code. But EFL has the same tokenizer as eina_str_split(). One comment I did before: Joone Hur please use "," instead of space as it is the same for Eina log. Last but not least, I'd still follow other ports and have better logging by using Eina log system instead of general purpose fprintf(stderr,...). 248003 12 60836 joone 2010-07-07 22:07:01 -0700 Created attachment 60836 updated patch I fixed all you commented. Thanks for reviewing. 248168 13 60836 tonikitoo 2010-07-08 06:34:08 -0700 Comment on attachment 60836 updated patch > + Reviewed by Gustavo Noronha Silva. pls do not pre-full "Reviewed by" field. Let the commit-bot fill it for you with the name of the reviewer (which is not necessarily Gustavo). 248172 14 60872 joone 2010-07-08 06:56:54 -0700 Created attachment 60872 updated patch2 248177 15 60875 joone 2010-07-08 07:03:20 -0700 Created attachment 60875 updated patch3 OK, I removed the reviewer name. Thanks. 248195 16 60875 lucas.de.marchi 2010-07-08 07:54:42 -0700 Comment on attachment 60875 updated patch3 > diff --git a/WebCore/platform/efl/LoggingEfl.cpp b/WebCore/platform/efl/LoggingEfl.cpp > void InitializeLoggingChannelsIfNecessary() > { > + static bool didInitializeLoggingChannels = false; > + if (didInitializeLoggingChannels) > + return; > + > + didInitializeLoggingChannels = true; > + > + char* logEnv = getenv("WEBKIT_DEBUG"); > + if (!logEnv) > + return; > + > +#if defined(NDEBUG) > + EINA_LOG_WARN("WEBKIT_DEBUG is not empty, but this is a release build. Notice that many log messages will only appear in a debug build."); > +#endif > + > + char** logv = eina_str_split(logEnv, ",", -1); eina_str_split might return NULL if it can not allocate space for either the new string or the array. It would crash on next line since you'd dereference a null pointer. Just add an EINA_SAFETY here. EINA_SAFETY_ON_NULL_RETURN(logEnv); 248222 17 joone 2010-07-08 08:35:36 -0700 (In reply to comment #16) > (From update of attachment 60875 [details]) > > diff --git a/WebCore/platform/efl/LoggingEfl.cpp b/WebCore/platform/efl/LoggingEfl.cpp > > void InitializeLoggingChannelsIfNecessary() > > { > > + static bool didInitializeLoggingChannels = false; > > + if (didInitializeLoggingChannels) > > + return; > > + > > + didInitializeLoggingChannels = true; > > + > > + char* logEnv = getenv("WEBKIT_DEBUG"); > > + if (!logEnv) > > + return; > > + > > +#if defined(NDEBUG) > > + EINA_LOG_WARN("WEBKIT_DEBUG is not empty, but this is a release build. Notice that many log messages will only appear in a debug build."); > > +#endif > > + > > + char** logv = eina_str_split(logEnv, ",", -1); > eina_str_split might return NULL if it can not allocate space for either the new string or the array. It would crash on next line since you'd dereference a null pointer. Just add an EINA_SAFETY here. > EINA_SAFETY_ON_NULL_RETURN(logEnv); You mean EINA_SAFETY_ON_NULL_RETURN(logv)? 248249 18 60897 joone 2010-07-08 09:04:30 -0700 Created attachment 60897 updated patch4 I applied EINA_SAFETY_ON_NULL_RETURN for checking whether eina_str_split returns NULL. 248252 19 lucas.de.marchi 2010-07-08 09:08:44 -0700 (In reply to comment #17) > You mean EINA_SAFETY_ON_NULL_RETURN(logv)? Yes. 250273 20 tonikitoo 2010-07-12 20:47:42 -0700 Joone, I think the code looks fine and you've addressed all comments from Lucas, Gustavo Noronha, and Gustavo Barbieri. However in comment #3, comment #5, comment #8 it was expressed desire for another direction for logging: use the already existent eina logging system. Gustavo, Lucas, Joone, do we have an agreement about the way to go? 250506 21 barbieri 2010-07-13 08:07:24 -0700 as I said, I rather go the eina way, but I'm not rejecting or blocking the current implementation. 250849 22 joone 2010-07-13 17:26:51 -0700 (In reply to comment #21) > as I said, I rather go the eina way, but I'm not rejecting or blocking the current implementation. I would consider it if possible to apply eina_log primitives to WebCore. Thanks for comments. 252520 23 joone 2010-07-16 08:14:51 -0700 There seems no other comments on this patch. Antonio, would you set commit-queue+ please? 254480 24 60897 tonikitoo 2010-07-21 13:08:53 -0700 Comment on attachment 60897 updated patch4 > +#include <string.h> do you really need this include? 254800 25 62299 joone 2010-07-22 08:17:50 -0700 Created attachment 62299 updated patch5 I fixed it, Thanks. 254819 26 62299 tonikitoo 2010-07-22 08:33:49 -0700 Comment on attachment 62299 updated patch5 Note for next patches, since I've already r+'ed it, you do not need to ask for review again. You can fix the problems, re-upload the patch with "Reviewed by Antonio Gomes" filled and just ask cq? 254878 27 62299 commit-queue 2010-07-22 10:48:48 -0700 Comment on attachment 62299 updated patch5 Clearing flags on attachment: 62299 Committed r63901: <http://trac.webkit.org/changeset/63901> 254879 28 commit-queue 2010-07-22 10:48:55 -0700 All reviewed patches have been landed. Closing bug. 59066 2010-06-17 20:20:25 -0700 2010-07-01 06:41:57 -0700 patch logging.diff text/plain 1788 joone.hur ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjA4YWVhZC4uZTYxMTJiOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0xNyAgSm9vbmUgSHVyICA8 am9vbmUuaHVyQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtFRkxdIGFkZCBzdXBwb3J0IGZvciBsb2dnaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDgwNworCisgICAgICAgIEVu YWJsZSB0byB0dXJuIGxvZyBjaGFubmVscyBvbiBmb3IgRUZMIHBvcnQKKworICAgICAgICAqIHBs YXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluaXRpYWxpemVM b2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisKIDIwMTAtMDYtMTcgIEJlbmphbWluIFBvdWxh aW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvZ2dpbmdF ZmwuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKaW5kZXggMTgyOWM4 MC4uZjgzYWVjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5j cHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKQEAgLTIyLDExICsy MiwzOSBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgorI2lu Y2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCisKKyNpbmNsdWRlIDxFaW5hLmg+CisjaW5jbHVkZSA8 c3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBJbml0aWFsaXplTG9nZ2lu Z0NoYW5uZWxzSWZOZWNlc3NhcnkoKQogeworICAgIHN0YXRpYyBib29sIGRpZEluaXRpYWxpemVM b2dnaW5nQ2hhbm5lbHMgPSBmYWxzZTsKKyAgICBpZiAoZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFu bmVscykKKyAgICAgICAgcmV0dXJuOworCisgICAgZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVs cyA9IHRydWU7CisKKyAgICBjaGFyKiBsb2dFbnYgPSBnZXRlbnYoIldFQktJVF9ERUJVRyIpOwor ICAgIGlmICghbG9nRW52KQorICAgICAgICByZXR1cm47CisKKyNpZiBkZWZpbmVkKE5ERUJVRykK KyAgICBFSU5BX0xPR19XQVJOKCJXRUJLSVRfREVCVUcgaXMgbm90IGVtcHR5LCBidXQgdGhpcyBp cyBhIHJlbGVhc2UgYnVpbGQuIE5vdGljZSB0aGF0IG1hbnkgbG9nIG1lc3NhZ2VzIHdpbGwgb25s eSBhcHBlYXIgaW4gYSBkZWJ1ZyBidWlsZC4iKTsKKyNlbmRpZgorCisgICAgY2hhciogbG9ndiA9 IHN0cnRvayhsb2dFbnYsICIgIik7CisKKyAgICB3aGlsZSAobG9ndikgeworICAgICAgICBpZiAo V1RGTG9nQ2hhbm5lbCogY2hhbm5lbCA9IGdldENoYW5uZWxGcm9tTmFtZShTdHJpbmcobG9ndikp KQorICAgICAgICAgICAgY2hhbm5lbC0+c3RhdGUgPSBXVEZMb2dDaGFubmVsT247CisgICAgICAg IGxvZ3YgPSBzdHJ0b2soMCwgIiAiKTsKKyAgICB9CisKKyAgICAvLyB0byBkaXNhYmxlIGxvZ2dp bmcgbm90SW1wbGVtZW50ZWQgc2V0IHRoZSBESVNBQkxFX05JX1dBUk5JTkcKKyAgICAvLyBlbnZp cm9ubWVudCB2YXJpYWJsZSB0byAxCiAgICAgTG9nTm90WWV0SW1wbGVtZW50ZWQuc3RhdGUgPSBX VEZMb2dDaGFubmVsT247CiB9CiAK 59457 2010-06-22 18:39:01 -0700 2010-07-07 22:05:24 -0700 The comment was fixed patch2.diff text/plain 1777 joone ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTJhNDM5ZS4uZjc3NGE1MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0yMiAgSm9vbmUgSHVyICA8 am9vbmUuaHVyQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtFRkxdIGFkZCBzdXBwb3J0IGZvciBsb2dnaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDgwNworCisgICAgICAgIEVu YWJsZSB0byB0dXJuIGxvZyBjaGFubmVscyBvbiBmb3IgRUZMIHBvcnQKKworICAgICAgICAqIHBs YXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluaXRpYWxpemVM b2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisKIDIwMTAtMDYtMjIgIFRvbnkgR2VudGlsY29y ZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRl bC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvZ2dpbmdFZmwuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKaW5kZXggMTgyOWM4MC4uMzUyNzk0NiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKQEAgLTIyLDExICsyMiwzOSBAQAogCiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgorI2luY2x1ZGUgIlBsYXRm b3JtU3RyaW5nLmgiCisKKyNpbmNsdWRlIDxFaW5hLmg+CisjaW5jbHVkZSA8c3RyaW5nLmg+CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBJbml0aWFsaXplTG9nZ2luZ0NoYW5uZWxzSWZO ZWNlc3NhcnkoKQogeworICAgIHN0YXRpYyBib29sIGRpZEluaXRpYWxpemVMb2dnaW5nQ2hhbm5l bHMgPSBmYWxzZTsKKyAgICBpZiAoZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVscykKKyAgICAg ICAgcmV0dXJuOworCisgICAgZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVscyA9IHRydWU7CisK KyAgICBjaGFyKiBsb2dFbnYgPSBnZXRlbnYoIldFQktJVF9ERUJVRyIpOworICAgIGlmICghbG9n RW52KQorICAgICAgICByZXR1cm47CisKKyNpZiBkZWZpbmVkKE5ERUJVRykKKyAgICBFSU5BX0xP R19XQVJOKCJXRUJLSVRfREVCVUcgaXMgbm90IGVtcHR5LCBidXQgdGhpcyBpcyBhIHJlbGVhc2Ug YnVpbGQuIE5vdGljZSB0aGF0IG1hbnkgbG9nIG1lc3NhZ2VzIHdpbGwgb25seSBhcHBlYXIgaW4g YSBkZWJ1ZyBidWlsZC4iKTsKKyNlbmRpZgorCisgICAgY2hhciogbG9ndiA9IHN0cnRvayhsb2dF bnYsICIgIik7CisKKyAgICB3aGlsZSAobG9ndikgeworICAgICAgICBpZiAoV1RGTG9nQ2hhbm5l bCogY2hhbm5lbCA9IGdldENoYW5uZWxGcm9tTmFtZShTdHJpbmcobG9ndikpKQorICAgICAgICAg ICAgY2hhbm5lbC0+c3RhdGUgPSBXVEZMb2dDaGFubmVsT247CisgICAgICAgIGxvZ3YgPSBzdHJ0 b2soMCwgIiAiKTsKKyAgICB9CisKKyAgICAvLyBUbyBkaXNhYmxlIGxvZ2dpbmcgbm90SW1wbGVt ZW50ZWQgc2V0IHRoZSBESVNBQkxFX05JX1dBUk5JTkcKKyAgICAvLyBlbnZpcm9ubWVudCB2YXJp YWJsZSB0byAxLgogICAgIExvZ05vdFlldEltcGxlbWVudGVkLnN0YXRlID0gV1RGTG9nQ2hhbm5l bE9uOwogfQogCg== 60836 2010-07-07 22:07:01 -0700 2010-07-08 06:57:12 -0700 updated patch patch_Logging.diff text/plain 1820 joone ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODMwZjNhMi4uNGExOTUwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0wOCAgSm9vbmUgSHVyICA8 am9vbmUuaHVyQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9y b25oYSBTaWx2YS4KKworICAgICAgICBbRUZMXSBhZGQgc3VwcG9ydCBmb3IgbG9nZ2luZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA4MDcKKworICAg ICAgICBFbmFibGUgdG8gdHVybiBsb2cgY2hhbm5lbHMgb24gZm9yIEVGTCBwb3J0CisKKyAgICAg ICAgKiBwbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbml0 aWFsaXplTG9nZ2luZ0NoYW5uZWxzSWZOZWNlc3NhcnkpOgorCiAyMDEwLTA3LTA3ICBKb3NlcGgg UGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQg YnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvZ2dp bmdFZmwuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKaW5kZXggMTgy OWM4MC4uMWE1OWNmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0Vm bC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKQEAgLTIzLDEw ICsyMyw0MCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKIAor I2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCisjaW5jbHVkZSA8RWluYS5oPgorI2luY2x1ZGUg PHN0cmluZy5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgSW5pdGlhbGl6ZUxvZ2dp bmdDaGFubmVsc0lmTmVjZXNzYXJ5KCkKIHsKKyAgICBzdGF0aWMgYm9vbCBkaWRJbml0aWFsaXpl TG9nZ2luZ0NoYW5uZWxzID0gZmFsc2U7CisgICAgaWYgKGRpZEluaXRpYWxpemVMb2dnaW5nQ2hh bm5lbHMpCisgICAgICAgIHJldHVybjsKKworICAgIGRpZEluaXRpYWxpemVMb2dnaW5nQ2hhbm5l bHMgPSB0cnVlOworCisgICAgY2hhciogbG9nRW52ID0gZ2V0ZW52KCJXRUJLSVRfREVCVUciKTsK KyAgICBpZiAoIWxvZ0VudikKKyAgICAgICAgcmV0dXJuOworCisjaWYgZGVmaW5lZChOREVCVUcp CisgICAgRUlOQV9MT0dfV0FSTigiV0VCS0lUX0RFQlVHIGlzIG5vdCBlbXB0eSwgYnV0IHRoaXMg aXMgYSByZWxlYXNlIGJ1aWxkLiBOb3RpY2UgdGhhdCBtYW55IGxvZyBtZXNzYWdlcyB3aWxsIG9u bHkgYXBwZWFyIGluIGEgZGVidWcgYnVpbGQuIik7CisjZW5kaWYKKworICAgIGNoYXIqKiBsb2d2 ID0gZWluYV9zdHJfc3BsaXQobG9nRW52LCAiLCIsIC0xKTsKKworICAgIGZvciAoaW50IGkgPSAw OyBsb2d2W2ldOyBpKyspIHsKKyAgICAgICAgaWYgKFdURkxvZ0NoYW5uZWwqIGNoYW5uZWwgPSBn ZXRDaGFubmVsRnJvbU5hbWUobG9ndltpXSkpCisgICAgICAgICAgICBjaGFubmVsLT5zdGF0ZSA9 IFdURkxvZ0NoYW5uZWxPbjsKKyAgICB9CisKKyAgICBmcmVlKCpsb2d2KTsKKyAgICBmcmVlKGxv Z3YpOworCisgICAgLy8gVG8gZGlzYWJsZSBsb2dnaW5nIG5vdEltcGxlbWVudGVkIHNldCB0aGUg RElTQUJMRV9OSV9XQVJOSU5HCisgICAgLy8gZW52aXJvbm1lbnQgdmFyaWFibGUgdG8gMS4KICAg ICBMb2dOb3RZZXRJbXBsZW1lbnRlZC5zdGF0ZSA9IFdURkxvZ0NoYW5uZWxPbjsKIH0KIAo= 60872 2010-07-08 06:56:54 -0700 2010-07-08 07:03:20 -0700 updated patch2 patch_logging2.diff text/plain 1774 joone ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODMwZjNhMi4uNmM4NWFhYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0wOCAgSm9vbmUgSHVyICA8 am9vbmUuaHVyQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIGFkZCBzdXBwb3J0IGZvciBs b2dnaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MDgwNworCisgICAgICAgIEVuYWJsZSB0byB0dXJuIGxvZyBjaGFubmVscyBvbiBmb3IgRUZMIHBv cnQKKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkluaXRpYWxpemVMb2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisKIDIwMTAtMDct MDcgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJi ZXItc3RhbXBlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvTG9nZ2luZ0VmbC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNw cAppbmRleCAxODI5YzgwLi4xYTU5Y2Y3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9Mb2dnaW5nRWZsLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNw cApAQCAtMjMsMTAgKzIzLDQwIEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9n Z2luZy5oIgogCisjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKKyNpbmNsdWRlIDxFaW5hLmg+ CisjaW5jbHVkZSA8c3RyaW5nLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBJbml0 aWFsaXplTG9nZ2luZ0NoYW5uZWxzSWZOZWNlc3NhcnkoKQogeworICAgIHN0YXRpYyBib29sIGRp ZEluaXRpYWxpemVMb2dnaW5nQ2hhbm5lbHMgPSBmYWxzZTsKKyAgICBpZiAoZGlkSW5pdGlhbGl6 ZUxvZ2dpbmdDaGFubmVscykKKyAgICAgICAgcmV0dXJuOworCisgICAgZGlkSW5pdGlhbGl6ZUxv Z2dpbmdDaGFubmVscyA9IHRydWU7CisKKyAgICBjaGFyKiBsb2dFbnYgPSBnZXRlbnYoIldFQktJ VF9ERUJVRyIpOworICAgIGlmICghbG9nRW52KQorICAgICAgICByZXR1cm47CisKKyNpZiBkZWZp bmVkKE5ERUJVRykKKyAgICBFSU5BX0xPR19XQVJOKCJXRUJLSVRfREVCVUcgaXMgbm90IGVtcHR5 LCBidXQgdGhpcyBpcyBhIHJlbGVhc2UgYnVpbGQuIE5vdGljZSB0aGF0IG1hbnkgbG9nIG1lc3Nh Z2VzIHdpbGwgb25seSBhcHBlYXIgaW4gYSBkZWJ1ZyBidWlsZC4iKTsKKyNlbmRpZgorCisgICAg Y2hhcioqIGxvZ3YgPSBlaW5hX3N0cl9zcGxpdChsb2dFbnYsICIsIiwgLTEpOworCisgICAgZm9y IChpbnQgaSA9IDA7IGxvZ3ZbaV07IGkrKykgeworICAgICAgICBpZiAoV1RGTG9nQ2hhbm5lbCog Y2hhbm5lbCA9IGdldENoYW5uZWxGcm9tTmFtZShsb2d2W2ldKSkKKyAgICAgICAgICAgIGNoYW5u ZWwtPnN0YXRlID0gV1RGTG9nQ2hhbm5lbE9uOworICAgIH0KKworICAgIGZyZWUoKmxvZ3YpOwor ICAgIGZyZWUobG9ndik7CisKKyAgICAvLyBUbyBkaXNhYmxlIGxvZ2dpbmcgbm90SW1wbGVtZW50 ZWQgc2V0IHRoZSBESVNBQkxFX05JX1dBUk5JTkcKKyAgICAvLyBlbnZpcm9ubWVudCB2YXJpYWJs ZSB0byAxLgogICAgIExvZ05vdFlldEltcGxlbWVudGVkLnN0YXRlID0gV1RGTG9nQ2hhbm5lbE9u OwogfQogCg== 60875 2010-07-08 07:03:20 -0700 2010-07-08 09:04:30 -0700 updated patch3 patch_logging3.diff text/plain 1813 joone ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODMwZjNhMi4uNDM1NTliMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0wOCAgSm9vbmUgSHVyICA8 am9vbmUuaHVyQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtFRkxdIGFkZCBzdXBwb3J0IGZvciBsb2dnaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDgwNworCisgICAgICAgIEVu YWJsZSB0byB0dXJuIGxvZyBjaGFubmVscyBvbiBmb3IgRUZMIHBvcnQKKworICAgICAgICAqIHBs YXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluaXRpYWxpemVM b2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisKIDIwMTAtMDctMDcgIEpvc2VwaCBQZWNvcmFy byAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBQYXZl bCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5j cHAgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcAppbmRleCAxODI5YzgwLi4x YTU5Y2Y3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcApAQCAtMjMsMTAgKzIzLDQw IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogCisjaW5jbHVk ZSAiUGxhdGZvcm1TdHJpbmcuaCIKKyNpbmNsdWRlIDxFaW5hLmg+CisjaW5jbHVkZSA8c3RyaW5n Lmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBJbml0aWFsaXplTG9nZ2luZ0NoYW5u ZWxzSWZOZWNlc3NhcnkoKQogeworICAgIHN0YXRpYyBib29sIGRpZEluaXRpYWxpemVMb2dnaW5n Q2hhbm5lbHMgPSBmYWxzZTsKKyAgICBpZiAoZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVscykK KyAgICAgICAgcmV0dXJuOworCisgICAgZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVscyA9IHRy dWU7CisKKyAgICBjaGFyKiBsb2dFbnYgPSBnZXRlbnYoIldFQktJVF9ERUJVRyIpOworICAgIGlm ICghbG9nRW52KQorICAgICAgICByZXR1cm47CisKKyNpZiBkZWZpbmVkKE5ERUJVRykKKyAgICBF SU5BX0xPR19XQVJOKCJXRUJLSVRfREVCVUcgaXMgbm90IGVtcHR5LCBidXQgdGhpcyBpcyBhIHJl bGVhc2UgYnVpbGQuIE5vdGljZSB0aGF0IG1hbnkgbG9nIG1lc3NhZ2VzIHdpbGwgb25seSBhcHBl YXIgaW4gYSBkZWJ1ZyBidWlsZC4iKTsKKyNlbmRpZgorCisgICAgY2hhcioqIGxvZ3YgPSBlaW5h X3N0cl9zcGxpdChsb2dFbnYsICIsIiwgLTEpOworCisgICAgZm9yIChpbnQgaSA9IDA7IGxvZ3Zb aV07IGkrKykgeworICAgICAgICBpZiAoV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCA9IGdldENoYW5u ZWxGcm9tTmFtZShsb2d2W2ldKSkKKyAgICAgICAgICAgIGNoYW5uZWwtPnN0YXRlID0gV1RGTG9n Q2hhbm5lbE9uOworICAgIH0KKworICAgIGZyZWUoKmxvZ3YpOworICAgIGZyZWUobG9ndik7CisK KyAgICAvLyBUbyBkaXNhYmxlIGxvZ2dpbmcgbm90SW1wbGVtZW50ZWQgc2V0IHRoZSBESVNBQkxF X05JX1dBUk5JTkcKKyAgICAvLyBlbnZpcm9ubWVudCB2YXJpYWJsZSB0byAxLgogICAgIExvZ05v dFlldEltcGxlbWVudGVkLnN0YXRlID0gV1RGTG9nQ2hhbm5lbE9uOwogfQogCg== 60897 2010-07-08 09:04:30 -0700 2010-07-22 08:17:50 -0700 updated patch4 patch_logging4.diff text/plain 1854 joone ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODMwZjNhMi4uNDM1NTliMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0wOCAgSm9vbmUgSHVyICA8 am9vbmUuaHVyQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtFRkxdIGFkZCBzdXBwb3J0IGZvciBsb2dnaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDgwNworCisgICAgICAgIEVu YWJsZSB0byB0dXJuIGxvZyBjaGFubmVscyBvbiBmb3IgRUZMIHBvcnQKKworICAgICAgICAqIHBs YXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluaXRpYWxpemVM b2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisKIDIwMTAtMDctMDcgIEpvc2VwaCBQZWNvcmFy byAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBQYXZl bCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5j cHAgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcAppbmRleCAxODI5YzgwLi4y NWRjODUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcApAQCAtMjMsMTAgKzIzLDQy IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogCisjaW5jbHVk ZSAiUGxhdGZvcm1TdHJpbmcuaCIKKyNpbmNsdWRlIDxFaW5hLmg+CisjaW5jbHVkZSA8c3RyaW5n Lmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBJbml0aWFsaXplTG9nZ2luZ0NoYW5u ZWxzSWZOZWNlc3NhcnkoKQogeworICAgIHN0YXRpYyBib29sIGRpZEluaXRpYWxpemVMb2dnaW5n Q2hhbm5lbHMgPSBmYWxzZTsKKyAgICBpZiAoZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVscykK KyAgICAgICAgcmV0dXJuOworCisgICAgZGlkSW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVscyA9IHRy dWU7CisKKyAgICBjaGFyKiBsb2dFbnYgPSBnZXRlbnYoIldFQktJVF9ERUJVRyIpOworICAgIGlm ICghbG9nRW52KQorICAgICAgICByZXR1cm47CisKKyNpZiBkZWZpbmVkKE5ERUJVRykKKyAgICBF SU5BX0xPR19XQVJOKCJXRUJLSVRfREVCVUcgaXMgbm90IGVtcHR5LCBidXQgdGhpcyBpcyBhIHJl bGVhc2UgYnVpbGQuIE5vdGljZSB0aGF0IG1hbnkgbG9nIG1lc3NhZ2VzIHdpbGwgb25seSBhcHBl YXIgaW4gYSBkZWJ1ZyBidWlsZC4iKTsKKyNlbmRpZgorCisgICAgY2hhcioqIGxvZ3YgPSBlaW5h X3N0cl9zcGxpdChsb2dFbnYsICIsIiwgLTEpOworCisgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9S RVRVUk4obG9ndik7CisKKyAgICBmb3IgKGludCBpID0gMDsgbG9ndltpXTsgaSsrKSB7CisgICAg ICAgIGlmIChXVEZMb2dDaGFubmVsKiBjaGFubmVsID0gZ2V0Q2hhbm5lbEZyb21OYW1lKGxvZ3Zb aV0pKQorICAgICAgICAgICAgY2hhbm5lbC0+c3RhdGUgPSBXVEZMb2dDaGFubmVsT247CisgICAg fQorCisgICAgZnJlZSgqbG9ndik7CisgICAgZnJlZShsb2d2KTsKKworICAgIC8vIFRvIGRpc2Fi bGUgbG9nZ2luZyBub3RJbXBsZW1lbnRlZCBzZXQgdGhlIERJU0FCTEVfTklfV0FSTklORworICAg IC8vIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIDEuCiAgICAgTG9nTm90WWV0SW1wbGVtZW50ZWQu c3RhdGUgPSBXVEZMb2dDaGFubmVsT247CiB9CiAK 62299 2010-07-22 08:17:50 -0700 2010-07-22 10:48:48 -0700 updated patch5 patch_logging5.diff text/plain 1819 joone ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjExNjM5NC4uMzM4MzcxZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0yMSAgSm9vbmUgSHVyICA8 am9vbmUuaHVyQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtFRkxdIGFkZCBzdXBwb3J0IGZvciBsb2dnaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDgwNworCisgICAgICAgIEVu YWJsZSB0byB0dXJuIGxvZyBjaGFubmVscyBvbiBmb3IgRUZMIHBvcnQKKworICAgICAgICAqIHBs YXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluaXRpYWxpemVM b2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisKIDIwMTAtMDctMjEgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvZ2dpbmdFZmwuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKaW5kZXggMTgyOWM4MC4uNTVkZTc2NSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKQEAgLTIzLDEwICsyMyw0MSBAQAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKIAorI2luY2x1ZGUgIlBsYXRmb3JtU3Ry aW5nLmgiCisjaW5jbHVkZSA8RWluYS5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQg SW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVsc0lmTmVjZXNzYXJ5KCkKIHsKKyAgICBzdGF0aWMgYm9v bCBkaWRJbml0aWFsaXplTG9nZ2luZ0NoYW5uZWxzID0gZmFsc2U7CisgICAgaWYgKGRpZEluaXRp YWxpemVMb2dnaW5nQ2hhbm5lbHMpCisgICAgICAgIHJldHVybjsKKworICAgIGRpZEluaXRpYWxp emVMb2dnaW5nQ2hhbm5lbHMgPSB0cnVlOworCisgICAgY2hhciogbG9nRW52ID0gZ2V0ZW52KCJX RUJLSVRfREVCVUciKTsKKyAgICBpZiAoIWxvZ0VudikKKyAgICAgICAgcmV0dXJuOworCisjaWYg ZGVmaW5lZChOREVCVUcpCisgICAgRUlOQV9MT0dfV0FSTigiV0VCS0lUX0RFQlVHIGlzIG5vdCBl bXB0eSwgYnV0IHRoaXMgaXMgYSByZWxlYXNlIGJ1aWxkLiBOb3RpY2UgdGhhdCBtYW55IGxvZyBt ZXNzYWdlcyB3aWxsIG9ubHkgYXBwZWFyIGluIGEgZGVidWcgYnVpbGQuIik7CisjZW5kaWYKKwor ICAgIGNoYXIqKiBsb2d2ID0gZWluYV9zdHJfc3BsaXQobG9nRW52LCAiLCIsIC0xKTsKKworICAg IEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKGxvZ3YpOworCisgICAgZm9yIChpbnQgaSA9IDA7 IGxvZ3ZbaV07IGkrKykgeworICAgICAgICBpZiAoV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCA9IGdl dENoYW5uZWxGcm9tTmFtZShsb2d2W2ldKSkKKyAgICAgICAgICAgIGNoYW5uZWwtPnN0YXRlID0g V1RGTG9nQ2hhbm5lbE9uOworICAgIH0KKworICAgIGZyZWUoKmxvZ3YpOworICAgIGZyZWUobG9n dik7CisKKyAgICAvLyBUbyBkaXNhYmxlIGxvZ2dpbmcgbm90SW1wbGVtZW50ZWQgc2V0IHRoZSBE SVNBQkxFX05JX1dBUk5JTkcKKyAgICAvLyBlbnZpcm9ubWVudCB2YXJpYWJsZSB0byAxLgogICAg IExvZ05vdFlldEltcGxlbWVudGVkLnN0YXRlID0gV1RGTG9nQ2hhbm5lbE9uOwogfQogCg==