40803 2010-06-17 17:07:34 -0700 TestNetscapePlugin has an incorrect implementation of "property" property 2010-06-18 10:21:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap abarth eric webkit.review.bot oldest_to_newest 239657 0 ap 2010-06-17 17:07:34 -0700 It's currently unused, but when I tried to use it to check some behavior, this brokenness has confused me a lot. Now that I understand what's going on, I already have a test and a fix. 239660 1 59050 ap 2010-06-17 17:09:45 -0700 Created attachment 59050 proposed fix 239993 2 ap 2010-06-18 10:00:16 -0700 Committed <http://trac.webkit.org/changeset/61415>. 240010 3 webkit.review.bot 2010-06-18 10:21:26 -0700 http://trac.webkit.org/changeset/61415 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/61416 http://trac.webkit.org/changeset/61414 http://trac.webkit.org/changeset/61415 59050 2010-06-17 17:09:45 -0700 2010-06-17 20:09:16 -0700 proposed fix PropertyProperty.txt text/plain 3588 ap SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYxMzYwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMTcgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODAz CisgICAgICAgIFRlc3ROZXRzY2FwZVBsdWdpbiBoYXMgYW4gaW5jb3JyZWN0IGltcGxlbWVudGF0 aW9uIG9mICJwcm9wZXJ0eSIgcHJvcGVydHkKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rl c3ROZXRzY2FwZVBsdWdJbi5zdWJwcm9qL1BsdWdpbk9iamVjdC5jcHA6IChwbHVnaW5HZXRQcm9w ZXJ0eSk6IERvbid0CisgICAgICAgIHBhc3MgYSBzdGF0aWMgc3RyaW5nIGJhY2ssIGl0J3MgZ29p bmcgdG8gYmUgcmVsZWFzZWQgYnkgTlBBUEkgaW1wbGVtZW50YXRpb24uCisKIDIwMTAtMDYtMTcg IEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUm9sbGluZyBvdXQgaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNjEyOTcgZHVlIHRvIGJ1aWxkIGVycm9ycy4K SW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi5zdWJw cm9qL1BsdWdpbk9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luLnN1YnByb2ovUGx1Z2luT2JqZWN0LmNwcAkocmV2aXNp b24gNjEyMDIpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVn SW4uc3VicHJvai9QbHVnaW5PYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjAsNyArMjYw LDEwIEBAIHN0YXRpYyBib29sIHBsdWdpbkdldFByb3BlcnR5KE5QT2JqZWN0KiAKIHsKICAgICBQ bHVnaW5PYmplY3QqIHBsdWdpbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8UGx1Z2luT2JqZWN0Kj4ob2Jq KTsKICAgICBpZiAobmFtZSA9PSBwbHVnaW5Qcm9wZXJ0eUlkZW50aWZpZXJzW0lEX1BST1BFUlRZ X1BST1BFUlRZXSkgewotICAgICAgICBTVFJJTkdaX1RPX05QVkFSSUFOVCgicHJvcGVydHkiLCAq cmVzdWx0KTsKKyAgICAgICAgc3RhdGljIGNvbnN0IGNoYXIqIG9yaWdpbmFsU3RyaW5nID0gInBy b3BlcnR5IjsKKyAgICAgICAgY2hhciogYnVmID0gc3RhdGljX2Nhc3Q8Y2hhcio+KGJyb3dzZXIt Pm1lbWFsbG9jKHN0cmxlbihvcmlnaW5hbFN0cmluZykgKyAxKSk7CisgICAgICAgIHN0cmNweShi dWYsIG9yaWdpbmFsU3RyaW5nKTsKKyAgICAgICAgU1RSSU5HWl9UT19OUFZBUklBTlQoYnVmLCAq cmVzdWx0KTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSBlbHNlIGlmIChuYW1lID09IHBs dWdpblByb3BlcnR5SWRlbnRpZmllcnNbSURfUFJPUEVSVFlfRVZFTlRfTE9HR0lOR10pIHsKICAg ICAgICAgQk9PTEVBTl9UT19OUFZBUklBTlQocGx1Z2luLT5ldmVudExvZ2dpbmcsICpyZXN1bHQp OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gNjEzNjApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xNyAgQWxleGV5IFByb3NrdXJ5 YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA4 MDMKKyAgICAgICAgVGVzdE5ldHNjYXBlUGx1Z2luIGhhcyBhbiBpbmNvcnJlY3QgaW1wbGVtZW50 YXRpb24gb2YgInByb3BlcnR5IiBwcm9wZXJ0eQorCisgICAgICAgICogcGx1Z2lucy9lbWJlZC1w cm9wZXJ0eS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsdWdpbnMvZW1iZWQtcHJv cGVydHkuaHRtbDogQWRkZWQuCisKIDIwMTAtMDYtMTcgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6 a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBDaHJvbWl1bSBleHBlY3Rh dGlvbnMgdXBkYXRlLgpJbmRleDogTGF5b3V0VGVzdHMvcGx1Z2lucy9lbWJlZC1wcm9wZXJ0eS1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGx1Z2lucy9lbWJlZC1wcm9w ZXJ0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbHVnaW5zL2Vt YmVkLXByb3BlcnR5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitU ZXN0IGFjY2Vzc2luZyBhIHBsdWdpbiBvYmplY3QgcHJvcGVydHkgdmlhIEhUTUxFbWJlZEVsZW1l bnQuCisKK1NVQ0NFU1MKSW5kZXg6IExheW91dFRlc3RzL3BsdWdpbnMvZW1iZWQtcHJvcGVydHku aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbHVnaW5zL2VtYmVkLXByb3BlcnR5Lmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbHVnaW5zL2VtYmVkLXByb3BlcnR5Lmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjIgQEAKKzxib2R5IG9ubG9hZD0idGVzdCgpIj4K KzxwPlRlc3QgYWNjZXNzaW5nIGEgcGx1Z2luIG9iamVjdCBwcm9wZXJ0eSB2aWEgSFRNTEVtYmVk RWxlbWVudC48L3A+Cis8ZGl2IGlkPWRpdj4KKzxlbWJlZCBpZD0idGVzdENQbHVnaW4iIHR5cGU9 ImFwcGxpY2F0aW9uL3gtd2Via2l0LXRlc3QtbmV0c2NhcGUiPgorPC9kaXY+Cis8c2NyaXB0Pgor aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIHZhciBjUGx1Z2luID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RDUGx1Z2luIik7CisgICAgdHJ5IHsKKyAgICAg ICAgdmFyIHByb3AgPSBjUGx1Z2luLnByb3BlcnR5OyAvLyB0cnkgb25jZSB0byBnaXZlIGl0IGEg Y2hhbmNlIHRvIGNyYXNoCisgICAgICAgIHByb3AgPSBjUGx1Z2luLnByb3BlcnR5OworICAgICAg ICBkaXYuaW5uZXJIVE1MID0gKHByb3AgPT0gInByb3BlcnR5IikgPyAiU1VDQ0VTUyIgOiAoIkZB SUxVUkU6ICIgKyBwcm9wKTsKKyAgICB9IGNhdGNoIChleCkgeworICAgICAgICBkaXYuaW5uZXJI VE1MID0gIkZBSUxVUkU6ICIgKyBleDsKKyAgICB9Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4K