40791 2010-06-17 10:59:21 -0700 Warnings from -Wextra in a Chromium Mac build 2010-06-19 07:07:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 thomasvl webkit-unassigned commit-queue dglazkov oldest_to_newest 239479 0 thomasvl 2010-06-17 10:59:21 -0700 A bunch of warnings from a -Wextra Chromium Mac build (will become the default). - checks of unsigned >= 0 - enumeral and non-enumeral type in conditional expression - copy ctors that don't call the super copy ctor or ctor. 239486 1 59018 thomasvl 2010-06-17 11:11:05 -0700 Created attachment 59018 proposed patch for the warnings 239492 2 59018 dglazkov 2010-06-17 11:21:32 -0700 Comment on attachment 59018 proposed patch for the warnings ok. WebCore/platform/chromium/ChromiumDataObject.cpp:70 + : RefCounted<ChromiumDataObject>() Fascinating. 239494 3 59018 dglazkov 2010-06-17 11:23:25 -0700 Comment on attachment 59018 proposed patch for the warnings oops, address is wrong. Can you re-upload with fix? 239498 4 59021 thomasvl 2010-06-17 11:27:14 -0700 Created attachment 59021 second patch with fixed email addr 239502 5 59023 thomasvl 2010-06-17 11:34:15 -0700 Created attachment 59023 Fixing tests part of changelog 240333 6 59023 commit-queue 2010-06-19 07:07:11 -0700 Comment on attachment 59023 Fixing tests part of changelog Clearing flags on attachment: 59023 Committed r61486: <http://trac.webkit.org/changeset/61486> 240334 7 commit-queue 2010-06-19 07:07:16 -0700 All reviewed patches have been landed. Closing bug. 59018 2010-06-17 11:11:05 -0700 2010-06-17 11:27:14 -0700 proposed patch for the warnings chromium_wextra.txt text/plain 6945 thomasvl SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTMzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDYtMTcgIFRob21hcyBWYW4gTGVudGVuICA8VGhvbWFzIFZh biBMZW50ZW4gPHRob21hc3ZsQGNocm9taXVtLm9yZz4+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2FybmluZ3MgZnJvbSAtV2V4dHJhIGluIGEgQ2hy b21pdW0gTWFjIGJ1aWxkCisgICAgICAgIDEuIGNoZWNrcyBvZiB1bnNpZ25lZCA+PSAwCisgICAg ICAgIDIuIGVudW1lcmFsIGFuZCBub24tZW51bWVyYWwgdHlwZSBpbiBjb25kaXRpb25hbCBleHBy ZXNzaW9uCisgICAgICAgIDMuIGNvcHkgY3RvcnMgdGhhdCBkb24ndCBjYWxsIHRoZSBzdXBlciBj b3B5IGN0b3Igb3IgY3RvcgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MDc5MQorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNocm9taXVtRGF0YU9iamVjdDo6Q2hyb21pdW1EYXRhT2JqZWN0KToKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UaGVtZUNocm9taXVtTWFjLm1tOgorICAgICAgICAoV2Vi Q29yZTo6dXBkYXRlU3RhdGVzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJv bWl1bU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OnVw ZGF0ZUFjdGl2ZVN0YXRlKToKKwogMjAxMC0wNi0xNyAgU2h1IENoYW5nICA8Y2hhbmcuc2h1QG5v a2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9i amVjdC5jcHAJKHJldmlzaW9uIDYxMzM2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9D aHJvbWl1bURhdGFPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw3ICs2Nyw4IEBAIGJv b2wgQ2hyb21pdW1EYXRhT2JqZWN0OjpoYXNEYXRhKCkgY29uc3QKIH0KIAogQ2hyb21pdW1EYXRh T2JqZWN0OjpDaHJvbWl1bURhdGFPYmplY3QoY29uc3QgQ2hyb21pdW1EYXRhT2JqZWN0JiBvdGhl cikKLSAgICA6IHVybFRpdGxlKG90aGVyLnVybFRpdGxlKQorICAgIDogUmVmQ291bnRlZDxDaHJv bWl1bURhdGFPYmplY3Q+KCkKKyAgICAsIHVybFRpdGxlKG90aGVyLnVybFRpdGxlKQogICAgICwg ZG93bmxvYWRNZXRhZGF0YShvdGhlci5kb3dubG9hZE1ldGFkYXRhKQogICAgICwgZmlsZUV4dGVu c2lvbihvdGhlci5maWxlRXh0ZW5zaW9uKQogICAgICwgZmlsZW5hbWVzKG90aGVyLmZpbGVuYW1l cykKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vVGhlbWVDaHJvbWl1bU1hYy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1RoZW1lQ2hyb21pdW1NYWMu bW0JKHJldmlzaW9uIDYxMzM2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9UaGVtZUNo cm9taXVtTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNzEsNyArMjcxLDggQEAgc3RhdGljIHZv aWQgdXBkYXRlU3RhdGVzKE5TQ2VsbCogY2VsbCwgQwogICAgIC8vIFdpbmRvdyBJbmFjdGl2ZSBz dGF0ZQogICAgIE5TQ29udHJvbFRpbnQgb2xkVGludCA9IFtjZWxsIGNvbnRyb2xUaW50XTsKICAg ICBib29sIHdpbmRvd0luYWN0aXZlID0gKHN0YXRlcyAmIFdpbmRvd0luYWN0aXZlU3RhdGUpOwot ICAgIE5TQ29udHJvbFRpbnQgdGludCA9IHdpbmRvd0luYWN0aXZlID8gTlNDbGVhckNvbnRyb2xU aW50IDogW05TQ29sb3IgY3VycmVudENvbnRyb2xUaW50XTsKKyAgICBOU0NvbnRyb2xUaW50IHRp bnQgPSB3aW5kb3dJbmFjdGl2ZSA/IHN0YXRpY19jYXN0PE5TQ29udHJvbFRpbnQ+KE5TQ2xlYXJD b250cm9sVGludCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IFtO U0NvbG9yIGN1cnJlbnRDb250cm9sVGludF07CiAgICAgaWYgKHRpbnQgIT0gb2xkVGludCkKICAg ICAgICAgW2NlbGwgc2V0Q29udHJvbFRpbnQ6dGludF07CiB9CkluZGV4OiBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0JKHJldmlzaW9uIDYxMzM2KQorKysgV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5tbQkod29ya2luZyBjb3B5KQpA QCAtOTEsNyArOTEsNyBAQCB2b2lkIFJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OnVwZGF0ZUFjdGl2 CiB7CiAgICAgTlNDb250cm9sVGludCBvbGRUaW50ID0gW2NlbGwgY29udHJvbFRpbnRdOwogICAg IE5TQ29udHJvbFRpbnQgdGludCA9IGlzQWN0aXZlKG8pID8gW05TQ29sb3IgY3VycmVudENvbnRy b2xUaW50XSA6Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOU0NsZWFy Q29udHJvbFRpbnQ7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0 aWNfY2FzdDxOU0NvbnRyb2xUaW50PihOU0NsZWFyQ29udHJvbFRpbnQpOwogCiAgICAgaWYgKHRp bnQgIT0gb2xkVGludCkKICAgICAgICAgW2NlbGwgc2V0Q29udHJvbFRpbnQ6dGludF07CkluZGV4 OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYxMzM4KQorKysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEwLTA2LTE3ICBUaG9tYXMgVmFu IExlbnRlbiAgPFRob21hcyBWYW4gTGVudGVuIDx0aG9tYXN2bEBjaHJvbWl1bS5vcmc+PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdhcm5pbmdzIGZy b20gLVdleHRyYSBpbiBhIENocm9taXVtIE1hYyBidWlsZAorICAgICAgICAxLiBjaGVja3Mgb2Yg dW5zaWduZWQgPj0gMAorICAgICAgICAyLiBlbnVtZXJhbCBhbmQgbm9uLWVudW1lcmFsIHR5cGUg aW4gY29uZGl0aW9uYWwgZXhwcmVzc2lvbgorICAgICAgICAzLiBjb3B5IGN0b3JzIHRoYXQgZG9u J3QgY2FsbCB0aGUgc3VwZXIgY29weSBjdG9yIG9yIGN0b3IKKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA3OTEKKworICAgICAgICAqIHNyYy9BdXRv RmlsbFBvcHVwTWVudUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9wdXBN ZW51Q2xpZW50OjpnZXRTdWdnZXN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6QXV0b0ZpbGxQb3B1 cE1lbnVDbGllbnQ6OnJlbW92ZVN1Z2dlc3Rpb25BdEluZGV4KToKKyAgICAgICAgKFdlYktpdDo6 QXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OnZhbHVlQ2hhbmdlZCk6CisgICAgICAgIChXZWJLaXQ6 OkF1dG9GaWxsUG9wdXBNZW51Q2xpZW50OjpzZWxlY3Rpb25DaGFuZ2VkKToKKyAgICAgICAgKiBz cmMvQXV0b2NvbXBsZXRlUG9wdXBNZW51Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6QXV0 b2NvbXBsZXRlUG9wdXBNZW51Q2xpZW50OjpnZXRTdWdnZXN0aW9uKToKKyAgICAgICAgKFdlYktp dDo6QXV0b2NvbXBsZXRlUG9wdXBNZW51Q2xpZW50OjpyZW1vdmVTdWdnZXN0aW9uQXRJbmRleCk6 CisKIDIwMTAtMDYtMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZDogY2hyb21pdW0gdGVzdHMgZml4LiBBZGRlZCBJbnNwZWN0b3JC YWNrZW5kIGRlbGVnYXRlcyBmb3IgbmV3IGluc3BlY3RvciBtZXRob2RzLgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5jcHAJKHJldmlzaW9u IDYxMzM2KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTU2LDcgKzU2LDcgQEAgV2ViU3RyaW5nIEF1dG9GaWxsUG9w dXBNZW51Q2xpZW50OjpnZXRTdQogICAgICAgICAtLWxpc3RJbmRleDsKIAogICAgIC8vIEZJWE1F OiBNb2RpZnkgdGhlIFBvcHVwTWVudSB0byBhZGQgdGhlIGxhYmVsIGluIGdyYXkgcmlnaHQtanVz dGlmaWVkLgotICAgIEFTU0VSVChsaXN0SW5kZXggPj0gMCAmJiBsaXN0SW5kZXggPCBtX25hbWVz LnNpemUoKSk7CisgICAgQVNTRVJUKGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKIAogICAg IFdlYlN0cmluZyBzdWdnZXN0aW9uID0gbV9uYW1lc1tsaXN0SW5kZXhdOwogICAgIGlmIChtX2xh YmVsc1tsaXN0SW5kZXhdLmlzRW1wdHkoKSkKQEAgLTY4LDcgKzY4LDcgQEAgV2ViU3RyaW5nIEF1 dG9GaWxsUG9wdXBNZW51Q2xpZW50OjpnZXRTdQogdm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVu dDo6cmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4KQogewogICAgIC8v IEZJWE1FOiBEbyB3ZSB3YW50IHRvIHJlbW92ZSBBdXRvRmlsbCBzdWdnZXN0aW9ucz8KLSAgICBB U1NFUlQobGlzdEluZGV4ID49IDAgJiYgbGlzdEluZGV4IDwgbV9uYW1lcy5zaXplKCkpOworICAg IEFTU0VSVChsaXN0SW5kZXggPCBtX25hbWVzLnNpemUoKSk7CiAgICAgbV9uYW1lcy5yZW1vdmUo bGlzdEluZGV4KTsKICAgICBtX2xhYmVscy5yZW1vdmUobGlzdEluZGV4KTsKIH0KQEAgLTgyLDcg KzgyLDcgQEAgdm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6dmFsdWVDaGFuZwogICAgIGlm IChtX3NlcGFyYXRvckluZGV4ICE9IC0xICYmIGxpc3RJbmRleCA+IHN0YXRpY19jYXN0PHVuc2ln bmVkPihtX3NlcGFyYXRvckluZGV4KSkKICAgICAgICAgLS1saXN0SW5kZXg7CiAKLSAgICBBU1NF UlQobGlzdEluZGV4ID49IDAgJiYgbGlzdEluZGV4IDwgbV9uYW1lcy5zaXplKCkpOworICAgIEFT U0VSVChsaXN0SW5kZXggPCBtX25hbWVzLnNpemUoKSk7CiAKICAgICB3ZWJWaWV3LT5jbGllbnQo KS0+ZGlkQWNjZXB0QXV0b0ZpbGxTdWdnZXN0aW9uKFdlYk5vZGUoZ2V0VGV4dEZpZWxkKCkpLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9uYW1l c1tsaXN0SW5kZXhdLApAQCAtOTksNyArOTksNyBAQCB2b2lkIEF1dG9GaWxsUG9wdXBNZW51Q2xp ZW50OjpzZWxlY3Rpb25DCiAgICAgaWYgKG1fc2VwYXJhdG9ySW5kZXggIT0gLTEgJiYgbGlzdElu ZGV4ID4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1fc2VwYXJhdG9ySW5kZXgpKQogICAgICAgICAt LWxpc3RJbmRleDsKIAotICAgIEFTU0VSVChsaXN0SW5kZXggPj0gMCAmJiBsaXN0SW5kZXggPCBt X25hbWVzLnNpemUoKSk7CisgICAgQVNTRVJUKGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsK IAogICAgIHdlYlZpZXctPmNsaWVudCgpLT5kaWRTZWxlY3RBdXRvRmlsbFN1Z2dlc3Rpb24oV2Vi Tm9kZShnZXRUZXh0RmllbGQoKSksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBtX25hbWVzW2xpc3RJbmRleF0sCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL0F1dG9jb21wbGV0ZVBvcHVwTWVudUNsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L2Nocm9taXVtL3NyYy9BdXRvY29tcGxldGVQb3B1cE1lbnVDbGllbnQuY3BwCShyZXZpc2lv biA2MTMzNikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b2NvbXBsZXRlUG9wdXBNZW51Q2xp ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYsMTMgKzQ2LDEzIEBAIHVuc2lnbmVkIEF1dG9j b21wbGV0ZVBvcHVwTWVudUNsaWVudDo6Z2UKIAogV2ViU3RyaW5nIEF1dG9jb21wbGV0ZVBvcHVw TWVudUNsaWVudDo6Z2V0U3VnZ2VzdGlvbih1bnNpZ25lZCBsaXN0SW5kZXgpIGNvbnN0CiB7Ci0g ICAgQVNTRVJUKGxpc3RJbmRleCA+PSAwICYmIGxpc3RJbmRleCA8IG1fc3VnZ2VzdGlvbnMuc2l6 ZSgpKTsKKyAgICBBU1NFUlQobGlzdEluZGV4IDwgbV9zdWdnZXN0aW9ucy5zaXplKCkpOwogICAg IHJldHVybiBtX3N1Z2dlc3Rpb25zW2xpc3RJbmRleF07CiB9CiAKIHZvaWQgQXV0b2NvbXBsZXRl UG9wdXBNZW51Q2xpZW50OjpyZW1vdmVTdWdnZXN0aW9uQXRJbmRleCh1bnNpZ25lZCBsaXN0SW5k ZXgpCiB7Ci0gICAgQVNTRVJUKGxpc3RJbmRleCA+PSAwICYmIGxpc3RJbmRleCA8IG1fc3VnZ2Vz dGlvbnMuc2l6ZSgpKTsKKyAgICBBU1NFUlQobGlzdEluZGV4IDwgbV9zdWdnZXN0aW9ucy5zaXpl KCkpOwogICAgIG1fc3VnZ2VzdGlvbnMucmVtb3ZlKGxpc3RJbmRleCk7CiB9CiAK 59021 2010-06-17 11:27:14 -0700 2010-06-17 11:34:15 -0700 second patch with fixed email addr chromium_wextra.txt text/plain 6905 thomasvl SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTMzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDYtMTcgIFRob21hcyBWYW4gTGVudGVuICA8dGhvbWFzdmxA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdhcm5pbmdzIGZyb20gLVdleHRyYSBpbiBhIENocm9taXVtIE1hYyBidWlsZAorICAg ICAgICAxLiBjaGVja3Mgb2YgdW5zaWduZWQgPj0gMAorICAgICAgICAyLiBlbnVtZXJhbCBhbmQg bm9uLWVudW1lcmFsIHR5cGUgaW4gY29uZGl0aW9uYWwgZXhwcmVzc2lvbgorICAgICAgICAzLiBj b3B5IGN0b3JzIHRoYXQgZG9uJ3QgY2FsbCB0aGUgc3VwZXIgY29weSBjdG9yIG9yIGN0b3IKKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA3OTEKKwor ICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL0Nocm9taXVtRGF0YU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bURh dGFPYmplY3Q6OkNocm9taXVtRGF0YU9iamVjdCk6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21p dW0vVGhlbWVDaHJvbWl1bU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnVwZGF0ZVN0YXRlcyk6 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW06CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTWFjOjp1cGRhdGVBY3RpdmVTdGF0ZSk6CisK IDIwMTAtMDYtMTcgIFNodSBDaGFuZyAgPGNoYW5nLnNodUBub2tpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bURhdGFPYmplY3QuY3BwCShyZXZpc2lvbiA2 MTMzNikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtNjcsNyArNjcsOCBAQCBib29sIENocm9taXVtRGF0YU9iamVj dDo6aGFzRGF0YSgpIGNvbnN0CiB9CiAKIENocm9taXVtRGF0YU9iamVjdDo6Q2hyb21pdW1EYXRh T2JqZWN0KGNvbnN0IENocm9taXVtRGF0YU9iamVjdCYgb3RoZXIpCi0gICAgOiB1cmxUaXRsZShv dGhlci51cmxUaXRsZSkKKyAgICA6IFJlZkNvdW50ZWQ8Q2hyb21pdW1EYXRhT2JqZWN0PigpCisg ICAgLCB1cmxUaXRsZShvdGhlci51cmxUaXRsZSkKICAgICAsIGRvd25sb2FkTWV0YWRhdGEob3Ro ZXIuZG93bmxvYWRNZXRhZGF0YSkKICAgICAsIGZpbGVFeHRlbnNpb24ob3RoZXIuZmlsZUV4dGVu c2lvbikKICAgICAsIGZpbGVuYW1lcyhvdGhlci5maWxlbmFtZXMpCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL1RoZW1lQ2hyb21pdW1NYWMubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9UaGVtZUNocm9taXVtTWFjLm1tCShyZXZpc2lvbiA2MTMzNikK KysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vVGhlbWVDaHJvbWl1bU1hYy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMjcxLDcgKzI3MSw4IEBAIHN0YXRpYyB2b2lkIHVwZGF0ZVN0YXRlcyhOU0Nl bGwqIGNlbGwsIEMKICAgICAvLyBXaW5kb3cgSW5hY3RpdmUgc3RhdGUKICAgICBOU0NvbnRyb2xU aW50IG9sZFRpbnQgPSBbY2VsbCBjb250cm9sVGludF07CiAgICAgYm9vbCB3aW5kb3dJbmFjdGl2 ZSA9IChzdGF0ZXMgJiBXaW5kb3dJbmFjdGl2ZVN0YXRlKTsKLSAgICBOU0NvbnRyb2xUaW50IHRp bnQgPSB3aW5kb3dJbmFjdGl2ZSA/IE5TQ2xlYXJDb250cm9sVGludCA6IFtOU0NvbG9yIGN1cnJl bnRDb250cm9sVGludF07CisgICAgTlNDb250cm9sVGludCB0aW50ID0gd2luZG93SW5hY3RpdmUg PyBzdGF0aWNfY2FzdDxOU0NvbnRyb2xUaW50PihOU0NsZWFyQ29udHJvbFRpbnQpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiBbTlNDb2xvciBjdXJyZW50Q29udHJv bFRpbnRdOwogICAgIGlmICh0aW50ICE9IG9sZFRpbnQpCiAgICAgICAgIFtjZWxsIHNldENvbnRy b2xUaW50OnRpbnRdOwogfQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJv bWl1bU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNo cm9taXVtTWFjLm1tCShyZXZpc2lvbiA2MTMzNikKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRoZW1lQ2hyb21pdW1NYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTkxLDcgKzkxLDcgQEAgdm9p ZCBSZW5kZXJUaGVtZUNocm9taXVtTWFjOjp1cGRhdGVBY3RpdgogewogICAgIE5TQ29udHJvbFRp bnQgb2xkVGludCA9IFtjZWxsIGNvbnRyb2xUaW50XTsKICAgICBOU0NvbnRyb2xUaW50IHRpbnQg PSBpc0FjdGl2ZShvKSA/IFtOU0NvbG9yIGN1cnJlbnRDb250cm9sVGludF0gOgotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlNDbGVhckNvbnRyb2xUaW50OworICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8TlNDb250cm9sVGlu dD4oTlNDbGVhckNvbnRyb2xUaW50KTsKIAogICAgIGlmICh0aW50ICE9IG9sZFRpbnQpCiAgICAg ICAgIFtjZWxsIHNldENvbnRyb2xUaW50OnRpbnRdOwpJbmRleDogV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lv biA2MTMzOCkKKysrIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwyMyBAQAorMjAxMC0wNi0xNyAgVGhvbWFzIFZhbiBMZW50ZW4gIDx0aG9tYXN2bEBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2FybmluZ3MgZnJvbSAtV2V4dHJhIGluIGEgQ2hyb21pdW0gTWFjIGJ1aWxkCisgICAg ICAgIDEuIGNoZWNrcyBvZiB1bnNpZ25lZCA+PSAwCisgICAgICAgIDIuIGVudW1lcmFsIGFuZCBu b24tZW51bWVyYWwgdHlwZSBpbiBjb25kaXRpb25hbCBleHByZXNzaW9uCisgICAgICAgIDMuIGNv cHkgY3RvcnMgdGhhdCBkb24ndCBjYWxsIHRoZSBzdXBlciBjb3B5IGN0b3Igb3IgY3RvcgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDc5MQorCisg ICAgICAgICogc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktp dDo6QXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OmdldFN1Z2dlc3Rpb24pOgorICAgICAgICAoV2Vi S2l0OjpBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6cmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgpOgor ICAgICAgICAoV2ViS2l0OjpBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6dmFsdWVDaGFuZ2VkKToK KyAgICAgICAgKFdlYktpdDo6QXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OnNlbGVjdGlvbkNoYW5n ZWQpOgorICAgICAgICAqIHNyYy9BdXRvY29tcGxldGVQb3B1cE1lbnVDbGllbnQuY3BwOgorICAg ICAgICAoV2ViS2l0OjpBdXRvY29tcGxldGVQb3B1cE1lbnVDbGllbnQ6OmdldFN1Z2dlc3Rpb24p OgorICAgICAgICAoV2ViS2l0OjpBdXRvY29tcGxldGVQb3B1cE1lbnVDbGllbnQ6OnJlbW92ZVN1 Z2dlc3Rpb25BdEluZGV4KToKKwogMjAxMC0wNi0xNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkOiBjaHJvbWl1bSB0ZXN0cyBmaXgu IEFkZGVkIEluc3BlY3RvckJhY2tlbmQgZGVsZWdhdGVzIGZvciBuZXcgaW5zcGVjdG9yIG1ldGhv ZHMuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xp ZW50LmNwcAkocmV2aXNpb24gNjEzMzYpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxs UG9wdXBNZW51Q2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTYsNyArNTYsNyBAQCBXZWJT dHJpbmcgQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OmdldFN1CiAgICAgICAgIC0tbGlzdEluZGV4 OwogCiAgICAgLy8gRklYTUU6IE1vZGlmeSB0aGUgUG9wdXBNZW51IHRvIGFkZCB0aGUgbGFiZWwg aW4gZ3JheSByaWdodC1qdXN0aWZpZWQuCi0gICAgQVNTRVJUKGxpc3RJbmRleCA+PSAwICYmIGxp c3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKKyAgICBBU1NFUlQobGlzdEluZGV4IDwgbV9uYW1l cy5zaXplKCkpOwogCiAgICAgV2ViU3RyaW5nIHN1Z2dlc3Rpb24gPSBtX25hbWVzW2xpc3RJbmRl eF07CiAgICAgaWYgKG1fbGFiZWxzW2xpc3RJbmRleF0uaXNFbXB0eSgpKQpAQCAtNjgsNyArNjgs NyBAQCBXZWJTdHJpbmcgQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OmdldFN1CiB2b2lkIEF1dG9G aWxsUG9wdXBNZW51Q2xpZW50OjpyZW1vdmVTdWdnZXN0aW9uQXRJbmRleCh1bnNpZ25lZCBsaXN0 SW5kZXgpCiB7CiAgICAgLy8gRklYTUU6IERvIHdlIHdhbnQgdG8gcmVtb3ZlIEF1dG9GaWxsIHN1 Z2dlc3Rpb25zPwotICAgIEFTU0VSVChsaXN0SW5kZXggPj0gMCAmJiBsaXN0SW5kZXggPCBtX25h bWVzLnNpemUoKSk7CisgICAgQVNTRVJUKGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKICAg ICBtX25hbWVzLnJlbW92ZShsaXN0SW5kZXgpOwogICAgIG1fbGFiZWxzLnJlbW92ZShsaXN0SW5k ZXgpOwogfQpAQCAtODIsNyArODIsNyBAQCB2b2lkIEF1dG9GaWxsUG9wdXBNZW51Q2xpZW50Ojp2 YWx1ZUNoYW5nCiAgICAgaWYgKG1fc2VwYXJhdG9ySW5kZXggIT0gLTEgJiYgbGlzdEluZGV4ID4g c3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1fc2VwYXJhdG9ySW5kZXgpKQogICAgICAgICAtLWxpc3RJ bmRleDsKIAotICAgIEFTU0VSVChsaXN0SW5kZXggPj0gMCAmJiBsaXN0SW5kZXggPCBtX25hbWVz LnNpemUoKSk7CisgICAgQVNTRVJUKGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKIAogICAg IHdlYlZpZXctPmNsaWVudCgpLT5kaWRBY2NlcHRBdXRvRmlsbFN1Z2dlc3Rpb24oV2ViTm9kZShn ZXRUZXh0RmllbGQoKSksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtX25hbWVzW2xpc3RJbmRleF0sCkBAIC05OSw3ICs5OSw3IEBAIHZvaWQgQXV0 b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OnNlbGVjdGlvbkMKICAgICBpZiAobV9zZXBhcmF0b3JJbmRl eCAhPSAtMSAmJiBsaXN0SW5kZXggPiBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obV9zZXBhcmF0b3JJ bmRleCkpCiAgICAgICAgIC0tbGlzdEluZGV4OwogCi0gICAgQVNTRVJUKGxpc3RJbmRleCA+PSAw ICYmIGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKKyAgICBBU1NFUlQobGlzdEluZGV4IDwg bV9uYW1lcy5zaXplKCkpOwogCiAgICAgd2ViVmlldy0+Y2xpZW50KCktPmRpZFNlbGVjdEF1dG9G aWxsU3VnZ2VzdGlvbihXZWJOb2RlKGdldFRleHRGaWVsZCgpKSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1fbmFtZXNbbGlzdEluZGV4XSwKSW5k ZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b2NvbXBsZXRlUG9wdXBNZW51Q2xpZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9jb21wbGV0ZVBvcHVwTWVudUNs aWVudC5jcHAJKHJldmlzaW9uIDYxMzM2KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9BdXRvY29t cGxldGVQb3B1cE1lbnVDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NiwxMyArNDYsMTMg QEAgdW5zaWduZWQgQXV0b2NvbXBsZXRlUG9wdXBNZW51Q2xpZW50OjpnZQogCiBXZWJTdHJpbmcg QXV0b2NvbXBsZXRlUG9wdXBNZW51Q2xpZW50OjpnZXRTdWdnZXN0aW9uKHVuc2lnbmVkIGxpc3RJ bmRleCkgY29uc3QKIHsKLSAgICBBU1NFUlQobGlzdEluZGV4ID49IDAgJiYgbGlzdEluZGV4IDwg bV9zdWdnZXN0aW9ucy5zaXplKCkpOworICAgIEFTU0VSVChsaXN0SW5kZXggPCBtX3N1Z2dlc3Rp b25zLnNpemUoKSk7CiAgICAgcmV0dXJuIG1fc3VnZ2VzdGlvbnNbbGlzdEluZGV4XTsKIH0KIAog dm9pZCBBdXRvY29tcGxldGVQb3B1cE1lbnVDbGllbnQ6OnJlbW92ZVN1Z2dlc3Rpb25BdEluZGV4 KHVuc2lnbmVkIGxpc3RJbmRleCkKIHsKLSAgICBBU1NFUlQobGlzdEluZGV4ID49IDAgJiYgbGlz dEluZGV4IDwgbV9zdWdnZXN0aW9ucy5zaXplKCkpOworICAgIEFTU0VSVChsaXN0SW5kZXggPCBt X3N1Z2dlc3Rpb25zLnNpemUoKSk7CiAgICAgbV9zdWdnZXN0aW9ucy5yZW1vdmUobGlzdEluZGV4 KTsKIH0KIAo= 59023 2010-06-17 11:34:15 -0700 2010-06-19 07:07:11 -0700 Fixing tests part of changelog chromium_wextra.txt text/plain 6922 thomasvl SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTMzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDYtMTcgIFRob21hcyBWYW4gTGVudGVuICA8dGhvbWFzdmxA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdhcm5pbmdzIGZyb20gLVdleHRyYSBpbiBhIENocm9taXVtIE1hYyBidWlsZAorICAg ICAgICAxLiBjaGVja3Mgb2YgdW5zaWduZWQgPj0gMAorICAgICAgICAyLiBlbnVtZXJhbCBhbmQg bm9uLWVudW1lcmFsIHR5cGUgaW4gY29uZGl0aW9uYWwgZXhwcmVzc2lvbgorICAgICAgICAzLiBj b3B5IGN0b3JzIHRoYXQgZG9uJ3QgY2FsbCB0aGUgc3VwZXIgY29weSBjdG9yIG9yIGN0b3IKKyAg ICAgICAgTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2Ugc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDc5MQorCisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNocm9taXVtRGF0YU9iamVjdDo6Q2hyb21pdW1EYXRhT2JqZWN0KToKKyAgICAgICAg KiBwbGF0Zm9ybS9jaHJvbWl1bS9UaGVtZUNocm9taXVtTWFjLm1tOgorICAgICAgICAoV2ViQ29y ZTo6dXBkYXRlU3RhdGVzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1 bU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OnVwZGF0 ZUFjdGl2ZVN0YXRlKToKKwogMjAxMC0wNi0xNyAgU2h1IENoYW5nICA8Y2hhbmcuc2h1QG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVj dC5jcHAJKHJldmlzaW9uIDYxMzM2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJv bWl1bURhdGFPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw3ICs2Nyw4IEBAIGJvb2wg Q2hyb21pdW1EYXRhT2JqZWN0OjpoYXNEYXRhKCkgY29uc3QKIH0KIAogQ2hyb21pdW1EYXRhT2Jq ZWN0OjpDaHJvbWl1bURhdGFPYmplY3QoY29uc3QgQ2hyb21pdW1EYXRhT2JqZWN0JiBvdGhlcikK LSAgICA6IHVybFRpdGxlKG90aGVyLnVybFRpdGxlKQorICAgIDogUmVmQ291bnRlZDxDaHJvbWl1 bURhdGFPYmplY3Q+KCkKKyAgICAsIHVybFRpdGxlKG90aGVyLnVybFRpdGxlKQogICAgICwgZG93 bmxvYWRNZXRhZGF0YShvdGhlci5kb3dubG9hZE1ldGFkYXRhKQogICAgICwgZmlsZUV4dGVuc2lv bihvdGhlci5maWxlRXh0ZW5zaW9uKQogICAgICwgZmlsZW5hbWVzKG90aGVyLmZpbGVuYW1lcykK SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vVGhlbWVDaHJvbWl1bU1hYy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1RoZW1lQ2hyb21pdW1NYWMubW0J KHJldmlzaW9uIDYxMzM2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9UaGVtZUNocm9t aXVtTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNzEsNyArMjcxLDggQEAgc3RhdGljIHZvaWQg dXBkYXRlU3RhdGVzKE5TQ2VsbCogY2VsbCwgQwogICAgIC8vIFdpbmRvdyBJbmFjdGl2ZSBzdGF0 ZQogICAgIE5TQ29udHJvbFRpbnQgb2xkVGludCA9IFtjZWxsIGNvbnRyb2xUaW50XTsKICAgICBi b29sIHdpbmRvd0luYWN0aXZlID0gKHN0YXRlcyAmIFdpbmRvd0luYWN0aXZlU3RhdGUpOwotICAg IE5TQ29udHJvbFRpbnQgdGludCA9IHdpbmRvd0luYWN0aXZlID8gTlNDbGVhckNvbnRyb2xUaW50 IDogW05TQ29sb3IgY3VycmVudENvbnRyb2xUaW50XTsKKyAgICBOU0NvbnRyb2xUaW50IHRpbnQg PSB3aW5kb3dJbmFjdGl2ZSA/IHN0YXRpY19jYXN0PE5TQ29udHJvbFRpbnQ+KE5TQ2xlYXJDb250 cm9sVGludCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IFtOU0Nv bG9yIGN1cnJlbnRDb250cm9sVGludF07CiAgICAgaWYgKHRpbnQgIT0gb2xkVGludCkKICAgICAg ICAgW2NlbGwgc2V0Q29udHJvbFRpbnQ6dGludF07CiB9CkluZGV4OiBXZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0JKHJldmlzaW9uIDYxMzM2KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAt OTEsNyArOTEsNyBAQCB2b2lkIFJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OnVwZGF0ZUFjdGl2CiB7 CiAgICAgTlNDb250cm9sVGludCBvbGRUaW50ID0gW2NlbGwgY29udHJvbFRpbnRdOwogICAgIE5T Q29udHJvbFRpbnQgdGludCA9IGlzQWN0aXZlKG8pID8gW05TQ29sb3IgY3VycmVudENvbnRyb2xU aW50XSA6Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOU0NsZWFyQ29u dHJvbFRpbnQ7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNf Y2FzdDxOU0NvbnRyb2xUaW50PihOU0NsZWFyQ29udHJvbFRpbnQpOwogCiAgICAgaWYgKHRpbnQg IT0gb2xkVGludCkKICAgICAgICAgW2NlbGwgc2V0Q29udHJvbFRpbnQ6dGludF07CkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHJldmlzaW9uIDYxMzM4KQorKysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEwLTA2LTE3ICBUaG9tYXMgVmFuIExl bnRlbiAgPHRob21hc3ZsQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXYXJuaW5ncyBmcm9tIC1XZXh0cmEgaW4gYSBDaHJvbWl1 bSBNYWMgYnVpbGQKKyAgICAgICAgMS4gY2hlY2tzIG9mIHVuc2lnbmVkID49IDAKKyAgICAgICAg Mi4gZW51bWVyYWwgYW5kIG5vbi1lbnVtZXJhbCB0eXBlIGluIGNvbmRpdGlvbmFsIGV4cHJlc3Np b24KKyAgICAgICAgMy4gY29weSBjdG9ycyB0aGF0IGRvbid0IGNhbGwgdGhlIHN1cGVyIGNvcHkg Y3RvciBvciBjdG9yCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQwNzkxCisKKyAgICAgICAgKiBzcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3Bw OgorICAgICAgICAoV2ViS2l0OjpBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6Z2V0U3VnZ2VzdGlv bik6CisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9wdXBNZW51Q2xpZW50OjpyZW1vdmVTdWdn ZXN0aW9uQXRJbmRleCk6CisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9wdXBNZW51Q2xpZW50 Ojp2YWx1ZUNoYW5nZWQpOgorICAgICAgICAoV2ViS2l0OjpBdXRvRmlsbFBvcHVwTWVudUNsaWVu dDo6c2VsZWN0aW9uQ2hhbmdlZCk6CisgICAgICAgICogc3JjL0F1dG9jb21wbGV0ZVBvcHVwTWVu dUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkF1dG9jb21wbGV0ZVBvcHVwTWVudUNsaWVu dDo6Z2V0U3VnZ2VzdGlvbik6CisgICAgICAgIChXZWJLaXQ6OkF1dG9jb21wbGV0ZVBvcHVwTWVu dUNsaWVudDo6cmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgpOgorCiAyMDEwLTA2LTE3ICBQYXZlbCBG ZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQ6IGNo cm9taXVtIHRlc3RzIGZpeC4gQWRkZWQgSW5zcGVjdG9yQmFja2VuZCBkZWxlZ2F0ZXMgZm9yIG5l dyBpbnNwZWN0b3IgbWV0aG9kcy4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b0ZpbGxQ b3B1cE1lbnVDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0 b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3BwCShyZXZpc2lvbiA2MTMzNikKKysrIFdlYktpdC9jaHJv bWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01 Niw3ICs1Niw3IEBAIFdlYlN0cmluZyBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6Z2V0U3UKICAg ICAgICAgLS1saXN0SW5kZXg7CiAKICAgICAvLyBGSVhNRTogTW9kaWZ5IHRoZSBQb3B1cE1lbnUg dG8gYWRkIHRoZSBsYWJlbCBpbiBncmF5IHJpZ2h0LWp1c3RpZmllZC4KLSAgICBBU1NFUlQobGlz dEluZGV4ID49IDAgJiYgbGlzdEluZGV4IDwgbV9uYW1lcy5zaXplKCkpOworICAgIEFTU0VSVChs aXN0SW5kZXggPCBtX25hbWVzLnNpemUoKSk7CiAKICAgICBXZWJTdHJpbmcgc3VnZ2VzdGlvbiA9 IG1fbmFtZXNbbGlzdEluZGV4XTsKICAgICBpZiAobV9sYWJlbHNbbGlzdEluZGV4XS5pc0VtcHR5 KCkpCkBAIC02OCw3ICs2OCw3IEBAIFdlYlN0cmluZyBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6 Z2V0U3UKIHZvaWQgQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OnJlbW92ZVN1Z2dlc3Rpb25BdElu ZGV4KHVuc2lnbmVkIGxpc3RJbmRleCkKIHsKICAgICAvLyBGSVhNRTogRG8gd2Ugd2FudCB0byBy ZW1vdmUgQXV0b0ZpbGwgc3VnZ2VzdGlvbnM/Ci0gICAgQVNTRVJUKGxpc3RJbmRleCA+PSAwICYm IGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKKyAgICBBU1NFUlQobGlzdEluZGV4IDwgbV9u YW1lcy5zaXplKCkpOwogICAgIG1fbmFtZXMucmVtb3ZlKGxpc3RJbmRleCk7CiAgICAgbV9sYWJl bHMucmVtb3ZlKGxpc3RJbmRleCk7CiB9CkBAIC04Miw3ICs4Miw3IEBAIHZvaWQgQXV0b0ZpbGxQ b3B1cE1lbnVDbGllbnQ6OnZhbHVlQ2hhbmcKICAgICBpZiAobV9zZXBhcmF0b3JJbmRleCAhPSAt MSAmJiBsaXN0SW5kZXggPiBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obV9zZXBhcmF0b3JJbmRleCkp CiAgICAgICAgIC0tbGlzdEluZGV4OwogCi0gICAgQVNTRVJUKGxpc3RJbmRleCA+PSAwICYmIGxp c3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKKyAgICBBU1NFUlQobGlzdEluZGV4IDwgbV9uYW1l cy5zaXplKCkpOwogCiAgICAgd2ViVmlldy0+Y2xpZW50KCktPmRpZEFjY2VwdEF1dG9GaWxsU3Vn Z2VzdGlvbihXZWJOb2RlKGdldFRleHRGaWVsZCgpKSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1fbmFtZXNbbGlzdEluZGV4XSwKQEAgLTk5LDcg Kzk5LDcgQEAgdm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6c2VsZWN0aW9uQwogICAgIGlm IChtX3NlcGFyYXRvckluZGV4ICE9IC0xICYmIGxpc3RJbmRleCA+IHN0YXRpY19jYXN0PHVuc2ln bmVkPihtX3NlcGFyYXRvckluZGV4KSkKICAgICAgICAgLS1saXN0SW5kZXg7CiAKLSAgICBBU1NF UlQobGlzdEluZGV4ID49IDAgJiYgbGlzdEluZGV4IDwgbV9uYW1lcy5zaXplKCkpOworICAgIEFT U0VSVChsaXN0SW5kZXggPCBtX25hbWVzLnNpemUoKSk7CiAKICAgICB3ZWJWaWV3LT5jbGllbnQo KS0+ZGlkU2VsZWN0QXV0b0ZpbGxTdWdnZXN0aW9uKFdlYk5vZGUoZ2V0VGV4dEZpZWxkKCkpLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9uYW1l c1tsaXN0SW5kZXhdLApJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9BdXRvY29tcGxldGVQb3B1 cE1lbnVDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b2Nv bXBsZXRlUG9wdXBNZW51Q2xpZW50LmNwcAkocmV2aXNpb24gNjEzMzYpCisrKyBXZWJLaXQvY2hy b21pdW0vc3JjL0F1dG9jb21wbGV0ZVBvcHVwTWVudUNsaWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ2LDEzICs0NiwxMyBAQCB1bnNpZ25lZCBBdXRvY29tcGxldGVQb3B1cE1lbnVDbGllbnQ6 OmdlCiAKIFdlYlN0cmluZyBBdXRvY29tcGxldGVQb3B1cE1lbnVDbGllbnQ6OmdldFN1Z2dlc3Rp b24odW5zaWduZWQgbGlzdEluZGV4KSBjb25zdAogewotICAgIEFTU0VSVChsaXN0SW5kZXggPj0g MCAmJiBsaXN0SW5kZXggPCBtX3N1Z2dlc3Rpb25zLnNpemUoKSk7CisgICAgQVNTRVJUKGxpc3RJ bmRleCA8IG1fc3VnZ2VzdGlvbnMuc2l6ZSgpKTsKICAgICByZXR1cm4gbV9zdWdnZXN0aW9uc1ts aXN0SW5kZXhdOwogfQogCiB2b2lkIEF1dG9jb21wbGV0ZVBvcHVwTWVudUNsaWVudDo6cmVtb3Zl U3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4KQogewotICAgIEFTU0VSVChsaXN0 SW5kZXggPj0gMCAmJiBsaXN0SW5kZXggPCBtX3N1Z2dlc3Rpb25zLnNpemUoKSk7CisgICAgQVNT RVJUKGxpc3RJbmRleCA8IG1fc3VnZ2VzdGlvbnMuc2l6ZSgpKTsKICAgICBtX3N1Z2dlc3Rpb25z LnJlbW92ZShsaXN0SW5kZXgpOwogfQogCg==